Trade context management associated bugs

      if (b) //if buy signal
      {
       
       if (DebugMode) Alert(Symbol()," ",Period(),": ", "b = true");
       if (OppositeClose) CloseOrders(OP_SELL);

       ordersTotal = myOpenOrders(Magic);
       
       RefreshRates();
       price = NormalizeDouble(Ask,Digits);

       sl = 0;
       tp = 0;
       ticket = Buy(Symbol(), GetLots(OP_BUY), price, sl, tp, Magic);
       
       if (ticket > -1) { if (DebugMode) Alert(Symbol()," ",Period(),": ", "Buy sent"); }
       
       return(0);
      }

int myOpenOrders(int magic = 0, int type =0)
{
   int count = 0;
   int total = OrdersTotal();
   if (IsTesting() && type==0) { return(total); }
   if (total== 0) { return(total); }

   
   for(int k=OrdersTotal()-1; k>=0; k--)
   {
      if (!OrderSelect(k, SELECT_BY_POS, MODE_TRADES)) continue;
      if (OrderSymbol() != Symbol()) continue;
      if (OrderMagicNumber() != magic ) continue;
      if (OrderType() != type && type!=0) continue;
      
      count++;
         
   }
   
   return(count);
}

int Buy(string symbol, double lot, double price, double sl, double tp, int magic, string comment="") 
{
  price = NormalizeDouble(price, Digits);
  sl = NormalizeDouble(sl, Digits);
  tp = NormalizeDouble(tp, Digits);
  lot = NormalizeDouble(lot,LotDigits);
    
  string _lot = DoubleToStr(lot, LotDigits);
  string _price = DoubleToStr(price, Digits);
  string _sl = DoubleToStr(sl, Digits);
  string _tp = DoubleToStr(tp, Digits);
  comment = StringConcatenate(OtherComments," #: ",DoubleToStr(Magic,0));
  
//  if (ShowPrintComments)Print("Buy \"", symbol, "\", ", _lot, ", ", _price, ", ", Slippage, ", ", _sl, ", ", _tp, ", ", magic, ", \"", comment, "\"");

  if(TradeIsBusy() < 0) { if(DebugMode) Alert(Symbol()," ",Period(),": TradeIsBusy, order delayed");  return(-1); }
  RefreshRates();
    
  int res = OrderSend(symbol, OP_BUY, lot, price, Slippage*mt, sl, tp, comment, magic, 0, clBuy);
 
  if (res >= 0) {
    TradeIsNotBusy();
    if(DebugMode) Alert(Symbol()," ",Period(),": TradeIsNotBusy, order sent");
    return (res);
  }
  else {
 
   Print("Buy failed: ", ErrorDescription(GetLastError()), " (", GetLastError(), ")");
     
   return (-1);
  } 


}

Quoting mfurlend

Disliked

Hi,
I am using the trade context management code found on mql4.com (http://articles.mql4.com/141). My trade context seems to be working fine now but a new problem has sprung up: my orders are sometimes duplicated. Has anyone encountered this issue before? The related code is quoted below:

From start function:
[code]...

Ignored

datetime getLastTradeTime(int ttype=OP_BUY, int mn)
{
   datetime dt;
   int i;
   for (i=0;i<OrdersTotal();i++)
   {
      if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES) == true) 
      {
         if (  OrderType()        == ttype 
            && OrderSymbol()      == Symbol() 
            && OrderMagicNumber() == mn)
         {         
            dt = OrderOpenTime();
            return(dt);
         } 
      }        
   }      
     
   return(dt);
}

//last trade time var
datetime ltt = getLastTradeTime(OP_BUY, YOUR_MAGICNUMBER)
   
if (iBarShift(NULL, 0, ltt) != 0) DO_YOUR_BUY_FUNCTION();

Quoting mfurlend

Disliked

Thanks for the code, I appreciate it. I know that code will indeed fix the problem but I feel like the code I already have should be sufficient to control orders per bar as long as there aren't any bugs.


I have the following at the top of my start function:

if (OneTimeCalculation && Volume[0] < 1) return(0);

Do you see an issue with that?

Ignored

if (OneTimeCalculation && Volume[0] > 1) return(0);

Quoting bandung

Disliked

i think if you want to trade only on first tiks of new bar... maybe.. you should use

Inserted Code

if (OneTimeCalculation && Volume[0] > 1) return(0);

i found that code in moving average.mq4 (ea sample when you install mt4)

Ignored

Quoting mfurlend

Disliked

Yeah thats what I meant to write (Volume[0]<1).

I was wondering if this is a bug that could be solved with the library LibOrderReliable.

Ignored

bool New_Bar()
{
   static datetime New_Time=0;
   if(New_Time!=Time[0]){
      New_Time=Time[0];
      return(true);
   }
   return(false);
}