Stop all and close all trades EA | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Close all trades at preset price level 33 replies

Analyse MT4 trades executed by trailing stop and Stop Loss 0 replies

Looking for EA to close all Buy Or all Sell trades when in profit 0 replies

Buy Stop and Sell Stop orders with OCO and Trailing Stop 0 replies

Close all trades !!! 1 reply

Attachments: Stop all and close all trades EA
Exit Attachments

Stop all and close all trades EA

  • #1
  • First Post: Dec 5, 2010 9:54am Dec 5, 2010 9:54am
hi i have a ea running on several pairs ie 8 charts open with same ea on each, i want to have an ea which i can entre current equity and also a equity increase target , once the target is hit all trades are clossed inc pending orders and all the ea's on all pairs stopped and it stops any other trades being opened until reset and started again. can anyone help
  • #2
  • Dec 17, 2010 6:37pm Dec 17, 2010 6:37pm
I think you cannot run 2 EAs on a chart at the same time. For your objective, what you can do is to modify the ea that you are running to incl a function to monitor equity target & stop itself when this target is hit as you want. Just what I know. Cheers!

Quoting censura
hi i have a ea running on several pairs ie 8 charts open with same ea on each, i want to have an ea which i can entre current equity and also a equity increase target , once the target is hit all trades are clossed inc pending orders and all the ea's on all pairs stopped and it stops any other trades being opened until reset and started again. can anyone help
  • #3
  • Edited Dec 18, 2010 2:39pm Dec 17, 2010 10:17pm | Edited Dec 18, 2010 2:39pm
You can try this. I haven't had a chance to fully test it yet, because I need to forward test it on a demo account.

Basically there is p_target for setting profit target over equity start value. If you want it to operate continuously, and reset each time the target is reached, leave recurring set to true. Otherwise set it to false, and it will only do it once.

If you want to use a magic number (recommended) leave magic set to true. Otherwise set it to false.

You will also need to set this up on its own chart, preferably with a pair that's fairly active.

Let me know how it works, okay?


ETA: Added "inhibit trade" global.
Attached File(s)
File Type: mq4 Close_on_Profit.mq4   2 KB | 1,012 downloads
  • #4
  • Dec 17, 2010 11:04pm Dec 17, 2010 11:04pm
Quoting censura
... and all the ea's on all pairs stopped and it stops any other trades being opened until reset and started again. can anyone help
Oh, I didn't catch this part. I just updated and added a global variable that should inhibit trades after target is reached.

You will have to add this code to your EA, however, as a qualifier before opening trades.

PHP Code
if(GlobalVariableGet("inhibit")==0){ open trade ... }
  • #5
  • Dec 19, 2010 9:46am Dec 19, 2010 9:46am
Thank you very much will test next wk
  • #6
  • Dec 19, 2010 12:08pm Dec 19, 2010 12:08pm
Yeah, the only thing I'm not really sure about is I'm telling it get the current time when it reaches the profit target (I haven't done this before) and to close all existing orders that were opened before that. It makes perfect sense though but, we won't actually know until we get a chance to test it.
  • #7
  • Dec 19, 2010 12:21pm Dec 19, 2010 12:21pm
Quoting ecTrade
If you want to use a magic number (recommended) leave magic set to true. Otherwise set it to false.
Actually, this probably won't make any difference so long as you have the same EA set up on different charts and only working with these trades (on same the account). If you are working with other trades besides this, you will need to come up with a different way of keeping track of equity, as opposed to overall AccountEquity().
  • #8
  • Dec 20, 2010 2:41am Dec 20, 2010 2:41am
I don't think it is working - maybe it would be easier to tell if it displayed last equity opening value , current equity just to make sure as i feel the equity has grown beyond where it should have clossed but it has not
  • #9
  • Edited 6:42am Dec 20, 2010 4:35am | Edited 6:42am
Okay, I have it so it will display Equity and Target in upper left-hand of screen. The Equity is constantly moving while Target should remain fixed.

Sorry I don't have much time to look at it now, as it's way passed my bedtime.


ETA: Updated so it will display magic number, close time and orders.
Attached File(s)
File Type: mq4 Close_on_Profit.mq4   3 KB | 717 downloads
  • #10
  • Dec 20, 2010 5:53am Dec 20, 2010 5:53am
Hey, I just tried this with 10 open charts, and it appears to be working the way it should. Although I didn't try it with the global "inhibit" code added to EA.

If you are still having problems, could you be more specific?

Thanks.
  • #11
  • Edited 3:11pm Dec 20, 2010 6:58am | Edited 3:11pm
Okay, I guess it wasn't working. I had to add initialize function and initialize some of the variables. Apparently it won't update variables in properties box unless this is done. Before I was just compiling it and noticed variables changed whenever I did that so, I didn't expect this to be an issue.

It should work now.
  • #12
  • Dec 20, 2010 10:06am Dec 20, 2010 10:06am
The ea worked as far as clossing trades but it was not able to stop ea from working - thank you for your time and effort on this.
  • #13
  • Dec 20, 2010 1:52pm Dec 20, 2010 1:52pm
If you want it to stop the EA from running, you will have to modify the OrderSend() code on the EA so it can pickup the global variable I'm talking about.

If you like, I can try adding this for you? It should be relatively easy to do, depending on the complexity of the EA. But no, I don't think you can get your EA to do what you want, unless you modify it this way.
  • #14
  • Dec 21, 2010 1:14am Dec 21, 2010 1:14am
Because of the complexity of the order process i added the code to the start function instead

int start(){if (GlobalVariableGet("inhibit") != 0){
return(0);
}

obviously once your ea changes inhibit to 1 then it should be stuck in the loop until global varable reset (thats what i thought)

I understand if i want the ea to be in recurring mode i will need to change this maybe with a sleep function for say 30min then add 1 to comparisson varibale ie

int start(){if (GlobalVariableGet("inhibit") != r){
sleep(18000);r=r+1; return(0);
}

I checked global varible and it is currently 0 as you would expect
  • #15
  • Edited 5:58am Dec 21, 2010 4:46am | Edited 5:58am
Quoting censura
Because of the complexity of the order process i added the code to the start function instead

int start(){if (GlobalVariableGet("inhibit") != 0){
return(0);
}
Yeah, that should work. Except I think it needs to say "if (GlobalVariableGet("inhibit") == 0" in order to initialize your EA. Or, that's what it would say if it preceded OrderSend().

Quote
obviously once your ea changes inhibit to 1 then it should be stuck in the loop until global varable reset (thats what i thought)
Actually, once it changes to 1, that means the first cycle is complete and it begins cycle 2 ... that is, if recurring is set to true. So, again, it's looking for a 0. Of course it only begins to count (see other post) when recurring is set to false, otherwise all it sees is 0. So, the EA keeps placing trades.

Quote
I understand if i want the ea to be in recurring mode i will need to change this maybe with a sleep function for say 30min then add 1 to comparisson varibale ie
No, if you want it set to recurring, you don't need to do anything, just leave everything as is (with recurring set to true). You don't even need to add the global inhibit, unless you specifically want your EA to stop placing orders after the first cycle.

Quote
int start(){if (GlobalVariableGet("inhibit") != r){
sleep(18000);r=r+1; return(0);
}
Not necessary.

Quote
I checked global varible and it is currently 0 as you would expect
Yes, and it needs to be set to 0 in order to get things started.
  • #16
  • Dec 21, 2010 5:36am Dec 21, 2010 5:36am
Quoting ecTrade
Actually, once it changes to 1, that means the first cycle is complete and it begins cycle 2 ... that is, if recurring is set to true. So, again, it's looking for a 0.
Oh, so long as recurring is set to true, the global inhibit won't begin to count, so it will always remain set at 0. It's only when it begins to count that it changes from 0 to something else, in which case everything stops after the first cycle. I know it sounds a bit counter-intuitive but, that's the way it works.
  • #17
  • Dec 21, 2010 6:13am Dec 21, 2010 6:13am
Hey, I added a slight mod to the (final) order count. I don't think it should affect anything, except possibly if it didn't work before? ...
Attached File(s)
File Type: mq4 Close_on_Profit.mq4   3 KB | 559 downloads
  • #18
  • Dec 22, 2010 12:14pm Dec 22, 2010 12:14pm
Hey, I started a thread that includes this EA over here. I'm actually pretty happy with the way it turned out and, intend to use it with more of my own setups.
  • #19
  • Dec 23, 2010 1:36am Dec 23, 2010 1:36am
Hi,

You are doing great job,

I also going to test your super trend EA with stop all and close all EA

thank you so much for your new genius method of trading

I also follow your way

bye
ajentha
  • #20
  • Dec 23, 2010 6:34am Dec 23, 2010 6:34am
Hey, I had to update the EA, as mentioned here. There was a reset issue (when EA gets reset) and I had to add a global variable to keep profit target from getting lost.
Attached File(s)
File Type: mq4 Close_on_Profit.mq4   3 KB | 891 downloads
0 traders viewing now