hey bros,
does someone have a ''close basket'' or close ''all positions'' ea?
would be awesome
ty!
Here ya go, bro.
Vegas Algorithm auto-trader by Steve and Squalou
- #244
- Dec 15, 2010 12:26pm Dec 15, 2010 12:26pm
- Joined Aug 2010 | Status: Tööröh | 14,292 Posts
Here ya go, bro.
Hero calls followed by margin calls...
- #246
- Dec 26, 2010 4:30pm Dec 26, 2010 4:30pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I want to make a slightly different version of this EA, replacing the MA with CCI. Don't want to keep pestering Steve, so I've been trying to learn how to do this stuff myself. Took a stab at it and the result is attached below, with the hope that a real coder might check it. There's a 'wrong parameters count' error that I can't figure out, but the rest of it compiled OK.
Here's what I attempted to do:
Remove all traces of the MA
Add CCI as a variable, with a value above/below...
All you have done wrong is miss out a couple of parameters in your cci call - highlighted in red in my code snippet:
- 0 represents the time frame parameter. 0 equates to the chart time frame and can be replaced by any of the available timeframes, for example PERIOD_H1 if you want to enforce the H1 time frame.
- PRICE_TYPICAL is one of those 'price enumeration' thingies - PRICE_OPEN, PRICE_CLOSE etc. Start typing PRICE_ and the editor will start to offer you the alternatives available.
Your code:
Inserted Code
double GetCci(int period, int shift)
{
return(iCCI(NULL, period, shift) );
}//End double GetCci(int period, int shift) Correct code:
Inserted Code
double GetCci(int period, int shift)
{
return(iCCI(NULL, [color=Red]0[/color], period, [color=Red]PRICE_TYPICAL[/color], shift) );
}//End double GetCci(int period, int shift) Up an' at 'em, tiger. Once you master the basics, the rest is easy. It is fantastic to have an idea and be immediately able to write the code to create the ea to test the idea.
Darn it, Steve, I was trying to quit pestering you!
Shoulda figured you'd be the first to respond. Thanks.
A month ago, mql4 code looked like Chinese algebra to me. Starting to make a little progress, tho. I found a good place to learn some basics: Expert Advisor Builder for MetaTrader 4 (in case anyone wants to take a gander). You can assemble simple EAs, which is nice, but the best part is that it really helped me understand how they operate. I've got a long ways to go, but it sure is nice being able to look at an EA's code and have a reasonable idea of how it works. The other thing I discovered is that it's actually kinda fun.
BTW, I ran the latest Beast last week and even with the multiple re-downloads and the allegedly awful time of year to be in the market and the fact that it missed more than a few trades, it still delivered almost 200 pips on the 6 major US$ pairs and the Euro/Yen. So even though i'm still messing around with this ALF thing, my money is on THE BEAST.
Mike
Shoulda figured you'd be the first to respond. Thanks.
A month ago, mql4 code looked like Chinese algebra to me. Starting to make a little progress, tho. I found a good place to learn some basics: Expert Advisor Builder for MetaTrader 4 (in case anyone wants to take a gander). You can assemble simple EAs, which is nice, but the best part is that it really helped me understand how they operate. I've got a long ways to go, but it sure is nice being able to look at an EA's code and have a reasonable idea of how it works. The other thing I discovered is that it's actually kinda fun.
BTW, I ran the latest Beast last week and even with the multiple re-downloads and the allegedly awful time of year to be in the market and the fact that it missed more than a few trades, it still delivered almost 200 pips on the 6 major US$ pairs and the Euro/Yen. So even though i'm still messing around with this ALF thing, my money is on THE BEAST.
Mike
- #249
- Dec 27, 2010 10:38am Dec 27, 2010 10:38am
Pinhead - people like you are a godsend to me. I aint got a clue about MQL - i can just about spell it. I have ALWAYS wanted to code my own EAs but never had the balls to bother learning MQL - thought it was too much and had no clue where to start. The fact that a month ago, you were in the same boat as I am in now and you have started to code now, gives me some hope. I hope to follow in your footsteps and I hope others on here will follow too.
Thank you and everyone on here - wishing US ALL a very prosperous and successful 2011.
I may never become good at coding, but any level of understanding can only help, imo. There's a simple logic to it that's not too difficult to grasp, and once you get past that, the rest looks like details. All I can say is come on in, Viv, the water's fine.
I'd also like to say thanks for the amazing education I continue to receive in this awesome forum. I've encountered some really excellent human beings here and the generosity they've shown has been an inspiration. I have a really good feeling about the coming trading year and wish you all great success and happiness.
Mike
- #250
- Dec 27, 2010 11:16am Dec 27, 2010 11:16am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Whilst you guys are a-stumblin and a-fumblin around, you might find the attached useful - it is the code I use whenever I create a new auto-trader.
I have included a commentary early on in the code to describe how to use it.
Go for it, guys. I am a 59-year-old pianist with a chaotic and not particularly bright mind. Frankly, if I can learn to code this stuff then it has to be child's play.
One tip, and it is a biggie. Every time you add a line of code or make an edit, press the F5 key to recompile the code. It is better to discover that you have made a silly mistake immediately rather than wait until you have to sift through 50 lines of code. Guess how I know.
I have included a commentary early on in the code to describe how to use it.
Go for it, guys. I am a 59-year-old pianist with a chaotic and not particularly bright mind. Frankly, if I can learn to code this stuff then it has to be child's play.
One tip, and it is a biggie. Every time you add a line of code or make an edit, press the F5 key to recompile the code. It is better to discover that you have made a silly mistake immediately rather than wait until you have to sift through 50 lines of code. Guess how I know.
Whilst you guys are a-stumblin and a-fumblin around, you might find the attached useful - it is the code I use whenever I create a new auto-trader.
I have included a commentary early on in the code to describe how to use it.
Go for it, guys. I am a 59-year-old pianist with a chaotic and not particularly bright mind. Frankly, if I can learn to code this stuff then it has to be child's play.
One tip, and it is a biggie. Every time you add a line of code or make an edit, press the F5 key to recompile the code. It is better to discover...
Now, that's handy. Thanks.
One question: Is Specific Time Inputs a date?
Mike
- #252
- Dec 27, 2010 4:21pm Dec 27, 2010 4:21pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Now, that's handy. Thanks.
One question: Is Specific Time Inputs a date?
Mike
- #253
- Dec 28, 2010 3:58am Dec 28, 2010 3:58am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Now, that's handy. Thanks.
One question: Is Specific Time Inputs a date?
Mike
StartTime is a double that the bot converts into a datetime data type in datetime hhmm_to_time(double hhmm)
To use it, declare a variable called ConvertedStartTime (or some such) and use the call
ConvertedStartTime = hhmm_to_time(StartTime);
From there, you can use ConvertedStartTime for specific time comarisons. If you wanted a specific ending time, you would do the same with, say, ConvertedEndTime i.e.
ConvertedEndTime = hhmm_to_time(EndTime);
squalou supplied the code for the conversion function - I haven't the remotest idea how it works. I needed it for macamans grid thingy. Usually, all we need is StartHour and EndHour to delineate our trading times - much simpler to code and understand.
Hope this helps.