Attachments: EA debugging help Please - SevenChi

EA debugging help Please - SevenChi

#1
First Post: Edited Dec 2, 2010 12:23pm Nov 29, 2010 10:12am | Edited Dec 2, 2010 12:23pm

Chistabo
Joined Apr 2009 | Status: Trader | 191 Posts

Hello!

I am kindly asking somebody knowleadgeable enough to help me debug this EA of mine.

The function TradeOncePerBar (GV TradedThisBar_) is not working properly - when EA is attached to Chart (ex. at recompiling) it will open new position, if signaled, on same Bar.

Would be also very handy if EA had 'button' for CLEAR CHART, that would delete Arrows and their connection lines (Chart -> Object List -> Name -> #) from opened and closed trades.

Also not shure if this piece of Code would work:

if (crossedLine ("trade all"))
{
GlobalVariableSet ("TradedThisBar_" + Symbol(), 0); Print ("GV TradedThisBar_ - False - TRADE ALL LineCrosed");
GlobalVariableSet ("SignalsOnly_" + Symbol(), 0); Print ("GV SignalyOnly_ - False - TRADE ALL LineCrosed");
GlobalVariableSet ("BuyOnly_" + Symbol(), 0); Print ("GV BuyOnly_ - False - TRADE ALL LineCrosed");
GlobalVariableSet ("SellOnly_" + Symbol(), 0); Print ("GV SellOnly_ - False - TRADE ALL LineCrosed");
}

It is supposed to trade immediately after line is crossed, but it seem that it waits for next Candle (Bar). Not shure. Sometimes it works, next not.

EA also had MaxTrades function, but, hey, Me, Myself and I were not able to make it work properly (... they can't say we never tried). So we deleted it. It worked on Tester, not on Demo. After position was open SignalsOnly was set to True???

EA is basically simple - Go with the flow (Cut the Loosers, Let the Winners run (and pile)).

From the Code is obvious that I am no Programmer, just WannaBeCoder. Code is taken from here and there (thank you 7bit, RR, TrendChaser, all others).

And of course thank you to anybody willing to help me with this.

Have fun,

Simon

Attached File(s)

offline_charts.mqh 15 KB | 397 downloads

SevenChi EA v1.1.mq4 36 KB | 410 downloads | Uploaded Dec 2, 2010 12:22pm

CommonFunctionsChi.mqh 57 KB | 379 downloads | Uploaded Dec 2, 2010 12:22pm

#2
Dec 2, 2010 12:14pm Dec 2, 2010 12:14pm

Chistabo
Joined Apr 2009 | Status: Trader | 191 Posts

Hello, Chistabo!

Is this a Christian name, Chistabo? I guess not. My deeeep intuition tells me this is something of higher spheres of Life. Wright? Maybe it means:
Chi = cosmic energy, Prana (India), Ki (Japan), Qi (China), Love (whole world)...
stabo - what does that means? Lets ask Uncle GoogleTranslator - ohh, I see, it means 'with you'.
So we could translate it, let see, ahaaa, May the Force be with You. Good! Good! Very good.

Now, I have managed to add CLEAR CHART function, to switch Open/Closed orders arrows on/off. After I figured out what 7bit's library code is doing, I had to modify it, just a little, don't be mad, Proffesor 7bit, I have huge respect to someone who programms like this and shares. Bow! Bow!

For the TradedThisBar function, I was thinking, Chistabo, maybe you could use something like:
Check ALL orders - if OrderOpenTime > iTime (...) TradedThisBar = true, else, ofcourse, false.
Now, why would you need this at all? Because sometimes I would like to open 'l position on the same (already traded) Bar. And the functions main reason is for EA not to open positions on every thick, too often.
AjDuNo, give it a try, Chistabo.

It was nice talking to myself,

Have fun,

Sajmon

PS: files on first post will be updated, if I figure it out how to do it. Well, if others can do it, I can do it too.

#3
Dec 3, 2010 5:17pm Dec 3, 2010 5:17pm

a_trader
| Joined Jun 2010 | Status: Trader | 113 Posts

all sorts of problems i see

for starters, globals are doubles, numbers only
boolean is a number, but shouldnt be used in globals
because when checking globals, 0 can be returned sometimes if theres a error or it doesnt exist
and 0 = false for boolean

you said the 1 trade per bar resets when you compile the ea
thats because in the deinit it deletes all the globals
you should only delete the globals necessary
if u delete all them in deinit, your not even using them, might as well not have them

when u compile a ea, it resets the ea on the chart, which means it re applies it, and it runs deinit

far as the objects on the chart
heres 1 that changes a boolean setting
this also shows how to use the globals
youl see im using 1=false 2=true

Inserted Code

  if (ObjectFind("gann_sl") == -1 ){
    ObjectCreate("gann_sl", OBJ_LABEL, 0, 0, 0);
    ObjectSet("gann_sl", OBJPROP_BACK, 0);
    ObjectSet("gann_sl", OBJPROP_CORNER, 0);
    ObjectSet("gann_sl", OBJPROP_XDISTANCE, 30);
    ObjectSet("gann_sl", OBJPROP_YDISTANCE, 320);}
    ObjectSetText("gann_sl","AUTO", 12,"Times New Roman",Gray);

    if (ObjectFind("gann_sl") != -1&&ObjectGet("gann_sl", OBJPROP_XDISTANCE)!=30){
    ObjectSet("gann_sl", OBJPROP_XDISTANCE, 30);
    ObjectSet("gann_sl", OBJPROP_YDISTANCE, 320);
    if (gann_sl)GlobalVariableSet(IsTesting()+Symbol()+"gann_sl",1); else GlobalVariableSet(IsTesting()+Symbol()+"gann_sl",2);
    }
    if (GlobalVariableGet(IsTesting()+Symbol()+"gann_sl")==1)gann_sl=false;
    if (GlobalVariableGet(IsTesting()+Symbol()+"gann_sl")==2){gann_sl=true;}
 if (gann_sl)ObjectSetText("gann_sl","AUTO", 12,"Times New Roman",White);
 if (!gann_sl)ObjectSetText("gann_sl","AUTO", 12,"Times New Roman",Gray);

heres 1 that executes a command

Inserted Code

         if (ObjectFind("closeall") == -1 ){
    ObjectCreate("closeall", OBJ_LABEL, 0, 0, 0);
    ObjectSet("closeall", OBJPROP_BACK, 0);
    ObjectSet("closeall", OBJPROP_CORNER, 0);
    ObjectSet("closeall", OBJPROP_XDISTANCE, 30);
    ObjectSet("closeall", OBJPROP_YDISTANCE, 220);}
    ObjectSetText("closeall","close all", 12,"Times New Roman",Yellow);

    if (ObjectFind("closeall") != -1&&ObjectGet("closeall", OBJPROP_XDISTANCE)!=30){
    close_all();
        orders();
    run_target();
    ObjectDelete("closeall");
    }

#4
Dec 4, 2010 7:48am Dec 4, 2010 7:48am

Chistabo
Joined Apr 2009 | Status: Trader | 191 Posts

Hello!

Thanks for tips, a trader!

ThisCode tips have been incorporated. And Murphy came along.

I have added ForceTrade function. And ClearArrows - for StopLoss and Tester arrows. And have rewritten TradedThisBar function.
Now it won't trade at all. But have updated my WannaBeCoder skills. Ex.:
- select orders:
for (int ord = 0; ord < OrdersTotal(); ord ++) - returns weird results
for (int ord = TotalOrders()-1; ord >= 0; ord --) - returns correct results

Still need to sleep over 'for' loops and 'return', 'continue' and 'break' operators. And nesting...

TradedThisBar function now looks like this:

Inserted Code

//----- TRADED THIS BAR FUNCTION - NUEVO - CHECK ORDERS OPENED - GV 1 = TRUE- GV 2 = FALSE ------------------------------------------------------------------
void CheckOrdersOpened (int magic)
   {
   int Total = OrdersTotal();
   for( int orde = Total-1; orde >= 0; orde --) // this IS right CODE for open orders - check, trail, close orders
      {
      int OpenTime = OrderOpenTime();
      int Ticket = OrderTicket();
      OrderSelect (orde, SELECT_BY_POS, MODE_TRADES);
         {
         if (OrderSymbol() == Symbol() && OrderMagicNumber() == magic)
            {
            if (OrderOpenTime() >= iTime (NULL, OncePerBarTF, 0))
               {
               Print ("Found OPEN order opened in this TradeOnce Bar! - GV TradedThisBar_ -> TRUE! " + Symbol() + " " + TimeToStr (TimeCurrent(), TIME_DATE | TIME_MINUTES));
               Print ("No: " + orde + " - Ticket: " + OrderTicket() + " " + Symbol () + " - Open time: "
               + TimeToStr (OrderOpenTime(), TIME_DATE | TIME_MINUTES) + " > iTime = " + TimeToStr (iTime (NULL, OncePerBarTF, 0)));
               GlobalVariableSet ("TradedThisBar_" + Symbol() + IsTesting(), 1);
               }
            else GlobalVariableSet ("TradedThisBar_" + Symbol() + IsTesting(), 2);
//            return;
            }
//         return(0);
         }
//      return;
      }
//   return; //???
   }

It searches through Open (for Closed i have same function) orders and if OrderOpenTime > iTime {TradedThisBar = true}. Well, now have to debugg it.

Maybe I should stick to previous TradedThisBar function? DuNo.

So long, my friends, thank you all.

Our written words shall cross again.

Shall the Pips be with you!

Have fun,

Simon

PS: I do not dare to update the complete Code, since it is a mess right now. Seems reasonable, doesn't? Well yeah... Back to sleepless nights...

#5
Dec 9, 2010 8:07am Dec 9, 2010 8:07am

Chistabo
Joined Apr 2009 | Status: Trader | 191 Posts

Hello!

If somebody would be interested, this Code works just fine:
- at top

Inserted Code

...
datetime          TradedThisBar = 0; // this works
...

- init() function

Inserted Code

...
   if (!GlobalVariableCheck ("TradedThisBar_" + Symbol()))  GlobalVariableSet ("TradedThisBar_" + Symbol(), TradedThisBar);  // TDB
...

- start() function

Inserted Code

...
      if (!SignalsOnly)
         {
         if (GlobalVariableGet ("TradedThisBar_" + Symbol()) == iTime (NULL, OncePerBarTF, 0)) return(0);
         else TradedThisBar = iTime (NULL, OncePerBarTF, 0);
            {
            GlobalVariableSet ("TradedThisBar_" + Symbol(), TradedThisBar);
            Print ("GV TradedThisBar BUY -> FALSE, iTime = " +  TimeToStr (iTime (NULL, OncePerBarTF, 0)) + " at " + TimeToStr  (TimeCurrent(), TIME_DATE | TIME_MINUTES));
            }
         if (MoneyManagement) Lots = NormalizeDouble  ((AccountFreeMargin() * Risk / 100 / ((Ask - BuySL) / Point /  TickValue)), 2);
         if (Lots < MarketInfo (Symbol(), MODE_MINLOT)) Lots = MarketInfo (Symbol(), MODE_MINLOT);
         else Lots = Lots;
//----- CHECK FREE MARGIN --------------------------------------------------------------------------------------------
         if (AccountFreeMargin() < (1000 * Lots))
            {
            Print ("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
            }
         RefreshRates();
         buy (Lots, BuySL, 0, magic, name + " BUY " + Symbol());
         Print ("BUY order opened " + Symbol() + "!");
         return(0);
         }
...

Thank you all for help,

Have fun,

Simon

#6
Dec 9, 2010 12:48pm Dec 9, 2010 12:48pm

Wert
| Membership Revoked | Joined Mar 2010 | 7 Posts

I have a problem with the MACD EA. The thing is that not work SL and TP. Can somebody fix it please?

Thanks!

Attached File(s)

MACD Histogram_v2.mq4 16 KB | 331 downloads

#7
Dec 13, 2010 1:52pm Dec 13, 2010 1:52pm

Chistabo
Joined Apr 2009 | Status: Trader | 191 Posts

Hi, Wert!

Have you checked the Code? There is a line:
PureSAR = true; // TRUE:no SL, no TP, no TS

This might be the Reason.
You also need iMACD custom indicator in Indicators folder, but since you are not complaining about that, I guess you have that. And, as far as I know, FireDave (and CodersGuru and others involved in this EA) are Code Masters, so it MUST work.
Check your settings, and Expert tab, there are possible reasons for EA not working.

In the Future, please include more relevant information about your problem, like EA Settings, your Broker etc.

Have fun,

Simon

#8
Last Post: Jan 20, 2011 3:15pm Jan 20, 2011 3:15pm

Wert
| Membership Revoked | Joined Mar 2010 | 7 Posts

Quoting Chistabo

Disliked

Hi, Wert!

Have you checked the Code? There is a line:
PureSAR...

Ignored

Hi Chistabo!

The problem was pureSAR, as you said. Option was turned on. Now works as expected.

Thanks a lot!

Platform Tech
/
EA debugging help Please - SevenChi
Reply to Thread

0 traders viewing now

Options

Similar Threads

EA debugging help Please - SevenChi