What's wrong w/ this code?

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red
double varHigh[],varLow[];
int init()
  {
   SetIndexStyle(0,DRAW_LINE);
   SetIndexShift(0,varHigh);
   SetIndexStyle(1,DRAW_LINE);
   SetIndexShift(1,varLow);
   SetIndexLabel(0,"High Yesterday");
   SetIndexLabel(1,"Low Yesterday");
   SetIndexEmptyValue(0,0.0);
   SetIndexEmptyValue(1,0.0);
   IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS));
   return(0);
  }
int deinit()
  {
   return(0);
  }
int start()
  {
   int    counted_bars=IndicatorCounted(); int limit; 
   if(counted_bars<0) {Alert("counted bars < 0"); return(-1); }
   if(counted_bars>0) counted_bars--;
   limit=Bars-counted_bars;
   for(int shift=0; shift<limit; shift++)
   {
         varHigh[shift]=iHigh(NULL,PERIOD_D1,shift);
         varLow[shift]=iLow(NULL,PERIOD_D1,shift);
         Comment(varHigh[shift]," ",varLow[shift]);
   }   
   return(0);
  }
//+------------------------------------------------------------------+

Quoting atr

Disliked

There might be other ways to skin this cat but I've done it like this:

varHigh[shift]= iHigh(NULL,PERIOD_D1, iBarShift(NULL, PERIOD_D1, iTime(NULL,PERIOD_D1,shift))

Basically you need to give the shift value in D1 terms, not H1 terms, otherwise the value is incorrect.

I haven't tested the rest of your code. Good luck.

Ignored

Quoting magnumfreak

Disliked

In your original code, change NULL to Symbol()

Ignored

Quoting magnumfreak

Disliked

Weird because it is working on mine with that change.

Ignored

//+------------------------------------------------------------------+
//|                                               Daily High Low.mq4 |
//|                                Copyright © 2010, Nondisclosure00 |
//|                                               [url]http://no.link.yet[/url] |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2010, Nondisclosure00"
#property link      "[url]http://no.link.yet[/url]"
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red
int varTimeFrame=1440;
double varHigh[];
double varLow[];
int init()
  {
   SetIndexBuffer(0,varHigh);
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(1,varLow);
   SetIndexStyle(1,DRAW_LINE);  
   return(0);
  }
int deinit()
  {
   return(0);
  }   
int start()
  {
  
   datetime varTimeArray[];
   int    i,limit,y=0,counted_bars=IndicatorCounted();
    
// Plot defined timeframe on to current timeframe   
   ArrayCopySeries(varTimeArray,MODE_TIME,Symbol(),varTimeFrame); 
   
   limit=Bars-counted_bars+varTimeFrame/Period();
   for(i=0,y=0;i<limit;i++)
   {
      if (Time[i]<varTimeArray[y]) y++;    
      varHigh[i] = 0; varLow[i] = 0;
 /***********************************************************   
   Add your main indicator loop below.  You can reference an existing
   indicator with its iName  or iCustom.
   Rule 1:  Add extern inputs above for all neccesary values   
   Rule 2:  Use 'TimeFrame' for the indicator timeframe
   Rule 3:  Use 'y' for the indicator's shift value
 **********************************************************/  
      varHigh[i]=iHigh(NULL,varTimeFrame,y+1);
      varLow[i]=iLow(NULL,varTimeFrame,y+1);
   }  
   return(0);
  }
//+------------------------------------------------------------------+

Quoting Dredding82

Disliked

hey sup all...was reading thru this and you guys seem pretty good at coding, i have a inidicator i was hoping someone could add a sound alert to it for which i could pick the .wav file since i made up some custom .wav files for each pair

Ignored

Quoting Zen_Leow

Disliked

Please create a separate thread for your request. btw, that ADK Trigger Arrows indicator repaints badly. I can see it shifting the position of past arrows back and forth a few candles. I'd advise against using it. just my 2 cents

Ignored

for(int shift=0; shift<limit; shift++)
   {
         varHigh[shift]=iHigh(NULL,PERIOD_D1,shift);
         varLow[shift]=iLow(NULL,PERIOD_D1,shift);
         Comment(varHigh[shift]," ",varLow[shift]);
   }

Quoting scott89

Disliked

Inserted Code

for(int shift=0; shift<limit; shift++)
   {
         varHigh[shift]=iHigh(NULL,PERIOD_D1,shift);
         varLow[shift]=iLow(NULL,PERIOD_D1,shift);
         Comment(varHigh[shift]," ",varLow[shift]);
   }

The little problem here is that you are trying to draw the "shift" high/low on the "shift" day, you are drawing today's high/low on today's time period.
Or at least that's what i see, i might be wrong =)

Ignored

Quoting nondisclosure00

Disliked

Thanks Scott. I got the code corrected. See above.

Ignored

   for(int i=limit; i>=0; i--)
     {
      int bar_shift = iBarShift(NULL,tf,Time[i]);