My demo is going nuts trying to send some trades and getting a zillion 'invalid stop' error. I shall have another look at the code later on.
Vegas Algorithm auto-trader by Steve and Squalou
- #83
- Nov 19, 2010 3:09am Nov 19, 2010 3:09am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
OK, leaving aside the invalid stop thingy that I should not be getting as I am testing an an Alpari demo, are you sure you have the robot set with the same settings as your indis?
In your pm, to talk about a 50 EMA, yet your template has a 55. Your Rsi is 10 rather than the default 14.
You have confused the coder. If you confuse him then nobody else stands a chance.
How about posting your strategy as you are actually testing it, not as you described to me in your pm?
In your pm, to talk about a 50 EMA, yet your template has a 55. Your Rsi is 10 rather than the default 14.
You have confused the coder. If you confuse him then nobody else stands a chance.
How about posting your strategy as you are actually testing it, not as you described to me in your pm?
- #84
- Nov 19, 2010 3:20am Nov 19, 2010 3:20am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Whilst you are preparing your spec, here is an update to play with.
I had the Alf/MA conditionals the wrong way around, so the bot was comaring Alf with the MA, not the MA with Alf.
This should send the trades in the correct direction.
Possibly.
I had the Alf/MA conditionals the wrong way around, so the bot was comaring Alf with the MA, not the MA with Alf.
This should send the trades in the correct direction.
Possibly.
- #85
- Edited 4:29am Nov 19, 2010 4:27am | Edited 4:29am
Bob also asked me to code a version with Alf and Alma taking the place of the H4 MA's, so here it is.
I have not tested this.
Have had the 1st of these loaded for a while, no trades. So had a better look through the code to guess at what should be happening.
Decided to pull the plug on this for now & try the 2nd version from post 73.
Like the idea of dropping the H4 MA's.
Had 1 +53 pip trade. EA moved the SL up a little much this time, but still good.
2nd trade hit SL at +1 pip. Next week should be good.
Will dig a little deeper to work out what some of the parts of GetStaValues() are doing.
Also trying to work out the get_trend() function. Not too sure about the "pAlf<=pAlf" in the lines
if (Alma>=Alf && pAlf<=pAlf) return (up);
if (Alf<=Alma && pAlf>=pAlf) return (down);
Will compare to the "originals".
cheers scalpz
Target 2 : Stoploss in the green
- #86
- Nov 19, 2010 4:45am Nov 19, 2010 4:45am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Thanks once again Steve,
Have had the 1st of these loaded for a while, no trades. So had a better look through the code to guess at what should be happening.
Decided to pull the plug on this for now & try the 2nd version from post 73.
Like the idea of dropping the H4 MA's.
Had 1 +53 pip trade. EA moved the SL up a little much this time, but still good.
2nd trade hit SL at +1 pip. Next week should be good.
Will dig a little deeper to work out what some of the parts of GetStaValues() are doing.
Also trying to work out the get_trend() function....
if (Alma>=Alf && pAlf<=pAlma) return (up); etc
- #87
- Nov 19, 2010 5:17am Nov 19, 2010 5:17am
Definitely something wrong there. Without looking, I guess it should be
if (Alma>=Alf && pAlf<=pAlma) return (up); etc
Thanks for the quick confirm.
Will alter my copy.
Back to the rest of the ea logic.
cheers scalpz
Target 2 : Stoploss in the green
- #89
- Nov 19, 2010 6:29am Nov 19, 2010 6:29am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Ah I just worked that bit out from comparing to a vegas version.
Thanks for the quick confirm.
Will alter my copy.
Back to the rest of the ea logic.
cheers scalpz
Cheers
OK, leaving aside the invalid stop thingy that I should not be getting as I am testing an an Alpari demo, are you sure you have the robot set with the same settings as your indis?
In your pm, to talk about a 50 EMA, yet your template has a 55. Your Rsi is 10 rather than the default 14.
You have confused the coder. If you confuse him then nobody else stands a chance.
How about posting your strategy as you are actually testing it, not as you described to me in your pm?
. I'd been tinkering while you were coding the EA and my template had changed a little. Yes, the settings of 50 and 10 are fine. Those settings, for the most part, didn't affect the main issue, which was that of the alf/ma relationship, and I see you fixed that. Thanks.
I'm using IBFX, and didn't think Crims ECN needed to be True either, but it fixed the problem of invalid stops for me.
Mike
- #92
- Nov 19, 2010 7:56am Nov 19, 2010 7:56am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I'm using IBFX, and didn't think Crims ECN needed to be True either, but it fixed the problem of invalid stops for me.
Mike
They probably mentioned this somewhere - in the small print at the bottom of one of their endless emails about webinars and stuff that nobody reads.
Dipsticks.
- #93
- Nov 19, 2010 7:58am Nov 19, 2010 7:58am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Steve,
Am I right in guessing the Pinhead EA can be traded on any TF?
- #94
- Nov 19, 2010 8:05am Nov 19, 2010 8:05am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I found another bug in Pinhead's bot.
Fix attached.
Fix attached.
Not really a fan of this system. I cannot see it making much money. With systems like this, you are better off flipping a coin and trading.
Sorry for being so negative - back testing shows no promise and my demo account today has been given a battering by this system.
Mine did, too. But the bot ain't right.
Due to my inexperience and ignorance, Steve was unable to code the EA to behave exactly the way I had intended. Thanks to his patience and kindness, it's almost there.
In my last post, I requested one more small, but important, fix.I'll try to illustrate the theory behind it with the charts below. Maybe I can change your mind. The filters are there to, hopefully, minimize whipsawing. It's why they're adjustable in the user inputs. I experimented with numerous combinations and, IMO, defaults are adequate. The only change I've made is setting SL @ 15. As Steve mentioned in an earlier post, the MA also acts as a SL if it is less than the input SL.
Mike
