ForexKiwi's D1 Fibo trading auto-trader by Steve Hopwood

Quoting hiredwhip

Disliked

Steve and FK.......Steve another really nice Fib trader on a D1 chart.....FK a great strategy.......Looking forward to a lot of fun....

whip

Ignored

Quoting ForexKiwi

Disliked

Thanks Whip.

Another nice day on demo. I added USDCHF to my demo currencies and that ran nicely. Overall netted approx +120 pips today and that was with USDCAD taking a 160 pip loss. EURUSD and GBPUSD just added 20 pips each.

Steve, after we made the change to add trading hours the bot doesn't seem to take many trades in backtest, rather than the daily trades it was taking before that. Have you had the same?

Ignored

Quoting SteveHopwood

Disliked

I have not been backtesting today. I have been trying to make the damned thing work on my IBFX Aussie demo.

Nobody trade with these clowns. Without actually saying so, they carry on the US thingy of making trading with them damn-near impossible. They just do it differently.

Ignored

Quoting ForexKiwi

Disliked

Re the bot, I'm finding I have to shut down the platform after the new day starts for it to bring the fib lines over from the day before yesterday and therefore send the right trades.

Ignored

   if (OldBars != Bars )
   {
      GetSwing();
      DrawFib();
      OldBars = Bars;
   }//if (OldBars != Bars )

Quoting squalou

Disliked

Now, the other thing is:

as D1 candles will differ for different brokrs and different "trade bell" setting...
shouldn't our D1 bars be synchronized with "TradingHour"?

If we set TradingHour to 12, the brokr's D1 bars are late by 12 hours already.

Knowing that H1 bars will not differ for different broker shifts, we can build virtual D1 candles to be 24 consecutive H1 candles that start/end at TradingHour.

This would represent more accurately our actual D1 periods, right ?

The swinghigh/swinglow code could...

Ignored

Quote

Disliked

And GetSwing() would be called every hour rather than every (D1) candle.

Inserted Code

   static datetime lastH1bar=0;
   if(TimeCurrent()>=lastH1bar+3600) // once per Hour
   {
      lastH1bar=TimeCurrent();
      GetSwing();
      DrawFib();
   }

SQ

Quoting SteveHopwood

Disliked

I have adopted this in the hope that it will overcome the lazy D1 fib change. It will cause the fib to re-draw every hour, but this is hardly a monumental increase in processor use. Update in post 1.

Ignored

Quoting ForexKiwi

Disliked

Thanks. I'll try that. It may not be until tomorrow as no trades have hit TP or SL from yesterday, so I'll be letting them run. Will be interesting going forward to see if we are better to close any trades that haven't hit TP or SL after a day and start a new day fresh, or let them continue.

Ignored

Quoting ForexKiwi

Disliked

Steve, how hard would it be to add a close variable at a certain time which we can test? I'd like to see what difference it makes in backtesting to close after a certain number of hours eg 23, and then be ready to take the next days trade in whatever direction that should be.

Ignored

Quoting ForexKiwi

Disliked

Steve, how hard would it be to add a close variable at a certain time which we can test? I'd like to see what difference it makes in backtesting to close after a certain number of hours eg 23, and then be ready to take the next days trade in whatever direction that should be.

Ignored

Quoting SteveHopwood

Disliked

This makes sense. The trades are based on the direction established yesterday, so carrying them through into tomorrow is relying on luck to re-establish the momentum. For sure, I have demo trades that look as though they might still be open this time next year.

I have added a TradeCloseHour input to the bot. Post 1 for the update.

Ignored

Quoting SteveHopwood

Disliked

I knew there had to be a reason FK is not re-drawing the fib at the start of each new candle, so I had a look at the ftlr bot, which does this quite cheerfully.

Dimwit that I am, I had forgotten that before being re-drawn, a fib has to be deleted.

Fix for this in post 1; I have just watched it do its thing in a visual backtest, so it definitely works.

Possibly.

I have added a new section to post 1 - a most profitable pairs and settings section. I will add to them as users post them.

Ignored

Quoting hiredwhip

Disliked

Good Morning Steve,
The file I just downloaded from Post 1 show's an undefined variable and won't compile for me.....Hopefully It's not something I'm doing....

whip

Ignored

Quoting SteveHopwood

Disliked

Cheers whip. I must have saved it without compiling to check the code.

Fix in post 1.

Ignored

Quoting SteveHopwood

Disliked

I knew there had to be a reason FK is not re-drawing the fib at the start of each new candle, so I had a look at the ftlr bot, which does this quite cheerfully.

Dimwit that I am, I had forgotten that before being re-drawn, a fib has to be deleted.

Fix for this in post 1; I have just watched it do its thing in a visual backtest, so it definitely works.

Possibly.

I have added a new section to post 1 - a most profitable pairs and settings section. I will add to them as users post them.

Ignored

Quoting ForexKiwi

Disliked

Fantastic!...

Ignored

Quoting SteveHopwood

Disliked

Give me a formula to calculate the appropriate lot size and I will code it. Don't expect me to come up with the formula myself; I can't - my mid does not work like that.

Mind, why ever would you want to go away and leave a trading robot unattended? Not even in your wildest, most desperate nightmares should you consider doing this. The havoc to which you might return would haunt your nightmares for the rest of your life.

There is no such thing as a trading robot that can be left unattended. Not yet, anyhow. At the very least, you need to be close...

Ignored