Sorting Variables by Numerical Order | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Array Variables Cannot Receive Numerical Values 2 replies

numerical and historical order book data, where? 0 replies

AL-Bit (Numerical trading By AboSolamn And MifaForex ) 120 replies

Request for numerical indicator to show hh ll of the day 0 replies

Using numerical value in external's 2 replies

Attachments: Sorting Variables by Numerical Order
Exit Attachments

Sorting Variables by Numerical Order

  • #1
  • First Post: Nov 2, 2010 12:16pm Nov 2, 2010 12:16pm
Okay, I'm sure there's a way to do this, I'm just having a hard time figuring it out. Basically I have eight variables (both positive and negative) which are updated each tick and I would like displayed in numerical order. Any ideas?

Thanks.
  • #2
  • Nov 2, 2010 12:33pm Nov 2, 2010 12:33pm
rangebound shows a bubble sort here: post 6:
http://www.forexfactory.com/showthread.php?t=113090
  • #3
  • Edited 3:41pm Nov 2, 2010 12:39pm | Edited 3:41pm
I don't understand what you mean by "sorting a variable", but if I had 8 variables and I wanted to display their values in ascending numerical order, then I would code it something like this:

Inserted Code
  // Assign random values to 8 variables.......
  MathSrand(TimeLocal());
  double v1 = (MathRand()-16384)/100.0;
  double v2 = (MathRand()-16384)/100.0;
  double v3 = (MathRand()-16384)/100.0;
  double v4 = (MathRand()-16384)/100.0;
  double v5 = (MathRand()-16384)/100.0;
  double v6 = (MathRand()-16384)/100.0;
  double v7 = (MathRand()-16384)/100.0;
  double v8 = (MathRand()-16384)/100.0;

  // Sort them into numerical order (lowest to highest) by loading them into an array, and sorting the array.....
  double arr[8];
  arr[0]=v1; arr[1]=v2; arr[2]=v3; arr[3]=v4; arr[4]=v5; arr[5]=v6; arr[6]=v7; arr[7]=v8;
  ArraySort(arr);
  
  // Display the values of the sorted array.....
  Comment(DoubleToStr(arr[0],2)+"\n"+DoubleToStr(arr[1],2)+"\n"+DoubleToStr(arr[2],2)+"\n"+DoubleToStr(arr[3],2)+"\n"+
          DoubleToStr(arr[4],2)+"\n"+DoubleToStr(arr[5],2)+"\n"+DoubleToStr(arr[6],2)+"\n"+DoubleToStr(arr[7],2)+"\n");

Hope that helps to get you started.
  • #4
  • Nov 2, 2010 2:55pm Nov 2, 2010 2:55pm
Hey, thanks guys. That should help, although I'm looking to sort the variables in descending order, similar to what RR was trying to do in the thread kenz987 pointed to. Whether it's ascending or descending it probably shouldn't matter though.

Oh, the variables themselves are specific and not random (although I guess the data itself is?) so, it's more a matter of ranking them whenever they are updated and displaying them in descending order.

Thanks again.
  • #5
  • Nov 2, 2010 3:45pm Nov 2, 2010 3:45pm
To sort array in descending order:

ArraySort(array_name,WHOLE_ARRAY,0,MODE_DESCEND);

BTW, I merely used the MathRand() function to populate the variables with some initial values. In reality, they could be any values: prices, volumes, whatever.
  • #6
  • Nov 2, 2010 4:43pm Nov 2, 2010 4:43pm
Quoting hanover
BTW, I merely used the MathRand() function to populate the variables with some initial values. In reality, they could be any values: prices, volumes, whatever.
Yes, understood. There was no need to generate random numbers. So, in accord with your illustration this is what I did:

PHP Code
  double arr_3[8];
  arr_3[0]=372.0; arr_3[1]=-55.22; arr_3[2]=1123.11; arr_3[3]=456.44; arr_3[4]=-27.2; arr_3[5]=36.3; arr_3[6]=55.3; arr_3[7]=111.12;
  double v1 = arr_3[0];
  double v2 = arr_3[1];
  double v3 = arr_3[2];
  double v4 = arr_3[3];
  double v5 = arr_3[4];
  double v6 = arr_3[5];
  double v7 = arr_3[6];
  double v8 = arr_3[7];

  // Sort them into numerical order (lowest to highest) by loading them into an array, and sorting the array.....
  double arr[8];
  arr[0]=v1; arr[1]=v2; arr[2]=v3; arr[3]=v4; arr[4]=v5; arr[5]=v6; arr[6]=v7; arr[7]=v8;
  ArraySort(arr);
  
  // Display the values of the sorted array.....
  Comment(DoubleToStr(arr[7],2)+" | "+DoubleToStr(arr[6],2)+" | "+DoubleToStr(arr[5],2)+" | "+DoubleToStr(arr[4],2)+" | "+
          DoubleToStr(arr[3],2)+" | "+DoubleToStr(arr[2],2)+" | "+DoubleToStr(arr[1],2)+" | "+DoubleToStr(arr[0],2)+" | ");
You'll notice I created another array (arr_3[8]) and filled it with static numbers and used this to fill variables v1, v2, v3, etc. You can also see I reversed the order of the first array (in Comments field) so everything will display in descending order and, everything seems to work just fine.

However, when I substitute the second array variables with something like, "arrUSD[1]-arrUSD[2]" (which closely approximates format of data I'm trying to rank), all I get is a bunch of zeros? ...

I suppose I can always try what you mentioned here ... ArraySort(array_name,WHOLE_ARRAY,0, MODE_DESCEND); ... although I suspect it won't make any difference.

Oh well, it looks like we're barking up the right tree anyway.

Thanks.
  • #7
  • Nov 2, 2010 4:54pm Nov 2, 2010 4:54pm
Quoting ecTrade
However, when I substitute the second array variables with something like, "arrUSD[1]-arrUSD[2]" (this closely approximates the format of the data I'm trying to rank), all I get is a bunch of zeros? ...
If the value of arrUSD[1]-arrUSD[2] is less than 0.005, then DoubleToStr(arrUSD[1]-arrUSD[2],2) will show 0.00, i.e. round it to the nearest 2 decimal places
Perhaps you need to increase to something like DoubleToStr(arrUSD[1]-arrUSD[2],6)?

Not sure if that's causing the problem, but it's the only thing I can think of.
  • #8
  • Nov 2, 2010 5:08pm Nov 2, 2010 5:08pm
Yeah, I think you're right. All these values are less than 0.01 which, are "converted" after the fact (for sake of displaying in comments field), by dividing them by Point. However, I would just assume maintain them as doubles, for it may require other calculations later on.

So, I think all I need to do is divide everything by Point first before putting it into the array, and it should work.

Thanks a lot!
  • #9
  • Nov 2, 2010 5:18pm Nov 2, 2010 5:18pm
Okay, I just tried it and it works!!!
  • #10
  • Edited 2:00am Nov 3, 2010 12:44am | Edited 2:00am
Well, it almost works ... I still need to associate five other variables with the one I just ranked, albeit it's not the main variable. It's just the data.

This is what I've done so far, in accord with the Relative Strength indicator I've modified (attached):

PHP Code
   int cur = Y_Top; 
   int st = Y_Step;      
//----
   bool sym[8]; string sym2[8]; color clr[8];
   sym[0]=USD; sym2[0]="USD"; clr[0]=Color_USD;
   sym[1]=EUR; sym2[1]="EUR"; clr[1]=Color_EUR;
   sym[2]=GBP; sym2[2]="GBP"; clr[2]=Color_GBP;
   sym[3]=CHF; sym2[3]="CHF"; clr[3]=Color_CHF;
   sym[4]=AUD; sym2[4]="AUD"; clr[4]=Color_AUD;
   sym[5]=CAD; sym2[5]="CAD"; clr[5]=Color_CAD;
   sym[6]=JPY; sym2[6]="JPY"; clr[6]=Color_JPY;
   sym[7]=NZD; sym2[7]="NZD"; clr[7]=Color_NZD;

   double dsp[8],arr_1[8],arr_2[8];
   dsp[0]=arrUSD[1]-arrUSD[2]; arr_1[0]=arrUSD[1]; arr_2[0]=arrUSD[2];
   dsp[1]=arrEUR[1]-arrEUR[2]; arr_1[1]=arrEUR[1]; arr_2[1]=arrEUR[2];
   dsp[2]=arrGBP[1]-arrGBP[2]; arr_1[2]=arrGBP[1]; arr_2[2]=arrGBP[2];
   dsp[3]=arrCHF[1]-arrCHF[2]; arr_1[3]=arrCHF[1]; arr_2[3]=arrCHF[2];
   dsp[4]=arrAUD[1]-arrAUD[2]; arr_1[4]=arrAUD[1]; arr_2[4]=arrAUD[2];
   dsp[5]=arrCAD[1]-arrCAD[2]; arr_1[5]=arrCAD[1]; arr_2[5]=arrCAD[2];
   dsp[6]=arrJPY[1]-arrJPY[2]; arr_1[6]=arrJPY[1]; arr_2[6]=arrJPY[2];
   dsp[7]=arrNZD[1]-arrNZD[2]; arr_1[7]=arrNZD[1]; arr_2[7]=arrNZD[2];

   double arr_3[8];
   arr_3[0]=dsp[0]; arr_3[1]=dsp[1]; arr_3[2]=dsp[2]; arr_3[3]=dsp[3]; arr_3[4]=dsp[4]; arr_3[5]=dsp[5];
   arr_3[6]=dsp[6]; arr_3[7]=dsp[7];
   
   ArraySort(arr_3); // Display  values of sorted array.....
   
   Comment(DoubleToStr(arr_3[7]/Point,2)+" | "+DoubleToStr(arr_3[6]/Point,2)+" | "+DoubleToStr(arr_3[5]/Point,2)+
     " | "+DoubleToStr(arr_3[4]/Point,2)+" | "+DoubleToStr(arr_3[3]/Point,2)+" | "+DoubleToStr(arr_3[2]/Point,2)+
     " | "+DoubleToStr(arr_3[1]/Point,2)+" | "+DoubleToStr(arr_3[0]/Point,2)+" | ");
   
   for(i = 0; i < 8; i++)
     {
       if(sym[i]) // **
         {
           stat="=";
           if(arr_2[i]<arr_1[i]) stat="+";
           if(arr_2[i]>arr_1[i]) stat="-";
           sl(sym2[i], dsp[i], "Symb"+sym2[i], stat, cur, clr[i]);
           cur += st;
         }
     }
This is what one data string/querie looked like before I modified it, where there was one for each currency for a total of eight:

PHP Code
 if(USD)
     {
       if (arrUSD[2]<arrUSD[1])  sl("USD", arrUSD[1] - arrUSD[2], "SymbUSD","+", cur, Color_USD);
       if (arrUSD[2]>arrUSD[1])  sl("USD", arrUSD[1] - arrUSD[2], "SymbUSD","-", cur, Color_USD);       
       if (arrUSD[2]==arrUSD[1]) sl("USD", arrUSD[1] - arrUSD[2], "SymbUSD","=", cur, Color_USD);              
       cur += st;
     }
If you load the indicator on a chart you will see it works the way it should ... or, I can't tell the difference between this and one that's not modified. You will also noticed the data variables are ranked correctly in the Comments field.

But, like I say, I still need to associate the other five variables with the data. If I can find a way to associate the sym[] variable, which is the main one, I should be able to get the rest of the variables to follow suit, I think ... or, we'll see.

Thanks.
Attached File(s)
File Type: mq4 CCFp_v1.0.2.1vert_0.mq4   23 KB | 437 downloads
  • #11
  • Edited Nov 4, 2010 10:16am Nov 3, 2010 12:24pm | Edited Nov 4, 2010 10:16am
Okay, it looks like I figured it out. I'm not sure how orthodox it is, but it appears to do the trick.

PHP Code
   int cur = Y_Top; 
   int st = Y_Step;      
//----
   bool sym[8]; string sym2[8]; color clr[8];      double arr_1[8];     double arr_2[8]; // **
   sym[0]=USD;  sym2[0]="USD";  clr[0]=Color_USD;  arr_1[0]=arrUSD[1];  arr_2[0]=arrUSD[2];
   sym[1]=EUR;  sym2[1]="EUR";  clr[1]=Color_EUR;  arr_1[1]=arrEUR[1];  arr_2[1]=arrEUR[2];
   sym[2]=GBP;  sym2[2]="GBP";  clr[2]=Color_GBP;  arr_1[2]=arrGBP[1];  arr_2[2]=arrGBP[2];
   sym[3]=CHF;  sym2[3]="CHF";  clr[3]=Color_CHF;  arr_1[3]=arrCHF[1];  arr_2[3]=arrCHF[2];
   sym[4]=AUD;  sym2[4]="AUD";  clr[4]=Color_AUD;  arr_1[4]=arrAUD[1];  arr_2[4]=arrAUD[2];
   sym[5]=CAD;  sym2[5]="CAD";  clr[5]=Color_CAD;  arr_1[5]=arrCAD[1];  arr_2[5]=arrCAD[2];
   sym[6]=JPY;  sym2[6]="JPY";  clr[6]=Color_JPY;  arr_1[6]=arrJPY[1];  arr_2[6]=arrJPY[2];
   sym[7]=NZD;  sym2[7]="NZD";  clr[7]=Color_NZD;  arr_1[7]=arrNZD[1];  arr_2[7]=arrNZD[2];

   double dsp[8],key; // **
   for(i = 0; i < 8; i++)
     {
       key=i*0.001; if(arr_1[i]-arr_2[i]<0){ key*=-1; }
       dsp[i]=NormalizeDouble((arr_1[i]-arr_2[i])/Point,2)+key;
     }

   double arr_3[8]; // **
   arr_3[0]=dsp[0]; arr_3[1]=dsp[1]; arr_3[2]=dsp[2]; arr_3[3]=dsp[3]; arr_3[4]=dsp[4]; arr_3[5]=dsp[5];
   arr_3[6]=dsp[6]; arr_3[7]=dsp[7];
   
   ArraySort(arr_3,WHOLE_ARRAY,0,MODE_DESCEND); // **
   
   string arr_4[8]; int var_1[8]; // **
   for(i = 0; i < 8; i++)
     {
       arr_4[i]=DoubleToStr(arr_3[i],3);
       arr_4[i]=StringSubstr(arr_4[i], StringLen(arr_4[i])-1, StringLen(arr_4[i]));
       var_1[i]=StrToInteger(arr_4[i]);
     }
  
   if(Comments) // **
     {
       Comment(DoubleToStr(arr_3[0],2)+" | "+DoubleToStr(arr_3[1],2)+" | "+DoubleToStr(arr_3[2],2)+
       " | "+DoubleToStr(arr_3[3],2)+" | "+DoubleToStr(arr_3[4],2)+" | "+DoubleToStr(arr_3[5],2)+
       " | "+DoubleToStr(arr_3[6],2)+" | "+DoubleToStr(arr_3[7],2)+" | n"+
       "| "+var_1[0]+" | "+var_1[1]+" | "+var_1[2]+" | "+var_1[3]+" | "+var_1[4]+" | "+var_1[5]+
       " | "+var_1[6]+" | "+var_1[7]+" |");
     }
   
   for(i = 0; i < 8; i++) // **
     {
       int v=var_1[i]; if(Old_Code){ v=i; }
       if(sym[v])
         {
           stat="=";
           if(arr_2[v]<arr_1[v]) stat="+";
           if(arr_2[v]>arr_1[v]) stat="-";
           sl(sym2[v], dsp[v], "Symb"+sym2[v], stat, cur, clr[v]);
           cur += st;
         }
     }
Basically it entailed determining variables arr_1[] and arr_2[] first, and basing variable dsp[] upon that. I then normalized it to two places and added a third digit (the key) based upon the array value of dsp[].

This is the code here:

PHP Code
   double dsp[8],key; // **
   for(i = 0; i < 8; i++)
     {
       key=i*0.001; if(arr_1[i]-arr_2[i]<0){ key*=-1; }
       dsp[i]=NormalizeDouble((arr_1[i]-arr_2[i])/Point,2)+key;
     }
I deciphered it by creating variables arr_3[], arr_4[] and var_1[].

The updated version of the indicator is attached below.

ETA: Modified code on EA ...
Attached File(s)
File Type: mq4 CCFp_v1.0.2.1vert_1.mq4   23 KB | 493 downloads
  • #12
  • Nov 3, 2010 12:38pm Nov 3, 2010 12:38pm
Oh, if anybody can tell me how to access variables sym[v] and dsp[v] via an EA that would be greatly appreciated. In the meantime I'll probably just set it up as globals until I can find a better way to do it.

Also, the indicator doesn't appear to be refreshing on the opening of a new bar, which is necessary if I intend to make an EA out of it. If somebody could point me in the right direction there, that would be appreciated too.
  • #13
  • Last Post: Nov 4, 2010 10:07am Nov 4, 2010 10:07am
In case anyone is interested, I started a new thread regarding the repaint issue here. There appears to be something wrong with the original code, although I can't be 100% certain about that.

Thanks.
0 traders viewing now