Dynamic (Magic Number) - Randomizing | Page 3 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Dynamic TakeProfit & Dynamic StopLoss EA/AI/Algorithm 0 replies

Need Script/EA can only generate Magic number 5 replies

GBPUSD Magic Number 45 replies

can we manually assign a magic number 4 replies

Ever seen this magic number bug? 4 replies

Dynamic (Magic Number) - Randomizing

  • #41
  • Sep 16, 2010 8:36am Sep 16, 2010 8:36am
If the MN is generated for example for USDCAD on timeframe H1, and a trade is entered, then the user changes the chart to 30min, how does the EA manage the order?
I think this is where the range would help, so once placed it can manage all trades within its range BUT you could get a duplicate if your not careful with switching xhart timeframes. I guess the period could be hard coded.

I use an EA where I place lines on the chart and orders are sent. If I change the timeframe this could screw me up. I would say in this case I'm better off using a modified hash of some sort.
Tipster Trendlines - Trade from the chart
  • #42
  • Sep 16, 2010 10:08am Sep 16, 2010 10:08am
Quoting Tipster
I think this is where the range would help, so once placed it can manage all trades within its range BUT you could get a duplicate if your not careful with switching xhart timeframes. I guess the period could be hard coded.
You can always make it timeframe specific when sorting the orders as well, I believe. Of course I rarely sort it according to timeframes myself.
  • #43
  • Sep 16, 2010 10:18am Sep 16, 2010 10:18am
Quoting 7bit
But why on earth would one ever want to change the numbers randomly between trades?
So the broker can't keep track of what you are doing in that particular trading session? I don't know, maybe it's overkill? Albeit it's still a relatively simple idea.
  • #44
  • Sep 16, 2010 11:58am Sep 16, 2010 11:58am
Quoting Tipster
I use an EA where I place lines on the chart and orders are sent. If I change the timeframe this could screw me up. I would say in this case I'm better off using a modified hash of some sort.
I have similar EAs (timeframe independent, one of them is almost like you describe with drawing lines, etc.). Instead of making the hash with
Inserted Code
magic = makeMagicNumber(WindowExpertName() + Symbol() + Period());
i simply use
Inserted Code
magic = makeMagicNumber(WindowExpertName() + Symbol());
and this will give me the same magic on all timeframes of that pair. Problem solved.
  • #45
  • Edited 12:26pm Sep 16, 2010 12:08pm | Edited 12:26pm
Quoting ecTrade
So the broker can't keep track of what you are doing in that particular trading session? I don't know, maybe it's overkill? Albeit it's still a relatively simple idea.
I don't care what the broker keeps track of. I trade with him so he will be able to see my trades. If he wants to watch me trading in real-time because he has nothing else to do he can do so anyways. If he wants to know why I'm so profitable he can run all sorts of statistical analysis on my history, I don't care. If he wants to mirror my trades with $BIG_LOTS then please let him do so, the weight of his lots will be on my side.

If your strategy is not profitable then it is not because the broker is screwing your trades, it is simply because your strategy is not profitable. This is the 99.9999% reason why a strategy fails. Because it simply does not work.

If the broker would intentionally mess up my trades I would close my account because I could not stop him from doing so anyways, no matter how random my numbers are. You cannot hide from your broker, either you trust him and trade with him or not.
  • #46
  • Sep 16, 2010 2:15pm Sep 16, 2010 2:15pm
Quoting 7bit
I don't care what the broker keeps track of.
So, why didn't you just say so in the first place? It was the whole point behind creating this thread by the way.

Quoting bluemele
Hi Ronald,

Thanks for the explanation. I guess that makes sense.

I guess the concern is that they supposedly are 'tracked' by the broker and if there is a way to do a client side tracking or some way to hide it from the broker. I am sure you have already thought of all of this, but trying to figure a way to hide my EA live.

Any idea's on how to do that is appreciated...

---I am becoming paranoid from some of the posts I am reading on this forum...
  • #47
  • Sep 16, 2010 2:43pm Sep 16, 2010 2:43pm
Quoting ecTrade
So, why didn't you just say so in the first place? It was the whole point behind creating this thread by the way.
Because the thread title could be misleading and to make people who might read this later understand that the intention of the original posting makes no sense and the only reason one would really want to auto-generate a magic number is to make it more user friendly and remove the need to manage it manually.

People should direct their energy into the creation of profitable trading strategies and into making their EAs robust and failsafe and not waste their time (and the time [or even money] of their potential users) with needlessly complicating them and inventing "features" that serve no other purpose than being complicated non-solutions to non-problems and snake-oil to satisfy the trader-paranoia while the real problems stay completely unaddressed and additional problems are even added.
  • #48
  • Sep 17, 2010 3:14am Sep 17, 2010 3:14am
Notwithstanding that you seemed to be more than willing to offer your own solution to this so-called "non-problem."

I only offered my idea because I thought there might be a genuine issue here, not merely add to the confusion as you seem to imply.
  • #49
  • Sep 17, 2010 8:51am Sep 17, 2010 8:51am
Quoting ecTrade
Notwithstanding that you seemed to be more than willing to offer your own solution to this so-called "non-problem."
You misunderstood me: The hash is not a solution to the non-problem of brokers being able to group your trades, its a solution to the real problem of accidental magic number conflicts that might arise when there are many different EAs running on even more different charts and the user has to manually make sure that they are all unique and always stay the same or are re-initialized to their same old value after a crash or reboot, timeframe change or recompile etc.

Its just automating a tedious and error prone task that is calling for automation. It makes the EA more robust and user friendly.
  • #50
  • Oct 1, 2010 3:30am Oct 1, 2010 3:30am
Just a quick question guys. When you use the same EA on different currencies, you have to change the magic number on each couple, or you can use the same magic number? I mean the EA in order to identify which trade is which, it uses the magic number AND the currencies involved, or just the magic number? Because if it is the latter, I guess it's essential to change the magic number for each trade, otherwise it doesn't matter...

Can someone enlight me pls?

Thanks in advance!
  • #51
  • Oct 1, 2010 9:50am Oct 1, 2010 9:50am
Quoting twamta
Just a quick question guys. When you use the same EA on different currencies, you have to change the magic number on each couple, or you can use the same magic number? I mean the EA in order to identify which trade is which, it uses the magic number AND the currencies involved, or just the magic number? Because if it is the latter, I guess it's essential to change the magic number for each trade, otherwise it doesn't matter...
EA's track trades based on Magic Number only (if they infact apply a magic number to the pair they trade)
So broadly, same/different multiple EA on same/different pair should be set with different magic numbers, if you want them to work/manage trades , not hindering with others.
(IMO Exception may be there in case say magic number is hard coded, something dependent on say comment, which is further say dependent on "Pair name + a fixed number", in which case multiple EA on different pairs, will work properly, as far as i can think)
Hope this helps.

P.S. Note: i ain't a pro programmer
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #52
  • Oct 2, 2010 3:44am Oct 2, 2010 3:44am
Radom choosen magic number can be a large benefit for EA traders as i am pretty sure brokers see the magic number and use it to bring profitable experts down.

Alltough i am far away from beeing a professional programer i think best way is to use a dll what picks the magic number from s simple .txt file. With this way a large number of numbers can be used and the broker will hava a hard time to recognize the EA.

At least when the same is done with TP, SL and other parameters.
  • #53
  • Jul 19, 2011 8:10am Jul 19, 2011 8:10am
Quoting JohnFX_King
Radom choosen magic number can be a large benefit for EA traders as i am pretty sure brokers see the magic number and use it to bring profitable experts down.

Alltough i am far away from beeing a professional programer i think best way is to use a dll what picks the magic number from s simple .txt file. With this way a large number of numbers can be used and the broker will hava a hard time to recognize the EA.

At least when the same is done with TP, SL and other parameters.

.. if you notice broker messing with you EA change to another broker or ECN or STP intemediary !! Why waste time with bucket shops? I never understood why people open accounts with these small shops domiciled in some banarebulic...!? To my experinece solid intermediaries are, Alpari UK (Ask for Pro feed! + 20k), OANDA (Broker), MB Trading (ECN), ATC (ECN), FXCM (NDD, expensive!)... I speak from experince as i lost one deposit to a bucket shop frad...
  • #54
  • Jul 19, 2011 8:56am Jul 19, 2011 8:56am
Quoting 7bit
It should not only be unique but also stay fixed or repeatable because you need the same number again later if you want to close the trades. And there can be crashes and reboots between open and close. Nobody wants an EA that will not automatically pick up its own trades and continue where it left after a reboot. Thats the whole purpose of all this magic number stuff and nothing else: grouping orders and always being able to find the EA's own orders. Otherwise you could just leave it completely away.
Yes, I totally agree! magic number should be genarated random so that same number would prevail after restarting from platform crash. Now would be great to find a piece of code that accomplish this!
I think good Random Magic need 3 things:
1) Proper random number generation
2) cheking that number not already in use (low propability, but still should check)
3) Same number used after EA recovered from platform crash.
  • #55
  • Jul 19, 2011 9:40am Jul 19, 2011 9:40am
Quoting kennyhubbard
Hi Ronald,

Here is the gist of the code......obviously it need to be properly incorporated into an EA........

[code]int AutoMagic()
{
string
Cur1 = StringSubstr(Symbol(),0,3),
Cur2 = StringSubstr(Symbol(),3,3),
magic1 = 0,
magic2 = 0;

int
Period_ID = 0;

if (Cur1 == "EUR") magic1 = 1;
if (Cur1 == "GBP") magic1 = 2;
if (Cur1 == "USD") magic1 = 3;
if (Cur1 == "AUD") magic1 = 4;
if (Cur1 == "CHF") magic1 = 5;
if (Cur1 == "CAD") magic1 = 6;
if (Cur1 == "JPY") magic1 = 7;...
Not sure if I understood you code correctly, but this code keep generating new random Magic all the time, reason being that:
Inserted Code
while (GlobalVariableCheck(AutoMagic)){                                                                         // if MagicNumber already exists  then increment
this will return true all the time since this will check in Global Variable exits, not that if the GV value exits and keep incrementing counter!

I think you should use :

Inserted Code
GlobalVariableGet(AutoMagic)

to check if CV value exist. I'm not programmer so just my 5 cents worth...
  • #56
  • Last Post: Edited 11:16pm Jun 3, 2025 7:26pm | Edited 11:16pm
A simple way to keep magic numbers unique is to just use the year month and day. if you create more than one EA in a day just add an extra digit. For example, today is June 4th, 2025 so the magic number for an EA I created today would be 250604. If I create a second EA today it would have magic number 2506042, a third 2506043 and so on. This guarantees uniqueness until 2125 and keeps them mostly to six digits, well within the range of integers. Don't be tempted to leave out the zeros, Jan 11th and Nov 1st would duplicate etc.

If you want a random number to be the magic number and for it to change on each EA load you could use "int magic_number = MathRand();" to generate it then use ObjectCreate and ObjectSet to display it on the chart window and/or use FileWrite to write/append it to a text file. The odds of duplication are low but you could create a function and run it in 'void init()' to read in previously created magic numbers from the text file and read/select each open trade and check for duplicates.
0 traders viewing now