Simple close script - some help with code needed | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help Needed With Simple EA Code 6 replies

2 simple lines of code needed, please help 18 replies

Close Current Pair Script - Need some help 2 replies

Simple Scalping Script Needed 1 reply

Simple script for trailing stop needed 2 replies

Simple close script - some help with code needed

  • #1
  • First Post: Edited 11:36pm Sep 15, 2010 9:43pm | Edited 11:36pm
Hello folks.

I'm trying to make myself some kind of a code which will close orders.

Here it is:

Inserted Code
switch(type2)
           {
            case OP_BUY  :
            case OP_SELL  : result = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 5,CLR_NONE);
            break;
            case OP_BUYSTOP:
            case OP_SELLSTOP: result = OrderDelete( OrderTicket() );
            break;
            }
     
         if(result == false)
            {
            Alert("Order " , OrderTicket() , " failed to close. Error:" , GetLastError() );
            Sleep(3000);
            }
I really don't understand the "return" parameter yet. I bet it's easy, if somebody can explain it to me different than what the help tells me. So far I just don't get it.
My concern here is that I want the programm to sleep for three seconds, if an error occurred, but I don't tell it to start over and try again. How can I do that?

Don't I have to add something like a return(-1), which afaik will make the program go back to the next outside bracket, which should be the start of this "switch"-code, right?

Thanks for your time in advance.

Greetings.
MikeFT
  • #2
  • Sep 16, 2010 12:15am Sep 16, 2010 12:15am
Mike,

Here is a sample code :-

Inserted Code
bool result;
   while(OrdersTotal() > 0){
      RefreshRates();
      OrderSelect(0,SELECT_BY_POS);
      if(OrderType()<2)result = OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
      else result = OrderDelete(OrderTicket());
      if(!result)Sleep(3000);
   }

A few comments. The coding purists will have you believe that you need all sorts of complicated error handling. My theory is that is fine with opening orders but when you have several orders that you want to close, error handling means zip....you need brute force. This code will do just that.....it will keep on trying to close your orders until the broker cuts you off, or your computer crashed from excessive logfiles.

The 'return' statement tells your code to drop everything and leave the current function right now. It goes back to the line that called the function. Whether you should return -1 or not, depends on what the calling expression expects. Remember a function is nothing more that a calculated variable, so it can return a string, an integer, a double......etc. Your return statement would be the result of whatever the functions purpose is.

Use 'break' and 'continue' if you want to move out of loops but stay within the current function.
  • #3
  • Last Post: Sep 17, 2010 2:18am Sep 17, 2010 2:18am
Quoting MikeFT
Hello folks.

I'm trying to make myself some kind of a code which will close orders.

Here it is:

I really don't understand the "return" parameter yet. I bet it's easy, if somebody can explain it to me different than what the help tells me. So far I just don't get it.
My concern here is that I want the programm to sleep for three seconds, if an error occurred, but I don't tell it to start over and try again. How can I do that?

Don't I have to add something like a return(-1), which afaik will make the program go back to the next outside...

Here is script I use, i will keep trying to close all trades until none are open, you can change to your needs, set the slippage to your needs ( 2ns to last parameter on OrderClose )

The return is use for Functions to returns a result to the caller, if you donīt need is just use return;

Inserted Code
          
int start()
{   
    
  int total = OrdersTotal();
  for(int i=total-1;i>=0;i--)
  {
    OrderSelect(i, SELECT_BY_POS);
    int type   = OrderType();
    bool result = false;
    
   
    RefreshRates ();
    switch(type)
     { 
      //Close opened long positions
      case OP_BUY       : result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );
                          break;
      //Close opened short positions
      case OP_SELL      : result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );
     }
    if(result == false)
    {
      Alert("Order " , OrderTicket() , " failed to close. Error:" , GetLastError() );
      Sleep(3000);
    }  
  }


      
      
   return(0);
}
0 traders viewing now