trying to write a script that emails me | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Basic Alt Key/Entry Script - Simplest Script Ever 1 reply

trying to make a multipair buy and sell script 6 replies

i like to add an indicator script into my own script. what would be the best idea? 3 replies

Custom indicator that emails 1 reply

Mobile notification of your emails (Yahoo/Hotmail) 2 replies

trying to write a script that emails me

  • #1
  • First Post: Sep 13, 2010 3:58pm Sep 13, 2010 3:58pm
The script is supposed to email me when a candle closes at the same price or -2 to +2 pips from the opening price. I want to be able to be able to email all the pair names...I'm not getting much ATM. Also how would I be able to incorporate time frames to this???


Inserted Code
int start()
  {
int value = iOpen(NULL,0,1)-iClose(NULL,0,1);
 
      if (iClose(NULL,0,1) == iOpen(NULL,0,1) || value == 2 || value == 1 || value == -1 || value == -2)
       {
       SendMail("from your expert", "Price dropped down to "+Symbol());
       }
   return(0);
  }
  • #2
  • Edited 5:40pm Sep 13, 2010 5:18pm | Edited 5:40pm
Quoting DBallerz
The script is supposed to email me when a candle closes at the same price or -2 to +2 pips from the opening price. I want to be able to be able to email all the pair names...I'm not getting much ATM. Also how would I be able to incorporate time frames to this???


[code]int start()...
Where should I begin?

Inserted Code
       if (iClose(NULL,0,1) == iOpen(NULL,0,1) || value == 2 || value == 1 || value == -1 || value == -2)
better:
Inserted Code
       if (MathAbs(value) <= 2 * Point)    // or 20 for the 5 digit brokers
now you need some code for calling this only once on a new bar:

+++ untested code +++
Inserted Code
int start() {
   static int lasttime;
   double diff;
   if (Time[0] != lasttime) {
      lasttime = Time[0];
      diff = MathAbs(iOpen(NULL, 0, 1) - iClose(NULL, 0, 1)) / Point;
      if (diff <= 2) {    // or 20 for the 5 digit brokers 
         SendMail(...);
      }
   }
}


You are new to coding, therefore one important (offtopic but very important) advice before it is too late and everything is lost:

Please from now on format your code like the above (my) example (this is the one true style 1TBS like it is also commonly used in Java) from the beginning on. You will become a better coder. Don't get ever used to all these ugly alternative Allmann/BSD/GNU/whatever styles and all their variants. They look ugly, you never know where exactly to place the braces, the auto-indentation of the editor won't be very cooperative in most cases, they use up twice as much room and generally badly hurt the eyes.

Opening brace always at the end of the line is a simple rule and looks nice and compact.
  • #3
  • Sep 13, 2010 5:48pm Sep 13, 2010 5:48pm
I am indeed new to coding hehe, I've always had trouble with braces and closing them, thank you for the tip. Time[0] means it looks for the closing of price at 0 aka 12pm right? Is it a better idea to change it to 11:59 maybe? As for time frames, all I have to do is load this indicator onto a chart with the appropriate time frame correct?

Also, what does / Point do?
  • #4
  • Sep 13, 2010 6:00pm Sep 13, 2010 6:00pm
Quoting DBallerz
I am indeed new to coding hehe, I've always had trouble with braces and closing them, thank you for the tip. Time[0] means it looks for the closing of price at 0 aka 12pm right? Is it a better idea to change it to 11:59 maybe? As for time frames, all I have to do is load this indicator onto a chart with the appropriate time frame correct?

Also, what does / Point do?
Time[0] is always the opening of the current (incomplete) bar. Whenever this changes we know that a new bar just began and then do our things that must be done only once on bar open.

iClose(Null, 0, 1) refers to the previous now just completed bar. We could also have used

Close[1] - Open[1]

instead of

iClose(Null, 0, 1) - iOpen(Null, 0, 1)

which is equivalent but I just copypasted fragments of your code.

diff is a price difference, something like 0.0003 and Point is the fixed value of a pip 0.00001 or 0.0001 depending on the boker. diff/pip is then the difference in pips.
  • #5
  • Sep 13, 2010 6:04pm Sep 13, 2010 6:04pm
Quoting 7bit
Time[0] is always the opening of the current (incomplete) bar. Whenever this changes we know that a new bar just began and then do our things that must be done only once on bar open.

iClose(Null, 0, 1) refers to the previous now just completed bar. W could also have used

Close[1] - Open[1]

instead of

iClose(Null, 0, 1) - iOpen(Null, 0, 1)


diff is a price difference, something like 0.0003 and Point is the fixed value of a pip 0.00001 or 0.0001 depending on the boker. diff/pip is then the difference in pips.
Well I've dragged it to the M1 chart to test it out and got the + candlestick and no email. Yes, I've tested the Mail under Options and I've recieved the Test Email. It won't be loaded as a Custom Indicator as well, only a Expert Advisor. Any ideas on what is wrong? Apologies from a noob.
  • #6
  • Edited 6:25pm Sep 13, 2010 6:11pm | Edited 6:25pm
Insert some Print() and look at the experts tab (log) what it outputs. This is easier than waiting for emails for testing and debugging.

Inserted Code
int start() {
   static int lasttime;
   double diff;
   if (Time[0] != lasttime) {
      lasttime = Time[0];
      diff = MathAbs(iOpen(NULL, 0, 1) - iClose(NULL, 0, 1)) / Point;
      [color=Red]Print("diff: " + diff);[/color]
      if (diff <= 2) {    // or 20 for the 5 digit brokers 
         [color=Red]Print("mail: " + diff);[/color]
      }
   }
}
still untested here because I am lazy and don't have metaeditor open.
  • #7
  • Last Post: Sep 13, 2010 6:12pm Sep 13, 2010 6:12pm
to run as an indicator it must contain the line
#property indicator_chart_window
at the top and put into the indicators folder. For testing and experimenting just leave it as an EA.
0 traders viewing now