Script fo Calculationg Lot size - Help needed | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Which would you prefer: increasing lot size or TP size? 24 replies

At what lot size/account size do you have scale issues? 39 replies

Please make a Buy/sell script with lot size calculator 2 replies

Lot size, contract size, max position ? 1 reply

BUY run profit 1 lot, SELL LIMIT 2 LOT down again n BUY 1 lot - EA Reqd 5 replies

Attachments: Script fo Calculationg Lot size - Help needed
Exit Attachments

Script fo Calculationg Lot size - Help needed

  • #1
  • First Post: Sep 9, 2010 5:33pm Sep 9, 2010 5:33pm
Hello folks,

I'm experimenting with some kind of code to calculate The Lotsize.
Inserted Code
extern double  Lots = 0.1;
extern double  StopLoss = 100;
extern double  RiskPerTradePercent = 5;

int start()
  {
    
      Lots = (AccountBalance() * RiskPerTradePercent/100) / ((MarketInfo(Symbol(),MODE_TICKVALUE) * StopLoss);
      Print("CalculatedLots: ", Lots());
   
   return(0);
  }
Two questions:

 

  1. I'm stuck right at the beginning with "unbalances left parenthesis"
    I don't see why! Could somebody please take a look.
  2. Whenever the LotSize will be calculated, I need to make sure that it will be a number MT understandes.
    I mean it must be 1.1, instead of 1.1045. How do I round the numbers?


Thanks.
MikeFT

Attached File(s)
File Type: mq4 TestRiskCalculation.mq4   < 1 KB | 576 downloads
  • #2
  • Edited 5:59pm Sep 9, 2010 5:41pm | Edited 5:59pm
1. Lots is a double not a function. Get rid of () in Lots().

2. Try this, but be sure you understand it thoroughly; it worked for me but it may not be what you need.

PHP Code
double minLots = MarketInfo(Symbol(), MODE_MINLOT);
   double stepLots = MarketInfo(Symbol(), MODE_LOTSTEP);
   
   double r = MathMod(calcLots, stepLots);
   if (r != 0.0) calcLots = calcLots - r;  // not a multiple, get rid of fractional part

   calcLots = MathMax(minLots, calcLots); // can't be smaller than MINLOT
   
   NormalizeDouble(calcLots, 2); // or 3 depending on broker
  • #3
  • Sep 9, 2010 6:13pm Sep 9, 2010 6:13pm
Thanks for your feedback. I removed the () behind "Lots". Sorry - I should have known that. But the error remains the same.

I'll look into your code. Thank you.

Here's the code after the change:

Inserted Code
extern double  Lots = 0.1;
extern double  StopLoss = 100;
extern double  RiskPerTradePercent = 5;

int start()
  {
    
      Lots = (AccountBalance() * RiskPerTradePercent/100) / ((MarketInfo(Symbol(),MODE_TICKVALUE) * StopLoss);
      Print("CalculatedLots: ", Lots);
   
   return(0);
  }
  • #4
  • Sep 9, 2010 6:50pm Sep 9, 2010 6:50pm
That seemed most obvious. They seems to be a ) needed after StopLoss or delete the extra ( before MarketInfo.
  • #5
  • Sep 9, 2010 8:05pm Sep 9, 2010 8:05pm


Attached File(s)
File Type: mq4 Buy with SL and TP without conf.mq4   2 KB | 468 downloads

Attached File(s)
File Type: mq4 Sell with SL and TP without conf.mq4   2 KB | 385 downloads
  • #6
  • Sep 9, 2010 9:12pm Sep 9, 2010 9:12pm
Quoting CodeMeister
That seemed most obvious. They seems to be a ) needed after StopLoss or delete the extra ( before MarketInfo.

I knew it was something like that. Just didn't see it. Thank you for your hint!

@andante9
Thanks. Will take a look at it.
  • #7
  • Sep 9, 2010 9:47pm Sep 9, 2010 9:47pm
Mike,

may i also suggest using a text editor such as NotePad++ instead of the Metaeditor. I find it very helpful in formatting my code as well as bracket checking.
  • #8
  • Sep 9, 2010 10:20pm Sep 9, 2010 10:20pm
@flyer415
How do you format the code in Notepad++?
I like this idea, but with the MetaEditor I like that I can Compile ever so often.

Thanks.
MikeFT
  • #9
  • Last Post: Sep 10, 2010 8:43am Sep 10, 2010 8:43am
I have Notepad++ open and Metaeditor open at the same time. I make the changes in NotePad++ and save it without closing it. Then i open the file in Meta and compile it. Test etc, make changes in Meta as required, compile and test. I close the file in Meta and then go back to NotePad++. NotePad++ tells you that there have been changes and do you want to accept them even though the changes were made in Meta and not NotePad++.

i like keeping Metaeditor open so i can use the dictionary and library help files. Sometimes i forget the order of parameters or capitals for a function.

Notepad++ is like any other editor in that it tracks the bracket issues, highlights bracket pairings in red, uses tabs well etc.
0 traders viewing now