OrderClose() issue on EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Partial OrderClose() 11 replies

Can I add a comment to an order closed with OrderClose()? 2 replies

OrderClose Error 145 during strategy tester 8 replies

OrderClose wont work 2 replies

OrderClose error 4107 1 reply

OrderClose() issue on EA

  • #1
  • First Post: Aug 27, 2010 1:14pm Aug 27, 2010 1:14pm
Hi All,

I am testing my EA and I am having an issue with OrderClose() in one of the functions, so I figured there may be a fancier way of getting it done. It is closing out most of the trades in the 'basket', but it is not closing out all of them. Please help.

The following code is a function and all that you would need I think:

Inserted Code
//+------------------------------------------------------------------+
double ProfitProtection()
//+------------------------------------------------------------------+
{
   bool     ClosedInProfit = 0;
   string   OrderSymbolClosedInProfit;
   double   TP;
   double   ProfitThisOrder;
   TakeProfit = OneSixthOfChart*2;
   TotalBasketProfit = 0;
   CurrentOrderProfit = 0;
   
   int OT = OrdersTotal();
   for(int bp=0; bp < OT; bp++) //cycle throug the open market orders  
   {
      if (OrderSelect(bp, SELECT_BY_POS, MODE_TRADES))
      {
         if (OrderSymbol()==Symbol() && OrderMagicNumber() == MagicNumber) 
         {
            TotalBasketProfit += OrderProfit() + OrderCommission() + OrderSwap();
            CurrentOrderProfit = OrderProfit() + OrderCommission() + OrderSwap();  
            if(OrderLots() != Lots && TotalBasketProfit >= MinimumProfitOfBasket)
            {
               ClosedInProfit = OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Center);
               OrderSymbolClosedInProfit = Symbol();
            }
         }
      }
      
      if(ClosedInProfit)
      {
         for(int co = 0; co < OrdersTotal(); co++)
         {
            if (OrderSelect(co, SELECT_BY_POS, MODE_TRADES))
            {
               if(OrderSymbol() == OrderSymbolClosedInProfit)
               {
                  OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Center);
               }
            }
         }
      }
   }
   //Comment("Basket: ", TotalBasketProfit);
}

Thank you for any assistance!
We are our own best indicator.
  • #2
  • Aug 27, 2010 1:50pm Aug 27, 2010 1:50pm
I figured it out..

I changed the code to the following:

Inserted Code
//+------------------------------------------------------------------+
double ProfitProtection()
//+------------------------------------------------------------------+
{
   bool     ClosedInProfit = 0;
   string   OrderSymbolClosedInProfit;
   double   TP;
   double   ProfitThisOrder;
   TakeProfit = OneSixthOfChart*2;
   TotalBasketProfit = 0;
   CurrentOrderProfit = 0;
   
   int OT = OrdersTotal();
   for(int bp=0; bp < OT; bp++) //cycle throug the open market orders  
   {
      if (OrderSelect(bp, SELECT_BY_POS, MODE_TRADES))
      {
         if (OrderSymbol()==Symbol() && OrderMagicNumber() == MagicNumber) 
         {
            TotalBasketProfit += OrderProfit() + OrderCommission() + OrderSwap();
            CurrentOrderProfit = OrderProfit() + OrderCommission() + OrderSwap();  
            if(OrderLots() != Lots && TotalBasketProfit >= MinimumProfitOfBasket)
            {
               ClosedInProfit = OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Center);
               OrderSymbolClosedInProfit = Symbol();
            }
         }
      }
      
      if(ClosedInProfit)
      {
         for (int co=OrdersTotal() - 1; co >= 0; co--)
         {
            if (OrderSelect(co, SELECT_BY_POS, MODE_TRADES))
            {
               if(OrderSymbol() == OrderSymbolClosedInProfit)
               {
                  OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Center);
               }
            }
         }
      }
   }
   //Comment("Basket: ", TotalBasketProfit);
}
We are our own best indicator.
  • #3
  • Aug 27, 2010 4:12pm Aug 27, 2010 4:12pm
Hi Gil,

So you discovered why they always tell you to count the orders down and not up........lol.

Anyway, here is a nice simple routine I use to close all. It is brute force and does not bother with the touchy feely error reports etc.....it will keep on trying to close your orders until it completes the task or your broker generates so many errors the platform crashes.

Inserted Code
void Close_All()
{
   while(OrdersTotal() > 0){
      OrderSelect(0,SELECT_BY_POS);
      RefreshRates();
      if(OrderType()<=1)OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
      else OrderDelete(OrderTicket());
   }
}

BTW, if you are closing hedged orders, there is a post that I made at MFB that shows a nifty way of closing those at double time.
  • #4
  • Aug 27, 2010 4:17pm Aug 27, 2010 4:17pm
Quoting kennyhubbard
Hi Gil,

So you discovered why they always tell you to count the orders down and not up........lol.

Anyway, here is a nice simple routine I use to close all. It is brute force and does not bother with the touchy feely error reports etc.....it will keep on trying to close your orders until it completes the task or your broker generates so many errors the platform crashes.

[code]void Close_All()
{...
What is MFB? I would be interested to look at it. This is good code. Much cleaner.

I am working at this and getting better.

Yes, I finally understand why you count down. haha....

YOU were the one who told me that, but I didn't listen, or atleast I forgot.. haha...
We are our own best indicator.
  • #5
  • Last Post: Aug 27, 2010 4:35pm Aug 27, 2010 4:35pm
Lol, at least now you understand why the need to count down. Knowing to count down is not quite the same as understanding why you should do it that way.

MFB == Myfxbook
0 traders viewing now