Code to check currentPosition?

My current function to check current position (0 = flat, 1 = long, -1 = short) is as follows:

int getCurrentPosition()
{
if (order_Ticket < 0)
{
return (0); //no position at the moment
}
else
{
if (OrderSelect(order_Ticket,SELECT_BY_TICKET,MODE_TRADES))
{
switch(OrderType())
{
//return opened long positions
case OP_BUY : return (1);
break;

//return opened short positions
case OP_SELL : return (-1);
break;
}
}
else if (OrderSelect(order_Ticket,SELECT_BY_TICKET,MODE_HISTORY))
{
return (0);
}
}
}


It doesn't work though. Anyone got a simpler, easier function?

Do you only have 1 position at a time?

In that case use OrdersTotal(). If it's > 0 then you have a position running, otherwise you're flat. If OrdersTotal() > 0, do a OrderSelect(0, SELECT_BY_POS) and then do your switch(OrderType()).

Hope you declare orderTicket when opening new positions? Otherwise use a for-loop to iterate through all open positions. Maybe you should even pay attention to your magic number?!

yeah, I used a similar approach to reply #1, except I used OrderCloseTime to figure out whether it was a closed order or open order. (Then used OrderType)

Guess that your function is right after an OrderSend() to check if the order was opened.

If so, you should try something like this :


FerruFx