Modify RR EA (Traffic Light)

I would like to modify an old RR EA (Traffic Light) to include a partial close feature. Close half position when in x pips profit with an on/off bool variable.

Before getting into a lot of coding detail, I would ask if a RR EA already exists that includes this feature in the logic format of the Traffic Light EA. If so please post it here. If I have something to follow, I believe I can handle the code.

I have been learning to code by studying/modifying Ronald's excellent work to include personal features.

Thanks!

Here is RR's CLOSEBUY code from Traffic Light:

//Check position
bool IsTrade = False;
for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber) {
IsTrade = True;
if(OrderType() == OP_BUY) {

if( (InvisibleStopLoss && UseStopLoss && OrderOpenPrice() >= Bid + StopLoss * Point) ||
(InvisibleTakeProfit && UseTakeProfit && OrderOpenPrice() <= Bid - TakeProfit * Point) )
Order = SIGNAL_CLOSEBUY;

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}

//MoveOnce
if(MoveStopOnce && MoveStopWhenPrice > 0) {
if(Bid - OrderOpenPrice() >= Point * MoveStopWhenPrice) {
if(OrderStopLoss() < OrderOpenPrice() + Point * MoveStopTo) {
OrderModify(OrderTicket(),OrderOpenPrice(), OrderOpenPrice() + Point * MoveStopTo, OrderTakeProfit(), 0, Red);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}

//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {

Here is what I would like to integrate:

extern bool PartialClose = True;
extern double PartialLots = 0.5;
extern double PartialProfitLevel = 0.00500;

****

if(PartialClose == True && IsTrade == True && OrderType() == OP_BUY && Bid == (OrderOpenPrice() + PartialProfitLevel) )
OrderClose(OrderTicket(), PartialLots, Bid, Slippage, MediumSeaGreen);

After testing a few times in different locations, I am uncertain where this should be placed and whether the code is correct or complete. In any case, the partial close does not occur.

Any help would be greatly appreciated!

By trial & error, I have found a solution that partially closes the trade and immediately opens a 2nd trade with the remaining lots and @ the original OrderOpenPrice(). Here are the changes I made:

if( (InvisibleStopLoss && UseStopLoss && OrderOpenPrice() >= Bid + StopLoss * Point) ||
(InvisibleTakeProfit && UseTakeProfit && OrderOpenPrice() <= Bid - TakeProfit * Point) || (PartialClose == True && IsTrade == True && OrderType() == OP_BUY && Bid
== (OrderOpenPrice() + PartialProfitLevel)) )
Order = SIGNAL_CLOSEBUY;

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), PartialLots, Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Partial Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}

This works here because I never use the InvisibleStopLoss/TakeProfit.

However, if after the partial close, Price retraces below the PartialProfitLevel and hits that level again, it closes the "2nd remaining lot trade".

Any ideas on how to avoid this so the trade runs until it's stopped out or hits take profit?

This is why I always split trades if I will partially close them

You can put a variable (before the start()) like
double partialisclosed=0;

Now, when the ea do a partialclose, you set partialisclosed=1;

And whenever the ea look for make a new partialclose, just add an if partialisclosed==0.

And when the position is stopped out or taken profit, just set again partialisclosed=0;

Hope it help

First, thanks for your response. Not sure how or where to code resetting to 0 when stopped out or hitting take profit. Everything else is pretty straight forward.

Dear sir, you can make a function that find the number of currently opened position with a certain magicnumber (or no magic number at all if you prefer), and when the opened positions are "0", then you can let the ea reset the stuff.

tunera,
Need a little help to finish Counter function. Please forgive my lack of knowledge here. I am a novice when it comes to programming. I love this stuff and want to learn. At any rate, here is what I have so far:

void PosCounter2()
{
int total = OrdersTotal();
for(int cntr = 0; cntr < total; cntr++)
{
OrderSelect(cntr, SELECT_BY_TICKET, MODE_TRADES);
if((OrderSymbol() == Symbol()) && (OrderMagicNumber() == MagicNumber))
}
}

I get the following compile message: "function returns no result". Can you help with the missing link?

Your help is much appreciated!

Hello,

I see that your function don't make any return.

If i would do it on my way, i would do it like this:

First, no function at all.

then, just put this soon after the start():

double openorders=0;
for(i=0;i<OrdersTotal();i++) {
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()==Symbol() && OrderMagicNumber()==Magicnumber)openorders++;
}
if(openorders==0)partialisclosed=0; // (the code to reset the partialcloses stuff)

Hope it help

Ok, that did it. The Partial Close is working beautifully.

Thanks once again for your expertise and generosity.

I believe I have added to my knowledge base with this little exercise.

I'm glad to see it work well, thank you too!
It's a pleasure for me

Hellou, it is I, Leclerc (he he...)!

tunera (Bow), your are great.

The logic is quite simple, but for us, weekend-coder, you guys are a great help. Thanks to the Big E too, for the question.

Big E, are you having any success with TraficLight EA from (Bow) RR?

Quote:
"I have been learning to code by studying/modifying Ronald's excellent work to include personal features." - same here, simple and effective.

Thank you for your help and cooperation,

Have fun,

Simon
Slovenia