Calculating Profit, etc | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

function for calculating profit doesn't work... 1 reply

6 MA indicator with auto-calculating pips/profit 0 replies

Help with calculating profit from multiple accounts 2 replies

Need help in calculating profit/loss 2 replies

Merc's special Fibonacci trading,in combo w/QQE Gann etc.etc. 7 replies

Calculating Profit, etc

  • #1
  • First Post: Aug 18, 2010 4:26pm Aug 18, 2010 4:26pm
I am hoping to get some code to help me calculate order totals. I will be looping through all orders, then through the usual select etc, then adding the $ value through each iteration.

Inserted Code
for(int i = 0; i < OrdersTotal(); i++)
      {
         if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
         {
            if(OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber)
            {
               if(OrderType() == 0)
               {
                  if(OrderComment() == "L")
                  {
                      LongsOrderProfit += (OrderProfit() + OrderSwap());
                      Print("Calculating Long Profit ", OrderType(), " ", LongsOrderProfit);
                  }

What is wrong w/ this logic? I seem to have no problem getting A calculation, however, it always ends up being much higher... seems to make sense to me...
We are our own best indicator.
  • #2
  • Aug 18, 2010 8:44pm Aug 18, 2010 8:44pm
Add in the OrderCommission() and you are good to go..............
  • #3
  • Aug 18, 2010 10:47pm Aug 18, 2010 10:47pm
Quoting kennyhubbard
Add in the OrderCommission() and you are good to go..............
Ok, wow, didn't even know that existed...

Considering Market Maker though, it wouldn't be required right?

Reason is, it doesn't seem to be adding up the right numbers...

That is why I think it is strange. It ends up coming up like 3.87 times the normal amount, then it changes, changes back,.... very confusing... Thanks for taking a look and will keep playing with it, but burnt out today..

Thanks Kenny!
We are our own best indicator.
  • #4
  • Aug 18, 2010 11:58pm Aug 18, 2010 11:58pm
Mmmmm, ok, that is strange. The logic and layout of your code is solid, so the problem is not there.

Perhaps try printing out the profit(ie profit + swap + commission) for each order individually. This should provide some clues as to where the problem lies.
  • #5
  • Last Post: Aug 19, 2010 10:41am Aug 19, 2010 10:41am
Quoting kennyhubbard
Mmmmm, ok, that is strange. The logic and layout of your code is solid, so the problem is not there.

Perhaps try printing out the profit(ie profit + swap + commission) for each order individually. This should provide some clues as to where the problem lies.
Yah, I figured I would take a break last night, will start up again in the afternoon to get this thing down... I was trying debugging while the market was NOT MOVING, so I will try today.

Thanks! I thought the code looked good too??

We are our own best indicator.
0 traders viewing now