MetaQuotes 4 Coding Lessons | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

I Will Learn Coding in 1 Month - Give me the 80/20 of MT4 Coding 14 replies

Metaquotes MT4 "demo.metaquotes.net " server will be stopped this April 2 replies

History data: MetaQuotes and Alpari 3 replies

Metatrader Metaquotes feed difference? 0 replies

Very simple metaquotes request 1 reply

Attachments: MetaQuotes 4 Coding Lessons
Exit Attachments

MetaQuotes 4 Coding Lessons

  • #1
  • First Post: Aug 18, 2010 12:00pm Aug 18, 2010 12:00pm
LESSON #1

Closing all buy, sell and pending orders, FAST.

Study the source code. Ask questions and I'll answer them as I'm able.

Closing open trades and pending orders is one of the main things MetaTrader users want to automate.

So here is a good EA you can use -- careful, because it closes EVERYTHING! -- and its source code provides a good starting point to start understanding the basics.

The code I uploaded uses an unusual looping technique that is not recommended for most EAs, but its advantage is that it does not depend on ticks from the chart the EA is attached to.

Study hard, use your brain. You can be an mq4 guru if you're not already.
Attached File(s)
File Type: mq4 CloseAll.mq4   2 KB | 455 downloads
Open to new approaches.
  • #2
  • Aug 31, 2010 12:49pm Aug 31, 2010 12:49pm
thank you.
  • #3
  • Aug 31, 2010 10:00pm Aug 31, 2010 10:00pm
I'm waitaing for next lesson,
but I dont' know how to ask you about the coding,
thanks for MetaCoder...
  • #4
  • Sep 9, 2010 2:16am Sep 9, 2010 2:16am
Hi MetaCoder,

I noticed in that CloseAll script that you make the EA Sleep for 1 second after each order is closed.

Is it better not to have that line if you want to close all orders, as you mentioned, FAST?

Cheers,
the-game.
  • #5
  • Sep 1, 2013 7:24pm Sep 1, 2013 7:24pm
the-game, answer to your question is this: as it was explained to me years ago, the brokers' servers tend to honor 1-second intervals between client requests. If our client applications hammer the servers with requests, they might tend to put our requests at the back of the queues, and that means we could get slowed down in the process of trying to go as fast as we can.

I like the more deterministic approach.
Open to new approaches.
  • #6
  • Sep 2, 2013 2:37am Sep 2, 2013 2:37am
Quoting MetaCoder
LESSON #1 Closing all buy, sell and pending orders, FAST. Study the source code. Ask questions and I'll answer them as I'm able. Closing open trades and pending orders is one of the main things MetaTrader users want to automate. So here is a good EA you can use -- careful, because it closes EVERYTHING! -- and its source code provides a good starting point to start understanding the basics. The code I uploaded uses an unusual looping technique that is not recommended for most EAs, but its advantage is that it does not depend on ticks from the chart...

no disrespect but, hardly a great example.... you have created it as an EA that never stops closing, so once running will close every trade the moment it is opened. The only way to stop it is to remove the EA. This kind of thing is better done with a process script not an EA and not infinite looping.....

if you want to help people with MT4 programming I would suggest that you send them to www.mql4.com where there are proper tutorials and many good examples that they can work through from the beginning and as fast or slow as they like.
  • #7
  • Sep 2, 2013 2:59am Sep 2, 2013 2:59am
better put a check on errors and it may create hundreds of close trade request , your broker will not be happy if this happened.
  • #8
  • Sep 2, 2013 3:47am Sep 2, 2013 3:47am
Quoting MaxDoom
{quote} no disrespect but, hardly a great example.... .
The code is broken, the function that loops through the orders will not close all the orders, it will miss some because the loop counts up . . . it needs to count down . . .

Loops and Closing or Deleting Orders
20 pips a day isn't too much to ask . . .
  • #9
  • Sep 2, 2013 3:55am Sep 2, 2013 3:55am
Quoting RaptorUK
{quote} The code is broken, the function that loops through the orders will not close all the orders, it will miss some because the loop counts up . . . it needs to count down . . . Loops and Closing or Deleting Orders
nice article
  • #10
  • Sep 6, 2013 10:54am Sep 6, 2013 10:54am
Also re OP's code, if there are no orders it will burn CPU calling CloseAll() and OrdersTotal() ?
  • #11
  • Sep 7, 2013 1:58am Sep 7, 2013 1:58am
Quoting ydrol
Also re OP's code, if there are no orders it will burn CPU calling CloseAll() and OrdersTotal() ?
Yes, there should be Sleep() for 50-100ms at least in main while() or (better) a condition to break while().
  • #12
  • Sep 7, 2013 9:22am Sep 7, 2013 9:22am
I wonder why the Author doesn't bother to check if the OrderSelect(), OrderClose() and OrderDelete() calls worked or not . . . . if they fail shouldn't the error be reported along with the relevant variables so the issue can be investigated after the fact ?

This will help: What are Function return values ? How do I use them ?
20 pips a day isn't too much to ask . . .
  • #13
  • Sep 8, 2013 4:08am Sep 8, 2013 4:08am
Quoting RaptorUK
I wonder why the Author doesn't bother to check if the OrderSelect(), OrderClose() and OrderDelete() calls worked or not . . . . if they fail shouldn't the error be reported along with the relevant variables so the issue can be investigated after the fact ? This will help: What are Function return values ? How do I use them ?
like I said it is a poor example in terms of code and solution....

I can't wait for the next coding lesson
  • #14
  • Last Post: Jan 29, 2023 12:24pm Jan 29, 2023 12:24pm
I am looking for someone to help with writing an EA. I am a junior member so my capabilities as far as communication is limited. I am looking for trailing entry points to be automated with a editable tp and sl. Anyone that can help?
0 traders viewing now