How to reference Custom Indicator (SuperTrend)

//+------------------------------------------------------------------+
//|                                              SuperTrend.mq4 v1.2 |
//|                   Copyright © 2008, Jason Robinson (jnrtrading). |
//|                                   http://www.spreadtrade2win.com |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, Jason Robinson."
#property link      "http://www.spreadtrade2win.com"

#property indicator_chart_window
#property indicator_color1 Lime
#property indicator_color2 Red
#property indicator_width1 2
#property indicator_width2 2
#property indicator_buffers 2
double TrendUp[], TrendDown[];
int changeOfTrend;
extern int Nbr_Periods = 10;
extern double Multiplier = 3.0;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexBuffer(0, TrendUp);
   SetIndexStyle(0, DRAW_LINE, STYLE_SOLID, 2);
   SetIndexLabel(0, "Trend Up");
   SetIndexBuffer(1, TrendDown);
   SetIndexStyle(1, DRAW_LINE, STYLE_SOLID, 2);
   SetIndexLabel(1, "Trend Down");
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int limit, i, flag, flagh, trend[5000];
   double up[5000], dn[5000], medianPrice, atr;
   int counted_bars = IndicatorCounted();
//---- check for possible errors
   if(counted_bars < 0) return(-1);
//---- last counted bar will be recounted
   if(counted_bars > 0) counted_bars--;
   limit=Bars-counted_bars;
   //Print(limit);
   
//----
   for (i = Bars; i >= 0; i--) {
      TrendUp[i] = EMPTY_VALUE;
      TrendDown[i] = EMPTY_VALUE;
      atr = iATR(NULL, 0, Nbr_Periods, i);
      //Print("atr: "+atr[i]);
      medianPrice = (High[i]+Low[i])/2;
      //Print("medianPrice: "+medianPrice[i]);
      up[i]=medianPrice+(Multiplier*atr);
      //Print("up: "+up[i]);
      dn[i]=medianPrice-(Multiplier*atr);
      //Print("dn: "+dn[i]);
      trend[i]=1;
   
      
      if (Close[i]>up[i+1]) {
         trend[i]=1;
         if (trend[i+1] == -1) changeOfTrend = 1;
         //Print("trend: "+trend[i]);
         
      }
      else if (Close[i]<dn[i+1]) {
         trend[i]=-1;
         if (trend[i+1] == 1) changeOfTrend = 1;
         //Print("trend: "+trend[i]);
      }
      else if (trend[i+1]==1) {
         trend[i]=1;
         changeOfTrend = 0;       
      }
      else if (trend[i+1]==-1) {
         trend[i]=-1;
         changeOfTrend = 0;
      }

      if (trend[i]<0 && trend[i+1]>0) {
         flag=1;
         //Print("flag: "+flag);
      }
      else {
         flag=0;
         //Print("flagh: "+flag);
      }
      
      if (trend[i]>0 && trend[i+1]<0) {
         flagh=1;
         //Print("flagh: "+flagh);
      }
      else {
         flagh=0;
         //Print("flagh: "+flagh);
      }
      
      if (trend[i]>0 && dn[i]<dn[i+1])
         dn[i]=dn[i+1];
      
      if (trend[i]<0 && up[i]>up[i+1])
         up[i]=up[i+1];
      
      if (flag==1)
         up[i]=medianPrice+(Multiplier*atr);
         
      if (flagh==1)
         dn[i]=medianPrice-(Multiplier*atr);
         
      //-- Draw the indicator
      if (trend[i]==1) {
         TrendUp[i]=dn[i];
         if (changeOfTrend == 1) {
            TrendUp[i+1] = TrendDown[i+1];
            changeOfTrend = 0;
         }
      }
      else if (trend[i]==-1) {
         TrendDown[i]=up[i];
         if (changeOfTrend == 1) {
            TrendDown[i+1] = TrendUp[i+1];
            changeOfTrend = 0;
         }
      }
   }
   WindowRedraw();
      
//----
   return(0);
  }
//+------------------------------------------------------------------+

Quoting luxinterior

Disliked

Read about the iCustom function in the mql help file.

Good luck

Lux

Ignored

Quoting luxinterior

Disliked

Read about the iCustom function in the mql help file.

Good luck

Lux

Ignored

double val=iCustom(NULL, TimeFrame, "SuperTrend",0,0,0);

double val = iCustom(NULL,TimeFrame,"SuperTrend","Nbr_Periods=3,Multiplier=1.25",0,0);

 
iCustom(NULL,0,"SuperTrend",10,3,0,1) //buffer 0 ie uptrend
 
iCustom(NULL,0,"SuperTrend",10,3,1,1) //buffer 1 ie downtrend

Quote

Disliked

If so, what happens when the custom indicator requires two parameters to be passed, how do you combine them to get the defined output?

iCustom(NULL,0,"SuperTrend",10,3,1,1) //buffer 1 ie downtrend

TrendDown[1]

Quoting kennyhubbard

Disliked

Hi Gil,



You pass the parameter to the indicator as you did in an earlier post(but without naming them). They must be in the order of extern variables as defined at the start of the indicator. The next digit you send is the buffer that you wish to extract. There are up to 8 buffers( in your particular example only 2), and since the iCustom function can only return 1 result, you must tell it which buffer you want the results of. As hayseed mentioned, the last parameter is the shift.

I personally think the iCustom is an highly innefficient...

Ignored

Quoting hayseed

Disliked

it might seem like a small matter, but when you post the code rather than uploading the indicator it requires us to take a couple extra steps.....

10 and 3 are your parameters......

0 and 1 are the target buffers, 0 is up trend buffer, 1 is downtred buffer.....

the last 1 is shift.....

.......h

Inserted Code

 
iCustom(NULL,0,"SuperTrend",10,3,0,1) //buffer 0 ie uptrend
 
iCustom(NULL,0,"SuperTrend",10,3,1,1) //buffer 1 ie downtrend

Ignored

Quoting kennyhubbard

Disliked

Hi Gil,

You are welcome mate.

On second thoughts, it may be better to stick with the iCustom. Transferring the code of an indicator to an EA is way more efficient, but it is not nearly as simple as I made it out to be.

It would be an excellent learning exercise but it may be worth getting to grips with creating simple indicators before you try it.

Ignored

//+------------------------------------------------------------------+
//|                                                SuperTrend V1.mq4 |
//|                      Copyright © 2010, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
double ExtMapBuffer1[];
double ExtMapBuffer2[];

int      Periods = 3;
double   Multiplier = 1.25;
int      TimeFrame = 240;
string   TrendDirection = "Long";

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
  
      
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   
      ExtMapBuffer1[1] = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,0,1);  //downtrend value
 
      ExtMapBuffer1[2] = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,1,1);  //uptrend value
      
      if(ExtMapBuffer1[1] < ExtMapBuffer1[2])
      {
         TrendDirection = "Down";
      }
   
      Comment("UpTrend: ", ExtMapBuffer1[1], "n", "DownTrend: ", ExtMapBuffer2[2], "n", "Trade Direction: ", TrendDirection);
   
//----
   return(0);
  }

Quoting bluemele

Disliked

The most confusing part of this for me, is ...

How do you know which 'buffer' is what? Confusing to me...

Buffer[0] is uptrend, why is that?? Where is that clear?

Ignored

int start()
  {
//----
   
      ExtMapBuffer1[1] = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,0,1);  //uptrend value
 
      ExtMapBuffer1[2] = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,1,1);  //downtrend value
      
      if(Bid <= ExtMapBuffer1[1]) 
      {
         TrendDirection = "Up!";
      }
      if(Bid >= ExtMapBuffer1[2]) 
      {
         TrendDirection = "Down!";
      }
   
      Comment("UpTrend: ", ExtMapBuffer1[1], "n", "DownTrend: ", ExtMapBuffer2[2], "n", "Trade Direction: ", TrendDirection);
   
//----
   return(0);
  }

//+------------------------------------------------------------------+
//|                                                SuperTrend V1.mq4 |
//|                      Copyright © 2010, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
double ExtMapBuffer1[];
double ExtMapBuffer2[];

int      Periods = 3;
double   Multiplier = 1.25;
int      TimeFrame = 240;
string   TrendDirection = "Long";


double   UpTrend,DownTrend;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
  
      
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   
      //ExtMapBuffer1[1] = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,0,1);  //uptrend value
 
      //ExtMapBuffer1[2] = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,1,1);  //downtrend value
      UpTrend = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,0,1);
      DownTrend = iCustom(NULL, 0, "SuperTrend",Periods,Multiplier,TimeFrame,1,1);
      
      /*if(Bid <= ExtMapBuffer1[1]) 
      {
         TrendDirection = "Up!";
      }
      if(Bid >= ExtMapBuffer1[2]) 
      {
         TrendDirection = "Down!";
      }
   
      //Comment("UpTrend: ", ExtMapBuffer1[1], "n", "DownTrend: ", ExtMapBuffer2[2], "n", "Trade Direction: ", TrendDirection);
   */
      Comment("UpTrend: ", UpTrend, "n", "DownTrend: ", DownTrend);
//----
   return(0);
  }

 
double getTrendMagic( string strSymbol, int intTF, int intCciPeriod, int intAtrPeriod, int intShift )
{
   double dblTM, dblCci, dblPrevTM, dblAtr;
   int intCurrShift;
 
   for ( int inx = 50; inx >= 0; inx-- )
   {
      intCurrShift = intShift + inx;
      dblCci = iCCI( strSymbol, intTF, intCciPeriod, PRICE_TYPICAL, intCurrShift );
      dblAtr = iATR( strSymbol, intTF, intAtrPeriod, intCurrShift );
 
      if ( dblCci >= 0 )   
      {
         dblTM = iLow( strSymbol, intTF, intCurrShift ) - dblAtr;
 
         if ( dblTM < dblPrevTM )    dblTM = dblPrevTM;
      }     
      else                  
      {
         dblTM = iHigh( strSymbol, intTF, intCurrShift ) + dblAtr; 
 
         if ( dblTM > dblPrevTM )    dblTM = dblPrevTM;   
      }  
 
      dblPrevTM = dblTM;
   }
 
   return( dblTM );
}