Dividing in MQL

Hi,

I have the code below, however I am unable to get the indicator to work.

---------

extern int MoveAvgPeriod = 1;
extern int MoveAvgMethod = MODE_SMA;

double BufferA[];


int init() {
IndicatorShortName("Price Action");
SetIndexBuffer(0,BufferA);
SetIndexLabel(0,"Price Action");
return(0);
}

int start() {

int iBarsToCalc = Bars - IndicatorCounted();
if (iBarsToCalc < Bars) iBarsToCalc++;

for (int i=iBarsToCalc-1;i>=0;i--) {
double CloseMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_CLOSE,i);
double OpenMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_OPEN, i);
double HigheMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_HIGH, i);
double LowMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_LOW, i);
double OpenMinusClose = OpenMA-CloseMA;
double OpenMinusLow = OpenMA-LowMA;
int Total = OpenMinusClose / HighMinusLow;
BufferA[i] = Total;

}
return(0);
}


----



If I replace the line
int Total = OpenMinusClose / HighMinusLow;
with any integer ie.
int Total = OpenMinusClose / 20;

it comes out fine.

Can someone please assist me?

Thank you.

Then add line above 'int Total = ...'.

(HigheMA is not HighMA because above definition is so.)

I have done that but it is still the same. Are you able to make the indicator work on your metatrader?

The code which you wrote is not all of it, so I try to add the header and display it.



change 'int Total' to 'double Total'.

this is what I did, please see if I miss anything out

----

#property indicator_separate_window
#property indicator_buffers 1
#property indicator_color1 Lime

extern int MoveAvgPeriod = 1;
extern int MoveAvgMethod = MODE_SMA;

double dPainBuffer[];


int init() {
IndicatorShortName("PAIN");
SetIndexBuffer(0,dPainBuffer);
SetIndexLabel(0,"PAIN");
return(0);
}

int start() {

int iBarsToCalc = Bars - IndicatorCounted();
if (iBarsToCalc < Bars) iBarsToCalc++;

for (int i=iBarsToCalc-1;i>=0;i--) {
double dCloseMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_CLOSE,i);
double dOpenMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_OPEN, i);
double dHigheMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_HIGH, i);
double dLowMA = iMA(NULL,0,MoveAvgPeriod,0,MoveAvgMethod,PRICE_LOW, i);
double OpenMinusClose = dOpenMA-dCloseMA;
double HighMinusLow = dHigheMA-dLowMA;
double Total = OpenMinusClose / HighMinusLow;
dPainBuffer[i] = Total;

}
return(0);
}

-------

ok, i found out this actually works in 15 mins timeframe but in other time frames, it does not show, do you know why this is so?

When no price move with one bar, zero division occurs.

change 2 lines
double Total = OpenMinusClose / HighMinusLow;
dPainBuffer[i] = Total;

to

I think that HighMinusLow=0 means no price action, so I set buffer to 0.

So that is the reason why it doesn't show up. Got it to work on other time frames now! Thanks alot for the assistance!