Need some help, EA closing/re-opening my G/U positions | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help with 10M chart - got it already but need some help! 1 reply

Alarms for opening, closing positions and pending order 4 replies

Please help - my EA incorrectly opened positions at market opening after weekend 4 replies

opening and closing trades on an EA 4 replies

True opening and closing hours? 16 replies

Need some help, EA closing/re-opening my G/U positions

  • #1
  • First Post: Aug 3, 2010 11:49am Aug 3, 2010 11:49am
Hi all,

Recently I'm live testing my EA and had a few open positions on GBPUSD and suddenly my EA decides to close all my GBPUSD positions (not because of stoploss or algorithms) and subsequently re-opens the position again straight afterwards as new trades with new stoplosses etc.

I ran the EA on the same time period via strategy tester and the EA didn't close the trade at that moment but instead held onto them for a lot longer. Are there any common causes for this?

Thanks for the help guys.
  • #2
  • Aug 3, 2010 12:17pm Aug 3, 2010 12:17pm
After closer inspection one of the trades that were closed and re-opened occurred on weekend and the other seemed to occur when my MT4 was turned off accidentally due to windows updates.

Could this be caused by the fact that if my EA opened a trade and I close the MT4 software and open it again, the trades will close/re-open again as new trades?
  • #3
  • Aug 3, 2010 1:42pm Aug 3, 2010 1:42pm
Can't do much without the code.
  • #4
  • Last Post: Aug 4, 2010 1:08am Aug 4, 2010 1:08am
The code is here, its basically the donchian channel (turtle) system. Sorry if its a bit messy I'm self-taught so don't really know all the proper ways to lay it out.

Didn't include the header as I feel it would make it even more messy. So just a description on same of the function:
SLEqualize - modifies all the stoplosses to be the same after a new re-entry.
long - pretty much acts as a order send for long positions, i use it because i intend to build more into it in the future but at the moment its just like an order send.
short - same as long but a short function.


PHP Code
#include <TradeCommandHeader.mqh>

//parameters
extern double risk = 0;
extern int tradeNumber = 4;
extern int entry1_look_back = 50;
extern int exit1_look_back = 20;
extern int volperiod = 50;
extern double SL_divider = 4;
extern double SL_multiplier = 2;
extern double lots = 0.1;/*lot sizing does not work atm*/
//global variables
double accRisk, stoploss, re_entry_point;
int total, currency_type;
string name = "Turtle Trader";
bool trade_type;
datetime trade_time;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   accRisk = AccountBalance()*risk;
   Print("Risk:",risk,"%  $",accRisk);
   if(Symbol() == "USDJPY" || Symbol() == "USDCHF" || Symbol() == "USDCAD") currency_type = 0;
   else if(Symbol() == "GBPUSD" || Symbol() == "EURUSD" || Symbol() == "AUDUSD") currency_type = 1;
   else  currency_type = 2;
      
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
   check();
   
   //Variable
   total = OrdersTotal();
   //hstTotal = OrdersHistoryTotal();
   
   //Shutdown due to wrong currency pair
   if(currency_type ==2){
      Print("Currency pair may not be suitable for EA");
      return(0);
   }
   
   //Shutdown on Sunday for 1 hour to prevent taking wrong signals
   if(total<1 && ((TimeDayOfWeek(Time[0]) == 0 && TimeHour(Time[0]) < 22))){
      //Print("SHUTDOWN PERIOD");
   }
   else if(total<1 && trade_time != Time[0]){ //Prevents entering trade right after SL is hit
      //Calculations
      double ATR = iATR(0,0,volperiod,1);
      stoploss = ATR*SL_multiplier;
      int long_signal = iHighest(0,0,MODE_HIGH, entry1_look_back, 1);
      int short_signal = iLowest(0,0,MODE_LOW, entry1_look_back, 1);
      /*if(hstTotal>0 && last_trade_blocker==0){
         if (OrderSelect(hstTotal-1, SELECT_BY_POS, MODE_HISTORY)==FALSE) Print("Profit Marker ERROR: ", GetLastError());
         if(OrderProfit()>0){
            last_trade_blocker = 1;
         }
      }*/  
      
      //Excecution
      if(High[0]>High[long_signal]){
         /*if(last_trade_blocker==1){
            last_trade_blocker = 2;
            Print("TRADE BLOCKED");
            return(0);
         }*/
         //lots = Lot_size_calculation(accRisk, stoploss, currency_type, Ask);
         long(lots, 0, Ask-stoploss, name, 0);
         trade_type = 1; //Type = long
         trade_time = Time[0];
         re_entry_point = Ask+stoploss/SL_divider;
         //last_trade_blocker = 0;
      }
      if(Low[0]<Low[short_signal]){
         /*if(last_trade_blocker==1){
            last_trade_blocker = 0;
            Print("TRADE BLOCKED");
            return(0);
         }*/
         //lots = Lot_size_calculation(accRisk, stoploss, currency_type, Bid);
         short(lots, 0, Bid+stoploss, name, 0);
         trade_type = 0; //Type = short
         trade_time = Time[0];
         re_entry_point = Bid-stoploss/SL_divider;
         //last_trade_blocker = 0;
      }
   }  
   else if(total>0 && trade_time != Time[0]){
      int exit_long = iLowest(0,0,MODE_LOW, exit1_look_back, 1);
      int exit_short = iHighest(0,0,MODE_HIGH, exit1_look_back, 1);
      
      if(trade_type==1){
         if(Low[0]<Low[exit_long]) close_trades(total);
         else if(Ask>re_entry_point && total<tradeNumber){
            long(lots, 0, Ask-stoploss, name, Aqua);
            trade_time = Time[0];
            re_entry_point = Ask+stoploss/SL_divider;
            SLEqualize(total+1, Ask-stoploss);
         }
      }
      if(trade_type==0){
         if(High[0]>High[exit_short]) close_trades(total);
         else if(Bid<re_entry_point && total<tradeNumber){
            short(lots, 0, Bid+stoploss, name, Yellow);
            trade_time = Time[0];
            re_entry_point = Bid-stoploss/SL_divider;
            trade_type = 0;
            SLEqualize(total+1, Bid+stoploss);
         }
      }
      
   }
   
      
   
   return(0);
  }
0 traders viewing now