Coding EA to check opening price - How do I handle this problem? | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Help with basic coding problem 16 replies

I Will Learn Coding in 1 Month - Give me the 80/20 of MT4 Coding 14 replies

Help with coding this problem - sort buy orders 6 replies

Problem with coding 7 replies

Coding Problem: Open[1] > EMA12 4 replies

Attachments: Coding EA to check opening price - How do I handle this problem?
Exit Attachments

Coding EA to check opening price - How do I handle this problem?

  • #21
  • Jul 31, 2010 6:11am Jul 31, 2010 6:11am
Correction, I realized that the <= OP_SELL works for both Buy and Sell Orders.
  • #22
  • Jul 31, 2010 6:13am Jul 31, 2010 6:13am
It does it for both........

Inserted Code
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {

Orders have numbers, so a buy = 0 and a sell = 1. This code says if your order type is less than or equal to 1, which covers both buy and sell.

return(0) is used to exit the trade function. If you look, two lines down you have this code :-

Inserted Code
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;

By exiting the function as soon as there is an error, we have avoided changing those parameters which I suspect tell the EA that the function has been successful(which is not actually correct).
  • #23
  • Jul 31, 2010 6:15am Jul 31, 2010 6:15am
When you replace the code with the last bit I gave you, you will need to delete one of the curly brakets just above the :-

Inserted Code
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
  • #24
  • Jul 31, 2010 6:22am Jul 31, 2010 6:22am
Why do I need to remove one of the curly brackets?

And do I still put another return(0); under the tickcheck and barcount?
  • #25
  • Jul 31, 2010 6:26am Jul 31, 2010 6:26am
Inserted Code
Why do I need to remove one of the curly brackets?

I have inserted an extra one before the else statement.

Inserted Code
And do I still put another return(0); under the tickcheck and barcount?

Yup, well actually, just leave the return that is already there in place.
  • #26
  • Jul 31, 2010 6:29am Jul 31, 2010 6:29am
Why did you insert an extra one above the else statement?
  • #27
  • Jul 31, 2010 6:33am Jul 31, 2010 6:33am
It changes the flow of the program. The reason there is no entry in the experts tab is because of a bug, which is hopefully fixed now.
  • #28
  • Jul 31, 2010 6:37am Jul 31, 2010 6:37am
There are entries in the expert tab when orders and successfully opened. But no entries when I encounter the off quotes problem.

What would the logic flow be like if I did not put in the extra curly bracket like you mentioned?

Can you check again to make sure whether it is faulty or not?

This is the full code for the buy order send logic which starts from here:

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
InTrade = false;
buyFlag = false;
return(0);
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

The above code has all brackets in their original positions.

IsTrade is set to false always btw.
  • #29
  • Jul 31, 2010 6:44am Jul 31, 2010 6:44am
If I add another curly bracket like you mentioned, then the "else{" would no longer be related to the "if(Ticket > 0)" function.

It would be related to the "if(!IsTrade)" function which is of no relevance here since IsTrade is always meant to be executed as false.
  • #30
  • Jul 31, 2010 6:45am Jul 31, 2010 6:45am
Inserted Code
//+------------------------------------------------------------------+
//| Signal End |
//+------------------------------------------------------------------+
//Buy
   if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))){
      if(!IsTrade){
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)){
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }
         if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;
         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
         Print("Sending order to the broker......");
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
               Print("BUY order opened : ", OrderOpenPrice());
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
            } 
         }
         else{
            Print("Error opening BUY order : ", GetLastError());
            InTrade = false;
            buyFlag = false;
            return(0);
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }
//Sell
   if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }
         if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;
         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
         Print("Sending order to the broker......");
         if(Ticket > 0){
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
               Print("SELL order opened : ", OrderOpenPrice());
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
            }
         } 
         else{
            Print("Error opening SELL order : ", GetLastError());
            InTrade = false;
            sellFlag = false;
            return(0);
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
    }
if (!EachTickMode) BarCount = Bars;
return(0);
}
//+------------------------------------------------------------------+
  • #31
  • Jul 31, 2010 6:53am Jul 31, 2010 6:53am
By following the logic of the code you just posted, the "else{" function would now be linked to the "if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))){" function.

But how can it work since Order would still be SIGNAL_BUY until the int start() function where Order is set to SIGNAL_NONE once again?
  • #32
  • Jul 31, 2010 7:01am Jul 31, 2010 7:01am
I have been known to get this wrong, but the way I read it, the else statement is now linked to the if(Ticket > 0){
  • #33
  • Jul 31, 2010 7:05am Jul 31, 2010 7:05am
Your code:

Inserted Code
Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel,  TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0,  DodgerBlue);
         if(Ticket > 0) 
{

               if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) 
  {
        Print("BUY order opened : ", OrderOpenPrice());
                   if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
     } 
  else 
  {
         Print("Error opening BUY order : ", GetLastError());
         InTrade = false;
         buyFlag = false;
      }
         }

looking at your code you dont have any action taken if Ticket <= 0
I would imagine that the Ticket number returned when this error occurs is either 0 or a negative number so you need to add an else clause to the if statement :

if(Ticket > 0)
{
}
else
{
//order did not go through
}
  • #34
  • Jul 31, 2010 7:08am Jul 31, 2010 7:08am
So my original code is already working fine with the logic flow right?
  • #35
  • Jul 31, 2010 7:08am Jul 31, 2010 7:08am
Hmm loooks like ou might have got there already ... there was about 3 hours between starting ththe above post and actually submitting it!
  • #36
  • Jul 31, 2010 7:13am Jul 31, 2010 7:13am
So in this case of my code (post 23), why would there be a problem if I did not add in the return(0); under the InTrade = false and buyFlag = false?

The InTrade and buyFlag should still be set to false shouldn't they?
  • #37
  • Edited 7:45am Jul 31, 2010 7:32am | Edited 7:45am
Why does the Print("Error opening BUY order : ", GetLastError()); not work if return(0); is not added underneath it?
  • #38
  • Jul 31, 2010 8:09am Jul 31, 2010 8:09am
Forget about the return(0) you're right it does nothing ... Your main problem
is as I stated earlier. However you can help yourself if you indent your code correctly then you will be able to see the logic clearer.
Unfortunately the formatting of text on this forum are annoying to say the least so I've attached 2 text files

orgcode.txt = your original code from post #3
newcode.txt = what you need to add

Open them with notepad / wordpad or MT4 code editor

You'll notice that the correct indenting makes the code easier to read ... Its very much worth your while formatting your statements correctly so you can see the logic flow
Attached File(s)
File Type: txt orgcode.txt   1 KB | 275 downloads
File Type: txt newcode.txt   2 KB | 296 downloads
  • #39
  • Jul 31, 2010 8:27am Jul 31, 2010 8:27am
Ah, I understand what is going on now.

In my original code, the "else{" was linked to "if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {"

But ticket would only be >0 if OrderSend() succeeds right?

In my situation, the OrderSelect() doesn't even get triggered because OrderSend() has failed, and results in ticket <= 0 right?
  • #40
  • Jul 31, 2010 8:49am Jul 31, 2010 8:49am
Checking the OrderSend()

http://docs.mql4.com/trading/OrderSend

I find out that trade errors with the server such as requotes and invalid stops happen at this function.

Therefore if that is the case, then the text file with the new code you posted would solve the problem by adding the "else{" not only to the OrderSelect() but also to the Ticket = OrderSend(), since my original code only adds the "else{" to the OrderSelect()

The indenting makes it very clear.

I believe this should be it. Thanks a lot!
0 traders viewing now