Possible to change the length of the lines? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

indicator that shows length of the previous candle's body 35 replies

How to define the length of an array with an extern variable? 5 replies

Question about number of streaks of a certain length in a trade sample 1 reply

Draw a certain-length line 3 replies

Attachments: Possible to change the length of the lines?
Exit Attachments

Possible to change the length of the lines?

  • #1
  • First Post: Edited Jul 20, 2010 2:04am Jul 19, 2010 10:31pm | Edited Jul 20, 2010 2:04am
Hi, people.

I'd like to ask if it is possible to change the length of the round number lines shown on the char in sweetspots Gold so that, there is a short line on the right side of the chart showing the round numbers?


The RN lines all over the screen are rather confusing once we manually draw PPZ.

Thanks in advance
Attached Image (click to enlarge)
Click to Enlarge Name: pic.gif Size: 105 KB
Attached File(s)
File Type: mq4 SweetSpots GOLD.mq4   4 KB | 456 downloads
  • #2
  • Jul 20, 2010 2:36am Jul 20, 2010 2:36am
Quoting Pinbar
Hi, people.

I'd like to ask if it is possible to change the length of the round number lines shown on the char in sweetspots Gold so that, there is a short line on the right side of the chart showing the round numbers?


The RN lines all over the screen are rather confusing once we manually draw PPZ.

Thanks in advance
modify the codes

line 'ObjectCreate....'
-> ObjectCreate(linename, OBJ_TREND, 0, Time[1], level, Time[0], level);

line 'ObjectMove...'
->
ObjectMove(linename, 0, Time[1], level);
ObjectMove(linename, 1, Time[0], level);

it makes sense?
  • #3
  • Jul 20, 2010 2:41am Jul 20, 2010 2:41am
Attached Image (click to enlarge)
Click to Enlarge Name: sweetspots_usdjpy_h1.gif Size: 15 KB
  • #4
  • Jul 20, 2010 3:11am Jul 20, 2010 3:11am
Many thanks, I will see if I can try and do it.

never really altered an indicator before.



I take it that this is the area that needs altering.
is it the line in red?



-----------------------------------------------------------------------------------------------
//+------------------------------------------------------------------+
//| Helper |
//+------------------------------------------------------------------+
void SetLevel(string text, double level, color col1, int linestyle, int thickness, datetime startofday)
{
int digits= Digits;
string linename= "[SweetSpot] " + text + " Line",
pricelabel;

// create or move the horizontal line
if (ObjectFind(linename) != 0) {
ObjectCreate(linename, OBJ_HLINE, 0, 0, level);
ObjectSet(linename, OBJPROP_STYLE, linestyle);
ObjectSet(linename, OBJPROP_COLOR, col1);
ObjectSet(linename, OBJPROP_WIDTH, thickness);

ObjectSet(linename, OBJPROP_BACK, True);
}
else {
ObjectMove(linename, 0, Time[0], level);
}
}
  • #5
  • Jul 20, 2010 3:29am Jul 20, 2010 3:29am
Modified it but must have got something wrong as when I try and attach it to a chart, nothing happens.


----------------------------------------------------------------------------------------------

//+------------------------------------------------------------------+
//| Helper |
//+------------------------------------------------------------------+
void SetLevel(string text, double level, color col1, int linestyle, int thickness, datetime startofday)
{
int digits= Digits;
string linename= "[SweetSpot] " + text + " Line",
pricelabel;

// create or move the horizontal line
if (ObjectFind(linename) != 0) {
ObjectCreate(linename, OBJ_TREND, 0, Time[1], level, Time[0], level);
line 'ObjectMove...'
->
ObjectMove(linename, 0, Time[1], level);
ObjectMove(linename, 1, Time[0], level);

ObjectSet(linename, OBJPROP_STYLE, linestyle);
ObjectSet(linename, OBJPROP_COLOR, col1);
ObjectSet(linename, OBJPROP_WIDTH, thickness);

ObjectSet(linename, OBJPROP_BACK, True);
}
else {
ObjectMove(linename, 0, Time[0], level);
}
}
  • #6
  • Jul 20, 2010 3:50am Jul 20, 2010 3:50am
Quoting Pinbar
Modified it but must have got something wrong as when I try and attach it to a chart, nothing happens.


----------------------------------------------------------------------------------------------

//+------------------------------------------------------------------+
//| Helper |
//+------------------------------------------------------------------+
void SetLevel(string text, double level, color col1, int linestyle, int thickness, datetime startofday)
{
int digits= Digits;
string linename= "[SweetSpot] " + text + " Line",
pricelabel;...
Changing ObjectCreate is right.
In regard to ObjectMove, you find 'ObjectMove...' in the code, then replace it.
  • #7
  • Jul 20, 2010 4:03am Jul 20, 2010 4:03am
Quoting Taiyakixz
Changing ObjectCreate is right.
In regard to ObjectMove, you find 'ObjectMove...' in the code, then replace it.

Will give it another try..

many thanks
  • #8
  • Jul 20, 2010 4:06am Jul 20, 2010 4:06am
Got it working.


Appreciate the help, many thanks for your kind assistance.
Attached Image (click to enlarge)
Click to Enlarge Name: pic.gif Size: 21 KB
  • #9
  • Edited 10:31pm Jul 20, 2010 8:35pm | Edited 10:31pm
Anyone know if it is possible to shorten the lines in the modified sweetspots gold ,as it has stopped showing the prices in the vertical scale, is it possible to have price displayed on the actual lines themselves as in the pic.

Displaying price on the lines is preferable to having them in the vertical scale anyway as, the round numbers get messed up with the MT4 prices.

Thanks in advance
Attached Image (click to enlarge)
Click to Enlarge Name: pic.gif Size: 264 KB
Attached File(s)
File Type: mq4 SweetSpots GOLD modification.mq4   4 KB | 464 downloads
  • #10
  • Jul 21, 2010 1:34am Jul 21, 2010 1:34am
bumping this in the hope someone can show me how to shorten the lines and add the price labels to them.
  • #11
  • Jul 21, 2010 11:38am Jul 21, 2010 11:38am
Quoting Pinbar
Anyone know if it is possible to shorten the lines in the modified sweetspots gold ,as it has stopped showing the prices in the vertical scale, is it possible to have price displayed on the actual lines themselves as in the pic.

Displaying price on the lines is preferable to having them in the vertical scale anyway as, the round numbers get messed up with the MT4 prices.

Thanks in advance
add the codes below 'extern int LineStyleSub=....'
Inserted Code
extern int ShiftLine = 15;
extern color TextColor = Orange;

change 'ObjectCreate....' line
Inserted Code
ObjectCreate(linename+"Text", OBJ_TEXT, 0, Time[0]+(ShiftLine+5)*Period()*60, level);
ObjectSetText(linename+"Text", DoubleToStr(level, Digits), 8, "Arial", TextColor);
ObjectCreate(linename, OBJ_TREND, 0, Time[0]+ShiftLine*Period()*60, level, Time[0]+(ShiftLine+1)*Period()*60, level);

change 'ObjectMove....' 2 lines
Inserted Code
ObjectMove(linename, 0, Time[0]+ShiftLine*Period()*60, level);
ObjectMove(linename, 1, Time[0]+(ShiftLine+1)*Period()*60, level);
ObjectMove(linename+"Text", 0, Time[0]+(ShiftLine+5)*Period()*60, level);

If you want to make lines shorter, change the value of ShiftLine larger.
You can change the value on parameter popup.
  • #12
  • Jul 21, 2010 11:40am Jul 21, 2010 11:40am
Attached Image (click to enlarge)
Click to Enlarge Name: sweetspots_eurusd_h1.gif Size: 16 KB
  • #13
  • Jul 21, 2010 8:45pm Jul 21, 2010 8:45pm
Taiyakixz

This is perfect, many many thanks.

I am also in Japan, you must also be melting in this heat, unless you are in Hokaido. Kanagawa is horribly hot right now, the 35C yesterday was devastating.

If you are in this area, I can buy you a beer for your trouble.

Feel free to PM me.


I will post this in the J16 thread and mention you created it.

Once again, I really appreciate the help.
Attached Image (click to enlarge)
Click to Enlarge Name: h4.gif Size: 30 KB
  • #14
  • Jul 22, 2010 3:40am Jul 22, 2010 3:40am
Quoting Pinbar
Taiyakixz

This is perfect, many many thanks.

I am also in Japan, you must also be melting in this heat, unless you are in Hokaido. Kanagawa is horribly hot right now, the 35C yesterday was devastating.

If you are in this area, I can buy you a beer for your trouble.

Feel free to PM me.


I will post this in the J16 thread and mention you created it.

Once again, I really appreciate the help.
I'm glad that I hear you are satisfied, because some members here have not replied anything after I advised.
I'm in Tokyo, yes very hot....I will move to Hokkaido next week.
I hope you trade well.
  • #15
  • Jul 23, 2010 2:13am Jul 23, 2010 2:13am
Quoting Taiyakixz
I'm glad that I hear you are satisfied, because some members here have not replied anything after I advised.
I'm in Tokyo, yes very hot....I will move to Hokkaido next week.
I hope you trade well.
Moving to Hokaido on a permanent basis or just a vacation?

I am envious.
  • #16
  • Jul 23, 2010 9:31am Jul 23, 2010 9:31am
Quoting Pinbar
Moving to Hokaido on a permanent basis or just a vacation?

I am envious.
permanent. problem is winter....
  • #17
  • Jul 24, 2010 8:41pm Jul 24, 2010 8:41pm
Quoting Taiyakixz
permanent. problem is winter....
Yes, that could be a problem if you don't like the cold.

Still. I hear the houses are built much differently than Kanto area and the insulation is far superior.


Good luck to you Taiyakixz and I hope you enjoy your new lifestyle.
  • #18
  • Sep 12, 2010 10:47am Sep 12, 2010 10:47am
Quoting Pinbar
Taiyakixz

This is perfect, many many thanks.

I am also in Japan, you must also be melting in this heat, unless you are in Hokaido. Kanagawa is horribly hot right now, the 35C yesterday was devastating.

If you are in this area, I can buy you a beer for your trouble.

Feel free to PM me.


I will post this in the J16 thread and mention you created it.

Once again, I really appreciate the help.
can you post the final corrected version, please?
  • #19
  • Last Post: Jul 28, 2013 6:00pm Jul 28, 2013 6:00pm
Hi pinbar/Taiyaki,


I've tried to change the codes according to Taiyaki's suggestions, and the shifted lines on round numbers worked, but I encountered a problem, where the lines automatically disappears. They re-appeared after I switched timeframes, but will disappear after a second or two.

Have you encountered the same issue? Do you possible know what might have caused this to happen?

Appreciate your help...


Thanks.
Knowing is not enough; we must apply. Willing is not enough; we must do.
0 traders viewing now