Comparing last 2 fractals - code help please | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Custom indicator Moving average+fractals MT5 coding help 0 replies

Fractals coding help 14 replies

Need Help: To Get Shifts of a Fractals Structure 4 replies

Help - any tools that can easily convert MQL4 code to Easy Language code? 7 replies

Weekend bars, fractals EA help 3 replies

Comparing last 2 fractals - code help please

  • #1
  • First Post: Jul 4, 2010 8:27am Jul 4, 2010 8:27am
I want to close trades when the last up fractal is lower than the second last up fractal, and same in reverse for down fractals.

I am using the following code to determine the last fractals:


Inserted Code
//+----Determines last up and down fractals, 
   double LastUpFractal,LastDownFractal,TimeOfLastDownFractal,TimeOfLastUpFractal;
 
 
   for(int k=1;k<Bars;k++){//for loop to find last UpFractal
      if(iFractals(NULL, Period(), MODE_UPPER,k)!=0){// NULL removed Symbol() added
         LastUpFractal=iFractals(NULL, Period(), MODE_UPPER,k);
         TimeOfLastUpFractal=Time[k];
         break;
         }//end if
      }//end for
   for(int j=1;j<Bars;j++){//for loop to find last DownFractal
      if(iFractals(NULL, Period(), MODE_LOWER,j)!=0){
         LastDownFractal=iFractals(NULL, Period(), MODE_LOWER,j);
         TimeOfLastDownFractal=Time[j];
         break;
         }//end if
      }//end for

My question is how to find out about the second last fractals - to then compare them and close trades if the rule is met?
  • #2
  • Jul 4, 2010 12:08pm Jul 4, 2010 12:08pm
Hi,

Obviously I am not a programmer. But I don't mind having a go at it. I am aiming to use this code in an EA. I am growing it step-by-step from MetaEditor help files as I go.

I need to find when the latest "up fractal" rises above the "second last up fractal". And the reverse for down fractals.

When the condition is met, I will then want it to close certain trades for me.

I am getting closer to my goal? Or am I totally missing the plot?

Inserted Code
 
   //+----Determines last up and down fractals, 
   double LastUpFractal,SecondLastUpFractal,LastDownFractal,SecondLastDownFractal;
   double TimeOfLastDownFractal,TimeOfLastUpFractal,TimeOfSecondLastDownFractal,TimeOfSecondLastUpFractal;
 
 
   for(int k=1;k<Bars;k++){//for loop to find last UpFractal
      if(iFractals(NULL, Period(), MODE_UPPER,k)!=0){// NULL removed Symbol() added
         LastUpFractal=iFractals(NULL, Period(), MODE_UPPER,k);
         TimeOfLastUpFractal=Time[k];
         continue;
         SecondLastUpFractal=iFractals(NULL, Period(), MODE_UPPER,k);
         TimeOfSecondLastUpFractal=Time[k];
         break;
         }//end if
      }//end for
   for(int j=1;j<Bars;j++){//for loop to find last DownFractal
      if(iFractals(NULL, Period(), MODE_LOWER,j)!=0){
         LastDownFractal=iFractals(NULL, Period(), MODE_LOWER,j);
         TimeOfLastDownFractal=Time[j];
         continue;
         SecondLastDownFractal=iFractals(NULL, Period(), MODE_UPPER,k);
         TimeOfSecondLastDownFractal=Time[k];
         break;
         }//end if
      }//end for
  • #3
  • Jul 4, 2010 9:48pm Jul 4, 2010 9:48pm
Haven't looked at your code but this is how I've done it:

findFractal gives the price of the fractal depending on up/down fractal, timeframe and how many fractals back you want to look at (given by nbr, where nbr = 0 gives the last fractal):

Inserted Code
double findFractal(int nbr, int mode, int timeframe)
{
   int i=3, n;
   for(n=0;n<=nbr;n++)
   {
      while(iFractals(Symbol(),timeframe,mode,i) == 0)
         i++;
      if(n<nbr)
         i++;
   }
   return(iFractals(Symbol(),timeframe,mode,i));
}
If you want to see if the last upfractal is lower than the secondlast upfractal, use this code:
Inserted Code
if( findFractal(1, MODE_UPPER, *timeframe of your choice*) < findFractal(0, MODE_UPPER, *timeframe of your choice*) )
{
   ***code to close order***
}
  • #4
  • Jul 5, 2010 8:41am Jul 5, 2010 8:41am
Very impressive response NowAndLater - your solution is tight and elegant.

I sincerely thank you very much!
  • #5
  • Jul 5, 2010 10:54am Jul 5, 2010 10:54am
Glad I could help
  • #6
  • Nov 22, 2010 4:29pm Nov 22, 2010 4:29pm
hello,

i have found this code for comparing the last Fractals valuea,but i have a problem with the code in my EA, when i search to compiling my Ea, Meta Editor give me a lot of errors, for example function definition unexepted, `nbr` variable not defined, etc.

how can i resolve this? I have the necessary on my Ea to use the last 2 or 3 High -Low values from the Fractal indicator. On an other Ea i have found this code, but gives only the last value of Fractals.

for(int a=1;a<Bars;a++)
{
if(iFractals(NULL,LowerTF,MODE_UPPE R,a)!=0)
{
LastUpFractal=iFractals(NULL,LowerT F, MODE_UPPER,a);
TimeOfLastUpFractal=Time[a];
break;
}
}

thank you
zickzack666
  • #7
  • Dec 6, 2016 9:49am Dec 6, 2016 9:49am
tht code really helped me..could u plz code "how to set "the last previous candle close which has crossed the upper band or lowerband as stoplevel"

thank u

plz if possible mail me the code .this is my email="[email protected]"
  • #8
  • Jun 9, 2019 1:09pm Jun 9, 2019 1:09pm
Quoting NowAndLater
Haven't looked at your code but this is how I've done it: findFractal gives the price of the fractal depending on up/down fractal, timeframe and how many fractals back you want to look at (given by nbr, where nbr = 0 gives the last fractal): double findFractal(int nbr, int mode, int timeframe) { int i=3, n; for(n=0;n<=nbr;n++) { while(iFractals(Symbol(),timeframe,mode,i) == 0) i++; if(n<nbr) i++; } return(iFractals(Symbol(),timeframe,mode,i)); }If you want to see if the last upfractal is lower than the secondlast upfractal, use this code: if( findFractal(1,...
@NowAndLater Any suggestions on how I could modify this to get the last 3 fractals at one time? Regardless of whether it's a high or low?
  • #9
  • Last Post: Apr 18, 2020 12:21am Apr 18, 2020 12:21am
Quoting NowAndLater
Haven't looked at your code but this is how I've done it: findFractal gives the price of the fractal depending on up/down fractal, timeframe and how many fractals back you want to look at (given by nbr, where nbr = 0 gives the last fractal): double findFractal(int nbr, int mode, int timeframe) { int i=3, n; for(n=0;n<=nbr;n++) { while(iFractals(Symbol(),timeframe,mode,i) == 0) i++; if(n<nbr) i++; } return(iFractals(Symbol(),timeframe,mode,i)); }If you want to see if the last upfractal is lower than the secondlast upfractal, use this code: if( findFractal(1,...
Hi NowAndLater,

Thank you for the code. I've been searching the code to find fractals and here I am found yours. But I do have question to clarify with you if you don't mind. You said that nbr = 0 gives the last fractal and your code to see if the last upfractal is lower than the secondlast upfractal, use this code: if( findFractal(1, MODE_UPPER, *timeframe of your choice*) < findFractal(0, MODE_UPPER, *timeframe of your choice*) where nbr 1 is lower than nbr 0. does this code mean that the last upfractal is higher than the second last upfractal? Thanks in advance.
0 traders viewing now