SUN's swing catcher method EA

Hello all! Needed some suggestions for an EA I am trying to make. Works best in AUD/USD M15.

Buy strategy:
Candle closes above 10 SMA
Stochastics(14,3,5) crossed upwards
MACD(21,55,8) not overbought(either line greater than 0.0011), also must be bullish
ADX greater than 30

Sell strategy:
Candle closes below 10 SMA
Stochastics(14,3,5) crosses downwards
MACD(21,55,8) not oversold(-0.0011), also must be bearish
ADX greater than 30

Buy Exit:
Candle closes below 10 SMA & Stochs crosses down, OR candle closes below & stochs is overbought

Sell Exit:
Candle closes above 10 SMA & stochs crosses up, OR candle closes above & stochs is oversold

The purpose of the ADX filter is so that choppy markets where price keeps crossing the SMA up and down are ignored. MACD extremes are also ignored because these tend to be reversal-prone.

The use of a stop-loss is optional - the exit rules are designed as such so that a reversal is immediately spotted and the trade is closed.

Back-testing results in MT4 showed a roughly 30-40 pip average profit trade, and a 20 pip average loss trade. However, win-loss percentage was 35/65. Ideally, if I could tip the percentage to 50/50 or greater, the strategy will be very profitable.

It seems that the EA still kicks in a few faulty entries. Whether it is the code that is flawed or the strategy, I am not sure. Any suggestions as to the strategy, and any offers to code the EA are welcome.

Cheers!

A few more filters can be added:

1) With most brokers, the spread goes up during news releases. A code can be added where if the spread doubles its average(user-defined) or more, the program doesn't place trades.

2) A Friday filter can also be added where the robot shuts down after a certain time on Friday.

3) A third filter can be added where all the requirements for an entry must be met within one or two candles of the MA cross.

My knowledge of coding is limited, so any advanced coders are more than welcome!

post your code and I give you my opinion

Posting code. Please note that this was done using a code generator, but all the criteria were entered by me.

Will post jpegs of trades in the next post shortly.

These pics are from an Aussie H4 and M15 chart. Theoretically, the entry criteria are generic enough for them to work on any pair and any timeframe, but the settings would need to be slightly tweaked to accommodate each pair's peculiarities.

buy example:

1. if MACD(main) different from zero and MACD (signal) > 0.0011 do not trade
2. Previous candle close above SMA 10
3. Stochastic Main < Sochastic Signal
4. ADX main > 30
5. MACD(main) > MACD(signal)

opposite for sell

Yea, thats correct. Do you think a few more filters should be added to prevent false entries?

Im not a good trader. I dont know what the best indicator value for this. But it is easy to add more filers.

The problem is that more filters takes away good trades.

I ran the code I sent you in visual mode in MT4 strategy tester..it seems it still kicked in a trade even though ADX was below 30. Can you please look over the code?

did two small modifications:
1. ADX indicator now checks value (>30) on previous bar, not the current. Remember that the indicator value on current bar repaints. Value can go above 30 and then below again and you will still have a trade. Now you have to wait for closed candle.
2. Added prameter Use_RSI_Trend_Check and RSI_Trend_Timeframe (60 = H1, 240 = H4, 1440 = Daily)
I use this alot to not trade against the trend. If RSI > 50 then you have uptrend if RSI < 50 you have downtrend.

Made quick backtest.. EA is still not profitable, but you have to find a way/indicator that filters good trades from bad

Hans

Okay, will do some expirementing and let you know. Thanks

i ran the EA again, with a few different settings on the RSI but still not getting good results. the positive trades are nearly twice as big as the losers, but the win:lose ratio is 70:30. that means the system is essentially good, but too many bad trades are still getting kicked in. Ill do some brainstorming and get back to you. I have changed the variable names and shortened the EA a little bit, and am attaching. See what you can do,

Gul

I think the EA should check indicator values for previous bar. Not current because of repaint problem. At the moment only ADX indicator works this way

can you please do the needful?

is it possible to have the indicator check stochastic values for up to two candles, and not further?