2 simple lines of code needed, please help | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help please! how to write code lines for an indi (scanner) 0 replies

Help Needed With Simple EA Code 6 replies

Please help me code a simple order based EA 3 replies

Simple close script - some help with code needed 2 replies

Can you please help code simple indicator ? 0 replies

2 simple lines of code needed, please help

  • #1
  • First Post: Jun 20, 2010 3:01am Jun 20, 2010 3:01am
I need 2 lines of code so I can edit an EA to test a theory.

Basically
if(last candlestick is 100 pips or more from open to close and bullish) {myOrderType= 2;}

if(last candlestick is 100 pips or more from open to close and bearish) {myOrderType= 1;}

big thanks in advance to anyone who provides this
  • #2
  • Jun 20, 2010 4:20am Jun 20, 2010 4:20am
Quoting BenScoobert
I need 2 lines of code so I can edit an EA to test a theory.

Basically
if(last candlestick is 100 pips or more from open to close and bullish) {myOrderType= 2;}

if(last candlestick is 100 pips or more from open to close and bearish) {myOrderType= 1;}

big thanks in advance to anyone who provides this

You can do it as below:

if (Bid>=iOpen(0,0,0)+100*Point && iClose[0]>iOpen[0] ) {myOrderType= 2;}
if (Bid<=iOpen(0,0,0)-100*Point && iClose[0]<iOpen[0] ) {myOrderType= 1;}

I think I know what u trying to do, I had done it before and can say some times profitable and sometimes not(base on backtesting)..

U can also filter using Bolinger Band... Good Luck
  • #3
  • Jun 20, 2010 4:29am Jun 20, 2010 4:29am
Inserted Code
if( (open[1] - close[1]) >= 100*Point )
[indent] myOrderType = 1;    //bearish
[/indent] if( (close[1] - open[1]) >= 100*Point )
[indent] myOrderType = 2;    //bullish[/indent]

  • #4
  • Jun 20, 2010 4:41am Jun 20, 2010 4:41am
ah so thats how its done, thanks girls
  • #5
  • Jun 20, 2010 5:28am Jun 20, 2010 5:28am
both close, i fumbled around with it and now it works


if((iOpen(0,0,0) - iClose(0,0,0)) >= 100*Point ) {myOrderType=2; }
if((iClose(0,0,0) - iOpen(0,0,0)) >= 100*Point) {myOrderType=1; }

thanks again
  • #6
  • Feb 21, 2011 12:48am Feb 21, 2011 12:48am
Hi,
i need a simple script which will buy 2 currency and sell one currency at a time.
can anyone help me?
  • #7
  • May 5, 2011 1:52pm May 5, 2011 1:52pm
Quoting BenScoobert
both close, i fumbled around with it and now it works


if((iOpen(0,0,0) - iClose(0,0,0)) >= 100*Point ) {myOrderType=2; }
if((iClose(0,0,0) - iOpen(0,0,0)) >= 100*Point) {myOrderType=1; }

thanks again

This has worked well for me but I'd like to try something a little more PA based

Does anyone know what code I'd need for the following change??

Instead of 100 pips on current barsize, I'd like to have 100 pips in the last hour.
  • #8
  • May 5, 2011 2:32pm May 5, 2011 2:32pm
Not sure what you mean by last hour, so I will cover both possibilities. If you mean the bars within the last hour and assuming a lower time frame chart, its just a matter of finding the number of bars (5M = 12 bars) and finding the High/Low of those bars and determining if the move was > 100 pips.

I suspect you probably mean an hour to the exact minute which is within a bar, unless you are using a 1M chart. That is somewhat more complicated. For that you would need an array of 60 elements and record the High/Low for each minute. Once the 61st minute is reached the array would have to shifted to allow storage of the new value and get rid of the oldest. For each new tick, find the High/Low of the array and determine if the move was > 100 pips. This is not easy to code, so you will have to do it yourself. I don't think its feasible or necessary to have more than 1 minute accuracy.
  • #9
  • May 5, 2011 3:17pm May 5, 2011 3:17pm
Quoting CodeMeister
Not sure what you mean by last hour, so I will cover both possibilities. If you mean the bars within the last hour and assuming a lower time frame chart, its just a matter of finding the number of bars (5M = 12 bars) and finding the High/Low of those bars and determining if the move was > 100 pips.

I suspect you probably mean an hour to the exact minute which is within a bar, unless you are using a 1M chart. That is somewhat more complicated. For that you would need an array of 60 elements and record the High/Low...
I was thinking 1 min, I guess its not going to be a couple of simple lines like the current bar size then......
  • #10
  • Edited 5:05am May 6, 2011 4:48am | Edited 5:05am
Quoting BenScoobert
This has worked well for me but I'd like to try something a little more PA based

Does anyone know what code I'd need for the following change??

Instead of 100 pips on current barsize, I'd like to have 100 pips in the last hour.
Ben,

Have you typed in either iClose or iOpen as search terms into the MetaEditor Navigator? If you do, you would see this:
Inserted Code
double iClose( string symbol, int timeframe, int shift) 
Returns Close value for the bar of indicated symbol with timeframe and shift. If local history is empty (not loaded), function returns 0.
For the current chart, the information about close prices is in the predefined array named Close[]. 
Parameters:
symbol   -   Symbol the data of which should be used to calculate indicator. NULL means the current symbol. 
timeframe   -   Timeframe. It can be any of Timeframe enumeration values. 0 means the current chart timeframe. 
shift   -   Index of the value taken from the indicator buffer (shift relative to the current bar the given amount of periods ago). 

Sample:
  Print("Current bar for USDCHF H1: ",iTime("USDCHF",PERIOD_H1,i),", ",  iOpen("USDCHF",PERIOD_H1,i),", ",
                                      iHigh("USDCHF",PERIOD_H1,i),", ",  iLow("USDCHF",PERIOD_H1,i),", ",
                                      iClose("USDCHF",PERIOD_H1,i),", ", iVolume("USDCHF",PERIOD_H1,i));

What you want to do is instead of using iClose(0,0,0) replace the 2nd term (timeframe) with PERIOD_H1 to reference the price for a H1 chart. The final zero refers to how many bars back to reference. Zero means the current 60 minute bar. You could put in 3 to look back 3 bars ago on the 60 minute timeframe for instance. You mentioned the last hour (assuming not the current hour). For this the call will be in the form:

iClose(0, PERIOD_H1, 1)

Play around with that and see what you can come up with.
  • #11
  • May 6, 2011 5:37am May 6, 2011 5:37am
Quoting FXEZ
Ben,

Have you typed in either iClose or iOpen as search terms into the MetaEditor Navigator? If you do, you would see this:
[code]double iClose( string symbol, int timeframe, int shift)
Returns Close value for the bar of indicated symbol with timeframe and shift. If local history is empty (not loaded), function returns 0.
For the current chart, the information about close prices is in the predefined array named Close[].
Parameters:
symbol...
This seems to be quite above my programming skill level......I can see this is going to take a while and I'm going to be a little wiser afterwards
  • #12
  • May 6, 2011 5:54am May 6, 2011 5:54am
FXEZ, using your logic then, I should run it on 1 min and look back 60 bars?
  • #13
  • May 6, 2011 6:27am May 6, 2011 6:27am
Quoting BenScoobert
FXEZ, using your logic then, I should run it on 1 min and look back 60 bars?
No, if you want the high and low of the 60 minute bar 1 60 minute bar ago, the easiest way is to reference it like:

iHigh(0, PERIOD_H1, 1)
iLow(0, PERIOD_H1, 1)

To get the current 1 hour bar high/low change 1 at the end to 0.
This will work within ANY time frame chart and still return the H1 high/low. It works the same way with all the other timeseries access functions.
  • #14
  • May 6, 2011 6:37am May 6, 2011 6:37am
Quoting FXEZ
No, if you want the high and low of the 60 minute bar 1 60 minute bar ago, the easiest way is to reference it like:

iHigh(0, PERIOD_H1, 1)
iLow(0, PERIOD_H1, 1)

To get the current 1 hour bar high/low change 1 at the end to 0.
This will work within ANY time frame chart and still return the H1 high/low. It works the same way with all the other timeseries access functions.
Its not the current bar I'm after, what I have does that fine already.

Ideally what I want is x pips with the last x mins, I think using H1 like you suggest only looks back in the current bar, is that correct?
  • #15
  • May 6, 2011 7:05am May 6, 2011 7:05am
Quoting BenScoobert
Its not the current bar I'm after, what I have does that fine already.

Ideally what I want is x pips with the last x mins, I think using H1 like you suggest only looks back in the current bar, is that correct?
The shift parameter (the third parameter in these functions) allows referencing of past bars. In the example
Inserted Code
iHigh(0, PERIOD_H1, 1)
You are referencing the high of 1 ago on an hour chart. You could change that number to 5 and reference 5 bars back etc.

This will reference the current bar:
Inserted Code
iHigh(0, PERIOD_H1, 0)
  • #16
  • May 6, 2011 7:52am May 6, 2011 7:52am
Quoting BenScoobert
Its not the current bar I'm after, what I have does that fine already.

Ideally what I want is x pips with the last x mins, I think using H1 like you suggest only looks back in the current bar, is that correct?

Ben, I think you just trigger me to the real HolyGrail in Forex...this is the missing piece of my puzzle. TQ.
  • #17
  • May 6, 2011 10:52am May 6, 2011 10:52am
I'll rephrase what i mean :-)

I want the highest high from the last m1 60bars
  • #18
  • May 6, 2011 11:44am May 6, 2011 11:44am
Have you tried consulting the MQL4 reference manual?
http://docs.mql4.com/series/iHighest

Inserted Code
val=High[iHighest(NULL,PERIOD_M1,MODE_HIGH,60,0)];
  • #19
  • Last Post: May 6, 2011 3:00pm May 6, 2011 3:00pm
Quoting Xaphod
Have you tried consulting the MQL4 reference manual?
http://docs.mql4.com/series/iHighest

Inserted Code
val=High[iHighest(NULL,PERIOD_M1,MODE_HIGH,60,0)];
Its hard to use when you don't understand the syntax properly, I'm not a coder I just copy and paste and cobble together a few bits to get jobs done, if after thorough testing they prove profitable I'll get them professionally done.
0 traders viewing now