Could someone please write the following very small EA for me...

Hi guys

I would appreciate so mush if someone could program this very small EA for me, I have been trying a few days now with only my knowledge that I got in school from programming ten years ago, but I am just not getting what I am looking for.

If someone could help me it would be much appreciated.


Open sell order
Open buy order
{Open two orders at the same time, like hedging}

int market
market = (the current market price) {Like 1.2200}

while count = true
{
if market = market + 20 pips
{
then open sell order
market = (the current market price again)
count = true (the EA must run until I stop it)
}

if market = market - 20 pips
{
then open buy order and market = market price
market = (the current market price again)
count = true (the EA must run until I stop it)
}
}

What I am looking for is as the price is going higher I want to open up a sell order every 20 pips, and as the price is going lower I want to open a buy order every 20 pips.

Kind regards

I have decided to code it so long, and after working out the small bugs I have managed to run it, but it does not place the buy and sell order at the beginning. It did a few times and then I worked on the code some more, but now it does not want to do it at all anymore.

Could someone please take a look and tell me where I went wrong.

Regards







//+------------------------------------------------------------------+
//| Johan.mq4 |
//| Copyright 2010, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright 2010, MetaQuotes Software Corp."
#property link "http://www.metaquotes.net"

//---- input parameters



extern bool Tagger = True;
int counter = 1;
bool Buy = true;
bool Sell = true;

extern double Order1LotSize = 0.1;
extern double TakeProfit1 = 0;
extern double Order2LotSize = 0.1;
extern double TakeProfit2 = 0;
extern double StopLoss = 22;

//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
int ticket;
int Price;

ticket=OrderSend(Symbol(),OP_SELL,Order1LotSize,Bid,3,Bid+StopLoss*Point,TakeProfit1,"RapidFireSELL-GBPUSD",255,0,CLR_NONE);
ticket=OrderSend(Symbol(),OP_BUY,Order1LotSize,Ask,3,Ask-StopLoss*Point,TakeProfit1,"RapidFireBUY-EURUSD",255,0,CLR_NONE);


while(true)

{
Price = Bid;

if (Price < Price + StopLoss)
{
ticket=OrderSend(Symbol(),OP_BUY,Order1LotSize,Ask,3,Ask-StopLoss*Point,TakeProfit1,255,0,CLR_NONE);

}

if (Price > Price - StopLoss)
{
ticket=OrderSend(Symbol(),OP_SELL,Order2LotSize,Bid,3,Bid+StopLoss*Point,TakeProfit2,255,0,CLR_NONE);

}


}
//----

//----
return(0);
}
//+------------------------------------------------------------------+

Hi purpleheart,
Nice user name

Try EA below.

(Price < Price + StopLoss)

Substituting real numbers would result in 1.2000<1.2000+.0022. I don't know what you really trying to say, but this won't get it done.

Thank you Sangmane, I would try it out and see what it does...

Thanks for the complement as well.

Hi CodeMeister.

What I am trying to say is if the price (1.2000) is smaller as price minus stoploss (1.2000 + .0022) then the EA must buy a lot of 0.1.



Meaning when 1.2000 > 1.2022 then open buy order.
Otherwise when 1.2000 < 1.9978 then open sell order.

Sorry, I see my "<>" were facing the wrong way.

But my real problem when running the EA is I get a "the comment parameter for OrderSend function must be a string" error the whole time.

Could someone help with this?

I have never seen this error. Your OrderSend() code compiled fine for me. Did you mean the error is a run time or compile error? Also would help if you included the error code (ie. 111 or whatever).

Hi Codemaster

I see the error been given the whole time in MT4 under the "Experts" tab...

I do not know why but some times it opens the first two orders, and other times it just gives me this error without doing anything in MT4...

I think you confirmed that it is a runtime error. That is strange that it fails some times and works at other times since you are using the same comment for all trades. Usually this type of error occurs when a parameter is missing - but the compiler catches it.

I'm not going to try it on my system because if the code works, it will enter an order for every tick and then I have a massive cleanup on my hands.

Maybe somebody else can spot something I missed.

Thanks for trying to help codemaster, I really really appreciate it.

I got it working now and found the problem.

I want to know if you can help me with this last bit of code.

I am looking for this bit...

Price = Bid;

while(true)
{
if (Price > Price + StopLoss)
{
ticket=OrderSend(Symbol(),OP_BUY,Order1LotSize,Ask,3,Ask-StopLoss*Point,TakeProfit1,NULL,255,0,CLR_NONE);

}

if (Price < Price - StopLoss)
{
ticket=OrderSend(Symbol(),OP_SELL,Order2LotSize,Bid,3,Bid+StopLoss*Point,TakeProfit2,NULL,255,0,CLR_NONE);

}

But there is nothing that happens when I put this in. Could you see if you would not maybe code it better if you can see what I am trying to accomplish. (What I want is to perform another action after "X" amount of pips after the first action. )

For instance:
external int = X
Action 1 happens and "marker = bid"
Now if marker = marker + "X" pips then do action 2
or if marker = marker - "X" pips then do action 3
marker = bid again
(----The above three lines must run the whole time----)

Any help would be MUCH appreciated.

Just saw that you've corrected the missing comment

My head is a little clearer now than earlier this morning. I think I understand what you are trying to do now - don't know why it wasn't plain before.

The problem goes back to this statement Price > Price + StopLoss . Again it makes no sense if you substitute real numbers. What you have to do is assign a new static variable called prevPrice to the price of the last trade. Then reword the statement to be Price > prevPrice + StopLoss. I think you need 2 variables - one for sell and one for buy.

I am trying to work this out for the past few hours now, but I just do not get how you mean.

How do I get the amount for "price" in the first place?
Is it " price == bid; "? Because the number never changes for me even though the bar goes up and down...

To tell the truth, once my order is open my bid price does not want to change to anything.

I am so frustrated

Well I think you have identified the crux of the matter - how to define the conditions of the first trade. Once that trade is made, the rest is easier because everything is done repeatedly.

The best way to enter the first trade - just buy / sell at market. You know that prevPrice will be 0 for the first trade. If that trade is successful, just set prevPrice to the Bid/Ask and wait for the market to move 22 pips. I still think you need 2 variables - one for buy and one for sell.