No value returned in indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

broker deposit returned to separate bank accounts 1 reply

Recently returned and what's happening to Eur/Jpy? 0 replies

Interesting - 0 pip spread, Commisions returned on losing trades? 25 replies

How to get an MA value of first indicators value? 2 replies

Could RSI value show most update value on eur/usd chart? 6 replies

Attachments: No value returned in indicator
Exit Attachments

No value returned in indicator

  • #1
  • First Post: Jun 6, 2010 6:23pm Jun 6, 2010 6:23pm
et al,

Can someone tell me why I don't get a vaule returned for BWMin in the following indicator?

I'm trying to get the lowest value for the last 120 in the Bandwidth array.

Thanks.
Inserted Code
/*+------------------------------------------------------------------+
                                                      bb - %b.mq4 
                               Copyright © 2010, Nondisclosure007 
                                               [url]http://no.link.yet[/url] 
                                               
[url]http://www.bollingerbands.com/services/bb/[/url]
   {click on Bollinger Bands Features}
//+------------------------------------------------------------------+*/
#property copyright "Copyright © 2010, Nondisclosure007"
#property link      "[url]http://no.link.yet[/url]"
#property indicator_separate_window
#property indicator_buffers 2
//---- input parameters
extern int       bbPeriod=10;
extern double    bbDeviation=1.9;
extern int       bbPrice=PRICE_MEDIAN;
double Bandwidth[],BWMin[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
   IndicatorShortName("Bandwidth - Period="+bbPeriod+"    ");   
   SetIndexStyle(0,DRAW_LINE,STYLE_SOLID,1,Blue);
   SetIndexBuffer(0,Bandwidth);
   SetIndexLabel(0,"Bandwidth");
   SetIndexStyle(1,DRAW_LINE,STYLE_SOLID,1,Gray);
   SetIndexBuffer(1,BWMin);
   SetIndexLabel(1,"BWMin");
   IndicatorDigits(Digits+1);
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   //Bar stuff
   int    counted_bars=IndicatorCounted(); int limit; 
   if(counted_bars<0) return(-1); 
   limit=Bars-counted_bars-1;
   for(int shift=0; shift<limit; shift++)
   {
      double bbUpper=iCustom(Symbol(),0,"Bands",bbPeriod,0,bbDeviation,bbPrice,1,shift);
      double bbMiddle=iCustom(Symbol(),0,"Bands",bbPeriod,0,bbDeviation,bbPrice,0,shift);
      double bbLower=iCustom(Symbol(),0,"Bands",bbPeriod,0,bbDeviation,bbPrice,2,shift);
      Bandwidth[shift]=(bbUpper-bbLower)/bbMiddle; 
      BWMin[shift]=Bandwidth[ArrayMinimum(Bandwidth,120,shift+1)];
   }
   return(0);
  }
//+------------------------------------------------------------------+
  • #2
  • Jun 6, 2010 6:35pm Jun 6, 2010 6:35pm
hey non d..... the zero divide police might be writing you a ticket......... there is a couple of'em that come down kinda harsh on us.....

is there a reason your using bands and not ibands.... h
to trade and code, keep both simple... no call to impress....h
  • #3
  • Jun 6, 2010 6:44pm Jun 6, 2010 6:44pm
rewrote it slightly, seems to plot ok..... had to use bands seeing how not sure what the icustom bands is.....h
Attached Image (click to enlarge)
Click to Enlarge Name: non d.gif Size: 22 KB
to trade and code, keep both simple... no call to impress....h
  • #4
  • Jun 6, 2010 7:18pm Jun 6, 2010 7:18pm
just noticed the code didn't stick to the post above..... changes should be obvious.....h

Inserted Code
 
#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red
//---- input parameters
extern int       bbPeriod    =          20;
extern double    bbDeviation =         2.0;
extern int       bbPrice     =           4;
extern int       lookback    =         120;
double Bandwidth[],BWMin[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
   IndicatorShortName("Bandwidth - Period="+bbPeriod+"    ");   
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,Bandwidth);
   SetIndexLabel(0,"Bandwidth");
   SetIndexStyle(1,DRAW_LINE);
   SetIndexBuffer(1,BWMin);
   SetIndexLabel(1,"BWMin");
   IndicatorDigits(Digits+1);
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   //Bar stuff
   int    counted_bars=IndicatorCounted();
   int limit;
   int shift; 
   double bbUpper;
   double bbLower;
   if(counted_bars<0) return(-1); 
   limit=Bars-counted_bars-1;
 
   for(shift=0; shift<limit; shift++)
      {
      bbUpper=iBands(NULL,0,bbPeriod,bbDeviation,0,PRICE_LOW,MODE_UPPER,shift);
      bbLower=iBands(NULL,0,bbPeriod,bbDeviation,0,PRICE_LOW,MODE_LOWER,shift);
 
      Bandwidth[shift]=(bbUpper-bbLower)/Point; 
      }
 
   for(shift=0; shift<limit; shift++)
      {  
      BWMin[shift]=Bandwidth[ArrayMinimum(Bandwidth,lookback,shift+1)];
      }
 
   return(0);
  }
to trade and code, keep both simple... no call to impress....h
  • #5
  • Last Post: Jun 7, 2010 2:50pm Jun 7, 2010 2:50pm
Thanks.

I let it run as is and, surprisingly, it started spitting out the BWMin value. But I see what you did and I'm making the changes.

I'm using iCustom calling Bands becuase I've changed Bands to use a double for deviation instead of an integer. Allow's further granularity.

Quoting hayseed
just noticed the code didn't stick to the post above..... changes should be obvious.....h

[code]
#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red
//---- input parameters
extern int...
0 traders viewing now