My Function not working correctly | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

required to function call function 2 replies

Help getting this indicator working correctly please.. 0 replies

iVolume function not working correctly in mq4? 15 replies

stop loss function and edit time function for Breakout EA 1 reply

Simple Trader not working correctly 2 replies

My Function not working correctly

  • #1
  • First Post: May 22, 2010 2:13pm May 22, 2010 2:13pm
I am trying to create a function that will not allow an order to be placed if there already is an order at any given point.
I created the function below and me EA is still placing orders ontop of eachother, can someone give any advice?
Thanks

//-------------
Part that calls the function in the program
Inserted Code
buytradeok = buytradeokfunc(highline);
Inserted Code
if (buytradeok < 1) {BUYORDER(LotValue,highline,MaxSlippage,lowline,takeprofithigh);}
//-------------
Function:
Inserted Code
int buytradeokfunc(double HIGHLINE)
   {
   for(int i=0;i<OrdersTotal();i++)
      {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderSymbol()==Symbol())
        {
         if(OrderType()==OP_BUY)
            {
            if (CompareDoubles(OrderOpenPrice(),HIGHLINE))  return(1);
            else  return(0);
            }
         }
      }
   }
  • #2
  • May 22, 2010 2:42pm May 22, 2010 2:42pm
See the correction inside your original code
Quoting bauerjj10
int buytradeokfunc(double HIGHLINE)
{
for(int i=0;i<OrdersTotal();i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderSymbol()==Symbol())
{
if(OrderType()==OP_BUY)
{
if (CompareDoubles(OrderOpenPrice(),HIGHLINE)) return(1);
//else return(0); remove this line
}
}
}
return(0); //add this line
}
  • #3
  • May 22, 2010 3:18pm May 22, 2010 3:18pm
Thank you that works!

One more question. I tried searching but was unable to figure out if this is possible.


is there a function that rounds to the nearest decimal.

So if a value is 0.14612
the function would produce 0.15 if I set it to the 100ths decimal spot??

The reason I ask is I am trying to compare Orderlots() to a double
  • #4
  • Last Post: May 22, 2010 4:31pm May 22, 2010 4:31pm
you can use MathRound()

example:
round to the nearest 100th decimal = 0.01

double d0 = 0.01; //100th decimal
double d1 = 0.14612; //value to be rounded up
double d2 = MathRound(d1/d0)*d0;
0 traders viewing now