A Simple London Breakout | Page 40 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

A Simple London Breakout V.2 1,490 replies

SIMPLE EA for a simple method needed!! 2 replies

Another Simple London Breakout System (with a twist) 46 replies

Simple london breakout v.9.2 error 1 reply

Need help with this simple london breakout EA 2 replies

Attachments: A Simple London Breakout
Exit Attachments

A Simple London Breakout

  • #781
  • May 21, 2010 6:06am May 21, 2010 6:06am
i set your EA..but no gmt offset....so the box is miss
  • #782
  • Edited 8:40am May 21, 2010 8:36am | Edited 8:40am
Sq,

Attached is the 4.0 EA with Martingale.

I've named it "London Breakout EA-V4.0_Pat With Mart".
Mer & Sq can decide to make it official with a Version change or extension.

All the Changes and Additions in the code are within //Pat --- //Pat.

Using FindNext with //Pat text will take you to all modifications.



The changes are based on the assumption

  1. that only a single Op_Buy or OP_Sell order exists. This is taken care of in Order Send code in (IsTradeAllowed()) in the Start routine.
  2. All Martingale losses are tolerable(Mer) - Unlimited Account Balance

The algo is to keep track of ticket number of Op_Buy order using p_LongOpenTicketNo and LongOpenTicketNo

or of Op_Sell order using
p_ShortOpenTicketNo and ShortOpenTicketNo

where p_ keeps track of open order at previous tick.

If p_LongOpenTicketNo > LongOpenTicketNo then the open OP_Buy order just closed ( similar for OP_Sell) last tick or this tick depending on when the "Aggregate" function is called.
Function GetProfitLossThisOrder is called to determine if the last order closed was profitable.

If Profitable, the Mart_Idx=0 (that is lots=Lot) else Mart_Idx++ and lots=Lot*MartFactor[Mart_Idx] prior to calling the OpenPendingOrder Function.

Array MartFactor holds the multipliers to be used in succesion.

MaxLevel is user definable, that is how many levels can the martingale advance to. Maximum is the number of factors in the MartFactor array and is checked in Init();

ReStartMartSeq is user definable , that is if MaxLevel is exceeded, should the EA revert index 0 of MartFactor or keep the last multiplier till a profitable order is achieved.

lotsToTrade determination is done prior to SendPendingOrder in if(IsTradeAllowed()) in the Start routine.

OCO and UseMartingale should be true. This check is performed in Init().

This just one way of implementing Martingale in this Ea. There maybe other more effecient ways to achieve the same result.

I've not had a chance to demo it since its Friday and, if I'm not mistaken, this EA will not backtest. If it does, we should have an answer by Sunday Open.

Hope this helps.

Pat

Attached File(s)
File Type: mq4 London Breakout EA-V4.0_Pat With Mart.mq4   44 KB | 633 downloads
  • #783
  • May 21, 2010 9:30am May 21, 2010 9:30am
Quoting squalou
hmmm.... trying to open 0.00 lots... !

It has to do with the "Risk" input (2%), and your current Account Free Margin.

I have put a check for the fixed Lot input, but not for the calculated Lot based on Risk and SL at trade open.

Can you try this change in the EA v4 code:

add the following code (in bold) at the beginning of the DisplayUserFeedback() function:

[code]
//+------------------------------------------------------------------+
void DisplayUserFeedback()
//+------------------------------------------------------------------+
{

[b]...
I changed the code and complied but MT4 still show error.
Attached Image (click to enlarge)
Click to Enlarge Name: Gbpusd.JPG Size: 76 KB
  • #784
  • May 21, 2010 10:34am May 21, 2010 10:34am
Quoting Pat1
Sq,

Attached is the 4.0 EA with Martingale.

I've named it "London Breakout EA-V4.0_Pat With Mart".
Mer & Sq can decide to make it official with a Version change or extension.


Pat
Pat and Squalou


Beat me if I am too stupid to run this piece of art on my server, but, unfortunately, I am getting very much the same error message as with the previous V4:

LB EA: USDCHF Some Indicator SETTINGS are missing;
Please verify objPrefix in the Indicator and the EA;
(objPrefix is currently set to LB- in the EA)

What am I missing here?

Thanks and keep up the great work!

Daniel
  • #785
  • May 21, 2010 12:24pm May 21, 2010 12:24pm
Quoting Pat1
Sq,

Attached is the 4.0 EA with Martingale.

I've named it "London Breakout EA-V4.0_Pat With Mart".
Mer & Sq can decide to make it official with a Version change or extension.

...

Hope this helps.

Pat

Wow! Great work Pat1!

Changes are pretty straight forward.

I'm sure Mer will love it!


ok... i just quickly spotted a first bug in GetProfitLossThisOrder() i think:
the selection function is wrong, it uses SELECT_BY_TICKET with an index in the trades history; it should be SEKECT_BY_POS.

But it's even simpler than that: we just want to select the order with ticketno...

Inserted Code
//+------------------------------------------------------------------+
void GetProfitLossThisOrder(int ticketno)
//+------------------------------------------------------------------+
{
    bool LastOrderProfitable=false;
    OrderSelect(ticketno,SELECT_BY_TICKET);
    if (TimeDayOfWeek(OrderCloseTime()) == TimeDayOfWeek(Time[0]) ) {
      if(OrderProfit()>0) LastOrderProfitable=true;
    }

    GetMart_Idx(LastOrderProfitable);
    
}//void GetProfitLossThisOrder(int ticketno)
Then, another bug might be in GetAggregatePosition():

Inserted Code
  if(p_LongOpenTicketNo >LongOpenTicketNo ) 
    GetProfitLossThisOrder( p_LongOpenTicketNo);
  } //  Long Open Order Just Closed Last tick (or this tick???)
p_LongOpenTicketNo is not initialized, should be set to 0 at init at least;
I'm not sure about the logic here yet: ticket numbers are assigned in increasing values, so the "previous" ticket should always be < current one, not >.

Same for Short ones.

I'll check more into details soon.
Got to go...

Great work Pat1 anyway.
We'll get this EA where Mer wants it to go!

BTW, you CAN backtest this EA...
It just needs to have the Indi setup on a chart with the pair to be tested, so the INPUTS variables are defined, then the EA will use those values, even in backtest mode.


Sq.
  • #786
  • May 21, 2010 12:31pm May 21, 2010 12:31pm
squalou,
did you see my issue posted about the ea opening the pending orders for the previous day even if past the trading session end time?
Can u look into that, or does it not happen to you?
  • #787
  • May 21, 2010 12:36pm May 21, 2010 12:36pm
Quoting tazmaan
squalou,
did you see my issue posted about the ea opening the pending orders for the previous day even if past the trading session end time?
Can u look into that, or does it not happen to you?
it happened to me all the time.
  • #788
  • May 21, 2010 12:47pm May 21, 2010 12:47pm
good, not just me then.
what i just did last night was to turn ea off until my box was done forming, and manually deleted all the pendings it put in.
Not a huge deal, but would be nice to not have to do that
  • #789
  • May 21, 2010 1:42pm May 21, 2010 1:42pm
Quoting xicecube
Pat and Squalou


Beat me if I am too stupid to run this piece of art on my server, but, unfortunately, I am getting very much the same error message as with the previous V4:

LB EA: USDCHF Some Indicator SETTINGS are missing;
Please verify objPrefix in the Indicator and the EA;
(objPrefix is currently set to LB- in the EA)

What am I missing here?

Thanks and keep up the great work!

Daniel
I received the same error
  • #790
  • May 21, 2010 2:40pm May 21, 2010 2:40pm
Quoting tazmaan
squalou,
did you see my issue posted about the ea opening the pending orders for the previous day even if past the trading session end time?
Can u look into that, or does it not happen to you?


i think i can reproduce it, finally!...

By changing the Indi time settings while the EA is loaded, to make it draw the box just a few minutes later.
I see it is sending orders while outside of trading hours, and also using "yesterday's" values...

Now i will get this one down too!!!
You'll have a nice working EA for next week, guys!
And with Pat's Martingale code debugged as well, hopefully, we'll have some very interesting week coming.

Sq
  • #791
  • May 21, 2010 3:40pm May 21, 2010 3:40pm
Awesome, glad u were able to recreate it so you can fix. Looking forward to playing with it next week! have a great weekend
  • #792
  • May 21, 2010 7:47pm May 21, 2010 7:47pm
Quoting tazmaan
Awesome, glad u were able to recreate it so you can fix. Looking forward to playing with it next week! have a great weekend
for the meantime, just use the manual version. im still using v8 together with the scriptv3.1
  • #793
  • Edited 10:57pm May 21, 2010 10:55pm | Edited 10:57pm
Sq,

We are interested in closing of an Op_Buy or Op_Sell trade.

If an Op_BuyStop changes to an Op_Buy last tick or this tick, LOTN(Long Open....) gets the value of its ticket number otherwise is equal to 0. p_LOTN was initialized as 0 when declared. Since it is less then LOTN, the two if statements will be false and the p_values will be initiated to LOTN value. If the Op_Buy closes, LOTN will be 0. P_LOTN will be revised to 0 after the getprofitlosslastorder function is run. In other words, the update of p_ values has to occur before a check for profitloss.

Similarly for SOTN and p_SOTN
Also,
In the event there is a half trade, the new ticket value of the remaing half order will be greater than the Initial ticket value and since the p- values have not been revised, the if statements will be false. The p_ values will be initialized to the new OTM values. If this remaining half order is a loss, Mart_Idx will increase. The logic is right. Let's see if MT4 obliges.


You are absolutely right about the By_Ticket coding in OrderSelect.
Thanks
Pat
  • #794
  • May 23, 2010 9:34am May 23, 2010 9:34am
Quoting Pat1
Sq,

We are interested in closing of an Op_Buy or Op_Sell trade.

If an Op_BuyStop changes to an Op_Buy last tick or this tick, LOTN(Long Open....) gets the value of its ticket number otherwise is equal to 0. p_LOTN was initialized as...
Pat, you are speaking another language, but I hope you can read this!

THANK YOU! And SQ! You guys rock!

We are our own best indicator.
  • #795
  • May 24, 2010 2:03am May 24, 2010 2:03am
I hope everyone had a good weekend and hopefully we will rebound from the train wreck regarding last weeks trading. I did want to update my Usd/Jpy trade from Friday as it was the only pair to have a valid box. I would have done it on Friday but had to rush to catch a flight to Chicago for the weekend for my birthday.

Usd/Jpy

Trade 1= -75 pips

The next valid trade will start with a multiplier of 2>
Attached Image (click to enlarge)
Click to Enlarge Name: usdjpy new.jpg Size: 106 KB
  • #796
  • May 24, 2010 9:24am May 24, 2010 9:24am
Quoting mer071898
I hope everyone had a good weekend and hopefully we will rebound from the train wreck regarding last weeks trading. I did want to update my Usd/Jpy trade from Friday as it was the only pair to have a valid box. I would have done it on Friday but had to rush to catch a flight to Chicago for the weekend for my birthday.

Usd/Jpy

Trade 1= -75 pips

The next valid trade will start with a multiplier of 2>
...
Unless you were a 'trend is your friend' kind of guy, I think everyone got killed...
We are our own best indicator.
  • #797
  • May 24, 2010 9:38am May 24, 2010 9:38am
I am hoping I can fix this issue?

When/IF I disconnect my MT4 while trades are in progress (must reboot), then I typically turn off EA's, then shut down MT4, then restart etc..

When I do that w/ this EA, it closes all my orders?

How do I reboot while trades are open?
We are our own best indicator.
  • #798
  • May 24, 2010 10:00am May 24, 2010 10:00am
I already read the first post.

I put an indicator and then put an EA. After that I get lot of error massages from MT4.

another case I put an indicator with other script and then put the EA. This case I do not get any error massage from MT4.
  • #799
  • May 24, 2010 12:03pm May 24, 2010 12:03pm
btw i tried USDCHF : 04:00-05:00 GMT box size 35 ..
EURJPY: 05:00-06:00 GMT box size 80...worked good today..

question to squalou on some pairs.. i have " the robot has been suspended. Reason: you need to change the Magicnumber input" even after change it's still written.. is normal?
  • #800
  • May 24, 2010 8:22pm May 24, 2010 8:22pm
Quoting mistersimple
btw i tried USDCHF : 04:00-05:00 GMT box size 35 ..
EURJPY: 05:00-06:00 GMT box size 80...worked good today..

question to squalou on some pairs.. i have " the robot has been suspended. Reason: you need to change the Magicnumber input" even after change it's still written.. is normal?
guess 1.
It is not enough to change the magic number while the ea is running. Remove the ea and change the magic number as you reload it or even earlier by editing the .mq4 file.

guess 2.
Need different magic number for each pair. But with 400 odd posts, guess you know that & I dont think it is enforced by the code.

guess 3.
You are trying to run it live so edit .mq4 file, then load it. Or save a set file, remove ea, reload ea & use the set file with the settings you want. Really is a bit like guess 1.

cheers scalpz
Target 2 : Stoploss in the green
0 traders viewing now