OrderModify Error | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

Why ordermodify error 1? 9 replies

OrderModify error 1 HELP PLEASE 5 replies

OrderModify() problem (NOT error code 1) 3 replies

OrderModify error 1 ?? 0 replies

Attachments: OrderModify Error
Exit Attachments

OrderModify Error

  • #1
  • First Post: Edited 8:34am May 17, 2010 8:08am | Edited 8:34am
I am stuck and not sure what I am doing wrong.
My EA is reporting a OrderModify error 1 on almost every tick.
I am trying to get the EA to modify an order when the "entry" variable changes from the OrderOpenPrice(), which was originally opened using "entry".

The EA is working correctly and will modify the order to the correct point, however, it is trying to modify it even when the entry variable is == to itself, or OrderOpenPrice().

In the past to check values I have placed a Print (entry); and Print (OrderOpenPrice()); directly after if (entry != OrderOpenPrice()) { and it is still trying to execute my ordermodify statement even when both of these are == to eachother.

What am I doing wrong?
Thank you
Here is the code I have pertaining to this issue.


Inserted Code
int totalorders = OrdersTotal();
for(int i=totalorders-1;i>=0;i--)
   {
   OrderSelect(i, SELECT_BY_POS);
 
   if (OrderSymbol()==Symbol()&& OrderType()== OP_SELLSTOP && RiskManagement==true)
      {
      if (entry != OrderOpenPrice())
         {
         OrderModify(OrderTicket(),entry,stoploss,takeprofit,0,0);
         }
      }
   if (OrderSymbol()==Symbol()&& OrderType()== OP_SELLSTOP && RiskManagement==false)
      {
      if (entry != OrderOpenPrice())
         {
         OrderModify(OrderTicket(),entry,entry+(StopLossPips*Point),entry-(TakeProfitPips*Point),0,0);
         }


I found the answer to my mistake, when comparing doubles it is best to use < & > rather than !=.
The guys over at MQL4 forums helped me out with this problem.
Thanks
  • #2
  • May 17, 2010 10:00am May 17, 2010 10:00am
Check the values of your variables during your program run.
The more experience the closer to the reality
  • #3
  • May 17, 2010 11:20am May 17, 2010 11:20am
Quoting Ivan
Check the values of your variables during your program run.

I did that and this is what it is returning

10:53:11 2008.11.13 12:00 work181 GBPUSD,H4: 1.5494
10:53:11 2008.11.13 12:00 work181 GBPUSD,H4: 1.5494
10:53:11 2008.11.13 12:00 work181 GBPUSD,H4: OrderModify error 1

the 1.5494 is the entry and openorderprice.

my function is below:

if (NormalizeDouble(entry,4) != OrderOpenPrice())
{
OrderModify(OrderTicket(),entry,stoploss,takeprofit,0,0);

it is still reaching the statement of the if function on every tick when it should not be because both "entry" and orderopenprice() are exactly the same.

I dont know why it is doing this.
  • #4
  • May 17, 2010 11:25am May 17, 2010 11:25am
I'm not sure how the 'entry' price is calculated, but extend it out to more decimals, do the same for the order entry price. I suspect there will be minute differences there which will require both values to be normalized.
  • #5
  • May 17, 2010 11:31am May 17, 2010 11:31am
Why NormalizeDouble(entry,4)...? Why not NormalizeDouble(entry,Digits)...? Are you sure it's a 4 digit account? As for OrderOpenPrice() variable, I would assume it's specified in Digits but, I could be mistaken?
  • #6
  • May 17, 2010 11:44am May 17, 2010 11:44am
Quoting Ronald Raygun
I'm not sure how the 'entry' price is calculated, but extend it out to more decimals, do the same for the order entry price. I suspect there will be minute differences there which will require both values to be normalized.

entry and entry1 are calculated by a couple of indicators.

I am not quite sure why this isnt working,
if you look at the code below.

my sellstop orders are not reaching the print functions when entry == orderopenprice(). <--- so this means it is working correctly for the sellstop orders.

when the program reaches the buystop orders it is reaching the print functions even when entry1 == orderopenprice(). <---this is not working correctly.



Inserted Code
[color=#0000ff]int[/color] totalorders = [color=#8a2be2]OrdersTotal[/color]();
[color=#0000ff]for[/color]([color=#0000ff]int[/color] i=totalorders-[color=#008000]1[/color];i>=[color=#008000]0[/color];i--)
   {
   [color=#8a2be2]OrderSelect[/color](i, SELECT_BY_POS);
   
   [color=#0000ff]if[/color] (OrderSymbol()==[color=#8a2be2]Symbol[/color]()&& OrderType()== OP_SELLSTOP && RiskManagement==true)
      {
      [color=#0000ff]if[/color] ([color=#8a2be2]NormalizeDouble[/color](entry,[color=#008000]4[/color]) != OrderOpenPrice())
         {
         [color=#8a2be2]Print[/color]([color=#8a2be2]NormalizeDouble[/color](entry,[color=#008000]4[/color]));
         [color=#8a2be2]Print[/color](OrderOpenPrice());
         OrderModify(OrderTicket(),entry,stoploss,takeprofit,[color=#008000]0[/color],[color=#008000]0[/color]);
         }
      }
   [color=#0000ff]if[/color] (OrderSymbol()==[color=#8a2be2]Symbol[/color]()&& OrderType()== OP_SELLSTOP && RiskManagement==false)
      {
      [color=#0000ff]if[/color] ([color=#8a2be2]NormalizeDouble[/color](entry,[color=#008000]4[/color]) != OrderOpenPrice())
         {
         OrderModify(OrderTicket(),entry,entry+(StopLossPips*[color=#8a2be2]Point[/color]),entry-(TakeProfitPips*[color=#8a2be2]Point[/color]),[color=#008000]0[/color],[color=#008000]0[/color]);
         }
      }
   [color=#0000ff]if[/color] (OrderSymbol()==[color=#8a2be2]Symbol[/color]()&& OrderType()== OP_BUYSTOP && RiskManagement==true)
      {
      [color=#0000ff]if[/color] ([color=#8a2be2]NormalizeDouble[/color] (entry1,[color=#008000]4[/color]) != OrderOpenPrice())
         {
         [color=#8a2be2]Print[/color]([color=#8a2be2]NormalizeDouble[/color](entry1,[color=#008000]4[/color]));
         [color=#8a2be2]Print[/color](OrderOpenPrice());
         OrderModify(OrderTicket(),entry1,stoploss1,takeprofit1,[color=#008000]0[/color],[color=#008000]0[/color]);
         }
      }
   [color=#0000ff]if[/color] (OrderSymbol()==[color=#8a2be2]Symbol[/color]()&& OrderType()== OP_BUYSTOP && RiskManagement==false)
      {
      [color=#0000ff]if[/color] ([color=#8a2be2]NormalizeDouble[/color](entry1,[color=#008000]4[/color]) != OrderOpenPrice())
         {
         OrderModify(OrderTicket(),entry1,entry1-(StopLossPips*[color=#8a2be2]Point[/color]),entry1+(TakeProfitPips*[color=#8a2be2]Point[/color]),[color=#008000]0[/color],[color=#008000]0[/color]);
         }
      }
  • #7
  • May 17, 2010 11:49am May 17, 2010 11:49am
Quoting ecTrade
Why NormalizeDouble(entry,4)...? Why not NormalizeDouble(entry,Digits)...? Are you sure it's a 4 digit account? As for OrderOpenPrice() variable, I would assume it's specified in Digits but, I could be mistaken?
its a 4 digit account, so digits or 4 should both work.

I have only been trying to program for a week now and am not familiar with all the different functions available.
  • #8
  • Edited 12:03pm May 17, 2010 11:50am | Edited 12:03pm
Oh, at what point are you saying entry=OrderOpenPrice()...? Because once you do, then the two should be exact (or, I've never had a problem here), and there shouldn't be any need to Normalize it. And, of course once you do, there's a good chance they are no longer exact, and this could be what's causing the error.

Also, when you normalize it, it rounds the number up or down, and if the OrderOpenPrice() variable is carried out further, then you're going to have a problem.
  • #9
  • May 17, 2010 11:59am May 17, 2010 11:59am
Quoting ecTrade
Oh, at what point are you saying entry=OrderOpenPrice()...? Because once you do, then the two should be exact (or, I've never had a problem here), and there shouldn't be any need to Normalize it. And, of course once you do, then they're not going to be exact, and this could be what's causing the error.

Sorry i can see how my wording in the last post could be confusing.

what I was saying is that if my entry variable is equal to the selected orders open price then this function below should not move on to its statement. (correct??)
if (NormalizeDouble(entry,4) != OrderOpenPrice())

Now this is working properly on sellstop orders, however when the program reaches the buystop orders with the exact same function with the exception of the variable, which is changed to entry1, it looks at
if (NormalizeDouble(entry1,4) != OrderOpenPrice())
and moves on to the statement which is to modify the order on every tick,
since the part of the order it is modifying is the entry1 and entry1 already equals itself it is returning ordermodify error 1

hope this makes sense
  • #10
  • Edited 12:43pm May 17, 2010 12:20pm | Edited 12:43pm
Why can't you just try ... if (entry != OrderOpenPrice()...? If as you say, both are 4 digits, there is no need to normalize it. Or, if they are not 4 digits (and are greater), then by declaring entry=OrderOpenPrice() should cover it. Of course that doesn't mean there aren't any instances where you may need to normalize numbers, but not here I don't think.

Or, maybe Ronald is right, and you should do something like ... if(NormalizeDouble(entry,4) != NormalizeDouble(OrderOpenPrice(),4)) ...? Or, it might be better to carry out it to the next digit if, as he says, there is the slightest variation between the two.
  • #11
  • May 17, 2010 12:39pm May 17, 2010 12:39pm
Quoting ecTrade
Why can't you just try ... if (entry != OrderOpenPrice()...? If as you say, both are 4 digits, there is no need to normalize it. Or, if they are not 4 digits (and are greater), then by declaring entry=OrderOpenPrice() should cover it. Of course that doesn't mean there aren't any instances where you may need to normalize numbers, but not here I don't think.

EC, i appreciate you trying to help me but I dont think you understand what I am trying to accomplish here.

let me try to explain more.

in my program the variable
double entry = the price I want my ea to place a sellstop order based off of an equation i created using a few indicators.

double entry1 = the price I want my ea to place a buystop order based off of a similar equation to the sellstop order.

so when my equations produce a different value for my entry, and entry1 variables I want to modify the sellstop and buystop orders to move the orderopenprice() to the new value of entry, or entry1.

It is working fine, the EA is modifying the orders when the value of entry and entry1 changes, the only issue I am having is that it is trying to modify entry1 even when it is equal to the current orderopenprice () on the buystop order.

hence my equation:
Inserted Code
[color=#0000ff]if[/color] (OrderSymbol()==[color=#8a2be2]Symbol[/color]()&& OrderType()== OP_BUYSTOP && RiskManagement==true)
      {
     [b] [color=#0000ff]if[/color] ([color=#8a2be2]NormalizeDouble[/color] (entry1,[color=#008000]4[/color]) != OrderOpenPrice())[/b]
         {
         OrderModify(OrderTicket(),entry1,stoploss1,takeprofit1,[color=#008000]0[/color],[color=#008000]0[/color]);
         }
      }

In the bold above I am trying to say that if the 4 digit entry price is not equal to the selected orders open price, then modify it and change the buystop price to the new entry price.


If this doesnt clear things up thank you for trying to help but I dont think I can explain it any better. Sorry if its confusing.
  • #12
  • May 17, 2010 12:40pm May 17, 2010 12:40pm
Quoting bauerjj10
Sorry i can see how my wording in the last post could be confusing.

what I was saying is that if my entry variable is equal to the selected orders open price then this function below should not move on to its statement....
Hi bauer,
I assume your entry and entry1 is based on what price shown on chart, which is Bid value. Sell's open price is in Bid, and Buy's open price is in Ask.
So to get a proper comparison, you should compare Buy's order open price with entry1+spread.
The statement for Buy order should be:
if (NormalizeDouble(entry1,4)+MarketInfo(Symbol(),MODE_SPREAD) != OrderOpenPrice())

One more thing, as you stated on the first post, you should be careful when comparing two doubles. But, Imo, this not the reason why the comparison works for Sell order but not for Buy order.

Hope this help
  • #13
  • May 17, 2010 1:12pm May 17, 2010 1:12pm
Yeah, this could take a while............

You need to provide more info on how those entries are calculated.

Also try placing the print functions right after the orderselect, so you can inspect the all variables under all conditions. It doesn't help you print the variables when it works, you need to see what they are when it is not doing its job. So, why is it executing the buy but not the sell.........It probably because the entry1 variable is is not what you think it is....but you are not printing it, so how will you ever know?
  • #14
  • May 17, 2010 1:26pm May 17, 2010 1:26pm
after re-read your problems and seeing that you got ordermodify error, there is a possibilities the current price was too close to entry/entry1 value.

so, before send an ordermodify command, do the following checking:

//get StopLevel value:
double StopLevel = MarketInfo(Symbol(),MODE_STOPLEVEL)*Point;
....
//sellstop order
if(entry < Bid-StopLevel)
OrderModify(.....
....
//buystop order
if(entry1 > Ask+StopLevel)
OrderModify(.....

you should also make sure that the current OrderOpenPrice() differ from the new OrderOpenPrice()
if(MathAbs(entry-OrderOpenPrice()) > StopLevel)
  • #15
  • May 17, 2010 1:28pm May 17, 2010 1:28pm
Quoting sangmane
Hi bauer,
I assume your entry and entry1 is based on what price shown on chart, which is Bid value. Sell's open price is in Bid, and Buy's open price is in Ask.
So to get a proper comparison, you should compare Buy's order open price with entry1+spread.
The statement for Buy order should be:
if (NormalizeDouble(entry1,4)+MarketInfo(Symbol(),MODE_SPREAD) != OrderOpenPrice())

One more thing, as you stated on the first post, you should be careful when comparing two doubles. But,...

Thank you, unfortunately the spread should not matter since I am selecting a pending order buystop and modifying its open price, I understand it will open at the ask value but it shouldnt matter when modifying a pending orders open price.

I did try your function above just incase I was wrong, since I am still very new at this programing, and it did not fix the problem.

I have 2 print functions in the statement just above the ordermodify function and they print the value of entry1 and then the value of orderopenprice()

This is the log ---------
13:08:20 2008.11.13 12:01 EA GBPUSD,H4: 1.5494 <----entry1 price
13:08:20 2008.11.13 12:01 EA GBPUSD,H4: 1.5494 <----orderopenprice()
13:08:20 2008.11.13 12:01 EA GBPUSD,H4: OrderModify error 1
--------------------

as you can see the open price is exactly equal to the openprice, and it still tried to modify the order even though the statement should not have even executed.
  • #16
  • May 17, 2010 1:34pm May 17, 2010 1:34pm
Quoting bauerjj10
Sorry i can see how my wording in the last post could be confusing.
Yeah, I was basing my reply on what you said in your second post, and that kind threw me. I was stating what seemed obvious, to me or, at least questionable. Having said that, it would probably be best to stand back and let you and one or two of these other folks to take care of it.

Thanks.
  • #17
  • May 17, 2010 2:22pm May 17, 2010 2:22pm
Quoting bauerjj10
Thank you, unfortunately the spread should not matter since I am selecting a pending order buystop and modifying its open price, I understand it will open at the ask value but it shouldnt matter when modifying a pending orders open price.

I did try your function above just incase I was wrong, since I am still very new at this programing, and it did not fix the problem.

I have 2 print functions in the statement just above the ordermodify function and they print the value of entry1 and then the value of orderopenprice()

This is the log ---------
13:08:20...
You're right, I misread the problem as a Buy order instead a Buy Stop order.

To overcome the price comparison problems, you can try the following function:

PHP Code
bool isEqual(double d1, double d2)
  {
    return(MathAbs(NormalizeDouble(d1,Digits)-NormalizeDouble(d2,Digits)) < 0.1*Point);
  }
example:
PHP Code
if(!isEqual(entry1,OrderOpenPrice())
{

}
  • #18
  • May 17, 2010 2:30pm May 17, 2010 2:30pm
Quoting sangmane
after re-read your problems and seeing that you got ordermodify error, there is a possibilities the current price was too close to entry/entry1 value.

so, before send an ordermodify command, do the following checking:

//get StopLevel value:
double StopLevel = MarketInfo(Symbol(),MODE_STOPLEVEL)*Point;
....
//sellstop order
if(entry < Bid-StopLevel)
OrderModify(.....
....
//buystop order
if(entry1 > Ask+StopLevel)
OrderModify(.....

you should also make sure that the current OrderOpenPrice() differ from the new OrderOpenPrice()
if(MathAbs(entry-OrderOpenPrice())...

Sangmane,
Im learning a lot from reading your code logic above. I changed my code to the following and added print functions in the modify order statement so we can see whats happening.

Here is the log for a few orders:

14:25:42 2008.11.13 12:00 EAwork181 GBPUSD,H4: open #1 buy stop 0.03 GBPUSD at 1.5494 sl: 1.4823 tp: 1.6135 ok
14:25:42 2008.11.13 12:00 EAwork181 GBPUSD,H4: BUYSTOP opened : 1.5494
14:25:42 2008.11.13 12:00 EAwork181 GBPUSD,H4: open #2 sell stop 0.03 GBPUSD at 1.4823 sl: 1.5494 tp: 1.4182 ok
14:25:42 2008.11.13 12:00 EAwork181 GBPUSD,H4: SELLSTOP order opened : 1.4823
14:25:43 2008.11.13 12:00 EAwork181 GBPUSD,H4: entry=1.4823
14:25:43 2008.11.13 12:00 EAwork181 GBPUSD,H4: orderopen=1.4823
14:25:43 2008.11.13 12:00 EAwork181 GBPUSD,H4: OrderModify error 1
14:25:43 2008.11.13 12:00 EAwork181 GBPUSD,H4: entry1=1.5494
14:25:43 2008.11.13 12:00 EAwork181 GBPUSD,H4: orderopen=1.5494
14:25:43 2008.11.13 12:00 EAwork181 GBPUSD,H4: OrderModify error 1

As you can see the buystop is the only function that is allowing the 2 equal values to pass through to the statement.

Below is the full code:
Inserted Code
int totalorders = OrdersTotal();
for(int i=totalorders-1;i>=0;i--)
   {
   OrderSelect(i, SELECT_BY_POS);
   
   if (OrderSymbol()==Symbol()&& OrderType()== OP_SELLSTOP && RiskManagement==true)
      {
      if(MathAbs(entry-OrderOpenPrice()) > 0)
         {
         if(entry < Bid-StopLevel)
            {
            Print("entry=",entry);
            Print("orderopen=",OrderOpenPrice()); 
            OrderModify(OrderTicket(),entry,stoploss,takeprofit,0,0);
            }
         }
      }
   if (OrderSymbol()==Symbol()&& OrderType()== OP_SELLSTOP && RiskManagement==false)
      {
      if(MathAbs(entry-OrderOpenPrice()) > 0)
         {
         if(entry < Bid-StopLevel)
            {
            OrderModify(OrderTicket(),entry,entry+(StopLossPips*Point),entry-(TakeProfitPips*Point),0,0);
            }
         }
      }
   if (OrderSymbol()==Symbol()&& OrderType()== OP_BUYSTOP && RiskManagement==true)
      {
      if(MathAbs(entry1-OrderOpenPrice()) > 0)
         {
         if(entry1 > Ask+StopLevel)
            {
            Print("entry1=",entry1);
            Print("orderopen=",OrderOpenPrice());
            OrderModify(OrderTicket(),entry1,stoploss1,takeprofit1,0,0);
            }
         }
      }
   if (OrderSymbol()==Symbol()&& OrderType()== OP_BUYSTOP && RiskManagement==false)
      {
      if(MathAbs(entry1-OrderOpenPrice()) > 0)
         {
         if(entry1 > Ask+StopLevel)
            {
            OrderModify(OrderTicket(),entry1,entry1-(StopLossPips*Point),entry1+(TakeProfitPips*Point),0,0);
            }
         }
      }
  • #19
  • May 17, 2010 2:32pm May 17, 2010 2:32pm
Try placing something like this after orderselect and showing us the results

bool result = NormalizeDouble(entry,4) != OrderOpenPrice();
bool result1 = NormalizeDouble(entry1,4) != OrderOpenPrice())
Print("entry = " + NormalizeDouble(entry,4));
Print("entry1 = " + NormalizeDouble(entry1,4);
Print("OrderOpenPrice = " + OrderOpenPrice());
Print("result = " + result);
Print('result1 = " + result1);
  • #20
  • May 17, 2010 2:56pm May 17, 2010 2:56pm
Hi Kenny,

Below is the log after including that code

PHP Code
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: open #1 buy stop 0.03 GBPUSD at 1.5494 sl: 1.4823 tp: 1.6135 ok
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: BUYSTOP opened : 1.5494
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: open #2 sell stop 0.03 GBPUSD at 1.4823 sl: 1.5494 tp: 1.4182 ok
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: SELLSTOP order opened : 1.4823
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry = 1.48230000
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry1 = 1.54940000
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: OrderOpenPrice = 1.48230000
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: result = 0
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: result1 = 1
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry=1.4823
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: orderopen=1.4823
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: OrderModify error 1
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry = 1.48230000
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry1 = 1.54940000
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: OrderOpenPrice = 1.54940000
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: result = 1
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: result1 = 1
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry1=1.5494
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: orderopen=1.5494
14:51:14 2008.11.13 12:00  EAwork181 GBPUSD,H4: OrderModify error 1
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry = 1.48230000
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry1 = 1.54940000
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: OrderOpenPrice = 1.48230000
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: result = 0
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: result1 = 1
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: entry=1.4823
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: orderopen=1.4823
14:51:15 2008.11.13 12:00  EAwork181 GBPUSD,H4: OrderModify error 1
0 traders viewing now