Gem of an EA needs a slight change | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

FP Markets - Hidden Gem for Traders? 22 replies

Nice EMA Cross Indicator...needs slight work please 7 replies

Central Banks and Big Players: Slight change in code reqd 7 replies

Slight mod needed for session indicator 4 replies

A Gem from Merlin 21 replies

Attachments: Gem of an EA needs a slight change
Exit Attachments

Gem of an EA needs a slight change

  • #21
  • May 12, 2010 5:35am May 12, 2010 5:35am
Quoting hayseed
hey toothman.... it's never a good policy to talk about someone else's code......

if it were me, the int signal() function would be kept and everything else rewritten...... and written in a precise manner.....

//----

in my experience, you should be able to close many trades at the same price in normal markets..... my experience is limited to ibfx...... it's not unusual for me to close 10 trades in a row at the same price ..... and you should be able to close hundreds in a row about as fast as you can count in typical speech.... it's...
35 wins in a row
Dear Hayseed, can you send me your EA's source ?
  • #22
  • May 12, 2010 5:47am May 12, 2010 5:47am
Quoting ecTrade
You might want to try this and see if it works anyway. Basically I wrapped it around all instances where it looks like it's opening new trades.
Okay, I just tried backtesting it but I guess not ...

It opens the first set of trades and closes them out but then it doesn't do anything? Oh well, it's not always easy trying to interpret someone else's code.
  • #23
  • Edited 7:13am May 12, 2010 6:15am | Edited 7:13am
Nevermind ... I just modified it to display the order count, and it by-passed it entirely. He/she has a different way of specifying the symbol and magic number (if that's what they're doing?) and, it will only work when I specify it the same way.

Now, if I set it up the way I normally set it up, it will count the first four orders but, won't reset afterwards ... so, I don't know?
  • #24
  • May 12, 2010 6:39am May 12, 2010 6:39am
All of those trades seem to be closed because the stoploss price was hit..

hey ronald.... that's correct.... a trailing stop was adjusting the original stoploss.... once the market moved against me they closed.... and of course you know this but some might not, a predefined stoploss is no guarentee of a closing price....

What if the EA sent a close order instead? Would the slippage have increased in your case?

in this case it would not have.... as long as the price does not move and lot size is acceptable, the last known price stands.... when closing large numbers of the same pair at the same occurrence in active markets, the closing price should be expected to differ..... sometimes for the worse and sometimes for the better......

//----

As I understood previous attempts at modifying this code, it was supposed to close the largest orders first, the logic being larger orders closed sooner results in a lower overall slippage cost.

that logic is understandable and commonly seen........

my route would differ....

//----

......h
to trade and code, keep both simple... no call to impress....h
  • #25
  • May 12, 2010 6:53am May 12, 2010 6:53am
Quoting sangmane
35 wins in a row
Dear Hayseed, can you send me your EA's source ?
//---

hey sangmane..... then you might trade as bad as me.....

that 36'th trade was likely a whoping looser..........h
to trade and code, keep both simple... no call to impress....h
  • #26
  • May 12, 2010 7:55am May 12, 2010 7:55am
Ok,I think Ec might be right. What I think is happening is when a level 4 trade is closing down, conditions are right for EA to open up a new level 1 trade. The L1 trade is then open while the other trades are being closed and it's getting closed immediately along with the other trades. So we need to adjust code to wait for all open trades to be closed before a new level 1 trade initiates. Any one up for that? thanks
  • #27
  • Edited May 13, 2010 8:37am May 12, 2010 8:44am | Edited May 13, 2010 8:37am
Okay, I think I got it. I moved the counter section down below the trade section but left the Close_All command up above. The counter works now as does the Close_All function, although its not readily discernible (see comments display).

There's also something flaky about the counter. It displays an extra digit when it's not supposed to. This isn't normal. It was counting down as it should, but would go only as low as "1" (with no visible trades). In which case Close_All remains set at "true" (yes I changed this) and it won't open any new trades. So I set it to reset when count is at less than or equal to "1," and it works! ... although I think it's kind of weird. As much as I don't like doing it this way (it's the first time I've seen this happen) it does work.

Oh, I also referenced the symbol and magic number the way I'm accustomed to.

ETA: Fixed flaky counter ... omitted line of code.
Attached File(s)
File Type: mq4 swb grid 4.1.0.3.mq4   13 KB | 454 downloads
  • #28
  • May 12, 2010 10:14am May 12, 2010 10:14am
Quoting ecTrade
Okay, I think I got it. I moved the counter section down below the trade section but left the Close_All command up above. The counter works now as does the Close_All function, although its not readily discernible (see comments display).

There's also something flaky about the counter. It displays an extra digit when it's not supposed to. This isn't normal. It was counting down as it should, but would go only as low as "1." In which case Close_All remains set at "true" (yes I changed this) and it won't open any new trades. So I set it to reset...
Ec,
Thank you so much. I'll give it a try.
  • #29
  • May 12, 2010 10:20am May 12, 2010 10:20am
how about a comment area as part of the EA. it would help to differentiate when running multiple ea's.

Great job on the changes
  • #30
  • May 12, 2010 6:18pm May 12, 2010 6:18pm
Quoting Toothman
Ec,
Thank you so much. I'll give it a try.
It should work as advertised, although it doesn't guarantee it will fix the problem you are asking about. Hopefully it will.
  • #31
  • May 12, 2010 6:20pm May 12, 2010 6:20pm
Quoting Tread
how about a comment area as part of the EA. it would help to differentiate when running multiple ea's.
Such as? ...
  • #32
  • May 13, 2010 8:36am May 13, 2010 8:36am
Quoting ecTrade
There's also something flaky about the counter. It displays an extra digit when it's not supposed to. This isn't normal. It was counting down as it should, but would go only as low as "1" (with no visible trades).
For anyone who is interested, I fixed the counter. I omitted a line of code when I did a copy and paste. I'm surprised it even worked at all, otherwise I probably would have caught it.
Attached File(s)
File Type: mq4 swb grid 4.1.0.3.mq4   13 KB | 311 downloads
  • #33
  • May 15, 2010 1:08am May 15, 2010 1:08am
for anyone interested I added a Hekien Ashi indicator and an option (both are in properties box) to set it in reverse. If you set it to forward (default) it won't work, as the EA is designed to buck the trend, so to speak. If you set it to reverse, it appears to act as a filter or, so it seems. When I first tested it without indicator, with EURUSD from 6-17-09 until today (after start of Euro crash in early December), it crashed in early February. When I tested it with indicator, and set it to reverse, it didn't crash at all (and includes most recent crash). So, it appears to have some effect.

You will need to copy the indicator to indicator folder and compile it, then open EA on chart and set both heiken_ashi and h_a_reverse to "true," and it should work.
Attached File(s)
File Type: mq4 swb grid 4.1.0.4.mq4   14 KB | 423 downloads
File Type: mq4 Heiken_Ashi_Ma_DZ_0.mq4   7 KB | 425 downloads
  • #34
  • May 16, 2010 2:22pm May 16, 2010 2:22pm
Quoting ecTrade
Okay, I think I got it. I moved the counter section down below the trade section but left the Close_All command up above. The counter works now as does the Close_All function, although its not readily discernible (see comments display).

There's also something flaky about the counter. It displays an extra digit when it's not supposed to. This isn't normal. It was counting down as it should, but would go only as low as "1" (with no visible trades). In which case Close_All remains set at "true" (yes I changed this) and it won't open any new trades....
Ec,
Great work. This version http://cdn.forexfactory.com/images/attach/mq4.gif swb grid 4.1.0.3.mq4 closed a level 3 for me last week with no flash trade so this might do the trick. Now if we could get the EA to TP all levels at the same price I think we'd increase our profits. Slippage always seems to take a pip or two from you as trades are shutting down.
  • #35
  • Edited 5:12am May 17, 2010 1:45am | Edited 5:12am
Quoting Toothman
Ec,
Great work. This version http://cdn.forexfactory.com/images/attach/mq4.gif swb grid 4.1.0.3.mq4 closed a level 3 for me last week with no flash trade so this might do the trick. Now if we could get the EA to TP all levels at the same price I think we'd increase our profits. Slippage always seems to take a pip or two from you as trades are shutting down.
Holy shit! I actually got this to work. It looks a little different on the graph though (almost inverted), but it basically does the same thing. I based target on tp_in_money variable, and they may not have. This might explain why it looks different, although I can't say for sure.

Let me know how it works, okay?

Oh, you need to set alt_closeall in properties box to true in order to get it to work.


ETA: Modified to add first_trade factor (adjustable), as first TP value seems too high ...
Attached File(s)
File Type: mq4 swb grid 4.1.0.5.mq4   15 KB | 403 downloads
  • #36
  • May 17, 2010 5:46am May 17, 2010 5:46am
Quoting ecTrade
Holy shit! I actually got this to work. It looks a little different on the graph though (almost inverted), but it basically does the same thing. I based target on tp_in_money variable, and they may not have. This might explain why it looks different, although I can't say for sure.

Let me know how it works, okay?

Oh, you need to set alt_closeall in properties box to true in order to get it to work.


ETA: Modified to add first_trade factor (adjustable), as first TP value seems too high ...
Ec,
Does this close all at the same TP? If it does it should make it safer and more profitable in fast moving markets. Will try it on a demo. Your the wiz.
  • #37
  • May 17, 2010 5:55am May 17, 2010 5:55am
Ec,
Can you explain what the first_ trade variable does? Does it override the tp_in_ money variable?
  • #38
  • May 17, 2010 6:47am May 17, 2010 6:47am
Quoting Toothman
Ec,
Does this close all at the same TP?
Yes.

Quoting Toothman
Ec,
Can you explain what the first_ trade variable does? Does it override the tp_in_ money variable?
Yes, it overrides tp_in_money variable, but only on the first trade. It's also adjustable. For example, I set it to 40 (as default) which is 40% of tp_in_money target. Currently it's set at $5.00 (default) so, 40% of that would be $2.00. Or, if you set it to 100 (100%), the first trade would $5.00. Or, if you set it to 200, the first trade would be $10.00, etc ...

I did this in the event that it may take forever (practically) for the first trade to close, if it doesn't veer in the opposite direction where it is more apt to close. Of course if you'd rather have it set to 100% (as default), the EA can easily be modified.
  • #39
  • May 17, 2010 7:23am May 17, 2010 7:23am
Ec,
I just had a trade with this latest version with tp in money set to $5 alt close all set to true and first trade set to 40. I saw trade go to +$9 so I closed it manually there. So either I'm confused with my settings or EA isn't functioning correctly? Shouldn't it have closed at around $2? 40% of $5?
  • #40
  • May 17, 2010 7:55am May 17, 2010 7:55am
Ec,
I must be slow but if you have a multiple trade and you have the first trade variable set to say 40, won't that first trade stay open even after the other trades have shut down? Don't we want all levels to close at the same time at the tp_in_money amount? That's what I'm after. Price hits your tp_in_money and all trades close immediately at exactly the same price.
0 traders viewing now