Mql4 Coding Help | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

MQL4 Coding and Fractal EA for you 14 replies

Learning MQL4, Coding an EA, Strength Indi, Entry and Exits 7 replies

Problems with coding local vs global variables on mql4 9 replies

MQL4 Language Most Recent Version is it updated beyond the tutorial on the mql4 websi 6 replies

Mql4 Coding Help

  • #1
  • First Post: Jan 29, 2009 9:09am Jan 29, 2009 9:09am
Hi guys

I have a problem with a code.

I would like to know how to perform a routine every time a candle exceed a MM, only 1 time, and the order can not be repeated until next crossing.

Code example:

Inserted Code
int limit=1;
double MMA;
for (int shift=1; shift<=limit; shift++) {

MMA=iMA(NULL,timeFrame,FastEMA,0,MODE_EMA,PRICE_CLOSE,shift);

//---- sell conditions
if (MMA>Ask + 0.0010){ 
SellValue=1;
break;
}
//---- buy conditions
if (MMA<Ask - 0.0010){
        BuyValue=1;
break;
}

}

The code above repeat the order for many times after take profit and before the next line cross.

I want the orders that it can open not exceed 1 order per cross. Or a limit variable (N orders).

So, If somebody could help, I would be grateful.

Thanks in advance.
  • #2
  • Jan 29, 2009 9:22am Jan 29, 2009 9:22am
There are better ways to this, but the easies would be to have a boolean.

In your init() you want TradeOK=True;

Then, once you make a trade you want to use TradeOK=false;

Finally, you need to modify the If statement to if((MMA>Ask + 0.0010) && (TradeOK=True))
  • #3
  • Jan 29, 2009 11:36am Jan 29, 2009 11:36am
Thanks, Milhouse!

I made the changes but still repeating orders every new candle before the next cross.


Another sugestion?

Cheers.
  • #4
  • Jan 29, 2009 12:56pm Jan 29, 2009 12:56pm
Inserted Code
 int limit=1;
double MMA, MMA1;
for (int shift=1; shift<=limit; shift++) {

MMA=iMA(NULL,timeFrame,FastEMA,0,MODE_EMA,PRICE_CLOSE,shift);
MMA1=iMA(NULL,timeFrame,FastEMA,0,MODE_EMA,PRICE_CLOSE,shift+1);

//---- sell conditions
if (MMA>Ask + 0.0010 && MMA1<Close[shift+1]){ 
SellValue=1;
break;
}
//---- buy conditions
if (MMA<Ask - 0.0010 && MMA1>Close[shift+1]){
        BuyValue=1;
break;
}

}

Try this code. You should check whether MMA of previous candle was higher or lower than price. If it is the same as current candle, then no cross happened on current candle.
  • #5
  • Jan 29, 2009 1:26pm Jan 29, 2009 1:26pm
Thanks, quaestus.

The code worked well. In fact the orders are repeated, but only when the trend is on the right side, even before the next intersection. Not yet well understood the logic, but I will do more tests later and post here.

Grateful for the little help!
  • #6
  • Jan 29, 2009 1:33pm Jan 29, 2009 1:33pm
There are few possible reasons why multiple orders are placed. Are orders only repeated on the same candle? Or does your EA also buy and sell on candles after the cross?
  • #7
  • Jan 30, 2009 9:36pm Jan 30, 2009 9:36pm
hello quaestus,

I did some backtests, but unfortunately the expression did not work right. I tried several alternatives.

The EA is based on this Ronald Raygun's generic EA Ma crossover:

http://www.forexfactory.com/showthread.php?t=105913

In this post has a better explanation:

http://www.forexfactory.com/showpost...7&postcount=21
  • #8
  • Jan 31, 2009 4:17am Jan 31, 2009 4:17am
Upload the EA file with the changes that you have done and I will have a look at it
  • #9
  • May 8, 2010 4:08pm May 8, 2010 4:08pm
Can someone let me know how to do the following,

I want to retrieve the value of a 40sma on the close of the 4-00am (UK time) candle and also the same value at the close of the 6-15am candle

can anyone provide the code for this

thank you
  • #10
  • May 9, 2010 7:57pm May 9, 2010 7:57pm
Quoting censura
Can someone let me know how to do the following,

I want to retrieve the value of a 40sma on the close of the 4-00am (UK time) candle and also the same value at the close of the 6-15am candle

can anyone provide the code for this

thank you
you may try this
Inserted Code
 
if (Hour() = 4 && Minute() = Period()) double maval1 = iMA(... parameters ......,1)
if (Hour() = 6 && Minute() = 15+Period()) double maval2 = iMA(... parameters ......,1)
the use of period() depends on the timeframe you're using, the above case is for timeframes below h1
  • #11
  • May 9, 2010 8:04pm May 9, 2010 8:04pm
While the above code may work it's a bit of a kludge.

Try using the iHour and iMinute and specify PERIOD_M1 as the time frame. Read about them in the help file.

Regards

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #12
  • May 9, 2010 8:15pm May 9, 2010 8:15pm
Just use ibarshift...
  • #13
  • Last Post: Jul 9, 2013 8:02am Jul 9, 2013 8:02am
sir
anybody help me how to write a code for weekly and monthly open. In advance thanks.
0 traders viewing now