finnished my first indicator now want to add EA to it. a few questions.

i just finished my first indicator.

which is very, very basic EMA. it uses some ideas from MCAD so it is not worth to use as EA in anyway. however it is for my learning experience

however i want to do the next step. and that is create a EA with the results the indicator gives me.

however i am a bit lost on what i should do. i want to have a clean code.

if i want to transform the indicator into an EA should i use a seperate script and load the indicator in the new script? then use the results of the indicator with Icustom() ?

or should i just use the indicator script and transform it into an EA?

talking about EA.

i have checked some sources on how to add the ordersend() but i see so many different kind of options. my heads spins.

so if possible could you give me advice on how to proceed?

also my indicator starts with #property indicator_separate_window

if i want to add all the code for the EA into same indicator script. should i remove that line?

actually below is the code i want to use to create the EA however i dont have an idea to use a buy and sell option in it

f= fastema
s= slowema

int start()
{
indicator[a] = iCustom(NULL,0,"indicator",f,s,0,a);

if (indicator[a] > indicator[a+1]) then add ordersend(op_buy) here?

else

if indicator[a] > indicator[a+1]) then add ordersend)op_sell) here?

thanks in advance

If possible put your indicator code in the EA. Just start a new EA project and create a function called CheckSignal that returns an integer. Check for a signal using the code you created for the indicator within it and return op_buy or op_sell or if no signal -1.

As for how to use ordersend there's a perfectly good example in the help file so just search for ordersend.

Good luck

Lux

thank you luxinterior for your help. i am also glad you didnt give the answer right away.

however i am trying now for 2 hours to fix the 'else' - unexpected token error.

unfortunate mql4 does not have a debugging mode.

my code at the moment

int OP = -1;
if (indicator[a] > indicator[a+1])OP = OP_BUY;

else

if indicator[a] < indicator[a+1])OP = OP_SELL;

int ticket = OrderSend( Symbol(), OP, lots, Ask, 1000, 0.0, 0.0, "Comment", 0, Green );
if ( ticket == -1 )
Print("OrderSend failed with error #",GetLastError());

could you please give an helping hand and tell where i need to look at.

please dont post the code+fix. just tell me where i should look at. i like to learn

thanks in advance

also i could not find anything in the documentation of meta edittor about ordersend. i tried to find it but no dice.

only 1 comment "unexpected token"?
i had this error usually because i used arithmatic operators (e.g. "=") instead of assignment operators (e.g. "==") or i put the array together with the "[]" while calling a function. check your whole script to see if you've missed or mis-input something.

by the way , Ask price is only for opening long and closing short positions, so you should

OrderSend and other commands
just highlight the keyword and hit F1

thank you both for the help.

i checked out your code lmyyyks and unfortunate i still get the same error

it happens because i add if OP = OP_BUY;

is added behind if (indicator[a] > indicator[a+1])OP = OP_BUY;

i get the else unexpected token error.

however if i remove Op = OP_buy; and keep

indicator[a] < indicator[a+1])OP = OP_SELL; is getting accepted since it is after the else ?

why does this happen?

thanks again for your input much appricated. hopefully in metatrader 5 we get a debugger

if this is the format you've copied from the script but not re-typed
i would say you've missed a left parenthesis
if this is not the case, try removing "else", it won't affect the logic.

T4F - The fix above should work but I would also suggest you get into the habit of using curly braces too.

For example...


It'll make your life easier and as you correctly pointed out MT4 doesn't have a built in debugger so you should try to do as much as possible to maintain clean and manageable code.

Good luck

Lux

first of all thanks for the input again.

progress report = 1 step further + 1 step back

at the bottom my code for my first EA and it worked. however it works with the standard indicator IMA.

however when i try to load my custom ema indicator into the EA, it does not work.

i simply wont get any output at all.

extern int f=6;
extern int s=6;

indicator[a] = iCustom(NULL,0,"indicator",f,s,0,a) ;

if (indicator[a] > indicator[a+1])
{lineup[a] = 1;} need to have buy info here.

else

indicator[a] < indicator[a+1])
{lineup[a] = -1;} need to have sell info here.

so how would i add the code above in my simple EA?

again please only give me hints not the direct code+fix. or if to difficult to give hints. then a partly fix.

thank you again for the info.

your humble student t4m.



//+------------------------------------------------------------------+
//| sample.EA.indicatortest.mq4
//+------------------------------------------------------------------+
extern int TakeProfit = 10;
extern int StopLoss = 10;

int start()
{
double lots, indicatortest, stop, profit, slippage;
indicatortest = iMA(NULL,0,21,0,MODE_EMA,PRICE_WEIGHTED,0);
lots = 0.1;
slippage = 3;

stop = StopLoss*Point;
profit = TakeProfit*Point;

if(Close[0]>indicatortest)
{
OrderSend(Symbol(), OP_BUY, lots, Ask,slippage, Ask-stop, Ask+profit, 0);
}

if(Close[0]<indicatortest)
{
OrderSend(Symbol(), OP_SELL, lots, Bid,slippage, Bid+stop, Bid-profit, 0);
}


return(0);
}
//+-----------------------------END----------------------------------+