Cant take this any more!! (iMaOnArray) | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

how can i do iMAOnArray within MQL5? 1 reply

iMAOnArray, MQL4 --> MQL5 3 replies

iMAOnArray not working on timeframe change: help please 2 replies

iMAonArray question 5 replies

Help - Using iMAOnArray? 1 reply

Cant take this any more!! (iMaOnArray)

  • #1
  • First Post: May 2, 2010 10:08am May 2, 2010 10:08am
Hello everyone! I will go directly to the point:

This is the code:

"
double AUX[22];
double EMASMAANGLE=0;
int j=0;
for(j=0; j<21; j++)
AUX[j] = iCustom(NULL, 0, "SMAAngle", 0, j);

EMASMAANGLE=iMAOnArray(AUX,21,21,0,MODE_EMA,j);

Alert(EMASMAANGLE);
"

Shouldnt that give me an alert with the EMA(21) of the last 21 EMAAngle indicator values?
This returns 0 instead!!

Thankyou!
  • #2
  • May 2, 2010 3:40pm May 2, 2010 3:40pm
When posting problems like this, you should include more detail. I usually ignore incomplete postings like this.

I am guessing that you see a popup alert with a 0 as the angle. If so, it is an easy problem - you need to format the value EMASMANGLE into a string from a double. Use the function DoubleToString() to do this. You will find the details in Help. If I am wrong, you need to provide more detail.
  • #3
  • May 2, 2010 4:21pm May 2, 2010 4:21pm
Also if you're posting code it's better to use the the forums code tags. Makes it easier to read and you're more likely to get responses.

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #4
  • Edited 4:26pm May 2, 2010 4:24pm | Edited 4:26pm
Im sorry, I have spent so many hours trying to fix it, that I assumed that by posting the code anyone would know which the problem was lol

I changed that code to this one:

Inserted Code
double AUX[21];
double EMASMAANGLE=0;
int j=0;
for(j=0; j<21; j++) 
{
AUX[20-j] = iCustom(NULL, 0, "SMAAngle", 0, j);

}

EMASMAANGLE=iMAOnArray(AUX,21,21,0, MODE_EMA,0);

Alert(DoubleToStr(EMASMAANGLE,8));

One of the problems what the one you already taught me how to correct.

Now with the popup alert being correctly shown, I need the value it shows to be the EMA(21) of the values stored in AUX variable.

But the value I get doesnt match the one in the chart, and they should be the same.

I already checked the values stored in AUX with alerts and they are stored correctly, so the fail is in the
Inserted Code
iMAOnArray(AUX,21,21,0, MODE_EMA,0);

By the way I also checked switching the order of AUX data and did neither work.

Just one more thing:
Thanks for the help!
  • #5
  • May 2, 2010 4:40pm May 2, 2010 4:40pm
To correct a false impression that you and many others have, most programmers can't just look at dozens of line of code and figure out what is wrong except when it is glaringly obvious. Even with our own code, it is not posssible and so it becomes a process of elimination.

Again I am guessing. It seems to me that you want to calculate values for the whole array not just the last 21 values. I think the call should be iMAOnArray(AUX,0,21,0, MODE_EMA,j);
  • #6
  • May 2, 2010 5:10pm May 2, 2010 5:10pm
Yeah what I mean is that I had spent so much time on it I couldnt realize what you say

As for what I am trying to get, I will try to describe it so you dont have to guess hehe....


I have an indicator (SMAAngle) which has one numeric value with every bar (its not a continuous line, just 1 value every bar)
Then, over that indicator, I put an EMA with period=21, and shift 0, applied of course to the values of that indicator.

What I want to get is just the latest value of that EMA.



So with the coding:

* The AUX array has the 21 (and only 21) latest values of the SMAAngle indicator
* I checked the values in the array AUX and they store correctly the values of SMAAngle indicator

* I took the
Inserted Code
EMASMAANGLE=iMAOnArray(AUX,21,21,0, MODE_EMA,0);
out of the iteration, because I just want the latest value.

Shouldnt EMASMAANGLE be returning the latest value of the EMA(21) of the SMAAngle indicator?
  • #7
  • May 2, 2010 7:49pm May 2, 2010 7:49pm
If you are only interested in the value for the latest bar, then the code you wrote should work. However I should point out the other values will not be right and I had assumed that was the problem.

I'm not very familar with IMAOnArray() so what I usually do in that situation is find a piece of code that is working and compare it to my code and then try to find the problem through the process of elimination. There are several indicators that come with MT4 such as MACD and ATR that use IMAOnArray(). I would suggest you become familar with them and perhaps you will find the problem.
  • #8
  • May 3, 2010 6:28am May 3, 2010 6:28am
I hope this can provide some help.

PHP Code
//---- buffers
   double AUX[];
   double EMASMAANGLE[];
//------------------------
   for(int j=0; j<21; j++) 
   {
      AUX[j] = iCustom(NULL, 0, "SMAAngle",/*enter custom indicator parameters here if necessary*/, 0, j);
   }
   int counted_bars = IndicatorCounted();
   int limit=Bars-counted_bars;
   for(int i=0; i<limit; i++)
   {
      EMASMAANGLE[i]=iMAOnArray(AUX,Bars,21,0, MODE_EMA,i);
      Alert(DoubleToStr(EMASMAANGLE[i],8));
   }
Free Programmer for Profitable Strategies
  • #9
  • May 3, 2010 11:21am May 3, 2010 11:21am
Ok, I will research on the indicators you suggest CodeMeister.
Unaizams, the code you shared will get a popup with "0" as value.

Thankyou for the help and time, If I get a solution I will post it.
  • #10
  • May 3, 2010 2:48pm May 3, 2010 2:48pm
I remembered something else this morning about iMAOnArray(). It can't be used in an EA. I remember struggling with this for hours - just like you and finally when I was looking for sample code I discovered this discussion thread which confirmed my suspicions. What I ended up doing was using iMAOnArray() in an indicator and retrieving the values by means of iCustom().

Sorry I didn't remember this in my earlier reponses. Don't waste any more time, I doubt if it can be done.

http://forum.mql4.com/9228
  • #11
  • May 3, 2010 3:55pm May 3, 2010 3:55pm
Thankyou so much!!

I think the smartest solution now will be to apply the EMA21 formula to the array I got with the data.
I have been checking but cant find the EMA formula used on metatrader, I used the one provided in the link below:

http://stockcharts.com/school/doku.p...ntial_moving_a

After using that formula, the code I got is this one:

Inserted Code
double AUX1=0;
double EMASMAANGLE=0;
int j=0;


for(j=0; j<21; j++)
{
AUX1=EMASMAANGLE;
EMASMAANGLE=iCustom(NULL, 0, "SMAAngle", 0, j+21)+AUX1;
}
AUX1=EMASMAANGLE;
EMASMAANGLE=AUX1/21;


j=0;
for(j=0; j<21; j++) 
{
AUX1=EMASMAANGLE;
EMASMAANGLE = AUX1+((iCustom(NULL, 0, "SMAAngle", 0, 20 - j)-AUX1))/11;
}

//  EMA(current) = ( (Price(current) - EMA(prev) ) x Multiplier) + EMA(prev)

Alert(DoubleToStr(EMASMAANGLE,8));

It doesnt give me the exact number calculated given by the chart, but I guess its as close as I will get ^_^

Thx again
  • #12
  • May 4, 2010 2:22am May 4, 2010 2:22am
Quoting Armagedoom
Hello everyone! I will go directly to the point:

This is the code:

"
double AUX[22];
double EMASMAANGLE=0;
int j=0;
for(j=0; j<21; j++)
AUX[j] = iCustom( NULL, 0, "SMAAngle", 0, j);

EMASMAANGLE=iMAOnArray(AUX,21,21,0,MODE_EMA,j);

Alert(EMASMAANGLE);
"

Shouldnt that give me an alert with the EMA(21) of the last 21 EMAAngle indicator values?
This returns 0 instead!!

Thankyou!
Hi Armagedoom,
You can use basic ema calculation:
PHP Code
 //Convert Ema Period (21) to Smooth Factor :
  double SF = 2.0/(21+1);
  //Define initial ema value : 
  double EmaSmaAngle = iCustom(NULL,0,"SMAAngle",0,21);
  //Iterate the next ema, start from the oldest data :
  for(j=20; j>=0; j--)
    EmaSmaAngle = EmaSmaAngle + SF*(iCustom(NULL,0,"SMAAngle",0,j)-EmaSmaAngle);
   Alert(EmaSmaAngle);
  • #13
  • May 4, 2010 7:00am May 4, 2010 7:00am
I'm having the same problem right now, seriouly frustrated.
Quoting CodeMeister
I remembered something else this morning about iMAOnArray(). It can't be used in an EA. I remember struggling with this for hours - just like you and finally when I was looking for sample code I discovered this discussion thread which confirmed my suspicions. What I ended up doing was using iMAOnArray() in an indicator and retrieving the values by means of iCustom().

Sorry I didn't remember this in my earlier reponses. Don't waste any more time, I doubt if it can be done.

http://forum.mql4.com/9228
I'm using the iMAOnArray() in my indicator, and it keeps returning 0 and has messed up my whole work.
  • #14
  • Last Post: May 4, 2010 3:29pm May 4, 2010 3:29pm
There are lots of code samples using iMAOnArray() in indicators. Just examine a few and compare them with your code.
0 traders viewing now