Attachments: A Simple London Breakout

A Simple London Breakout

#281
Apr 20, 2010 5:48am Apr 20, 2010 5:48am

maya007
| Joined Jun 2009 | Status: Trader | 138 Posts

Hello,
Steve please look at the void SendSingleTrade, there is a bug in the section "price is out of the box":

Inserted Code

//Sell stop trade
   if (type == OP_SELLSTOP)
   {
      ....
      //Allow for this being a reentry after a retrace
      if [color=Red](bid < highest)[/color]
      {
       .....

The condition should be "(bid < lowest)".

Pavel

#282
Apr 20, 2010 6:11am Apr 20, 2010 6:11am

ironrabbia
| Joined Jul 2009 | Status: Trader | 1 Post

Hello: i am trying to build a very simple ea. It has only a few lines, but i want it to test my strategy. The problem is that it doesn´t works. The ea is the next:

//---- input parameters
extern int barback=7;
extern int hora_de_trade=9;
extern int minuto_de_trade=0;
extern int TP=450;
extern int fin_de_orden=24;
extern int pips_sobre_el_maximo=33;
extern int pips_bajo_el_minimo=12;
extern int ancho_maximo=300;
extern double tamano_de_lote=0.1;

int start()
{
double maximo = iHighest(NULL,0,MODE_HIGH,barback,1) + pips_sobre_el_maximo;
double minimo = iLowest(NULL,0,MODE_LOW,barback,1)- pips_bajo_el_minimo;

if (Hour() == hora_de_trade && Minute() == minuto_de_trade && (maximo - minimo) < ancho_maximo)
{OrderSend(Symbol(),OP_BUYSTOP,tamano_de_lote,maximo,0,minimo,maximo + TP,"amilcar",0,fin_de_orden,Green);
OrderSend(Symbol(),OP_SELLSTOP,tamano_de_lote,minimo,0,maximo,minimo - TP,"amilcar",0,fin_de_orden,Red);
}

//----
return(0);
}
///the end.

Can somebody tell me wich is the problem?

#283
Apr 20, 2010 6:32am Apr 20, 2010 6:32am

squalou
Joined Mar 2010 | Status: Trader | 588 Posts

I just couln't resist to share pending results at that time for today's breakout... (level factors set to entry=0.3;TP=1.3, i.e. the "mild" settings :-)

All pairs i monitored this morning have made 1 trade as of now: (noon GMT)

4 WINs / 1 pending / 0 LOSS !

EU: still pending
GU: +45p
GJ: +53p
EJ: +39p
UJ: +13p
EG: +11p
========
total :+ 161 pips !!!!!!!!!

This all just looks VEEEEEEEEEERY promising...

Great job mer...

Steve, i'll give a try to the bot as well.
Your multipair bots are just awesome!

I'll come back later with my "green box winners" extension to the indicator some time... still got to figure how to code that...

Squalou.

#284
Apr 20, 2010 7:01am Apr 20, 2010 7:01am

MorningMania
| Joined Nov 2009 | Status: Trader | 201 Posts

Quoting SteveHopwood

Disliked

This version has:
[list][*]broker and local time display[*]MaxLossesAllowedPerPair is an input that allows us to limit our losses on individual pairs. The rationale is this: if our trades lose a few times then there must be something going on in the markets that we do not know about, so it is better to step away for a while. There are a couple of things to note:[list][*]setting the input to...

Ignored

The ea in NanningBob 60x90 has an option for a Martingale system. Perhaps you can borrow it. It keeps track of the level you're at (how deep into the martingale) and it has a user defined multiplier for the lotsize, so 1 for same lots all the time, 2 for double at each level, etc.

Another way would be to "read" the lotsize in the current open orders and multiply the largest by 2. Not experienced enough in mql4 to know how to do that though.

#285
Apr 20, 2010 7:11am Apr 20, 2010 7:11am

SteveHopwood
| Commercial User | Joined Apr 2007 | 8,331 Posts

Quoting maya007

Disliked
Hello,
Steve please look at the void SendSingleTrade, there is a bug in the section "price is out of the box":
Inserted Code
//Sell stop trade
   if (type == OP_SELLSTOP)
   {
      ....
      //Allow for this being a reentry after a retrace
      if [color=Red](bid < highest)[/color]
      {
       .....
The condition should be "(bid < lowest)".
Ignored

Nice one again Pavel. Cheers.

Coders need to make this change. Non-coders need to re-download from a few posts ago. I have edited it to include the fix.

#286
Edited 2:44pm Apr 20, 2010 7:26am | Edited 2:44pm

sangmane
Joined Apr 2009 | Status: MT4 Programmer | 758 Posts

I just finished my EA for testing the profitability of this strategy, especially the Martingale aspect.

My Martingale method calculates lot size based on Risk, which is equal to a percentage of Account Balance. When a trade is a loss, instead of double the previous trade's lot, I double the Risk. I use this method because the SL size of this strategy (hence the box size) varies from session to session.

Below is the equity curve for GU M15, from Jan to Dec 2009. I have bad history data in 2010 (lost 3 months data from Jan 2010 to Mar 2010).

I use the default setting, $10.000 account size.

Pls note that Box is drawn based on the highest/lowest price from 03.00GMT to 06.00GMT, while the indicator draw box from 03.00GMT to 06.15GMT.

The EA attached is experimental... It can contain errors...

Edited: formula for risk-based-lot-calc was for 5-digits broker. When used on 4-digits, it gave 10 times than it ought to be. Now it should be normal..

Attached Image (click to enlarge)

Click to Enlarge

Name: slotester.gif
Size: 6 KB

Attached File(s)

Simple Breakout Orig.ex4 10 KB | 815 downloads

#287
Apr 20, 2010 7:37am Apr 20, 2010 7:37am

squalou
Joined Mar 2010 | Status: Trader | 588 Posts

Attached is an updated Indicator with the following extensios:

- added inputs:
- SessionEndTime for future use (the "green box"!)
- EntryFactor (0.3)
- TPFactor (1.3)

- Profit Target and Stops are printed in pips in addition to Price

- It also includes changes from Sangmane V3.1 :-)

Sangmane, can you post the .mq4 of your EA instead of the EX4 ? Thx

Sq.

Attached File(s)

London BreakoutV4.mq4 6 KB | 675 downloads

#288
Edited 8:13am Apr 20, 2010 7:40am | Edited 8:13am

The flame
| Joined Dec 2009 | Status: Pips brewer | 210 Posts

hi steve, i may be wrong but there's something not working properly with the re-entry stuff:
on eurusd for example the prices just cross down the long entry point, this should generate an input for a new buy at pipsdistance etc, the ea instead places a pending sell at pips distance!

then how can i switch off the re-entry part? should i take a look at the code?
thanks.....

ps i really appreciate all of your ea's....i'm one of the first readers of the boj thread even if as i'm not particularly able in coding i never achieved the vouch to write there!

EDIT: ok we almost wrote together! u already fixed this!!

#289
Apr 20, 2010 7:54am Apr 20, 2010 7:54am

enewbold
| Joined Apr 2009 | Status: Trader | 276 Posts

Quoting SteveHopwood

Disliked

Nice one again Pavel. Cheers.

Coders need to make this change. Non-coders need to re-download from a few posts ago. I have edited it to include the fix.

Ignored

Done. Thank you.

Ed

#290
Apr 20, 2010 8:16am Apr 20, 2010 8:16am

DXTrade
| Joined Jul 2007 | Status: Take Five | 755 Posts

Quoting The flame

Disliked

hi steve, i may be wrong but there's something not working properly with the re-entry stuff:
on eurusd for example the prices just cross down the long entry point, this should generate an input for a new buy at pipsdistance etc, the ea instead places a pending sell at pips distance!

then how can i switch off the re-entry part? should i take a look at the code?
thanks.....

ps i really appreciate all of your ea's....i'm one of the first readers of the boj thread even if as i'm not particularly able in coding i never achieved the vouch to...

Ignored

He can not place a buy stop as he is still in the buy trade on EU.
At least here...

"The only successful substitute for brains is silence."

#291
Apr 20, 2010 8:19am Apr 20, 2010 8:19am

The flame
| Joined Dec 2009 | Status: Pips brewer | 210 Posts

Quoting DXTrade

Disliked

He can not place a buy stop as he is still in the buy trade on EU.
At least here...

Ignored

ya but that was because i switched it on late to tes the re entry stuff!
anyway it seems somone else spotted the error and steve already fixed it!

#292
Edited 8:50am Apr 20, 2010 8:39am | Edited 8:50am

SteveHopwood
| Commercial User | Joined Apr 2007 | 8,331 Posts

Quoting The flame

Disliked

hi steve, i may be wrong but there's something not working properly with the re-entry stuff:
on eurusd for example the prices just cross down the long entry point, this should generate an input for a new buy at pipsdistance etc, the ea instead places a pending sell at pips distance!

then how can i switch off the re-entry part? should i take a look at the code?
thanks.....

ps i really appreciate all of your ea's....i'm one of the first readers of the boj thread even if as i'm not particularly able in coding i never achieved the vouch to write...

Ignored

You can post in the BOJ and BS threads now.

Those re-entries are incorrect, so turn them off for now - the new input is AllowReEntries.

There is a flaw in the logic. Damned if I can work out what it is.

Attached File(s)

Steve Hopwood's London session breakout multi-pair.mq4 25 KB | 588 downloads

#293
Apr 20, 2010 8:49am Apr 20, 2010 8:49am

DXTrade
| Joined Jul 2007 | Status: Take Five | 755 Posts

Working fine here.
EU buy reached SL and a new buy stop was placed immediately.

"The only successful substitute for brains is silence."

#294
Apr 20, 2010 9:02am Apr 20, 2010 9:02am

kijkij
| Commercial User | Joined May 2008 | 211 Posts

What is your net profit in pips for whole year test? Can you EA mq4 file?

Quoting sangmane

Disliked

I just finished my EA for testing the profitability of this strategy, especially the Martingale aspect.

My Martingale method calculates lot size based on Risk, which is equal to a percentage of Account Balance. When a trade is a loss, instead of double the previous trade's lot, I double the Risk. I use this method because the SL size of this strategy (hence the box size) is vary from session to session.

Below is the equity curve for GU M15, from Jan to Dec 2009. I have bad history data in 2010 (lost 3 months data from Jan 2010 to Mar 2010).

I...

Ignored

#295
Apr 20, 2010 9:06am Apr 20, 2010 9:06am

Elovv
| Joined Aug 2007 | Status: Trader | 747 Posts

Quoting sangmane

Disliked

I just finished my EA for testing the profitability of this strategy, especially the Martingale aspect.

My Martingale method calculates lot size based on Risk, which is equal to a percentage of Account Balance. When a trade is a loss, instead of double the previous trade's lot, I double the Risk. I use this method because the SL size of this strategy (hence the box size) is vary from session to session.

Below is the equity curve for GU M15, from Jan to Dec 2009. I have bad history data in 2010 (lost 3 months data from Jan 2010 to Mar 2010).

I...

Ignored

Hi sangmane

Promissing result

Does Your EA works with both 4 and 5 digit criminals?

Cheers
Elovv

#296
Edited 10:55am Apr 20, 2010 10:20am | Edited 10:55am

sangmane
Joined Apr 2009 | Status: MT4 Programmer | 758 Posts

Hi kijkij,

Your username is unique. It forms triangle on keyboard layout

@Squalo:
As I've stated in my post, I code that EA in order to find out what parameter (TimeStart/End, Entry/TP/SL scale factor, MaxBoxSize, etc) for each pair that will give good result. I haven't posted the mq4 file so that we can focus more on finding the good parameter for the strategy and share it to the forum. I'm affraid if I post the mq4, the discussion focus will be shifted to the code, not the strategy itself.

Besides, there is nothing so special in the code. It's the strategy parameters and improvements that important. Once the strategy is considered to be reasonable profit and stable, there are many programmers that can make EA

@Ellov, I don't understand what do you mean by digit criminals. Is it something related to digit manipulation? EA accept input in pips for Min/MaxBoxSize in pips, regardless your broker's digit.

If there are parameters that you don't understand, kindly ask it

Cheers

#297
Apr 20, 2010 12:49pm Apr 20, 2010 12:49pm

xmph
| Joined Jan 2009 | Status: Trader | 139 Posts

Quoting sangmane

Disliked

I just finished my EA for testing the profitability of this strategy, especially the Martingale aspect.

My Martingale method calculates lot size based on Risk, which is equal to a percentage of Account Balance. When a trade is a loss, instead of double the previous trade's lot, I double the Risk. I use this method because the SL size of this strategy (hence the box size) varies from session to session.

Below is the equity curve for GU M15, from Jan to Dec 2009. I have bad history data in 2010 (lost 3 months data from Jan 2010 to Mar 2010).

I...

Ignored

It would be interested to see how your martingale and the rest of your money management did from Jan to March1st of 2010 as I found it to be hard on the account based the original martingale proposed; the reason is martingaling without taking into account the amount lost and simply multiplying the lot size may not be sufficient to recoup if the successive wins are small (because of small raging boxes) ..... that's what happen in Feb-March2010 on GU if I remember well (that's what caught my attention earlier ... it may be ok for the account if trading multiple pairs though. I did not check that)

Now I understand this is not the point of the thread thus if you want to share thoughts on money management to back-up this nice strategy, please PS me.

PS: for re-entry, use a MTF trend line not to re-enter small ranging conditions and get into multiple losses ... just a thought ;-)

XmPh.

#298
Apr 20, 2010 1:44pm Apr 20, 2010 1:44pm

tazmaan
| Joined Apr 2008 | Status: Trader | 1,114 Posts

Quoting sangmane

Disliked

I just finished my EA for testing the profitability of this strategy, especially the Martingale aspect.

The EA attached is experimental... It can contain errors...

Ignored

Nice job on this, and some nice results I am seeing as well.
I have backtested it on dukascopy tick data from 4/12/09 til 4/17/10 using default. I did have to eliminate the two weeks around xmas/new year, but final result from 10k starting balance and default ea settings is 31.2k ending balance.
Appears DD ran about 38%

Good work!

#299
Apr 20, 2010 1:47pm Apr 20, 2010 1:47pm

squalou
Joined Mar 2010 | Status: Trader | 588 Posts

Sangmane,
no problem, i was curious about the martingale code.
"criminals" or "crims" is Steve's word for "brokers"

#300
Apr 20, 2010 2:35pm Apr 20, 2010 2:35pm

sangmane
Joined Apr 2009 | Status: MT4 Programmer | 758 Posts

Squalou,

The basic code of Martingale:
1. find the number of the last number of successive losses, lets say N
2. calculate lot size based on N and the starting lot:
lot = MathPow(Multiplier,N)*initlot
Classic Martingale uses Multiplier = 2.

simple routine for calculate the last number of successive losses:

PHP Code

int LossesCount()
  {
    int Cnt=0;
    for(int i = OrdersHistoryTotal()-1; i>=0; i--)
    {
      OrderSelect(i,SELECT_BY_POS,MODE_HISTORY);
      if(OrderProfit()>0) break;
      Cnt++;
    }
    return(Cnt);
  }

then,

PHP Code

lot = MathPow(Multiplier,LossesCount())*initlot;

Now, I feel like we are in Programming Discussion Folder

Trading Systems
/
A Simple London Breakout
Reply to Thread
- 1 13 14 Page 15 16 17 53
- 1 14 Page 15 16 53

6 traders viewing now

Options

Similar Threads

A Simple London Breakout