Need Help With My Code | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help with 10M chart - got it already but need some help! 1 reply

Help - any tools that can easily convert MQL4 code to Easy Language code? 7 replies

Need help with Code 1 reply

Need help in money management code 1 reply

T3 Cross Ea - Need A Little Code Help 0 replies

Need Help With My Code

  • #1
  • First Post: Apr 7, 2010 11:53am Apr 7, 2010 11:53am
Hello everyone,

I'm new to this community, and Forex trading. Hope I will learn a lot here!

Let's get on with my first question. From the start I want to learn to program my own expert advisors to help me with certain tasks.

Just for exercise purposes I coded a quick EA that notifies you when three different moving averages cross at the same point (their values are the same).

here is the code:

Inserted Code
double sma =iMA(NULL,0,14,0,MODE_SMA,PRICE_CLOSE,0);
double ema = iMA(NULL,0,14,0,MODE_EMA,PRICE_CLOSE,0);
double lwma = iMA(NULL,0,14,0,MODE_LWMA,PRICE_CLOSE,0);



if ((sma == ema) || (sma == lwma) || (ema == lwma) )
{
PlaySound("Alarm.wav");
Alert("Crossed MA!");
}

The problem is IT DOES NOT WORK. I tried just about everything for some reason it does not want to work.

Can anybody please show me what I am doing wrong?

Thanks!
  • #2
  • Apr 7, 2010 12:08pm Apr 7, 2010 12:08pm
There is very rarely a bar where multiple moving averages are exactly the same.

Instead, you should check for the cross of multiple moving averages.

so....

if(FastMACurrent > SlowMACurrent && FastMAPrevious < SlowMAPrevious) Print("Cross Up")
  • #3
  • Apr 7, 2010 12:31pm Apr 7, 2010 12:31pm
Quoting Ronald Raygun
There is very rarely a bar where multiple moving averages are exactly the same.

Instead, you should check for the cross of multiple moving averages.

so....

if(FastMACurrent > SlowMACurrent && FastMAPrevious < SlowMAPrevious) Print("Cross Up")
Mmm... ok I see what you mean. Maybe if I put a range in? For instance if the values of the two or three moving averages are within 0.5% of each other, then the alarm should go off?

Maybe you will understand better if I show you what I want to do. Look at the pic below, where the arrow is, where the three lines are the same, that is when I want to be alerted. How can I achieve this?

http://www.online-forex-trading.co.za/MA.jpg

Thanks!
  • #4
  • Apr 7, 2010 1:04pm Apr 7, 2010 1:04pm
Then compare each permutation of MAs

MA1Current
MA1Previous
MA2Current
MA2Previous
MA3Current
MA3Previous

if(MA1Current > MA2Current && MA1Current > MA3Current && MA2Current > MA3Current && MA1Previous < MA2Previous && MA1Previous < MA3Previous && MA2Previous < Ma3Previous) Print("Cross Up")
  • #5
  • Apr 7, 2010 1:17pm Apr 7, 2010 1:17pm
PHP Code
double sma =iMA(NULL,0,14,0,MODE_SMA,PRICE_CLOSE,0);
double ema = iMA(NULL,0,14,0,MODE_EMA,PRICE_CLOSE,0);
double lwma = iMA(NULL,0,14,0,MODE_LWMA,PRICE_CLOSE,0);

double range = 0.0001;
if (MathMax(sma,MathMax(ema,lwma)) - 
MathMin(sma,MathMin(ema,lwma)) < range)
{
PlaySound("Alarm.wav");
Alert("Crossed MA!");
}
  • #6
  • Apr 7, 2010 1:25pm Apr 7, 2010 1:25pm
While I'm at it I have one more question:

When I'm alerted about the three MA's that are the same, I don't know on which opened graph or window/tab they are. How can I get the timeframe and currency pair of the chart?

I searched book.mql4.com but cannot seem to find the certain function

Thanks!
  • #7
  • Apr 7, 2010 2:01pm Apr 7, 2010 2:01pm
Symbol() => Currency Pair
Period() => Timeframe in minutes (1440 for D1)
  • #8
  • Apr 7, 2010 2:16pm Apr 7, 2010 2:16pm
Quoting Saidar
Mmm... ok I see what you mean. Maybe if I put a range in? For instance if the values of the two or three moving averages are within 0.5% of each other, then the alarm should go off?

Maybe you will understand better if I show you what I want to do. Look at the pic below, where the arrow is, where the three lines are the same, that is when I want to be alerted. How can I achieve this?

http://www.online-forex-trading.co.za/MA.jpg

Thanks!
Hi:
I'm still kinda new to forex so I'm just making an observation. The MA's are drawn as a line so it looks like a smooth, continuous line, but it's really not. It really draws point to point and fills in between them, based on the time frame you are using. So while it looks like there is a point where all three prices are the same, if you check your MA values at each point, you'll likely find they cross without ever being exactly equal. If that's the case, then your condition never triggers. Might be better to use a cross as someone else suggested.

http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/ is pretty good for generating code based on your ideas, then you could simply change it from placing an order to sending you an email alert or playing a sound file or something.

Hope that helps,
John
  • #9
  • Last Post: Apr 7, 2010 3:49pm Apr 7, 2010 3:49pm
Quoting pipppindog
Hi:
I'm still kinda new to forex so I'm just making an observation. The MA's are drawn as a line so it looks like a smooth, continuous line, but it's really not. It really draws point to point and fills in between them, based on the time frame you are using. So while it looks like there is a point where all three prices are the same, if you check your MA values at each point, you'll likely find they cross without ever being exactly equal. If that's the case, then your condition never triggers. Might be better to use a cross as someone else suggested.

http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/...
Awesome thanks John, that web application looks a bit confusing but will spend some time to figure it out.

Thanks!
0 traders viewing now