FRAMAOsma.....

I've modified FRAMA Ehlers in FRAMAOsma but I've two problems....

1) the values of osma compared to the values of frama and signal are too small and I can't see any of the 3 values.

2) when I change time-frame or re-start metatrader program, the history of OSMA histogram disappears.

the code is right...

.......where do I wrong?!?

Thanks for yours helping!
:-)

//
//+------------------------------------------------------------------+
// FRAMAOsma
//
// Description: Fractal Adaptive Moving Average - by John Ehlers
// Version 1.1 7/17/2006
//
// Heavily modified and reprogrammed by Matt Kennel ([email protected])
//
// Notes:
// October 2005 Issue - "FRAMA - Fractal Adaptive Moving Average"
// Length will be forced to be an even number. Odd numbers will be bumped up to the
// next even number.
// Formula Parameters: Defaults:
// RPeriod 16

#property copyright "Copyright 2005, MrPip " // and mbkennel
#property link "http://www.metaquotes.net/"

//---- indicator settings
#property indicator_separate_window
#property indicator_buffers 4
#property indicator_color1 Red
#property indicator_color2 Lime
#property indicator_color3 Red
#property indicator_color4 Lime

//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
double ExtMapBuffer3[];
double ExtMapBuffer4[];

extern int RPeriod = 16;
extern double multiplier = 4.6;
extern double signal_multiplier = 2.5;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{


//---- 1 additional buffers are used for counting.
IndicatorBuffers(4);

//---- drawing settings
SetIndexBuffer(0,ExtMapBuffer1);
SetIndexStyle(0,DRAW_LINE,STYLE_SOLID,2);
SetIndexShift(0,0);
IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS));
SetIndexBuffer(1,ExtMapBuffer2);
SetIndexStyle(1,DRAW_LINE,STYLE_SOLID,2);
SetIndexShift(1,0);
SetIndexBuffer(2,ExtMapBuffer3);
SetIndexStyle (2,DRAW_HISTOGRAM);
SetIndexShift(2,0);
SetIndexBuffer(3,ExtMapBuffer4);
SetIndexStyle (3,DRAW_HISTOGRAM);
SetIndexShift(3,0);

//---- initialization done
return(0);
}

int start()
{
int i,k,counted_bars=IndicatorCounted();

if (Bars < RPeriod) return(0);
Comment("Bars : ",Bars);
int maxshift = Bars-RPeriod-1;
int limit= maxshift - counted_bars;
if (limit < 1) limit = 1;

int N = MathFloor(RPeriod/2)*2; // Force N to even number
double frama = Close[maxshift];
double signal = frama;

ExtMapBuffer1[maxshift] = Close[maxshift];
ExtMapBuffer2[maxshift] = Close[maxshift];

for(int shift = limit-1; shift >= 0; shift--) {
double dimension_estimate = DEst(shift,N);

double alpha = MathExp(-multiplier*(dimension_estimate-1.0));
double alphas = MathExp(-signal_multiplier*(dimension_estimate-1.0));

if (alpha > 1.0) alpha = 1.0;
if (alpha < 0.01) alpha = 0.01;
if (alphas > 1.0) alphas = 1.0;
if (alphas < 0.01) alphas = 0.01;

frama = alpha* Close[shift] + (1.0-alpha)* ExtMapBuffer1[shift+1];
signal = alphas * frama + (1.0 - alphas)* ExtMapBuffer2[shift+1];

ExtMapBuffer1[shift] = frama;
ExtMapBuffer2[shift] = signal;
ExtMapBuffer3[shift] = EMPTY_VALUE;
ExtMapBuffer4[shift] = EMPTY_VALUE;

double FRAMAOsma = (ExtMapBuffer1[shift]-ExtMapBuffer2[shift]);

if(FRAMAOsma > 0)
ExtMapBuffer3[i] = FRAMAOsma;
else ExtMapBuffer4[i] = FRAMAOsma;
}
return(0);
}


double DEst(int shift, int n) {
//
double R1, R2, R3;
int n2 = n/2;

R3 = Range(shift,n) / n;
R1 = Range(shift,n2) / n2;
R2 = Range(shift+n2,n2) / n2;

return( (MathLog(R1+R2)-MathLog(R3) )* 1.442695 ) ; // log_2(e) = 1.442694




}

double Range(int i, int k)
{
return( High[Highest(NULL,0,MODE_HIGH,k,i)] - Low[Lowest(NULL,0,MODE_LOW,k,i)] );
}

Because you calculate Osma = Frama - Signal, of course Osma will always be very small compared to Frama and Signal. Frama will have values of 1.5xxx (for GU) and Osma will be a few pips.

It's like you compare the value of MACD(12,26,9) with Ema12 and Ema26

Well....this is for the first problem...but for the Osma history that disappears?!

Could you help me to code it, again...in a correct mode?

Regards..

Sorry....but...I must calculate OSMA = FRAMA - Signal. And It's correct that FRAMA have values of 1,5xxx (for cable) and OSMA only few pips.

I must have a voice that ask = "show only OSMA"

Because if I make disappear the FRAMA - Signal from chart in the separate window....I've solved the problem!!!!!

But how?!?!?!?

Then I study how disappears the history when I change time-frame or restart metatrader platform..........


Thanks.

Hi and Happy Easter....

Could you add 2 buffers on FRAMA_MBK ehlers (that I copy below)....DOWN ARROW WHEN SIGNAL CROSS DOWN THE FRAMA and UP ARROW WHEN SIGNAL CROSS UP THE FRAMA?


Regards....


FRAMA_MBK ehlers:

//---- indicator settings
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Red
#property indicator_color2 Blue

//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];

extern int RPeriod = 16;
extern double multiplier = 4.6;
extern double signal_multiplier = 2.5;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{


//---- 1 additional buffers are used for counting.
IndicatorBuffers(2);

//---- drawing settings
SetIndexBuffer(0,ExtMapBuffer1);
SetIndexStyle(0,DRAW_LINE,STYLE_SOLID,2);
SetIndexShift(0,0);
IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS));
SetIndexBuffer(1,ExtMapBuffer2);
SetIndexStyle(1,DRAW_LINE,STYLE_SOLID,2);
SetIndexShift(1,0);


//---- initialization done
return(0);
}

int start()
{
int i,k,counted_bars=IndicatorCounted();

if (Bars < RPeriod) return(0);
Comment("Bars : ",Bars);
int maxshift = Bars-RPeriod-1;
int limit= maxshift - counted_bars;
if (limit < 1) limit = 1;

int N = MathFloor(RPeriod/2)*2; // Force N to even number
double frama = Close[maxshift];
double signal = frama;

ExtMapBuffer1[maxshift] = Close[maxshift];
ExtMapBuffer2[maxshift] = Close[maxshift];

for(int shift = limit-1; shift >= 0; shift--) {
double dimension_estimate = DEst(shift,N);

double alpha = MathExp(-multiplier*(dimension_estimate-1.0));
double alphas = MathExp(-signal_multiplier*(dimension_estimate-1.0));

if (alpha > 1.0) alpha = 1.0;
if (alpha < 0.01) alpha = 0.01;
if (alphas > 1.0) alphas = 1.0;
if (alphas < 0.01) alphas = 0.01;

frama = alpha* Close[shift] + (1.0-alpha)* ExtMapBuffer1[shift+1];
signal = alphas * frama + (1.0 - alphas)* ExtMapBuffer2[shift+1];

ExtMapBuffer1[shift] = frama;
ExtMapBuffer2[shift] = signal;


}
return(0);
}


double DEst(int shift, int n) {
//
double R1, R2, R3;
int n2 = n/2;

R3 = Range(shift,n) / n;
R1 = Range(shift,n2) / n2;
R2 = Range(shift+n2,n2) / n2;

return( (MathLog(R1+R2)-MathLog(R3) )* 1.618 ) ; // log_2(e) = 1.618




}

double Range(int i, int k) {

return( High[Highest(NULL,0,MODE_HIGH,k,i)] - Low[Lowest(NULL,0,MODE_LOW,k,i)] );
}
Forward Message

you make a typo here :
should be :
I don't see the point to display both frama/signal and their difference (what you call "Osma") in one window. You should only put 2 or more buffer that has the same range.

I've made some change to your indicator, displaying only "Osma"

Well done! :-)

It's ok.....


Could you help me again, building FRAMA_MBK with signal on chart window (DOWN ARROW WHEN SIGNAL CROSS DOWN THE FRAMA and UP ARROW WHEN SIGNAL CROSS UP THE FRAMA? (Then we have found a very good indicator for GU H1.....)


Regards....


FRAMA_MBK ehlers:

//---- indicator settings
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Red
#property indicator_color2 Blue

//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];

extern int RPeriod = 16;
extern double multiplier = 4.6;
extern double signal_multiplier = 2.5;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{


//---- 1 additional buffers are used for counting.
IndicatorBuffers(2);

//---- drawing settings
SetIndexBuffer(0,ExtMapBuffer1);
SetIndexStyle(0,DRAW_LINE,STYLE_SOL ID,2);
SetIndexShift(0,0);
IndicatorDigits(MarketInfo(Symbol() ,MODE_DIGITS));
SetIndexBuffer(1,ExtMapBuffer2);
SetIndexStyle(1,DRAW_LINE,STYLE_SOL ID,2);
SetIndexShift(1,0);


//---- initialization done
return(0);
}

int start()
{
int i,k,counted_bars=IndicatorCounted() ;

if (Bars < RPeriod) return(0);
Comment("Bars : ",Bars);
int maxshift = Bars-RPeriod-1;
int limit= maxshift - counted_bars;
if (limit < 1) limit = 1;

int N = MathFloor(RPeriod/2)*2; // Force N to even number
double frama = Close[maxshift];
double signal = frama;

ExtMapBuffer1[maxshift] = Close[maxshift];
ExtMapBuffer2[maxshift] = Close[maxshift];

for(int shift = limit-1; shift >= 0; shift--) {
double dimension_estimate = DEst(shift,N);

double alpha = MathExp(-multiplier*(dimension_estimate-1.0));
double alphas = MathExp(-signal_multiplier*(dimension_estima te-1.0));

if (alpha > 1.0) alpha = 1.0;
if (alpha < 0.01) alpha = 0.01;
if (alphas > 1.0) alphas = 1.0;
if (alphas < 0.01) alphas = 0.01;

frama = alpha* Close[shift] + (1.0-alpha)* ExtMapBuffer1[shift+1];
signal = alphas * frama + (1.0 - alphas)* ExtMapBuffer2[shift+1];

ExtMapBuffer1[shift] = frama;
ExtMapBuffer2[shift] = signal;


}
return(0);
}


double DEst(int shift, int n) {
//
double R1, R2, R3;
int n2 = n/2;

R3 = Range(shift,n) / n;
R1 = Range(shift,n2) / n2;
R2 = Range(shift+n2,n2) / n2;

return( (MathLog(R1+R2)-MathLog(R3) )* 1.618 ) ; // log_2(e) = 1.618




}

double Range(int i, int k) {

return( High[Highest(NULL,0,MODE_HIGH,k,i)] - Low[Lowest(NULL,0,MODE_LOW,k,i)] );
}

here it is

What do you think about it?

P.S. FRAMAOSma and FRAMAArrow are different here:

FRAMAOsma: return( (MathLog(R1+R2)-MathLog(R3) )* 1.442695 ) ; // log_2(e) = 1.442694

FRAMAArrow: return( (MathLog(R1+R2)-MathLog(R3) )* 1.618 ) ; // log_2(e) = 1.618


;-)

your first post use 1.4.., and the 4th post use 1.618. you can change it to what you prefer to

Yes, I've seen the difference.....I thought you haven't.....

Many, many thanks for your work!!!


..............regards..................

Hi, sangmane...

This is the code of Ichi_OsMA_ but I've the same problem of FRAMAOsMA....I'm not be able to insert OsMA code (Blue for positive OsMA and Red for negative OsMA)......could you help me?

Regards...

==============================================================

#property indicator_separate_window

#property indicator_buffers 2

#property indicator_color1 Maroon
#property indicator_color2 Green

extern int Tenkan=9;
extern int Kijun=26;
extern int Senkou=52;




double ExtMapBuffer2[];
double ExtMapBuffer3[];

//+------

int init()
{




SetIndexBuffer (0,ExtMapBuffer2);
SetIndexStyle (0,DRAW_LINE);
SetIndexDrawBegin (0,Senkou);

SetIndexBuffer (1,ExtMapBuffer3);
SetIndexStyle (1,DRAW_LINE);
SetIndexDrawBegin (1,Senkou);



SetIndexLabel(0,"Tenkan");
SetIndexLabel(1,"PriceChk");



IndicatorShortName("Ichi OsMA TC ("+Tenkan+","+Kijun+","+Senkou+") ");

return(0);
}

//+----------

int start()
{
int i,limit,counted_bars=IndicatorCounted();

if(counted_bars<0) return(-1);
if(counted_bars>0) counted_bars--;

limit=Bars-counted_bars;


for (i=limit; i>=0; i--)
{


ExtMapBuffer2[i] = iIchimoku(NULL, 0, Tenkan, Kijun, Senkou, MODE_TENKANSEN, i)-
iIchimoku(NULL, 0, Tenkan, Kijun, Senkou, MODE_SENKOUSPANB, i-Kijun);

ExtMapBuffer3[i] = iIchimoku(NULL, 0, Tenkan, Kijun, Senkou, MODE_CHINKOUSPAN, i+Kijun)-
iIchimoku(NULL, 0, Tenkan, Kijun, Senkou, MODE_SENKOUSPANB, i-Kijun);

}



return(0);
}
//+-----------

hi toro,

if you still can't solve the problem, post your indicator file (mq4) so that it is easy to debug

Well....here it is!

your indi display correctly. what do you mean by osma code?

I don't display the OsMA on Ichi Chart like your "FRAMAOsMA"...

See picture

toro, i suggest you read MQL book http://www.mql4.com/files/MQl4BookEnglish.chm. check the file below

Yes....I need to read again MQL book....

But....thanks for your help!