BuyStop SellStop Order error, please help! | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Fdax: 1 buystop and 1 sellstop per day 16 replies

BuyStop/SellStop pause 3 replies

can anybody help me with a problem of Buystop order? 1 reply

S.O.S: Problem with Buystop/sellstop 3 replies

EA to MODIFY BUYSTOP AND SELLSTOP ? HELP! 1 reply

BuyStop SellStop Order error, please help!

  • #1
  • First Post: Edited 7:12pm Mar 21, 2010 6:52pm | Edited 7:12pm
I'm making an EA that makes pending orders for breakout strategies. However during backtesting orders couldn't be sent. It kept displaying the following 3 errors:
"OrderSend error 130"
"OrderSend error 4107" but I'd already allowed dll imports
and
"invalid takeprofit for OrderSend Function"
I've tested and checked it many times, still couldn't manage to fix it.

I am using MT4 from GoMarkets which does not set limits on placing buystop, sellstop, stoploss and takeprofit

Could anyone please help me?

PHP Code
int CurrentTime = Hour()*100 + Minute();
double high = High[iHighest(0,0,MODE_HIGH,8,1)];
double low = Low[iLowest(0,0,MODE_LOW,8,1)];
if (CurrentTime >= start || CurrentTime < end)
  {
  if(GateB==0)
    {
    Buy=OrderSend(Symbol( ) ,OP_BUYSTOP,Lots,high,Slip,low,high+Point*TakeProfit,"",0,0,Blue);
    GateB=1;
    }
  }
One strange thing was that I'd tried to print the values of "high" and "low" and the outcome were both 5-digit while the mt4 itself is a 6-digit one. I don't know whether this has anything to deal with the errors.
  • #2
  • Mar 21, 2010 7:45pm Mar 21, 2010 7:45pm
Error 130 can be caused by the SL/TP being too close to the Bid/Ask or the number isn't a proper price - precisely 4 or 5 digits. You think that it isn't the first reason, so you need to ensure that the price is sent properly and the way to do this is with NormalizeDouble(price, Digits).

4107 is similar but it applies to the Price parameter. It also needs to be normalized.

I really don't understand the statement about your broker not having restrictions on how close the TP, SL are. I think the restrictions are in place but they aren't explicit. It would be reckless for the broker to allow everybody to change them to anything they want. You can test this in demo by seeing how close you get. My guess is that it will be somewhere around 2-3 times the spread. If I am right, the solution to your errors is place market orders when the desired SL, TP is too close.
  • #3
  • Mar 21, 2010 9:14pm Mar 21, 2010 9:14pm
I've tried using the normalizedouble function, still the returned values were 4-digit (like 1.xxx00).

As for the minimum distance for points for parameters like s/l, t/p, etc. there shouldn't be any problem, because I've made pending orders, both manually and using EA, of t/p 15 points and they worked.
So I think the problem would mostly probably be due to returning the highest and lowest values.
  • #4
  • Mar 21, 2010 9:49pm Mar 21, 2010 9:49pm
Quoting lmyyyks
One strange thing was that I'd tried to print the values of "high" and "low" and the outcome were both 5-digit while the mt4 itself is a 6-digit one. I don't know whether this has anything to deal with the errors.
it is either 4 or 5, not 5 or 6. the digits behind the decimal point are counted.

Is it possible that you are backtesting with downloaded 5 digit data while your broker only is 4 digit?

do the following:

for all prices given to the OrderSend function use NormalizeDouble(price, Digits). For convenience just make a wrapper function OrderSendN() that has the exact same parameters as OrderSend() and internally does the normalizing before it calls the original OrderSend().

Then in your EA replace all calls to OrderSend() with calls to OrderSendN().

Something like this would be a good start:
Inserted Code
int orderSendN(
   string symbol, 
   int cmd, 
   double volume, 
   double price, 
   int slippage, 
   double stoploss,
   double takeprofit,
   string comment="",
   int magic=0,
   datetime expiration=0,
   color arrow_color=CLR_NONE
){
   int ticket;
   Print("orderSendN(" 
      + symbol + "," 
      + cmd + "," 
      + volume + "," 
      + price + "," 
      + slippage + "," 
      + stoploss + ","
      + takeprofit + ","
      + comment + ","
      + magic + ","
      + expiration + ","
      + arrow_color + ")");
      
   ticket = OrderSend(
            symbol,
            cmd,
            volume,
            NormalizeDouble(price, MarketInfo(symbol, MODE_DIGITS)), 
            slippage,
            NormalizeDouble(stoploss, MarketInfo(symbol, MODE_DIGITS)),
            NormalizeDouble(takeprofit, MarketInfo(symbol, MODE_DIGITS)),
            comment,
            magic,
            expiration,
            arrow_color
   );
   return(ticket);
}
  • #5
  • Mar 22, 2010 10:19am Mar 22, 2010 10:19am
thanks7bit, though your script didn't help.
But I guess I've figured out the problem, my script has no problem, but it seemed that errors will occur for SendOrder() if i use more than three or more levels of "if()".
i.e.
PHP Code
if()
  {
  if()
    {
    if()
      {
      SendOrder();}
    }
  }
Very strange.

One more strange thing is that my mt4 is 5-digited, and the history data downloaded are also 5-digited, but the data calculated is always 4-digited.
  • #6
  • Mar 22, 2010 10:43pm Mar 22, 2010 10:43pm
Quoting lmyyyks
if i use more than three or more levels of "if()"
this is not the reason.

There must be an error in your calculations or the program logic. Keep debugging until you find it. Print out every variable at every step and also put messages like Print("inside the second if") Print("inside the order function"), everywhere, even where you don't expect the error to be (thats where it usually hides). This will help you to trace the whole program flow and see where it does something other than what you expected. You will then soon find the error.
  • #7
  • Edited 11:34pm Mar 22, 2010 11:32pm | Edited 11:34pm
Quoting 7bit
this is not the reason.

There must be an error in your calculations or the program logic. Keep debugging until you find it. Print out every variable at every step and also put messages like Print("inside the second if") Print("inside the order function"), everywhere, even where you don't expect the error to be (thats where it usually hides). This will help you to trace the whole program flow and see where it does something other than what you expected. You will then soon find the error.
I know it sounds weird, but the only difference was that I put a if (x == 0) condition for the script, then it couldn't send any order but only showed those errors.
where x is a boolean variable
  • #8
  • Mar 23, 2010 7:12am Mar 23, 2010 7:12am
Quoting lmyyyks
I know it sounds weird, but the only difference was that I put a if (x == 0) condition for the script, then it couldn't send any order but only showed those errors.
where x is a boolean variable
then x has not the value false. Simply Print(x) before the if() and you will see.

And with with boolean values you should use one of the following if constructs (the 3rd and the 4th are shorthands for the first two)

if (x == true)
if (x == false)
if (x)
if (!x)

and not compare it to a number.
  • #9
  • Last Post: Mar 23, 2010 7:39pm Mar 23, 2010 7:39pm
Quoting 7bit
then x has not the value false. Simply Print(x) before the if() and you will see.

And with with boolean values you should use one of the following if constructs (the 3rd and the 4th are shorthands for the first two)

if (x == true)
if (x == false)
if (x)
if (!x)

and not compare it to a number.
Thanks, because I didn't realized that before that number's couldn't be used, because it's acceptable to use numbers to defined boolean variables. I'll try it out.

However, I did have tried using x as an integer ("if( x == 2){}) and still error came out and no orders were made.
0 traders viewing now