Horizontal line name | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Horizontal line alert function 14 replies

MT4 horizontal line base on price value indicator 17 replies

Trendline or Horizontal line order outside of the Line 20 replies

Horizontal Line Drawing 3 replies

HELP! Simple Indicator: Place horizontal line on hi and lo of prev. day 11 replies

Attachments: Horizontal line name
Exit Attachments

Horizontal line name

  • #1
  • First Post: Mar 11, 2010 7:14pm Mar 11, 2010 7:14pm
I am using the following code to draw a horzontal line when certain conditions are met.

ObjectCreate("linename", OBJ_HLINE, 0, Time[0], l_close_88, 0, 0);


The problem i am having is that the indi will only draw the line the first time the condition is met. After this it does not draw the line even if the condition is met. I think this is because the name is fixed.

How to program this so that the name can be unique everytime?
bull in a china shop
  • #2
  • Mar 11, 2010 7:37pm Mar 11, 2010 7:37pm
ObjectCreate("linename"+TimeCurrent(), OBJ_HLINE, 0, Time[0], l_close_88, 0, 0);
  • #3
  • Mar 12, 2010 3:01am Mar 12, 2010 3:01am
Thanks Sangmane.
bull in a china shop
  • #4
  • Mar 12, 2010 4:15am Mar 12, 2010 4:15am
So i have the code as follows:

if (l_close_88 < l_open_96) {
ld_104 = (l_open_96 - l_close_88) / Point;
if (ld_104 > GapSize) ObjectCreate("high"+TimeCurrent (), OBJ_HLINE, 0, Time[0], l_close_88, 0, 0);


The idea is that if their is a gap between the opening price of the current candle and the closing price of the last candle, then draw a horizontal line at the closing price of the last candle.


The indi is drawing a horizontal line. It is near, but does not match the closing price of the last candle.

For every tick price move on the new candle, the indi draws a new horizontal line, until that bar has closed. so instead of having 1 line, it draws several objects.

Is there a way of forcing it to draw the object only once, and then wait for the next bar to form before allowing it to draw again. or have it analyse the last bar against the one before that (ie instead of the current bar and last bar).
bull in a china shop
  • #5
  • Mar 12, 2010 9:31am Mar 12, 2010 9:31am
PHP Code
static datetime NewTime;
if(NewTime!=Time[0])
{
  NewTime = Time[0];
  if (l_close_88 < l_open_96) {
  ld_104 = (l_open_96 - l_close_88) / Point;
  if (ld_104 > GapSize) ObjectCreate("high"+TimeCurrent (), OBJ_HLINE, 0, Time[0], l_close_88, 0, 0);
}
  • #6
  • Mar 12, 2010 10:24am Mar 12, 2010 10:24am
i have tried the changes, but no object is being drawn???

sorry sangmane, its my first time trying to mod an indi.

anyway, heres the full code. some of it may be left over from the orignal which i have attached.


PHP Code
 #property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 DodgerBlue
#property indicator_color2 Red


extern int DisplayDistance = 15;
extern int GapSize = 20;

static datetime NewTime;

int init() {
   
   return (0);
}

int deinit() {
   return (0);
}

int start() {
   double l_close_88;
   double l_open_96;
   double ld_104;
   double ld_112;
   int li_76 = IndicatorCounted();
   if (li_76 < 0) return (-1);
   if (li_76 > 0) li_76--;
   int li_0 = Bars - li_76;
   int li_unused_80 = 0;
   int li_unused_84 = 0;
   for (int l_index_4 = 0; l_index_4 <= li_0; l_index_4++) {
      l_close_88 = Close[l_index_4 + 1];
      l_open_96 = Open[l_index_4];
      ld_104 = 0;
      ld_112 = 0;



if(NewTime!=Time[0])
{
  NewTime = Time[0];

      if (l_close_88 < l_open_96) {
         ld_104 = (l_open_96 - l_close_88) / Point;
         if (ld_104 > GapSize) ObjectCreate("high"+TimeCurrent (), OBJ_HLINE, 0, Time[0], l_close_88, 0, 0);
      }



      if (l_close_88 > l_open_96) {
         ld_112 = (l_close_88 - l_open_96) / Point;
         if (ld_112 > GapSize) ObjectCreate("low"+TimeCurrent (), OBJ_HLINE, 0, Time[0], l_close_88, 0, 0);
 
 
      }}
   }
   return (0);
}
Attached File(s)
File Type: mq4 gspot finder.mq4   1 KB | 435 downloads
bull in a china shop
  • #7
  • Edited 11:41am Mar 12, 2010 11:36am | Edited 11:41am
i see u r using decompiled indicator. pls find my "code from scratch" indicator below. the file name should be read "gapSpot"...
Attached Image (click to enlarge)
Click to Enlarge Name: gspot.gif Size: 10 KB
Attached File(s)
File Type: mq4 gSpot.mq4   2 KB | 1,077 downloads
  • #8
  • Mar 12, 2010 11:45am Mar 12, 2010 11:45am
Thank you Sangmane.
bull in a china shop
  • #9
  • Last Post: Mar 16, 2010 7:34pm Mar 16, 2010 7:34pm
Sangmane, could you add a box alert to your code. Thanks in advance.
bull in a china shop
0 traders viewing now