OrderModify error 1 HELP PLEASE | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

Need Help with Ordermodify Error 1 5 replies

Why ordermodify error 1? 9 replies

OrderModify() problem (NOT error code 1) 3 replies

OrderModify error 1 ?? 0 replies

OrderModify error 1 HELP PLEASE

  • #1
  • First Post: Mar 4, 2010 12:56pm Mar 4, 2010 12:56pm
Hello ,

i need help i realy dont know what i fucked with code buy EA give me all the times ERROR on Modify !

The code :

PHP Code
 for (i=0;i<=OrdersTotal();i++)
      {
         OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
         
         if (OrderSymbol()==Symbol() && OrderType()<=OP_SELL)
            {  
               
               if (OrderType()==OP_BUY)
                  {
                       diff=(Bid-OrderOpenPrice())/Point;
                        if (diff>=270 && OrderStopLoss()>=0)
                           {  
                            OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice(),OrderTakeProfit(),0,GreenYellow);
                           } 
                  }
                  if (OrderType()==OP_SELL)
                  {  
                     
                     diff=(OrderOpenPrice()-Ask)/Point;
                     
                        if (diff>=270 && OrderStopLoss()>=0)
                           {  
                            OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice(),OrderTakeProfit(),0,GreenYellow);
                                    
                                 
                                                     
                                     
                           } 
                      }
                      }     
                  }
  • #2
  • Mar 4, 2010 1:10pm Mar 4, 2010 1:10pm
If unchanged values are passed as the function parameters, the error 1 (ERR_NO_RESULT) will be generated.

Is something changing whenever you modify the order?
  • #3
  • Mar 4, 2010 2:02pm Mar 4, 2010 2:02pm
before call ordermodify to modify stoploss, check the following condition:
for buy order
1. new sl should be lower than Bid-StopLevel
2. absolute difference between old sl and new sl should be greater than StopLevel

for sell order
1. new sl should be higher than Ask+StopLevel
2. absolute difference between old sl and new sl should be greater than StopLevel

double StopLevel = MarketInfo(Symbol(),MODE_STOPLEVEL)*Point;

in your case, OrderOpenPrice() is the new SL (you move SL to BE):
PHP Code
for (i=0;i<=OrdersTotal();i++)
      {
         OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
         
         if (OrderSymbol()==Symbol() && OrderType()<=OP_SELL)
            {  
               
               if (OrderType()==OP_BUY)
                  {
                       diff=(Bid-OrderOpenPrice())/Point;
                        if (diff>=270 && OrderOpenPrice()>Bid-StopLevel && MathAbs(OrderOpenPrice()-OrderStopLoss())>StopLevel)
                           {  
                            OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice(),OrderTakeProfit(),0,GreenYellow);
                           } 
                  }
                  if (OrderType()==OP_SELL)
                  {  
                     
                     diff=(OrderOpenPrice()-Ask)/Point;
                     
                        if (diff>=270 && OrderStopLoss()>=0 && OrderOpenPrice()<Ask+StopLevel && MathAbs(OrderOpenPrice()-OrderStopLoss())>StopLevel)
                           {  
                            OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice(),OrderTakeProfit(),0,GreenYellow);
                                    
                                 
                                                     
                                     
                           } 
                      }
                      }     
                  }
maybe point number 1 isn't necessary as you've had (Bid-OrderOpenPrice())/Point>270, it is there just to be safe
  • #4
  • Mar 5, 2010 2:39am Mar 5, 2010 2:39am
hello ,

thanks for help .. but if i past your code intro my EA .. the ea dont change no orders !

When i past my code :
Its only modify 1-2orders from 5 for all athers i get 2010.03.05 09:37:27 2010.03.04 15:04 0000 GBPJPY,H1: OrderModify error 1

Please help

Thanks
  • #5
  • Mar 5, 2010 2:50am Mar 5, 2010 2:50am
Quoting llUkc
Hello ,

i need help i realy dont know what i fucked with code buy EA give me all the times ERROR on Modify !

The code :

[php]
for (i=0;i<=OrdersTotal();i++)...
As Ronald Raygan pointed out correctly , you have to check if new Stoploss to be changed by OrderModify is different than previous one otherwise an error 1 is triggered.
So your code should be changed as follow to avoid that nasty error :

PHP Code
 for (i=0;i<=OrdersTotal();i++)
      {
         OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
         
         if (OrderSymbol()==Symbol() && OrderType()<=OP_SELL)
            {  
               
               if (OrderType()==OP_BUY)
                  {
                       diff=(Bid-OrderOpenPrice())/Point;
                        if (diff>=270 && OrderStopLoss()>=0 && OrderStopLoss() != OrderOpenPrice())
                           {  
                            OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice(),OrderTakeProfit(),0,GreenYellow);
                           } 
                  }
                  if (OrderType()==OP_SELL)
                  {  
                     
                     diff=(OrderOpenPrice()-Ask)/Point;
                     
                        if (diff>=270 && OrderStopLoss()>=0 && OrderStopLoss() != OrderOpenPrice())
                           {  
                            OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice(),OrderTakeProfit(),0,GreenYellow);                        
                           } 
                      }
                      }     
                  }
Cheers,
Skyline
  • #6
  • Last Post: Mar 5, 2010 3:25am Mar 5, 2010 3:25am
sorry, i make some typo on the code.
Quote
for buy order
1. new sl should be lower than Bid-StopLevel
according to point 1, the code for BUY should be:
if (diff>=270 && OrderOpenPrice()<Bid-StopLevel && MathAbs(OrderOpenPrice()-OrderStopLoss())>StopLevel)

and for sell order,
if (diff>=270 && OrderStopLoss()>=0 && OrderOpenPrice()>Ask+StopLevel && MathAbs(OrderOpenPrice()-OrderStopLoss())>StopLevel)
0 traders viewing now