EA help small problem | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Small account - small leverage (30:1) 0 replies

Small bells, small whistles. 2 replies

Small time relative newbie taking small steps 177 replies

Reality check - do small FX accounts inevitably stay small? 14 replies

problem, problem, is it MT4 platform or EA, Please help................ 1 reply

EA help small problem

  • #1
  • First Post: Mar 3, 2010 9:00pm Mar 3, 2010 9:00pm
Hi there ! I have a small problem with an EA I am writing by the orders not being put in at all ... This is the code :

string TI;

iCustom(NULL, 0, "MEGATREND PROBABILITY METER II",13,6,0) ;

TI = ObjectDescription("trend_comment_");


All of the above returns the correct value that I want as either "SHORT" or "LONG"

Now if I write

if (TI == "SHORT")
OrderSend(Symbol(), OP_SELL,Lots,Bid,1,0,0,0,0,0,Red)

or

if (TI == "LONG")
OrderSend(Symbol(), OP_BUY,Lots,Bid,1,0,0,0,0,0,Green);

Now the TI value does get returned saying "LONG" or "SHORT" but no order is put in my metatrader ... any Ideas what I might be doing wrong?

Is it maybe the wrong values I am putting in the OrderSend function...?

Thanks a lot..!
  • #2
  • Mar 4, 2010 4:36am Mar 4, 2010 4:36am
For starters, Sell is ask and buy is bid.

-Your slippage is also quite small, it's possible the trade window passes too quickly
-One of your parameters needs to be a string value.

OrderSend( string symbol, int cmd, double volume, double price, int slippage, double stoploss, double takeprofit, string comment=NULL, int magic=0, datetime expiration=0, color arrow_color=CLR_NONE)
  • #3
  • Mar 4, 2010 6:09am Mar 4, 2010 6:09am
hey xl8er..... it's clear to see your going to keep your foot on the excelerator till this job is done.....

your ordersend lines are correct except for the buy must be at Ask, comments can be a 0.....

//----

ferrufx mentioned selling out, guess megatrendfx made him an offer he could not refuse..... unless they rewrote his work, which is very doubtful, you might have to recode yours....


//----

the code below places trades accorrding to ferrufx's original work probability number..... the indicator must be on the chart..... and i'm guessing megatrend's version is identical, if so it should also work....

keep the pedal to the metal......h


Inserted Code
 
 
 
//+------------------------------------------------------------------+
//|                                                  probability.mq4 |
//|                                                            ....h |
//|                                                 hayseedville.com |
//+------------------------------------------------------------------+
#property copyright "....h"
#property link      "hayseedville.com"
   extern int    trigger           =     70;
   extern double ProfitTarget      =  100.0;    
   extern double Stoploss          =  100.0;    
   extern double Lots              =   0.01;
   extern double TotalPipsTarget   =    500;
   extern int    Slippage          =      3;
   extern int    MagicNumber       = 220000;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
 
 
   string value     = ObjectDescription("prop_value");
 
   double probability = StrToDouble(StringSubstr(value,0,StringLen(value)-1));  
 
 
   string direction = ObjectDescription("trend_comment_");
 
   int buy   = StringFind(direction,"LONG",0);
   int sell  = StringFind(direction,"SHORT",0);
 
   if(OrdersTotal() == 0)
   { 
   if(probability > trigger && buy  != -1)
   {
   OrderSend(Symbol(),OP_BUY,Lots,Ask,3,Ask-Stoploss*Point,Ask+ProfitTarget*Point,0,MagicNumber,0,CLR_NONE);
   }
 
   if(probability > trigger && sell != -1)
   {
   OrderSend(Symbol(),OP_SELL,Lots,Bid,3,Bid+Stoploss*Point,Bid-ProfitTarget*Point,0,MagicNumber,0,CLR_NONE);
   }
 
   }
 
 
 //if(TotalPips() > TotalPipsTarget) {CloseAllThisSymbol(); CloseAllThisSymbol(); CloseAllThisSymbol(); Print("TotalPips Target Hit Closing All");}
 
 
 
 
 
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
to trade and code, keep both simple... no call to impress....h
  • #4
  • Last Post: Edited 9:10am Mar 4, 2010 9:03am | Edited 9:10am
Hey Sorry Guys ha ha my bad I copied the wrong stuff over to the forum yes I saw ha ha ....

Yes I'm really pushing this project keen to get it done soon soon , Ive been trading this same system for a year now and It has got me such excellent results so I decided Id go the automated systematic way and take out all emotion ....

but yes If anyone is keen on the development of this EA let me know as my programming knowledge sucks ha ha but should be able to work something out...!

Ive already got the layout of the EA , and the strategy Ive been using up till now so only thing is to get it in code ha ha ... Missions !

thanks so much for the help I really appreciate it more that anything...!

Enjoy the day...


Cool website btw hayseed ....!
0 traders viewing now