New Idea for Sinewave Support & Resistance Indy!

Hey guys, had an idea about adding some programming to this Sinewave indy. What I would like to accomplish is to have text printed saying "PullBack"along side the lines if (the newest sinewave support level greater than previous support level in an uptrend . As soon as the newest support comes in lower than previous support than I want to print "END". Just the opposite in a downtrend.

The pic below illustrates the idea. Same idea can be found at http://emini-watch.com/category/hilbert-sine-wave

I think that is the same way he is doing it with the version on the emini site.

Actually, not sure if that is the way he has programmed it or not, anyone got any ideas about how he is coming to the conclusion of when to print a pullback or end of trend signal?

Now I know how it is being plotted. If we get a break of say a resistance level, then it is considered a breakout into a trend. The next signal would be a pullback when we get out first support level after the breakout. Then we get an "End" signal when the next resistance level is formed.

He says on website usually good for a reversal. Looking for high volume churn bars or climax bars or low volume in these areas help to identify if price is going to reverse or not.

Know just need to figure out how to write this into the above sinewave indicator.

Like i have mentioned in previous threads, my programming skills are not like some of the other more experienced programmers here at FF but I will try to implement this idea into the code. Just may take some time to figure out how to put it in there.

Here is another pick of the idea.

Hey guys, here is the code that draws the lines on the chart. You need both indicators below for it to work. Just want to add the code to the SineSupportMod.mq4 that will print a "pullback" or "end" when the conditions mentioned in the previous post are met. Any ideas that can make this easy to code.

Here is the code for it

//+------------------------------------------------------------------+
//| SineSupport.mq4 |
//| Copyright 2008, Craig Dargan |
//| |
//+------------------------------------------------------------------+
#property copyright "Copyright 2008, Craig Dargan"
#property link ""

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 White
#property indicator_color2 Crimson
#property indicator_width1 2
#property indicator_width2 2
//---- input parameters
extern double alpha=0.07;
//---- buffers
double resistance[];
double support[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0,DRAW_LINE,1);
//SetIndexArrow(0,250);
SetIndexBuffer(0,resistance);
SetIndexEmptyValue(0,0.0);
SetIndexStyle(1,DRAW_LINE,1);
//SetIndexArrow(1,250);
SetIndexBuffer(1,support);
SetIndexEmptyValue(1,0.0);
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();
//----
if (counted_bars<0) return(-1);
if (counted_bars>0) counted_bars--;

int limit = Bars-counted_bars;

for (int i=limit;i>=0;i--)
{
double sine=iCustom(Symbol(),0,"Sinewave2",alpha,0,i);
double lead=iCustom(Symbol(),0,"Sinewave2",alpha,1,i);
double sinelast=iCustom(Symbol(),0,"Sinewave2",alpha,0,i+1);
double leadlast=iCustom(Symbol(),0,"Sinewave2",alpha,1,i+1);

if (leadlast>sinelast && lead<sine)
{
resistance[i]=iHigh(Symbol(),0,i);
support[i]=NULL;

}
else
{
if (leadlast<sinelast && lead>sine)
{
resistance[i]=NULL;
support[i]=iLow(Symbol(),0,i);
}
else
{
resistance[i]=resistance[i+1];
support[i]=support[i+1];
}
}
}

//----
return(0);
}
//+------------------------------------------------------------------+

Hi Scot,
I am only getting 2straight line on my chart. What is wrong?

Hey 4xtrend, if you are using the last 2 indies posted, you need both in your indicators folder.

If using the first one posted, you only need that one in your indicators folder.

Well, here is what I have so far. Got the code to print the PB(pullback) on the support line when price breaks resistance, but when I try to do the same code for the break of support it prints "PB" on every resistance line. Can't figure out what the hell is going on there.

Any suggestions?

What the F#@$#%#@ is up with this code. I can get it to print "PB" on support lines, but using same code to print "PB" for resistance line will print it on every single resistance line.

There is something here that I am not seeing?

This is the code so far.


//+------------------------------------------------------------------+
//| Sinewave with Support & Resitance.mq4 |
//| |
//| Sinewave |
//| |
//| Algorithm taken from book |
//| "Cybernetics Analysis for Stock and Futures" |
//| by John F. Ehlers |
//| |
//| [email protected] |
//| http://www.mqlsoft.com/ |
//| - adapted by Gerald Binon 17/05/2009 |
//| - changed by Igorad, www.forex-tsd.com 19/05/2009 |
//+------------------------------------------------------------------+
#property copyright "Coded by Witold Wozniak"
#property link "www.mqlsoft.com"

#property indicator_separate_window
#property indicator_buffers 3
#property indicator_color1 Red
#property indicator_color2 Blue
#property indicator_color3 Yellow

#property indicator_minimum -1
#property indicator_maximum 1
#property indicator_level1 0

double Sine[];
double LeadSine[];
double Cycle[];
double Smooth[];

double Resistance[];
double Support[];
double trend[];

extern double Alpha = 0.07;
extern bool DrawPriceTrendLines = true;
int buffers = 0;
int drawBegin = 0;

double tempReal, rad2Deg, deg2Rad, label;
int ilow, ihigh;
datetime sTime, rTime;




int init() {
drawBegin = 8;
initBuffer(Sine, "Sine", DRAW_LINE);
initBuffer(LeadSine, "Lead", DRAW_LINE);
initBuffer(Cycle);
initBuffer(Smooth);
initBuffer(Resistance); // "ResisT",DRAW_ARROW, STYLE_DASHDOT,1);
initBuffer(Support);
initBuffer(trend);

IndicatorBuffers(buffers);
IndicatorShortName("Sinewave with S&R[" + DoubleToStr(Alpha, 2) + "]");
tempReal = MathArctan(1.0);
rad2Deg = 45.0 / tempReal;
deg2Rad = 1.0 / rad2Deg;

return (0);
}


int deinit()
{
for(int i = ObjectsTotal() - 1; i >= 0; i--)
{
string label = ObjectName(i);
if(StringSubstr(label, 0, 18) != "Support Resistance")
continue;
ObjectDelete(label);
}
for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText = ObjectName(i);
if(StringSubstr(DrawText, 0, 2) != "PB")
continue;
ObjectDelete(DrawText);
}
/* for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText1 = ObjectName(i);
if(StringSubstr(DrawText1, 0, 2) != "End")
continue;
ObjectDelete(DrawText1);
}*/
return(0);
}


int start() {
if (Bars <= drawBegin) return (0);
int countedBars = IndicatorCounted(), currents;
if (countedBars < 0) return (-1);
if (countedBars > 0) countedBars--;
int s, limit = Bars - countedBars - 1, Flagup,Flagdn;
currents=s;
for (s = limit; s >= 0; s--) {
Smooth[s] = (P(s) + 2.0 * P(s + 1) + 2.0 * P(s + 2) + P(s + 3)) / 6.0;
Cycle[s] = (1.0 - 0.5 * Alpha) * (1.0 - 0.5 * Alpha) * (Smooth[s] - 2.0 * Smooth[s + 1] + Smooth[s + 2])
+ 2.0 * (1.0 - Alpha) * Cycle[s + 1]
- (1.0 - Alpha) * (1.0 - Alpha) * Cycle[s + 2];
double period = iCustom(0, 0, "CyclePeriod", Alpha, 0, s);
int DCPeriod = MathFloor(period);
double RealPart = 0.0;
double ImagPart = 0.0;
for (int count = 0; count < DCPeriod; count++) {
RealPart += MathSin(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
ImagPart += MathCos(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
}
double DCPhase;
if (MathAbs(ImagPart) > 0.0000001) {
DCPhase = rad2Deg * MathArctan(RealPart / ImagPart);
} else if (MathAbs(ImagPart) <= 0.0000001) {
if (RealPart >= 0.0) {
DCPhase = 90.0;
} else {
DCPhase = -90.0;
}
}
DCPhase += 90.0;
if (ImagPart < 0) {
DCPhase += 180.0;
}
if (DCPhase > 315.0) {
DCPhase -= 360.0;
}
Sine[s] = MathSin(DCPhase * deg2Rad);
LeadSine[s] = MathSin((DCPhase + 45.0) * deg2Rad);
if (DCPhase == 180 && LeadSine[s + 1] > 0) {
LeadSine[s] = MathSin(45 * deg2Rad);
}
if (DCPhase == 0 && LeadSine[s + 1] < 0) {
LeadSine[s] = MathSin(225 * deg2Rad);
}


//Attemp to draw a resistance support line at cross over

if (DrawPriceTrendLines == true)
{
trend[s] = trend[s+1];
if (LeadSine[s] > Sine[s] && LeadSine[s+1] < Sine[s+1]) trend[s] = 1;
if (LeadSine[s] < Sine[s] && LeadSine[s+1] > Sine[s+1]) trend[s] =-1;

if(Close[s]>Resistance[s+1] && trend[s]>0){ //print PB for support

Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
DrawText(sTime, Time[s+1], Support[s], Support[s], "PB",0);
}

if(trend[s]>0)
{
Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
}

///////////////////////////////////////////////////////////////////////////////////////

if(Close[s]<Support[s+1] && trend[s]<0){ //print PB for resistance

Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}

DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
DrawText(rTime, Time[s+1], Resistance[s], Resistance[s], "PB",0);
}

if(trend[s]<0)
{
Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}
DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
}
}


}



return (0);
}

double P(int index) {
return ((High[index] + Low[index]) / 2.0);
}

void initBuffer(double array[], string label = "", int type = DRAW_NONE, int arrow = 0, int style = EMPTY, int width = EMPTY, color clr = CLR_NONE) {
SetIndexBuffer(buffers, array);
SetIndexLabel(buffers, label);
SetIndexEmptyValue(buffers, EMPTY_VALUE);
SetIndexDrawBegin(buffers, drawBegin);
SetIndexShift(buffers, 0);
SetIndexStyle(buffers, type, style, width);
SetIndexArrow(buffers, arrow);
buffers++;
}


void DrawPriceTrendLines(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string label = "Support Resistance" + DoubleToStr(x1, 0);
ObjectDelete(label);
ObjectCreate(label, OBJ_TREND, 0, x1, y1, x2, y2, 0, 0);
ObjectSet(label, OBJPROP_RAY, 0);
ObjectSet(label, OBJPROP_COLOR, lineColor);
ObjectSet(label, OBJPROP_STYLE, style);
ObjectSet(label, OBJPROP_WIDTH, 3);
}

void DrawText(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText = "PB" + DoubleToStr(x1, 0);
ObjectDelete(DrawText);
ObjectCreate(DrawText, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText, "PB", 10, "Comic Sans MS Bold", White);
}

/*void DrawText1(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText1 = "End" + DoubleToStr(x1, 0);
ObjectDelete(DrawText1);
ObjectCreate(DrawText1, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText1, "End", 12, "Comic Sans MS", White);
}*/

What a nightmare this is becoming, can already tell this will be a week long process trying to figure this out.

Ok, here is what I have now, got both support and resistance lines to print "PB" when condition is met after a break of support or resistance.

BUT........ when i switch time frames it labels all the support and resistance lines with "PB". I then have to compile code in MetaEditor while still loaded on my chart again to make it go back to label them properly. don't know what's going on there.

Next thing after I figure that out I need to put the "End of trend" text on the support or resistance line immediately after any "PB" sign. Yaaaaaaaaaaa!

Anyone want to contribute to the cause?

Here is the code as of now and pic.

#property indicator_separate_window
#property indicator_buffers 3
#property indicator_color1 Red
#property indicator_color2 Blue
#property indicator_color3 Yellow

#property indicator_minimum -1
#property indicator_maximum 1
#property indicator_level1 0

double Sine[];
double LeadSine[];
double Cycle[];
double Smooth[];

double Resistance[];
double Support[];
double trend[];

extern double Alpha = 0.07;
extern bool DrawPriceTrendLines = true;
int buffers = 0;
int drawBegin = 0;

double tempReal, rad2Deg, deg2Rad, label;
int ilow, ihigh;
datetime sTime, rTime;




int init() {
drawBegin = 8;
initBuffer(Sine, "Sine", DRAW_LINE);
initBuffer(LeadSine, "Lead", DRAW_LINE);
initBuffer(Cycle);
initBuffer(Smooth);
initBuffer(Resistance); // "ResisT",DRAW_ARROW, STYLE_DASHDOT,1);
initBuffer(Support);
initBuffer(trend);

IndicatorBuffers(buffers);
IndicatorShortName("Sinewave with S&R[" + DoubleToStr(Alpha, 2) + "]");
tempReal = MathArctan(1.0);
rad2Deg = 45.0 / tempReal;
deg2Rad = 1.0 / rad2Deg;

return (0);
}


int deinit()
{
for(int i = ObjectsTotal() - 1; i >= 0; i--)
{
string label = ObjectName(i);
if(StringSubstr(label, 0, 18) != "Support Resistance")
continue;
ObjectDelete(label);
}
for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText = ObjectName(i);
if(StringSubstr(DrawText, 0, 2) != "PB")
continue;
ObjectDelete(DrawText);
}
//ObjectDelete("PB");
/* for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText1 = ObjectName(i);
if(StringSubstr(DrawText1, 0, 2) != "End")
continue;
ObjectDelete(DrawText1);
}*/
return(0);
}


int start() {
if (Bars <= drawBegin) return (0);
int countedBars = IndicatorCounted(), currents;
if (countedBars < 0) return (-1);
if (countedBars > 0) countedBars--;
int s, limit = Bars - countedBars - 1, Flagup,Flagdn;
currents=s;
for (s = limit; s >= 0; s--) {
Smooth[s] = (P(s) + 2.0 * P(s + 1) + 2.0 * P(s + 2) + P(s + 3)) / 6.0;
Cycle[s] = (1.0 - 0.5 * Alpha) * (1.0 - 0.5 * Alpha) * (Smooth[s] - 2.0 * Smooth[s + 1] + Smooth[s + 2])
+ 2.0 * (1.0 - Alpha) * Cycle[s + 1]
- (1.0 - Alpha) * (1.0 - Alpha) * Cycle[s + 2];
double period = iCustom(0, 0, "CyclePeriod", Alpha, 0, s);
int DCPeriod = MathFloor(period);
double RealPart = 0.0;
double ImagPart = 0.0;
for (int count = 0; count < DCPeriod; count++) {
RealPart += MathSin(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
ImagPart += MathCos(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
}
double DCPhase;
if (MathAbs(ImagPart) > 0.0000001) {
DCPhase = rad2Deg * MathArctan(RealPart / ImagPart);
} else if (MathAbs(ImagPart) <= 0.0000001) {
if (RealPart >= 0.0) {
DCPhase = 90.0;
} else {
DCPhase = -90.0;
}
}
DCPhase += 90.0;
if (ImagPart < 0) {
DCPhase += 180.0;
}
if (DCPhase > 315.0) {
DCPhase -= 360.0;
}
Sine[s] = MathSin(DCPhase * deg2Rad);
LeadSine[s] = MathSin((DCPhase + 45.0) * deg2Rad);
if (DCPhase == 180 && LeadSine[s + 1] > 0) {
LeadSine[s] = MathSin(45 * deg2Rad);
}
if (DCPhase == 0 && LeadSine[s + 1] < 0) {
LeadSine[s] = MathSin(225 * deg2Rad);
}


//Attemp to draw a resistance support line at cross over

if (DrawPriceTrendLines == true)
{
trend[s] = trend[s+1];
if (LeadSine[s] > Sine[s] && LeadSine[s+1] < Sine[s+1]) trend[s] = 1;
if (LeadSine[s] < Sine[s] && LeadSine[s+1] > Sine[s+1]) trend[s] =-1;

if(Support[s]>Resistance[s+1] && trend[s]>0){ //print PB for support

Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
DrawText(sTime, Time[s+1], Support[s], Support[s], "PB",0);
}

else
{
Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
}

///////////////////////////////////////////////////////////////////////////////////////

if(Resistance[s]<Support[s+1] && trend[s]<0){ //print PB for resistance

Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}

DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
DrawText(rTime, Time[s+1], Resistance[s], Resistance[s], "PB",0);
}

if(trend[s]<0)
{
Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}
DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
}
}


}



return (0);
}

double P(int index) {
return ((High[index] + Low[index]) / 2.0);
}

void initBuffer(double array[], string label = "", int type = DRAW_NONE, int arrow = 0, int style = EMPTY, int width = EMPTY, color clr = CLR_NONE) {
SetIndexBuffer(buffers, array);
SetIndexLabel(buffers, label);
SetIndexEmptyValue(buffers, EMPTY_VALUE);
SetIndexDrawBegin(buffers, drawBegin);
SetIndexShift(buffers, 0);
SetIndexStyle(buffers, type, style, width);
SetIndexArrow(buffers, arrow);
buffers++;
}


void DrawPriceTrendLines(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string label = "Support Resistance" + DoubleToStr(x1, 0);
ObjectDelete(label);
ObjectCreate(label, OBJ_TREND, 0, x1, y1, x2, y2, 0, 0);
ObjectSet(label, OBJPROP_RAY, 0);
ObjectSet(label, OBJPROP_COLOR, lineColor);
ObjectSet(label, OBJPROP_STYLE, style);
ObjectSet(label, OBJPROP_WIDTH, 3);
}

void DrawText(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText = "PB" + DoubleToStr(x1, 0);
ObjectDelete(DrawText);
ObjectCreate(DrawText, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText, "PB", 10, "Comic Sans MS Bold", White);
}

/*void DrawText1(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText1 = "End" + DoubleToStr(x1, 0);
ObjectDelete(DrawText1);
ObjectCreate(DrawText1, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText1, "End", 12, "Comic Sans MS", White);
}*/

Another day has passed. Time to continue on and get this indicator working the way I want it to.

You think that I could flag it somehow, once we get a "PB" signal I assign an integer to a flag variable and when the computer reads the code through again
and sees the flag is equal to the integer then it should print the "End".

Here is the code now but not making any difference. What am I doing wrong?

#property indicator_separate_window
#property indicator_buffers 3
#property indicator_color1 Red
#property indicator_color2 Blue
#property indicator_color3 Yellow

#property indicator_minimum -1
#property indicator_maximum 1
#property indicator_level1 0

double Sine[];
double LeadSine[];
double Cycle[];
double Smooth[];

double Resistance[];
double Support[];
double trend[];

extern double Alpha = 0.07;
extern bool DrawPriceTrendLines = true;
int buffers = 0;
int drawBegin = 0;

double tempReal, rad2Deg, deg2Rad, label;
int ilow, ihigh;
datetime sTime, rTime;




int init() {
drawBegin = 8;
initBuffer(Sine, "Sine", DRAW_LINE);
initBuffer(LeadSine, "Lead", DRAW_LINE);
initBuffer(Cycle);
initBuffer(Smooth);
initBuffer(Resistance); // "ResisT",DRAW_ARROW, STYLE_DASHDOT,1);
initBuffer(Support);
initBuffer(trend);

IndicatorBuffers(buffers);
IndicatorShortName("Sinewave with S&R[" + DoubleToStr(Alpha, 2) + "]");
tempReal = MathArctan(1.0);
rad2Deg = 45.0 / tempReal;
deg2Rad = 1.0 / rad2Deg;

return (0);
}


int deinit()
{
for(int i = ObjectsTotal() - 1; i >= 0; i--)
{
string label = ObjectName(i);
if(StringSubstr(label, 0, 18) != "Support Resistance")
continue;
ObjectDelete(label);
}
for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText = ObjectName(i);
if(StringSubstr(DrawText, 0, 2) != "PB")
continue;
ObjectDelete(DrawText);
}
//ObjectDelete("PB");
/* for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText1 = ObjectName(i);
if(StringSubstr(DrawText1, 0, 2) != "End")
continue;
ObjectDelete(DrawText1);
}*/
return(0);
}


int start() {
if (Bars <= drawBegin) return (0);
int countedBars = IndicatorCounted(), currents;
if (countedBars < 0) return (-1);
if (countedBars > 0) countedBars--;
int s, limit = Bars - countedBars - 1, Flagup,Flagdn;
currents=s;
for (s = limit; s >= 0; s--) {
Smooth[s] = (P(s) + 2.0 * P(s + 1) + 2.0 * P(s + 2) + P(s + 3)) / 6.0;
Cycle[s] = (1.0 - 0.5 * Alpha) * (1.0 - 0.5 * Alpha) * (Smooth[s] - 2.0 * Smooth[s + 1] + Smooth[s + 2])
+ 2.0 * (1.0 - Alpha) * Cycle[s + 1]
- (1.0 - Alpha) * (1.0 - Alpha) * Cycle[s + 2];
double period = iCustom(0, 0, "CyclePeriod", Alpha, 0, s);
int DCPeriod = MathFloor(period);
double RealPart = 0.0;
double ImagPart = 0.0;
for (int count = 0; count < DCPeriod; count++) {
RealPart += MathSin(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
ImagPart += MathCos(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
}
double DCPhase;
if (MathAbs(ImagPart) > 0.0000001) {
DCPhase = rad2Deg * MathArctan(RealPart / ImagPart);
} else if (MathAbs(ImagPart) <= 0.0000001) {
if (RealPart >= 0.0) {
DCPhase = 90.0;
} else {
DCPhase = -90.0;
}
}
DCPhase += 90.0;
if (ImagPart < 0) {
DCPhase += 180.0;
}
if (DCPhase > 315.0) {
DCPhase -= 360.0;
}
Sine[s] = MathSin(DCPhase * deg2Rad);
LeadSine[s] = MathSin((DCPhase + 45.0) * deg2Rad);
if (DCPhase == 180 && LeadSine[s + 1] > 0) {
LeadSine[s] = MathSin(45 * deg2Rad);
}
if (DCPhase == 0 && LeadSine[s + 1] < 0) {
LeadSine[s] = MathSin(225 * deg2Rad);
}

int flag[];
//Attemp to draw a resistance support line at cross over

if (DrawPriceTrendLines == true)
{
trend[s] = trend[s+1];
if (LeadSine[s] > Sine[s] && LeadSine[s+1] < Sine[s+1]) trend[s] = 1;
if (LeadSine[s] < Sine[s] && LeadSine[s+1] > Sine[s+1]) trend[s] =-1;

if(flag[s+1]== 2 /*&& trend[s]>0*/){ //print End for support

Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
DrawText1(sTime, Time[s+1], Support[s], Support[s], "End",0);
}

if(Support[s]>Resistance[s+1] && trend[s]>0 && flag[s+1] != 2){ //print PB for support

Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
DrawText(sTime, Time[s+1], Support[s], Support[s], "PB",0);
flag[s]=1;
}

else
{
Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
}

///////////////////////////////////////////////////////////////////////////////////////

if(flag[s+1]== 1 /*&& trend[s]<0*/){ //print End for resistance

Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}

DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
DrawText1(rTime, Time[s+1], Resistance[s], Resistance[s], "End",0);
}


if(Resistance[s]<Support[s+1] && trend[s]<0 && flag[s+1] != 1){ //print PB for resistance

Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}

DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
DrawText(rTime, Time[s+1], Resistance[s], Resistance[s], "PB",0);
flag[s]= 2;
}

if(trend[s]<0)
{
Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}
DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
}
}


}



return (0);
}

double P(int index) {
return ((High[index] + Low[index]) / 2.0);
}

void initBuffer(double array[], string label = "", int type = DRAW_NONE, int arrow = 0, int style = EMPTY, int width = EMPTY, color clr = CLR_NONE) {
SetIndexBuffer(buffers, array);
SetIndexLabel(buffers, label);
SetIndexEmptyValue(buffers, EMPTY_VALUE);
SetIndexDrawBegin(buffers, drawBegin);
SetIndexShift(buffers, 0);
SetIndexStyle(buffers, type, style, width);
SetIndexArrow(buffers, arrow);
buffers++;
}


void DrawPriceTrendLines(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string label = "Support Resistance" + DoubleToStr(x1, 0);
ObjectDelete(label);
ObjectCreate(label, OBJ_TREND, 0, x1, y1, x2, y2, 0, 0);
ObjectSet(label, OBJPROP_RAY, 0);
ObjectSet(label, OBJPROP_COLOR, lineColor);
ObjectSet(label, OBJPROP_STYLE, style);
ObjectSet(label, OBJPROP_WIDTH, 3);
}

void DrawText(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText = "PB" + DoubleToStr(x1, 0);
ObjectDelete(DrawText);
ObjectCreate(DrawText, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText, "PB", 10, "Comic Sans MS Bold", White);
//flag[0]=1;
}

void DrawText1(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText1 = "End" + DoubleToStr(x1, 0);
ObjectDelete(DrawText1);
ObjectCreate(DrawText1, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText1, "End", 12, "Comic Sans MS", White);
//flag[0]=2;
}

It would be much appreciated if any experienced programmers on FF could look at the latest code and give me some advice as to what I am doing wrong?

Pretty Please!

hey scottstone..... just briefly scaned over everything..... will take a closer look at your request and read the hilbert link to get his thoughts...... we should be able to put the nightmares to rest.....

or at least the ones involving mq4......h

ya, nightmare on scott street. lol

Hey appreciate the help Hayseed. If you look through the link to the site above you will find that the Hilbert Sinewave combines the best characteristics of a moving average and an ocsillator. There is a lot of great suggestions on how to apply this to a persons trading once you understand how it works.

hey scottstone..... save the ea "blank" below and the indicator "ssr".....

slowly run a visual backtest on any pairs 60 minute chart using the ea 'blank'.... don't expect trades......

while it's running attach the ssr indicator..... the ssr indicator is the indicator in post 1 reduced to the main chart only...... see if the the labels support and resistance are representing your understanding of the lines..... ie, blue represents support and red represents resistance....

if so, as long as the next blue line is higher than the previous blue line the uptrend is intact.... new support is higher than prior support..... like stairs.... but if the next blue line is below the previous blue line the uptrend has ended.... at this point we print "end" on the chart..... and opposite theory for downtrend.....

your using the term 'pullback', i'm just using the terms , support/resistance, which are inside the code..... we can adjust the terms to suit you.....

is my basic understanding correct..... and btw, that indicator repaints slightly....h

Thanks hayseed, will try it out here right away and see how it works.

Tried out your version but only get the text on the first support and resistance line.

This is my understanding of the indicator after having read and studied all the articles related to the sinewave on the emini site are as follows. Pic included.

The only time that text is placed on a support or resistance(S/R) line is when we have a breakout above a resistance level or a breakout below a support level with the next S/R line that's formed labeled as a pullback ("PB").

Then the very next S/R level that is formed after the PB is labeled with a End of trend signal ("End").

I don't think that having the next S/R level above or below changes the way the lines are labeled.

For example:

Immediately after we have a break of resistance the next support line will be labeled ("PB") and the next resistance line will be marked as the end of trend ("End"), in that order.

Pic below.

Here is what I have so far.

Got the "PB" to print in right locations.

End of trend signal not in the right location.

Also when I switch time frames it messes everything up. I have to compile it again to go back to what it was showing before.

The code and indy below.
//////////////////////////////////////////////////////////
#property indicator_separate_window
#property indicator_buffers 3
#property indicator_color1 Red
#property indicator_color2 Blue
#property indicator_color3 Yellow

#property indicator_minimum -1
#property indicator_maximum 1
#property indicator_level1 0

double Sine[];
double LeadSine[];
double Cycle[];
double Smooth[];

double Resistance[];
double Support[];
double trend[];

extern double Alpha = 0.07;
extern bool DrawPriceTrendLines = true;
int buffers = 0;
int drawBegin = 0;

double tempReal, rad2Deg, deg2Rad, label;
int ilow, ihigh;
datetime sTime, rTime;




int init() {
drawBegin = 8;
initBuffer(Sine, "Sine", DRAW_LINE);
initBuffer(LeadSine, "Lead", DRAW_LINE);
initBuffer(Cycle);
initBuffer(Smooth);
initBuffer(Resistance); // "ResisT",DRAW_ARROW, STYLE_DASHDOT,1);
initBuffer(Support);
initBuffer(trend);

IndicatorBuffers(buffers);
IndicatorShortName("Sinewave with S&R[" + DoubleToStr(Alpha, 2) + "]");
tempReal = MathArctan(1.0);
rad2Deg = 45.0 / tempReal;
deg2Rad = 1.0 / rad2Deg;

return (0);
}


int deinit()
{
for(int i = ObjectsTotal() - 1; i >= 0; i--)
{
string label = ObjectName(i);
if(StringSubstr(label, 0, 18) != "Support Resistance")
continue;
ObjectDelete(label);
}
for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText = ObjectName(i);
if(StringSubstr(DrawText, 0, 2) != "PB")
continue;
ObjectDelete(DrawText);
}
//ObjectDelete("PB");
for(i = ObjectsTotal() - 1; i >= 0; i--)
{
string DrawText1 = ObjectName(i);
if(StringSubstr(DrawText1, 0, 2) != "End")
continue;
ObjectDelete(DrawText1);
}
return(0);
}


int start() {
if (Bars <= drawBegin) return (0);
int countedBars = IndicatorCounted(), currents;
if (countedBars < 0) return (-1);
if (countedBars > 0) countedBars--;
int s, limit = Bars - countedBars - 1, Flagup,Flagdn;
currents=s;
for (s = limit; s >= 0; s--) {
Smooth[s] = (P(s) + 2.0 * P(s + 1) + 2.0 * P(s + 2) + P(s + 3)) / 6.0;
Cycle[s] = (1.0 - 0.5 * Alpha) * (1.0 - 0.5 * Alpha) * (Smooth[s] - 2.0 * Smooth[s + 1] + Smooth[s + 2])
+ 2.0 * (1.0 - Alpha) * Cycle[s + 1]
- (1.0 - Alpha) * (1.0 - Alpha) * Cycle[s + 2];
double period = iCustom(0, 0, "CyclePeriod", Alpha, 0, s);
int DCPeriod = MathFloor(period);
double RealPart = 0.0;
double ImagPart = 0.0;
for (int count = 0; count < DCPeriod; count++) {
RealPart += MathSin(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
ImagPart += MathCos(deg2Rad * 360.0 * count / DCPeriod) * Cycle[s + count];
}
double DCPhase;
if (MathAbs(ImagPart) > 0.0000001) {
DCPhase = rad2Deg * MathArctan(RealPart / ImagPart);
} else if (MathAbs(ImagPart) <= 0.0000001) {
if (RealPart >= 0.0) {
DCPhase = 90.0;
} else {
DCPhase = -90.0;
}
}
DCPhase += 90.0;
if (ImagPart < 0) {
DCPhase += 180.0;
}
if (DCPhase > 315.0) {
DCPhase -= 360.0;
}
Sine[s] = MathSin(DCPhase * deg2Rad);
LeadSine[s] = MathSin((DCPhase + 45.0) * deg2Rad);
if (DCPhase == 180 && LeadSine[s + 1] > 0) {
LeadSine[s] = MathSin(45 * deg2Rad);
}
if (DCPhase == 0 && LeadSine[s + 1] < 0) {
LeadSine[s] = MathSin(225 * deg2Rad);
}
/////////////////////////////////////////////////////////////////////////////////

int flag;
//Attemp to draw a resistance support line at cross over

if (DrawPriceTrendLines == true)
{
trend[s] = trend[s+1];
if (LeadSine[s] > Sine[s] && LeadSine[s+1] < Sine[s+1]) trend[s] = 1;
if (LeadSine[s] < Sine[s] && LeadSine[s+1] > Sine[s+1]) trend[s] =-1;

if(flag == 2){ //print End for support

Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
DrawText1(sTime, Time[s+1], Support[s], Support[s], "End1",0);
flag= 0;
}

if(Support[s]>Resistance[s+1] && trend[s]>0 /*&& flag != 2*/){ //print PB for support

Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];

}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
DrawText(sTime, Time[s+1], Support[s], Support[s], "PB",0);
flag =1;
}

else
{
Support[s] = Support[s+1];
if (trend[s] != trend[s+1])
{
Support[s] = Low[s];
sTime = Time[s];
}

DrawPriceTrendLines(sTime, Time[s], Support[s], Support[s], Crimson, STYLE_SOLID);
flag =0;
}

///////////////////////////////////////////////////////////////////////////////////////

if(flag == 1 && Support[s+1]){ //print End for resistance

Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}

DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
DrawText1(rTime, Time[s+1], Resistance[s], Resistance[s], "End2",0);
flag = 0;
}


if(Resistance[s]<Support[s+1] && trend[s]<0){ //print PB for resistance

Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];

}

DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
DrawText(rTime, Time[s+1], Resistance[s], Resistance[s], "PB",0);
flag = 2;
}

if(trend[s]<0)
{
Resistance[s] = Resistance[s+1];
if (trend[s] != trend[s+1])
{
Resistance[s] = High[s];
rTime = Time[s];
}
DrawPriceTrendLines(rTime, Time[s],Resistance[s], Resistance[s], White,STYLE_SOLID);
flag =0;
}

}


}



return (0);
}

double P(int index) {
return ((High[index] + Low[index]) / 2.0);
}

void initBuffer(double array[], string label = "", int type = DRAW_NONE, int arrow = 0, int style = EMPTY, int width = EMPTY, color clr = CLR_NONE) {
SetIndexBuffer(buffers, array);
SetIndexLabel(buffers, label);
SetIndexEmptyValue(buffers, EMPTY_VALUE);
SetIndexDrawBegin(buffers, drawBegin);
SetIndexShift(buffers, 0);
SetIndexStyle(buffers, type, style, width);
SetIndexArrow(buffers, arrow);
buffers++;
}


void DrawPriceTrendLines(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string label = "Support Resistance" + DoubleToStr(x1, 0);
ObjectDelete(label);
ObjectCreate(label, OBJ_TREND, 0, x1, y1, x2, y2, 0, 0);
ObjectSet(label, OBJPROP_RAY, 0);
ObjectSet(label, OBJPROP_COLOR, lineColor);
ObjectSet(label, OBJPROP_STYLE, style);
ObjectSet(label, OBJPROP_WIDTH, 3);
}

void DrawText(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText = "PB" + DoubleToStr(x1, 0);
ObjectDelete(DrawText);
ObjectCreate(DrawText, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText, "PB", 10, "Comic Sans MS Bold", White);
//return(1);
}

void DrawText1(datetime x1, datetime x2, double y1, double y2, color lineColor, double style)

{
string DrawText1 = "End" + DoubleToStr(x1, 0);
ObjectDelete(DrawText1);
ObjectCreate(DrawText1, OBJ_TEXT, 0, x1, y1, x2, y2, 0, 0);
ObjectSetText(DrawText1, "End", 12, "Comic Sans MS", White);
//return(2);
}

This is what happens when I switch time frames.