Help to convert an Indicator to an EA.

I have a cust0m indicat0r {MACD Divergence Indicat0r} that I need t0 c0nvert t0 an EA. Can s0me b0dy help me make this indicat0r generate buy and sell signals 0r atleast give me the c0des I need t0 make it d0 s0. Dats all I need. I kn0w that we have t0 call it fr0m ICust0m, but thats where I need help. I have attached the indicat0r.thanks.

So, what are these the four alerts signals you are trying to work with?

"Classical bullish divergence on: "
"Reverse bullish divergence on: "
"Classical bearish divergence on: "
"Reverse bearish divergence on: "

Or, is there more to it than this? If all you are trying to do is convert these into Buy and Sell signals, I should be able to help.

Actually no, I think it goes into the EA folder once you convert it into an EA ... I believe.

Also, by "classical bullish," does that mean you are looking to Buy, and by "reverse bullish," you are looking to Sell? And it's the opposite of that with the bearish signals?

Thanks f0r y0ur pr0mpt resp0nse. The classical bullish and reverse bullish are b0th t0 generate buy signals and the classical bearish and reverse bearish are t0 generate sell signals. I w0uld be m0st grateful if y0u can help me 0n this, thanks.

Okay, it's in the works. I should have something to show for it shortly.

Okay, I believe I have a reasonable facsimile here.

Initially I tried converting the indicator into an EA saved it in the Experts folder. It compiled but, when I went to open it up on the chart it wouldn't do anything. So, I decided to add a global variable to the indicator and create a new EA to read it and open any new trades from there. This is why there are two files.

The first file needs to go into the indicator folder (no need to create a "custom" folder, and the second file (which says "EA") should go into the experts folder.

I set it up so all you need to do is input the information for the first trade ("Classical bullish divergence on: ") and it will copy it over to the other three options. If you decide want to input each one individually, you have the option to do that too (or else leave them set to zero).

Also, depending on how many digits your broker uses, you may have to adjust for that. Currently it's set for four digits. If you go with a five digit broker, you'll have to add another "0" after the Take Profit and Stop Loss values.

It's also setup so it opens only one trade at a time and won't open any new ones until after the current one has closed and, hopefully, not until after a new indicator arrow/alarm sounds. At least that's the way it should work in theory. I haven't fully had a chance to test it yet so, we'll just have to wait and see.

There is one bug that I'm aware of. When you first open the indicator it displays all the previous "events" (with arrows) up until the last one. In other words the information I'm using to create the global variable is always in the "on" state, and remains that way until a new "event" occurs. So, when I open the EA it thinks a new event has just occurred and automatically opens a new trade which, of course, I'm sure you don't want it to do. I will have to see what I can do to fix it. But hey, if this is the only problem, I would say I did pretty good.

Basically it's there to give you a chance to look at it and tell me what you think, and offer any possible feedback you might have. You never know, I may wind up using it myself.

Hi, I want t0 say tanks f0r taking 0ut time t0 help me with this EA. I did everything y0u said t0 d0, but the EA d0esnt 0pen trades when I back test it. Its n0t w0rking. may be there are min0r hitches. C0uld y0u please take a sec0nd l00k at it and test it again, Thanks. Im waiting t0 hear fr0m U.

You're right. There were three new signals this morning, but the time didn't update itself. It seemed like it was working yesterday but, that was before I did a whole lot of other stuff (mostly to the EA). Or, maybe it wasn't updating at all?

Okay, I just checked. I closed the indicator and reopened it, and the time updated at that point. That tells me it's not updating on the indicator side. If so, I can't make any guarantees that it will work. I will go back and take a look though.

But hey, if anyone else wants to take a stab it, I have no problem with that.

Oh, do you know if there's any way to back test an indicator on the MT4 platform? If I try to forward test it (which I've been doing) it takes too long to generate the signals.

Wow! I just got a new signal, a "reverse bearish," as opposed to "classical bullish" (over the last few signals) which, showed up in the comments field, except it didn't update the time. That tells me part of it's working anyway. So, it's a place to start.

0k tank. im expectant. bt wat i dnt undastand is why u r nt using i cd ust0m. i dint c wer d ea made reference 2 d ihdicat0r and is it dat difficult t0 create an ea frm dis indicat0r. tank all d same 4 ur eff0rts.

Reading such childish alphabet soup in a serious programming forum for grown-ups makes my eyes and my brain hurt.

Okay, I think I fixed the problem with the EA.

As for the indicator, I modified it and am generating a signal off the current time. And, so long as there is only one iteration, like with the alarm, it should work. If, however, it continues to update itself (within a specified "window"), and a trade has already opened and closed, it will open a new trade which, of course we don't want to happen.

I've attached the modified files, and note the "02" revisions. Just put them in their respective folders and don't forget to compile therm.

Oh, if you try back testing the EA without the indicator, it won't work. Normally I don't use indicators, so I don't know if it's possible to back test both at the same time?

Yeah, and it's only getting worse.

No, the EA doesn't make reference to the indicator. It just picks up the global variables ("T_option" and "Reset_T") which are generated by the indicator.

Oh, the EA actually works. I'm just having a problem generating the "right" signal from the indicator as described above.

In fact, just as I finished describing the indicator problem, the indicator generated a new signal and, the EA saw it and opened a new trade. Unfortunately (as I was afraid), the time continues to update (and will for at least a few minutes afterwards), and now it's just opened the third trade. It looks like it just stopped updating though. Oh well ...

But hey, this appears to be the only problem, and should be easy enough to fix. But, if I can't get to it, I'm sure someone else should be able to help out.

Okay, it looks like I have something here. It took a little time and I wound up modifying both files. Note, both are at revision "03" now.

I also set up a Test option on the indicator, at the bottom of Input Options in Properties box. And here, if you enter a number between 1 and 4, it tells the EA to open a Trade for that specific option. It may not always work the first time though, possibly because of too much volatility between ticks (after clicking the "OK" button) so, you may have to repeat it. There's also a number in parenthesis after the time (on status line at top of chart) which is set to 1 after the test is initialized. After the trade is placed it is reset to 0. Or, if not, and it remains set at 1, more than likely because it didn't work (and place a trade), you will have to retest it (successfully) or set the Test option to 0. Otherwise it won't allow you to place anymore trades.

Does that make any sense? If you have any questions, let me know ...

Thanks.

Alright. I just placed my first successful trade!

Okay, I have one question here. Is there any way to attach an indicator to an EA or, open both at the same time on the same chart?

Any ideas?

Thanks.

For anyone interested, I modified the code a bit on the indicator on this post (MACD_Divergence_V1.1_03), because there was a bug in it. So, if you downloaded a copy prior to the modification stamp, you might want to re-download it.

Oh, I did not modify the EA (MACD_Diverge_EA_V1.1_03), so you only need to download the indicator. Or, if you're not sure, you should probably download both.

Thanks.

Ectrade. EA looking good.
I like divergence trading and like your indicator. However, the indicator doesn't paint signal until one whole candle after the signal candle has closed. I think understand this, as it has to be sure the signal is valid, this is different to other signals that just repaint th signal out if it turns out to be wrong.

But is there a way of painting a signal to the chart to show that this candle could be a signal candle, and then the proper signal when confirmation has happened? This would help me back test it visually.

I also have on your EA. It took a profitable trade on the EU, however there is no corresponding signal on the indicator to show why a trade was taken?

Any help much appreciated.

I was just taking advantage of the available signals, per Sokyboy's request. Other than that, I don't really know a whole lot about the indicator, or how it's supposed to work.

I was thinking about modifying the EA so you can call up the indicator without attaching it to the chart. This also makes it possible to back test the indicator with the EA, according to what 7 bit is saying in this thread here. So, maybe this will help, I don't know?

nice job ecTrade,

i'm watching MACD-divergence indicator and see that old lines divergence are never deleted (happen when switching timeframes).
could you add some code into it to clean it ?