Menu
Sister Sites

Options

Bookmark Thread

First Page First Unread Last Page Last Post

Print Thread

Similar Threads

EA based on indicator which changes based on numbers of bars 0 replies

If previous bar=bull/bull then 2 replies

Trading Price Based Charts Instead of Time Based Charts 1 reply

Bull/Bears 3 replies

Price-based Vs. Pip-based 5 replies

Attachments: Check based on Bull and Bears
Exit Attachments

Check based on Bull and Bears

  • Post #1
  • Quote
  • First Post: Jan 22, 2010 11:36am Jan 22, 2010 11:36am
I need a check whats based on bulls and bears.
I have the basics already:
extern bool EnableBull = True;

int BullSignal = EMPTY_VALUE;

//BULL
if (EnableBull==True) {
//check1 needed
BullSignal = OP_SELL
} else {
BullSignal = EMPTY_VALUE;
}

I need now add the commend of check needed the following.
When there are 4 or more bullish candles after each other.
And after those 4 or more bullish candles must be 1 bearish candle, when this bearish candle is closed it needs to open an Short trade.

In this picture you see an example:
http://www.fabje.eu/bla.png

1: Bullish Candle number one
2: Bullish Candle number two
3: Bullish Candle number three
4: Bullish Candle number four
5: Bearish Candle
6: Open Short

The code should be something like this I think:
If (bull1 = true) && (bull2 = true) && (bull3 = true) && (bull4 = true) && (bear = true) {
BullSignal = OP_SELL
} else {
BullSignal = EMPTY_VALUE;
}

Someone here that can help me with this?
you can check between close price and open price,

bullish=Close[x]>Open[x];

bearish=Open[x]>Close[x];

u can use looping statement to check
I'm trying it like this now:
Creating the booleans.
Inserted Code
bool b_bullish;
bool b_bullish1;
bool r_bullish;
bool r_bullish1;
Set the booleans on false.
Inserted Code
void bullish() {
    bool b_bullish = false;
    bool r_bullish = false;
    bool b_bullish1 = false;
    bool r_bullish1 = false;
}

The check:
Inserted Code
1   if (EnableBull==True) {  
2      if (b_bullish = Close[] > Open[]) {
3         r_bullish = true;
4      } else {
5         BullSignal = EMPTY_VALUE;
6      }        
7    
8      if (r_bullish == true){
9         BullSignal = OP_SELL;
10      } else {
11      BullSignal = EMPTY_VALUE;
12      }
13 }

But I get some errors:
'b_bullish' - left parenthesis expected - line 2
']' - wrong dimension - line 2
'=' - assignment expected - line 2
']' - semicolon expected - line 2
']' - unexpected token - line 2
'>' - unexpected token - line 2
'Open' - unexpected token - line 2
']' - wrong dimension - line 2
'{' - assignment expected - line 2
'else' - unexpected token - line 4

Someone knows whats going on?
I see that the [ and ] errors in the code are because these are used for arrays.
Anyone here that can help me how it should be done?
Quoting fabje
I'm trying it like this now:
Creating the booleans.
Inserted Code
bool b_bullish;
bool b_bullish1;
bool r_bullish;
bool r_bullish1;
Set the booleans on false.
[code]void bullish() {...
if (Close[1] > Open[0]) {

for [0] is current bar while [1] is pervious bar

hope this help
I'm now first detecting what kind of candle is was.
Inserted Code
      if (Open[1] > Open[0]) {
         Print("Bearish");
      }
When I backtest this I get this kind of results:
2010.01.23 13:26:00 2010.01.18 18:58 EA GBPUSD,H1: Bearish
2010.01.23 13:26:00 2010.01.18 18:57 EA GBPUSD,H1: Bearish
2010.01.23 13:26:00 2010.01.18 18:56 EA GBPUSD,H1: Bearish
2010.01.23 13:26:00 2010.01.18 18:55 EA GBPUSD,H1: Bearish
How can I make it possible that it only checks based on the timeframe that I use? So when it is set on H1 it only checks on 17:00 | 18:00 | 19:00 etc.
Quoting fabje
I'm now first detecting what kind of candle is was.
[code]...
use iOpen/ iClose ?
double iOpen( string symbol, int timeframe, int shift)
Returns Open value for the bar of indicated symbol with timeframe and shift. If local history is empty (not loaded), function returns 0.
For the current chart, the information about open prices is in the predefined array named Open[].
Hmm when I do the following:
Inserted Code
double opencheck        = 0.0;
double closecheck       = 0.0;
   if (EnableBull==True) {  
      opencheck = iOpen("GBPUSD",60,0); 
      closecheck = iClose("GBPUSD",60,0); 
      if (opencheck > closecheck) {
         Print("Bearish");
      }
      if (opencheck < closecheck) {
         Print("Bullish");
      }
   }
I still get with backtesting these kind of results:
2010.01.23 13:26:00 2010.01.18 18:58 EA GBPUSD,H1: Bearish
2010.01.23 13:26:00 2010.01.18 18:57 EA GBPUSD,H1: Bearish
2010.01.23 13:26:00 2010.01.18 18:56 EA GBPUSD,H1: Bearish
2010.01.23 13:26:00 2010.01.18 18:55 EA GBPUSD,H1: Bearish

Do I something wrong :S?
Quoting fabje
Hmm when I do the following:
[code]
double opencheck...
you are checking the current bar of H1 ?
When I use the following code:
Inserted Code
      opencheck = iOpen("GBPUSD",PERIOD_H1,0); 
      closecheck = iClose("GBPUSD",PERIOD_H1,0);
      if (opencheck < closecheck) {
         Print("This is a Bullish Candle");  
         BullSignal = EMPTY_VALUE;      
      }
      if (opencheck > closecheck) {
         Print("This is a Bearish Candle");
         BullSignal = EMPTY_VALUE;
      }
I get the results of the currentbar of every tick.

But now I want that as soon as this bar closes it sets a variable on true.
Because when I make it like this:
Inserted Code
      opencheck = iOpen("GBPUSD",PERIOD_H1,0); 
      closecheck = iClose("GBPUSD",PERIOD_H1,0);
      if (opencheck < closecheck) {
         Print("This is a Bullish Candle");
         [b]bull = true;[/b]
         BullSignal = EMPTY_VALUE;      
      }
      if (opencheck > closecheck) {
         Print("This is a Bearish Candle");
         BullSignal = EMPTY_VALUE;
      }
It will set this variable every tick when opencheck is smaller then the closecheck on true. But I don't what that, I want that the variable called bull, only will be set on true as soon as the bar is closed, and when opencheck is smaller then closecheck.
use iBars(NULL,TimeFrame)

for example

Inserted Code
int LastBar;

int init()
{
  LastBar = iBars(NULL,PERIOD_H4);
}

int start()
{
  if(LastBar != iBars(NULL,PERIOD_H4))
  {
    LastBar = iBars(NULL,PERIOD_H4);
    Print("New H4 Bar");
    //checking candle start
    //  ....
    //checking candle end
  }
}
Inserted Code
   
   int COUNT = 0;
 
   for( int i = 5; i > 1; i--)
   {
      if(Close[i] > Open[i]) { COUNT = COUNT + 1 ; } else { COUNT = COUNT - 1 ; }
     
   }

   if( COUNT == 4  && Close[1] < Open[1] ) { "SHORT TRIGGER" }
   if( COUNT == -4 && Close[1] > Open[1] ) { "LONG TRIGGER" }

Does that help?
  • Post #13
  • Quote
  • Edited 3:13pm Jan 23, 2010 1:13pm | Edited 3:13pm
Quoting kennyjohnson
Inserted Code
   
   int COUNT = 0;
 
   for( int i = 5; i > 1; i--)
   {
      if(Close[i] > Open[i]) { COUNT = COUNT + 1 ; } else { COUNT = COUNT - 1 ; }
     
   }

   if( COUNT == 4  && Close[1] < Open[1] ) { "SHORT TRIGGER" }
   if( COUNT == -4 && Close[1] > Open[1] ) { "LONG TRIGGER" }
Does that help?
Can you tell what it exactly does line for line, so I can understand the code?

I have the code now like this:
Inserted Code
      int COUNT = 0;
      for( int i = 5; i > 1; i--){
         if(Close[i] > Open[i]) { COUNT = COUNT + 1 ; } else { COUNT = COUNT - 1 ; }
      }
      if (EnableBull==True) {
         if (COUNT == 4  && Close[1] < Open[1]) { 
            BullSignal=OP_BUY; 
         } 
      }
      if (EnableBears==True) {
         if (COUNT == -4 && Close[1] > Open[1]) { 
            BearSignal=OP_SELL; 
         } 
      }
And when I backtest it get this order:
1 2009.01.05 00:00 sell 1 0.10 1.4542 0.0000 0.0000 0.00 10000.00
2 2009.01.05 00:00 modify 1 0.10 1.4542 0.0000 1.4462 0.00 10000.00
3 2009.01.05 00:57 modify 1 0.10 1.4542 1.4541 1.4462 0.00 10000.00
4 2009.01.05 00:58 modify 1 0.10 1.4542 1.4540 1.4462 0.00 10000.00
5 2009.01.05 01:00 modify 1 0.10 1.4542 1.4539 1.4462 0.00 10000.00
6 2009.01.05 01:02 modify 1 0.10 1.4542 1.4536 1.4462 0.00 10000.00
7 2009.01.05 01:03 close 1 0.10 1.4506 1.4536 1.4462 36.00 10036.00

And this is a screenshot of that order:
http://www.fabje.eu/bla2.png
As we can see it opened the order at number 5, but if we look at my first post it should open the order at number 6.
If we go back to my rules I said when there are 4 bearish candles, wait until the next candle is closed, is this a bullish candle, open a Short trade.
This that last check isn't done.

But there are not always 4 bearish of bullish candles, sometimes there are more as we can see in this picture.
http://www.fabje.eu/bla3.png

Here we see 7 bearish candles in a row. And after those 7 bearish candle there is a bullish candle at number 8.
And when the candle at number 9 openend it should start a Short trade.
After the Short trade is made the market was going down as we can see in the following picture.
http://www.fabje.eu/bla4.png

And we could have earned at least 50pips.
in this case, u do not need to count how many bullish before the bearish...

your condition should be:
just look for the last 5 bars

if(bar2 to bar5== bullish && bar1 ==bearish) trigger buy at Open[0])

that's the logic of your system
  • Post #15
  • Quote
  • Edited 10:34am Jan 24, 2010 10:14am | Edited 10:34am
For starters, you have the candles numbered backwards. The MT4 convention is the current candle is 0 and the previous candle is 1.

The code I posted checks candles 5,4,3,2 and counts how many are bullish and how many are bearish. If all 4 are bullish and candle 1 is bearish, then it is a short trigger.

Make sure you reset your variables at the same time you set COUNT to 0. I have a suspicion this is where you problem lies.
Inserted Code
// reset variables

BullSignal=
BearSignal=


      int COUNT = 0;

// count candles 2 through 5

      for( int i = 5; i > 1; i--){
         if(Close[i] > Open[i]) { COUNT = COUNT + 1 ; } else { COUNT = COUNT - 1 ; }
      }
// check for long 

      if (EnableBull==True) {
         if (COUNT == -4  && Close[1] > Open[1]) { 
            BullSignal=OP_BUY; 
         } 
      }

// check for short

      if (EnableBears==True) {
         if (COUNT == 4 && Close[1] < Open[1]) { 
            BearSignal=OP_SELL; 
         } 
      }

You also had the bulls/bears reversed.
I have it now like this:
I have placed the following code at the begin of my code even before int init().
Inserted Code
int COUNT = 0;
int BBSignal = EMPTY_VALUE;
And this code is placed in the: int start() part.
Inserted Code
   for (int i = 5; i > 1; i--) {
      if(Close[i] > Open[i]) { 
         COUNT = COUNT + 1; 
      } else { 
         COUNT = COUNT - 1; 
      }
   }
   if (EnableBB==True) {
      if (COUNT == 4  && Close[1] < Open[1]) { 
         BBSignal=OP_BUY; 
      } 
   }
   if (EnableBB==True) {
      if (COUNT == -4 && Close[1] > Open[1]) { 
         BBSignal=OP_SELL; 
      }  
   }
And with backtesting I got this result:
http://www.fabje.eu/bla6.png

It started at first a LONG trade and it should be a SHORT trade. And that second LONG trade shouldn't even be there.

I placed the code: int COUNT = 0; now almost everywhere in the code but I can't figure it out what is going wrong.
I have placed it as explained above, I have test it to put it before the for loop: for (int i = 5; i > 1; i--) {

If have checked what happend when I put: COUNT = 0:
After BBSignal=OP_BUY and BBSignal=OP_SELL, but that also didn't solve the problem.
A little update.

I'm now a little bit further, it opens at the right time according the conditions.
Only after that trade it doen't set the variable BBSignal back to EMPTY_VALUE. So it keeps saying OP_BUY or OP_SELL according what was first.
When the first order is finished, it keeps saying OP_BUY/OP_SELL. When when the first order is finished, in the next following candle it opens a new order. When this order is done it resets BBSignal from OP_BUY/OP_SELL back to EMPTY_VALUE.
I have really no idea what is going wrong and why he does this.
I have placed the code "BBSignal = EMPTY_VALUE;" at some points where I think it solved the problem but it wasn't. Some examples of where I placed the code "BBSignal = EMPTY_VALUE;" are right behind the point that it opens an order, or when it will be closed.

I have the code now like this:
Inserted Code
int BBSignal            = EMPTY_VALUE;
int startbuy            = EMPTY_VALUE;
int startsell             = EMPTY_VALUE;

   if (EnableBB==True) {   
      if(Close[2] < Open[2] && Close[2+1] < Open[2+1] && Close[2+2] < Open[2+2] && Close[2+3] < Open[2+3])
      {
         if(Close[1] > Open[1] && Open[1] != startbuy)
         {
            bbsignal_buy();
         }
      }      
      if(Close[2] > Open[2] && Close[2+1] > Open[2+1] && Close[2+2] > Open[2+2] && Close[2+3] > Open[2+3])
      {
         if(Close[1] < Open[1] && Open[1] != startsell)
         {
            bbsignal_sell();
         }
      }
   }   

void bbsignal_buy()
{
   BBSignal=OP_BUY;
   startbuy = Open[0];
}

void bbsignal_sell()
{
   BBSignal=OP_SELL;
   startsell = Open[0];
}
Someone that has an idea how to solve this?
Quoting fabje
A little update.

[/code]Someone that has an idea how to solve this?
I think this is what you want.

Test it. I just make a quick code.
Hope it helps.
Attached File(s)
File Type: mq4 4bull1bear.mq4   2 KB | 713 downloads
File Type: ex4 4bull1bear.ex4   3 KB | 465 downloads
Quoting akukaya
I think this is what you want.

Test it. I just make a quick code.
Hope it helps.
I get an OrderSend error 130.

edit:

I put your way in my EA like this:
Inserted Code
bool NewBar()
{   
   static datetime lastbar = 0;   
   datetime curbar = Time[0];  
   if(lastbar!=curbar)
   {      
      lastbar=curbar;      
      return (true); 
   } else {
      return(false);   
   }
}

   if (EnableBB==True) {   
      if(NewBar())
      {
         if(  Close[5]>Open[5] &&  Close[4]>Open[4] &&  Close[3]>Open[3]&&  Close[2]>Open[2]&&  Close[1]<Open[1])
         {
            BBSignal=OP_SELL;
         }
         if(  Close[5]<Open[5] &&  Close[4]<Open[4] &&  Close[3]<Open[3]&&  Close[2]<Open[2]&&  Close[1]>Open[1])
         {
            BBSignal=OP_BUY;
         }
      }
   }

And it seems to work
Quoting fabje
I get an OrderSend error 130.

edit:

I put your way in my EA like this:
[code]
bool NewBar()
{...

the ordersend error due to price digit I think..anyway..good it works for you...Is it profitable?
0 traders viewing now