a question of global variables | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

MT4 global variables: my new best friend 34 replies

Problem getting Global Variables to Work 12 replies

Trouble with Global Variables 9 replies

Question about External Variables 2 replies

Exporting & importing Global variables to CSV Files 3 replies

a question of global variables

  • #1
  • First Post: Jan 9, 2010 6:31am Jan 9, 2010 6:31am
Hi, there,

I want to open 2 trades everyday. Unfortunately the following code is not working. After the first 2 trades in the first day, the global variable "DayofTrade" keeps to be 0 instead of becoming back to -1. Could anyone here give me some help?

Many thanks in advance!

Inserted Code
int DayofTrade = -1;

int init(){return(0);}
int deinit(){return(0);}

int start()
{

   int MagicNumber=10;   
   if(Hour()==0 && DayofTrade == -1)
   { 
    OrderSend(Symbol(), OP_BUY, 1, Ask, 3, 0, 0,"my comment",MagicNumber);
    OrderSend(Symbol(), OP_SELL, 1, Bid, 3, 0, 0,"my comment",MagicNumber);
    DayofTrade=0;
   }   
   return(0);
}
  • #2
  • Jan 9, 2010 6:48am Jan 9, 2010 6:48am
You initialize DayOfTrade before the start() function. The code doesn't go all the way back to the beginning, it goes back to the start() function.

You need to move the initialization of that variable down to inside the start() function.
  • #3
  • Jan 9, 2010 8:27am Jan 9, 2010 8:27am
hey dogberry..... moving the int DayofTrade = -1; to the start function might have the unpleasant side effect of a new set of orders at every tick.....

perhaps you could use Day() or DayOfWeek() such as below......just a thought......h


Inserted Code
 
int DayofTrade = -1;
 
//+-----
int init()
  {
//----
 
//----
   return(0);
  }
//+-------
int deinit()
  {
//----
 
//----
   return(0);
  }
 
//+------------------------------------------------------------------+
int start()
  {
//----
   int MagicNumber=10;   
   if(Hour()==0 && DayofTrade != DayOfWeek())
   { 
    OrderSend(Symbol(), OP_BUY, 1, Ask, 3, 0, 0,"my comment",MagicNumber);
    OrderSend(Symbol(), OP_SELL, 1, Bid, 3, 0, 0,"my comment",MagicNumber);
    DayofTrade = DayOfWeek();
   }   
//----
   return(0);
  }
to trade and code, keep both simple... no call to impress....h
  • #4
  • Jan 9, 2010 9:07am Jan 9, 2010 9:07am
Many thanks Ronald. But exactly like hayseed said, moving the int DayofTrade = -1; to inside the start() function triggers a new set of orders at every tick.


Quoting Ronald Raygun
You initialize DayOfTrade before the start() function. The code doesn't go all the way back to the beginning, it goes back to the start() function.

You need to move the initialization of that variable down to inside the start() function.
  • #5
  • Last Post: Jan 9, 2010 9:13am Jan 9, 2010 9:13am
Thanks hayseed! Problem solved.

Quoting hayseed
hey dogberry..... moving the int DayofTrade = -1; to the start function might have the unpleasant side effect of a new set of orders at every tick.....

perhaps you could use Day() or DayOfWeek() such as below......just a thought......h
0 traders viewing now