Order entry Script with memory? | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Scripts for Limit entry, Stop entry, Market entry 47 replies

Is there EA/Script for "Pending Order" entry and can assign Magic No.? 25 replies

Basic Alt Key/Entry Script - Simplest Script Ever 1 reply

2009.03.11 15:41:15Tester memory handler: tester stopped because not enough memory 19 replies

Order Entry Script 0 replies

Attachments: Order entry Script with memory?
Exit Attachments

Order entry Script with memory?

  • #1
  • First Post: Dec 22, 2009 11:58am Dec 22, 2009 11:58am
I use scripts for all my order entries and have several that work just fine, but it is tedious to have to edit the script every time I want to increase the lot size. Using a script with #property show inputs is also not good as it then takes too long to actually make the entry. I prefer to just drag and drop/ execute it.

In metatrader the standard order entry interface will "remember" the last order size and use it unless changed. What I want to do is to be able to mimic that behavior with a script. Set the order entry size with the normal interface, and then have the script execute it when used.

I have several order entry with money management scripts, but they compound a bit too rapidly.

Hope this makes sense. I am not a programmer and have looked literally everywhere for this.

Is it possible, and is there already one somewhere I have missed?

Thanks In Advance,
Clay
  • #2
  • Dec 22, 2009 12:03pm Dec 22, 2009 12:03pm
Have the script save the last lot size used as a globalvariable
  • #3
  • Dec 22, 2009 11:40pm Dec 22, 2009 11:40pm
Problem is that I'm an ok "hack" and can sometimes figure out how to modify existing code, but I have no idea where to even begin with what you say to do.

God bless,
Clay
  • #4
  • Dec 23, 2009 6:04am Dec 23, 2009 6:04am
Inserted Code
double LastLotSize = 0; //Set the last known lot size to 0
double LotAddOn = 3.14; //This adds to whatever the most recent lot size was

if(GlobalVariableCheck(Symbol()+"LotScript")) //Check if there is a global variable that already has the lot size. If true...
     {
     LastLotSize = GlobalVariableGet(Symbol()+"LotScript")); //Set LastLotSize to whatever value is in the GlobalVariable.
     }

double LastLotSize = LastLotSize + LotAddon; //Add the add on...

int Ticket = OrderSend(); //Place the order...

if(Ticket != -1)
     {
     GlobalVariableSet(Symbol()+"LotScript", LastLotSize); //Set the global variable to the value of the lot size that was used in OrderSend().
     }
  • #5
  • Dec 23, 2009 9:43am Dec 23, 2009 9:43am
Many thanks Ronald. I really appreciate this.

I have a question, why did you include a portion to increase the lotsize? My plans are to use the MM script I already have to set the lotsize based on risk at the beginning of each trading session or perhaps trading week, still working on that part. Then use this script to just execute the exact same lotsize each and every trade until I decide to increase it manually.

I have modified a very simple order entry script I have and hopefully I have done what you suggested. I see one possible issue though, the variable "LostScipt" isn't set anywhere before it's use. Is thas a pre-set variable of some kind?

Please let me know if I missed it somewhere here.

Inserted Code
 
//+------------------------------------------------------------------+
//|                                                                  |
//|      Buy Same Lots Each Time Script                              |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright ""
#property link      ""
#include <stdlib.mqh>
#include <WinUser32.mqh>
//+------------------------------------------------------------------+
//| script to trade same size each time                              |
//+------------------------------------------------------------------+
int start()
  {
//----
 
double LastLotSize = 0; //Set the last known lot size to 0
double LotAddOn = 3.14; //This adds to whatever the most recent lot size was
//----
if(GlobalVariableCheck(Symbol()+"LotScript")) //Check if there is a global variable that already has the lot size. If true...
     {
     LastLotSize = GlobalVariableGet(Symbol()+"LotScript")); //Set LastLotSize to whatever value is in the GlobalVariable.
     }
double LastLotSize = LastLotSize + LotAddon; //Add the add on...
 
if(Ticket != -1)
     {
     GlobalVariableSet(Symbol()+"LotScript", LastLotSize); //Set the global variable to the value of the lot size that was used in OrderSend().
     }
   int ticket=OrderSend(Symbol(),OP_BUY,LastLotSize,Ask,3,Ask-21*Point,0,Null,255,0,Green);
 
     if(ticket<1)
     {
      int error=GetLastError();
      Print("Error = ",ErrorDescription(error));
      return;
     } 
//----
   OrderPrint();
   return(0);
  }
//+------------------------------------------------------------------+
  • #6
  • Dec 23, 2009 10:50am Dec 23, 2009 10:50am
I wasn't sure how you were going to manipulate the lot size, so I showed you where that would happen--if it did.

LotScript is a string, not a variable. I also made an assumption that you will trade different lot sizes for different pairs, so the names of the global variables would be something like "EURUSDLotScript" or "GBPUSDLotScript" for EU and GU respectively.
  • #7
  • Dec 23, 2009 11:15am Dec 23, 2009 11:15am
So to make this "pair agnostic" it works on any pair the code would be "()LotScript" then? Also, do I have the rest of the code correct?

My intent is to use the MM script I have to set the lotsize, or the standard MT Order Interface. Either would work fine for my purposes.

Also, if I am retrieving the last lost size from global memory, then why would I also set that to "0"?
  • #8
  • Dec 23, 2009 11:58am Dec 23, 2009 11:58am

  1. Just take out Symbol()
  2. Your OrderSend is in the wrong place.
  3. If you are simply using some MM function, why do you need lot size history?
  4. You reset the variable, then get the value from globalvariables.

  • #9
  • Dec 23, 2009 12:48pm Dec 23, 2009 12:48pm
Perhaps I explained it all improperly. I an looking to be able to set the trade size one time per session. I can do that with either the standard MT Order interface, or a script I have that calculates the size of the order based on a risk level in the script.

THEN I want to have a single script that executes on any currency, that same exact order size. Then I will adjust the SL basedo on the currency and the volatility, etc.

I have modified the code again to elminate the incrementing function and moved the order send function. Hope I have it right now.


Inserted Code
//+------------------------------------------------------------------+
//|                                                                                             |
//|      Buy Same Lots Each Time Script                                            |
//|                                                                                             |
//+------------------------------------------------------------------+
#property copyright ""
#property link      ""
#include <stdlib.mqh>
#include <WinUser32.mqh>
//+------------------------------------------------------------------+
//| script to trade same size each time                              |
//+------------------------------------------------------------------+
int start()
  {
//----
 
double LastLotSize = 0; //Set the last known lot size to 0
 
//----
if(GlobalVariableCheck(Symbol()+"LotScript")) //Check if there is a global variable that already has the lot size. If true...
     {
     LastLotSize = GlobalVariableGet(Symbol()+"LotScript")); //Set LastLotSize to whatever value is in the GlobalVariable.
     }
   int ticket=OrderSend(Symbol(),OP_BUY,LastLotSize,Ask,3,Ask-21*Point,0,Null,255,0,Green);
 
if(Ticket != -1)
     {
     GlobalVariableSet(Symbol()+"LotScript", LastLotSize); //Set the global variable to the value of the lot size that was used in OrderSend().
     }
     if(ticket<1)
     {
      int error=GetLastError();
      Print("Error = ",ErrorDescription(error));
      return;
     } 
//----
   OrderPrint();
   return(0);
  }
//+------------------------------------------------------------------+

Thanks again for the help and input. Truly apprecaited.
  • #10
  • Dec 23, 2009 1:19pm Dec 23, 2009 1:19pm
Hmm.... if you want the last lot size used....



Inserted Code
double LastLot = 0;
datetime RecentTrade = 0;
int Totals = OrdersTotal():

for (int T = Totals; T > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_TRADES);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}

int HTotals = OrderHistoryTotals();

for (int HT = HTotals; HT > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_HISTORY);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}

Comment("Last Lot Size Used: ", LastLot);
  • #11
  • Dec 23, 2009 1:40pm Dec 23, 2009 1:40pm
Ok,,, I'm effectively totally lost now. I apologize for my ingorance of MQL, but I am not a programmer by any stretch of the imagination.

Where in the script would I put all that, or would it be easier for you to make the changes and let me see so I can understand a bit better.

By the way, I know this is taking up a bunch of your time and I appreciate it and I also understand if you don't want to go any further on this.
  • #12
  • Dec 23, 2009 1:47pm Dec 23, 2009 1:47pm
I originally thought you were only using the script to place trades, I didn't realize the script was working along side other trades.


This new script does the following:

 

  1. Scans through all open and historic trades.
  2. Finds most recent trade.
  3. Gets lot size.

You can then put the ordersend after that script.

  • #13
  • Dec 23, 2009 2:13pm Dec 23, 2009 2:13pm
Sounds great Ronald, I'll mod the script a bit and test it out. Then if I have an error or something I'll come back and ask more questions.

'Til then, thank you so very much.

God bless,
Clay
  • #14
  • Dec 23, 2009 2:35pm Dec 23, 2009 2:35pm
No Idea what I did wrong, but it threw 27 errors when I compiled the script.

Here is what I have.

Inserted Code
//+------------------------------------------------------------------+
//|                                                                  |
//|      Buy Same Lots Each Time Script                              |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright ""
#property link      ""
#include <stdlib.mqh>
#include <WinUser32.mqh>
//+------------------------------------------------------------------+
//| script to trade same size each time                              |
//+------------------------------------------------------------------+
int start()
  {
//----
double LastLot = 0;
datetime RecentTrade = 0;
int Totals = OrdersTotal():
for (int T = Totals; T > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_TRADES);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
int HTotals = OrderHistoryTotals();
for (int HT = HTotals; HT > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_HISTORY);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
Comment("Last Lot Size Used: ", LastLot);
//----
   int ticket=OrderSend(Symbol(),OP_BUY,LastLotSize,Ask,3,Ask-21*Point,0,Null,255,0,Green);
   
if(Ticket != -1)
     {
     GlobalVariableSet(Symbol()+"LotScript", LastLotSize); //Set the global variable to the value of the lot size that was used in OrderSend().
     }
     if(ticket<1)
     {
      int error=GetLastError();
      Print("Error = ",ErrorDescription(error));
      return;
     } 
//----
   OrderPrint();
   return(0);
  }
//+------------------------------------------------------------------+

And attached is a screen shot of the errors.
Attached Image (click to enlarge)
Click to Enlarge Name: 2009-12-23_132605.jpg Size: 276 KB
  • #15
  • Dec 23, 2009 2:45pm Dec 23, 2009 2:45pm
Ok,, I was able to diagnose a few of them. The ones that are left are all having to do with unbalanced parenthesis and the "T" variable not being defined.

Image of those attached.
Attached Image (click to enlarge)
Click to Enlarge Name: 2009-12-23_134511.jpg Size: 216 KB
  • #16
  • Dec 26, 2009 3:02pm Dec 26, 2009 3:02pm
Been playing with this some more. Seems the whole issue is this "variable T not defined" thing. When I throw in something to try to define it (above the first "for" statement) all the unbalanced parenthesis errors evaporate, but I still get ONE error about T not being defined. Not sure what more to do.

Here is the last code I have. Could you perhaps make a suggestion?

Thanks in advance Ronald.

Inserted Code
//+------------------------------------------------------------------+
//|                                                                  |
//|      Buy Same Lots Each Time Script                              |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright ""
#property link      ""
#include <stdlib.mqh>
#include <WinUser32.mqh>
//+------------------------------------------------------------------+
//| script to trade same size each time                              |
//+------------------------------------------------------------------+
int start()
  {
//----
double LastLot = 0;
datetime RecentTrade = 0;
int Totals = OrdersTotal():
for (int T = Totals; T > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_TRADES);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
int HTotals = OrderHistoryTotals();
for (int HT = HTotals; HT > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_HISTORY);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
Comment("Last Lot Size Used: ", LastLot);
//----
   int ticket=OrderSend(Symbol(),OP_BUY,LastLot,Ask,3,Ask-21*Point,0,"",255,0,Green);
 
if(ticket != -1)
     {
     GlobalVariableSet(Symbol()+"LotScript", LastLot); //Set the global variable to the value of the lot size that was used in OrderSend().
     }
     if(ticket<1)
     {
      int error=GetLastError();
      Print("Error = ",ErrorDescription(error));
      return;
     } 
//----
   OrderPrint();
   return(0);
  }
//+------------------------------------------------------------------+
  • #17
  • Dec 26, 2009 4:10pm Dec 26, 2009 4:10pm
hey clay..... if you hit f3 it should bring up your global variables.... then if you add one, eclaylots for example, you can later call it in your scripts....

might be simplier than orderselect route..... just a thought......h

Inserted Code
 
int start()
  {
 
   double lots = GlobalVariableGet("eclaylots");
//----
   int ticket = OrderSend(Symbol(),OP_BUY,lots,Ask,3,0,0,"global lots",255,0,CLR_NONE);
   return(0);
  }
Attached Image (click to enlarge)
Click to Enlarge Name: eclay.jpg Size: 145 KB
to trade and code, keep both simple... no call to impress....h
  • #18
  • Dec 26, 2009 5:47pm Dec 26, 2009 5:47pm
Note changes in bold.

The historical trades loop was using the value of the open trade loop.

Inserted Code
//+------------------------------------------------------------------+
//|                                                                  |
//|      Buy Same Lots Each Time Script                              |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright ""
#property link      ""
#include <stdlib.mqh>
#include <WinUser32.mqh>
//+------------------------------------------------------------------+
//| script to trade same size each time                              |
//+------------------------------------------------------------------+
int start()
  {
//----
double LastLot = 0;
datetime RecentTrade = 0;
int Totals = OrdersTotal():
for (int T = Totals; T > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_TRADES);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
int HTotals = OrderHistoryTotals();
for (int HT = HTotals; HT > 0; [b]HT[/b]--)
{
OrderSelect([b]HT[/b], SELECT_BY_POS, MODE_HISTORY);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
Comment("Last Lot Size Used: ", LastLot);
//----
   int ticket=OrderSend(Symbol(),OP_BUY,LastLot,Ask,3,Ask-21*Point,0,"",255,0,Green);
 
if(ticket != -1)
     {
     GlobalVariableSet(Symbol()+"LotScript", LastLot); //Set the global variable to the value of the lot size that was used in OrderSend().
     }
     if(ticket<1)
     {
      int error=GetLastError();
      Print("Error = ",ErrorDescription(error));
      return;
     } 
//----
   OrderPrint();
   return(0);
  }
//+------------------------------------------------------------------+
  • #19
  • Dec 27, 2009 1:45am Dec 27, 2009 1:45am
Thanks guys, I'll give both solutions a try and see what happens. Will get back to you with the results.

God bless,
Clay
  • #20
  • Dec 27, 2009 5:26pm Dec 27, 2009 5:26pm
OK,, I got this script from Ronald to finally quit throwing errors.

There were a couple of ":" where it seems there should have been ";" and "OrderHistoryTotals" should have been "OrdersHistoryTotal" with the "s" moved to "Orders" from "Totals".

But now, even without errors, it doesn't execute an order for some reason.

Hayseed, I haven't tried your option yet, but the issue there would be that I would need a script to allow that variable to be set and the number to also be set by the script.

The reason for that is that I want this to be as "point and click" as possible for those who know absolutely nothing about programming to be able to use it.

While I am trying to get this to work for me, I'm sure others may want to use it once finished.

So, I will try to write a simple script to set that global variable, then modify my Sell and Buy "normal" scripts to access and use it.

Again, guys, I really, really appreciate this effort on your part to help me.

Ronald, here is the modified code that no longer throws errors. Can you see a reason why it's not executing an order?

Inserted Code
//+------------------------------------------------------------------+
//| script to trade same size each time                              |
//+------------------------------------------------------------------+
int start()
  {
//----
double LastLot = 0;
datetime RecentTrade = 0;
int Totals = OrdersTotal();
for (int T = Totals; T > 0; T--)
{
OrderSelect(T, SELECT_BY_POS, MODE_TRADES);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
int HTotals = OrdersHistoryTotal();
for (int HT = HTotals; HT > 0; HT--)
{
OrderSelect(HT, SELECT_BY_POS, MODE_HISTORY);
if(OrderOpenTime() > RecentTrade)
 {
 LastLot = OrderLots();
 RecentTrade = OrderOpenTime();
 }
}
Comment("Last Lot Size Used: ", LastLot);
//----
   int ticket=OrderSend(Symbol(),OP_BUY,LastLot,Ask,3,Ask-21*Point,0,"",255,0,Green);
 
if(ticket != -1)
     {
     GlobalVariableSet(Symbol()+"LotScript", LastLot); //Set the global variable to the value of the lot size that was used in OrderSend().
     }
     if(ticket<1)
     {
      int error=GetLastError();
      Print("Error = ",ErrorDescription(error));
      return;
     } 
//----
   OrderPrint();
   return(0);
  }
//+------------------------------------------------------------------+__________________
0 traders viewing now