Why is this indicator wacky

Can anyone tell me why this indicator-http://cdn.forexfactory.com/images/attach/mq4.gif i-Breakeven.mq4 works fine on the Interbank FX (IBFX) platform but shows wacky calculations on the FXsolutions Australia platform? Is it because one platform uses 4 digits and the other 5? If so, what would I change in the code to get it to work for a 4 digit platform? thanks

I am 99% sure that you are right, but of course there may be more than one thing wrong. To fix, just look for the places that convert pips to points and vice versa and multiply or divide by 10 or 1. Here is what I like to use to determine what the broker is using.

pips = MarketInfo(Symbol(), MODE_TICKSIZE);
if (Digits < 4) pf = (0.01/pips); // 10 or 1

if (Digits > 3) pf = (0.0001/pips); // 10 or 1

This is the only thing I can find in the code that looks like what you're talking about. Do you see anything here I should change? thanks.
double sum = 0;
string level0 = "";

size = ArraySize(Sym);
for (i=0; i<size; i++)
{
if (Lots[i] == 0) {
level0 = "Lock";
}
else {
int dig = MarketInfo(Sym[i], MODE_DIGITS);
double point = MarketInfo(Sym[i], MODE_POINT);

double COP = Lots[i]*MarketInfo(Sym[i], MODE_TICKVALUE);
double val = MarketInfo(Sym[i], MODE_BID) - point*Equity[i]/COP;
level0 = DoubleToStr(val, dig);
}

Here is the entire code. Again, this indicator works fine on the( IBFX) platform which is 5 digits but doesn't work on the FXSolutions Australia platform which is 4 digits. Any help would really be appreciated. thank you #property copyright " 2007 RickD"
#property link "www.e2e-fx.net"

#define major 1
#define minor 0

#property indicator_chart_window
#property indicator_buffers 0

extern int Corner = 0;
extern int dy = 20;

extern color _Header = OrangeRed;
extern color _Text = RoyalBlue;
extern color _Data = CadetBlue;
extern color _Separator = MediumPurple;



string prefix = "capital_";

void init()
{
Comment("");
clear();
}

void deinit()
{
Comment("");
clear();
}

void clear()
{
string name;
int obj_total = ObjectsTotal();
for (int i=obj_total-1; i>=0; i--)
{
name = ObjectName(i);
if (StringFind(name, prefix) == 0) ObjectDelete(name);
}
}

void start()
{
clear();

string Sym[];
double Equity[];
double Lots[];
ArrayResize(Sym, 0);
ArrayResize(Equity, 0);
ArrayResize(Lots, 0);

int cnt = OrdersTotal();
for (int i=0; i<cnt; i++)
{
if (!OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) continue;

int type = OrderType();
if (type != OP_BUY && type != OP_SELL) continue;

bool found = false;

int size = ArraySize(Sym);
for (int k=0; k<size; k++)
{
if (Sym[k] == OrderSymbol()) {
Equity[k] += OrderProfit() + OrderCommission() + OrderSwap();
if (type == OP_BUY) Lots[k] += OrderLots();
if (type == OP_SELL) Lots[k] -= OrderLots();
found = true;
break;
}
}

if (found) continue;

int ind = ArraySize(Sym);
ArrayResize(Sym, ind+1);
Sym[ind] = OrderSymbol();

ArrayResize(Equity, ind+1);
Equity[ind] = OrderProfit() + OrderCommission() + OrderSwap();

ArrayResize(Lots, ind+1);
if (type == OP_BUY) Lots[k] = OrderLots();
if (type == OP_SELL) Lots[k] = -OrderLots();
}

//-----
string name = prefix + "symbols";
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 30);
ObjectSet(name, OBJPROP_YDISTANCE, 35);
ObjectSetText(name, "Symbol", 10, "Tahoma", _Header);
ObjectSet(name, OBJPROP_CORNER, Corner);


name = prefix + "equity";
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 130);
ObjectSet(name, OBJPROP_YDISTANCE, 35);
ObjectSetText(name, "Equity", 10, "Tahoma", _Header);
ObjectSet(name, OBJPROP_CORNER, Corner);


name = prefix + "breakeven";
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 220);
ObjectSet(name, OBJPROP_YDISTANCE, 35);
ObjectSetText(name, "Breakeven", 10, "Tahoma", _Header);
ObjectSet(name, OBJPROP_CORNER, Corner);


name = prefix + "tmp1";
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 20);
ObjectSet(name, OBJPROP_YDISTANCE, 35+dy);
ObjectSetText(name, "-----------------------------------------------------",
10, "Tahoma", _Separator);
ObjectSet(name, OBJPROP_CORNER, Corner);



double sum = 0;
string level0 = "";

size = ArraySize(Sym);
for (i=0; i<size; i++)
{
if (Lots[i] == 0) {
level0 = "Lock";
}
else {
int dig = MarketInfo(Sym[i], MODE_DIGITS);
double point = MarketInfo(Sym[i], MODE_POINT);

double COP = Lots[i]*MarketInfo(Sym[i], MODE_TICKVALUE);
double val = MarketInfo(Sym[i], MODE_BID) - point*Equity[i]/COP;
level0 = DoubleToStr(val, dig);
}


name = prefix + "symbol"+i;
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0); ObjectSet(name, OBJPROP_XDISTANCE, 30);
ObjectSet(name, OBJPROP_YDISTANCE, 35+dy*(i+2));
ObjectSetText(name, Sym[i], 10, "Tahoma", _Text);
ObjectSet(name, OBJPROP_CORNER, Corner);


name = prefix + "equity"+i;
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 120);
ObjectSet(name, OBJPROP_YDISTANCE, 35+dy*(i+2));

string eq = DoubleToStr(Equity[i], 2);
if (Equity[i] > 0) eq = "+" + eq;
eq = "$" + eq;

ObjectSetText(name, eq, 10, "Tahoma", _Data);
ObjectSet(name, OBJPROP_CORNER, Corner);


name = prefix + "breakeven"+i;
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 230);
ObjectSet(name, OBJPROP_YDISTANCE, 35+dy*(i+2));
ObjectSetText(name, level0, 10, "Tahoma", _Data);
ObjectSet(name, OBJPROP_CORNER, Corner);


sum += Equity[i];
}


name = prefix + "tmp2";
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 20);
ObjectSet(name, OBJPROP_YDISTANCE, 35+dy*(i+2));
ObjectSetText(name, "-----------------------------------------------------",
10, "Tahoma", _Separator);
ObjectSet(name, OBJPROP_CORNER, Corner);


name = prefix + "total";
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 30);
ObjectSet(name, OBJPROP_YDISTANCE, 35+dy*(i+3));
ObjectSetText(name, "Total", 10, "Tahoma", _Text);
ObjectSet(name, OBJPROP_CORNER, Corner);


name = prefix + "equity_total";
if (ObjectFind(name) == -1) {
ObjectCreate(name, OBJ_LABEL, 0, 0, 0);
}

ObjectSet(name, OBJPROP_XDISTANCE, 120);
ObjectSet(name, OBJPROP_YDISTANCE, 35+dy*(i+3));eq = DoubleToStr(sum, 2);
if (Equity[i] > 0) eq = "+" + eq;
eq = "$" + eq;

ObjectSetText(name, eq, 10, "Tahoma", _Data);
ObjectSet(name, OBJPROP_CORNER, Corner);

This indicator worked fine on my 4 digit broker FXDD, but I obviously didn't stress test it, so you might have found something I didn't. This is the part of the code that is affected by 4/5 digit and looks alright. There is another possibility. Some brokers aren't consistent in setting MarketInfo values properly. I haven't seen it with these ones, but I have with STOPLEVEL and SPREAD. You need to verify that the values are non zero and make sense.

I just spoke to FXSolutions Australia and they said the yen pairs on their platform are 2 digits and the rest of the pairs are 4. Does that shed any light on the subject? thanks

That is normal for 4 digit brokers. I forgot to ask does this problem appear for most pairs or just a few?

The problem appears on all pairs. This is how it looks on my chart.

When you get into situations like this, you sometimes have to use a process of elimination. The screen shot shows that this line is OK because the breakeven amounts are 2 and 4 digits.

int dig = MarketInfo(Sym[i], MODE_DIGITS);

So that leaves these lines. We know the value Equity[i] is OK and Lots[i] is probably OK as well. Shouldn't take much to find out what is wrong.

double point = MarketInfo(Sym[i], MODE_POINT);
double COP = Lots[i]*MarketInfo(Sym[i], MODE_TICKVALUE);
double val = MarketInfo(Sym[i], MODE_BID) - point*Equity[i]/COP;


Good luck and Merry Christmas

Will bump this up again. Are there any programmers out there who can help with this problem? I have no programming skills so I really need someone to show me exactly what changes I would have to make to the code in post #4. thank you

Hi,
this indicator works on other platforms, so it's not the problem of the indicator but the problem of their MT4 platform which gives incorrect MarketInfo values (at least MODE_TICKVALUE). Eg. for EURUSD it should be 10 (10$ per 1 pip), for EURJPY - 10.9266 etc. On FX Sol Au it's 0.0001 or 0.01 which is of course incorrect. So I think that you should first email their support and ask them to correct it.