Please help, where is my error? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

mt4 error - newb help please 20 replies

Please help with this EA - Ordersend error 130 11 replies

BuyStop SellStop Order error, please help! 8 replies

OrderModify error 1 HELP PLEASE 5 replies

Help please with compilation error 2 replies

Attachments: Please help, where is my error?
Exit Attachments

Please help, where is my error?

  • #1
  • First Post: Dec 14, 2009 3:22am Dec 14, 2009 3:22am
I have been trying literally forages to add an alert the the bat atr v2 indi, without success, I keep on being flooded by email, even when no cross occurs.
PLEASE, if anybody could help me out, I would be very grateful.
Thanks in advance,
Wendy
Attached File(s)
File Type: mq4 BAT ATR v2 Alert.mq4   5 KB | 329 downloads
  • #2
  • Dec 14, 2009 4:08pm Dec 14, 2009 4:08pm
anyone, please?
I have absolutely no programming experience, I'm sure it is just a matter of minutes for any of you guys....you would really help me out. Staying in front of a screen 24/5 is not very nice.
Wendy
  • #3
  • Dec 14, 2009 11:35pm Dec 14, 2009 11:35pm
Quoting wvehoven
I keep on being flooded by email, even when no cross occurs.
I think the problem is that the SendMail() statements are sitting inside the main loop, which means they're potentially being tested against every historical candle on the chart. Hence, in the worst case, an alert will activate once per historical crossover. The limit variable restricts the number of candles that are tested/plotted on each new tick, but my understanding is that the IndicatorCounted() function gets reset every time the chart is refreshed, e.g. by toggling timeframes, editing the indicator parameters, re-attaching the indicator.

Also, I note that the EmailON parameter is not being used in the main part of the code.

I am working on a solution for you, and will post it when it's complete. Please be patient, as it will take me a while to test it fully. This is largely because (1) crossovers occur rarely, even on a M1 chart, and (2) I don't currently have the MT4 e-mail facilities set up.
  • #4
  • Dec 14, 2009 11:56pm Dec 14, 2009 11:56pm
hi wendy,

it seems your code contains too many variable and there is an access to a future value (High[i-1], Low[i-1]). instead of make some mods to you code, i modified my atr stop indicator and adding alert/sendmail feature.

hope this help,

stephen
Attached File(s)
File Type: mq4 ATR Stop Alert.mq4   2 KB | 369 downloads
  • #5
  • Dec 15, 2009 1:20am Dec 15, 2009 1:20am
Quoting hanover
I think the problem is that the SendMail() statements are sitting inside the main loop, which means they're potentially being tested against every historical candle on the chart. Hence, in the worst case, an alert will activate once per historical crossover. The limit variable restricts the number of candles that are tested/plotted on each new tick, but my understanding is that the IndicatorCounted() function gets reset every time the chart is refreshed, e.g. by toggling timeframes, editing the indicator parameters, re-attaching...
No rush. I am very grateful you are trying to help, looks like SantaClaus has put me into his "good girls" list this year!
Seriously, thank you. If you want to see more crossovers change the parameters 5 and 4 into 2 and 1, on a m1 chart that should do the trick for testing purposes.
Wendy
  • #6
  • Dec 15, 2009 1:31am Dec 15, 2009 1:31am
Quoting sangmane
hi wendy,

it seems your code contains too many variable and there is an access to a future value (High[i-1], Low[i-1]). instead of make some mods to you code, i modified my atr stop indicator and adding alert/sendmail feature.

hope this help,

stephen
I just took a quick look at the code and the functionality seems to be the same. I am definitely going to test it out today, I can't thank you enough!
  • #7
  • Dec 15, 2009 10:38am Dec 15, 2009 10:38am
Hi Wendy,

Please try the attached fix.

It should alert whenever the most recently completed candle crosses the BAT line, immediately the first tick of the newly forming candle occurs. I assume that this is what you require.

ChartAlerts = TRUE will generate MT4's standard audio/visual alert on your chart.

EmailAlerts = TRUE should generate an e-mail. I haven't been able to test this, but the logic is exactly the same as for the Chart Alert.

I've been around this forum way too long. I can remember when the original BAT strategy was released by Team Aphid. There's some interesting discussion in that link (if you haven't already seen it).

Good luck,
David
Attached File(s)
File Type: mq4 BAT ATR v2 Alert.mq4   5 KB | 338 downloads
  • #8
  • Dec 16, 2009 5:58am Dec 16, 2009 5:58am
Hi David,


I thank you very much for your help.


I did read on the entire BAT thread and was impressed, but used on an hourly chart SL could get very wide, and knowing myself I would not resist and bail out.

Instead I discovered that using a very similar strategy but on 15min charts, using awesome as an additional filter, SL would be quite small and the winning percentage truely high, I am talking about 85-90%. after reaching 161.8 I put my Sl at breakeven (or close half position and remainders at breakeven). Awesome divergence is also a good way to determine exit, among others, as following the bat lines itself does leave some pips on the table.

If you're interested try and take a look with these indi's on the chart, it has become my main trading technique for some time now. I tried to post in the BAT thread but couldn't get much interest from there. It truely is a shame.

Anyways, THANKS!






Quoting hanover
Hi Wendy,

Please try the attached fix.

It should alert whenever the most recently completed candle crosses the BAT line, immediately the first tick of the newly forming candle occurs. I assume that this is what you require.

ChartAlerts = TRUE will generate MT4's standard audio/visual alert on your chart.

EmailAlerts = TRUE should generate an e-mail. I haven't been able to test this, but the logic is exactly the same as for the Chart Alert.

I've been around this forum way too long. I can remember when the [url="http://www.forexfactory.com/showthread.php?t=12808"]original...
  • #9
  • Dec 16, 2009 5:38pm Dec 16, 2009 5:38pm
Quoting wvehoven
Hi David,

I thank you very much for your help.......
Hi Wendy, you're welcome.

Just curious, a few quick questions:

1) What settings do you use for BAT? Are they ATR=5, Factor=4?

2) Do you take the 'full monty' trades, when price retraces to the 61.8 and 38.2, as described by Team Aphid?

3) How do you use AO in connection with the entries? e.g. for a long entry, do you delay entry further until AO turns green, or until it crosses the zero point? Or if AO is 'wrong' (color, or side of zero point) at the time the BAT line is hit, do you skip the trade altogether?

4) You say your SLs are tight, but Factor=4 delays entry quite late, i.e. a significant distance from the previous swing high/low. Where do you set your initial SL?

5) Do you have a preference for any particular currency pairs, using this method?

Thanks,
David
  • #10
  • Dec 18, 2009 6:37am Dec 18, 2009 6:37am
1. 5 and 4, absolutely yes.
2. Distance between recent hgh and low may not always justify full monty trades(they might just be 4 or 5 pips apart and therefore not so usefull). If the distance is at more than 30 pips from original entry point I do take them, mostly the 38.2 fib. I did backtested with all full monty entries and it resulted positive, but manually it is difficult to follow up.

3. AO has to be at 0 or crossed to the right direction. If it is already negative, (for a short trade for example), I only take the entry if the AO is still at very low values and just turned red after some green bars. This should mean price has retraced a bit but resumes short direction. IF AO does not confirm, i do not enter. If Ao confirms within the next 4-5 bars i only enter if price has not moved more than 15pips away from original entry point.

4. I use the ATR lines as my stop or recent high/low +10 pips, whichever is less. 50 pips or so is not a high SL in my opinion, and following the ATR I have NEVER lost more than that.

5: GBP, AUD, EURJPY and EURGBP.
GBPJPY gives great returns but is tricky, she is the one that could hit even a 100 pip Sl in 10 minutes time so i avoid her, sigh.

Cheers



Quoting hanover
Hi Wendy, you're welcome.

Just curious, a few quick questions:

1) What settings do you use for BAT? Are they ATR=5, Factor=4?

2) Do you take the 'full monty' trades, when price retraces to the 61.8 and 38.2, as described by Team Aphid?

3) How do you use AO in connection with the entries? e.g. for a long entry, do you delay entry further until AO turns green, or until it crosses the zero point? Or if AO is 'wrong' (color, or side of zero point) at the time the BAT line is hit, do you skip the trade altogether?

4) You say your SLs are tight,...
  • #11
  • Last Post: Dec 18, 2009 12:54pm Dec 18, 2009 12:54pm
Wendy, many thanks for this info.

Wishing you and yours a Merry Xmas, and many pips in 2010,

David
0 traders viewing now