how to code this | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

indicator code to inside EA code 15 replies

Help - any tools that can easily convert MQL4 code to Easy Language code? 7 replies

Translating some code into Pseudo code for a laymen? 3 replies

Hidden Code in Code 12 replies

Custom backtesting code 9 replies

Attachments: how to code this
Exit Attachments

how to code this

  • #1
  • First Post: Dec 11, 2009 7:40pm Dec 11, 2009 7:40pm
Hi All,

I am trying to code recognition of a situation where I am on a 15 minute chart but I want to look back at the open or close of last 3, 4hr bars depending on which way it closed.

I am trying to define the candle situation in the picture at the redline on the first set of bars as an altert but I cant think of how to do it without a bunch of code that seems way excessive.

Anyone with any ideas, would be great

cheers
Attached Image (click to enlarge)
Click to Enlarge Name: bottom.gif Size: 10 KB
  • #2
  • Dec 11, 2009 9:44pm Dec 11, 2009 9:44pm
I'm not real sure I understand your question, but I will take a chance.

I think you want to identify a pattern of bars. I have done this a number of times for things like a 2 bar reversal and an inside bar. I always start with a simple bar description such as a down or up bar (close > open). Then, I usually want to eliminate some of these; for instance short bars or those with long wicks.

Once I have the necessary bars described, I combine them (ie. down bar followed by up bar). The code is usually very small and easy to understand because I build the complexity from simple pieces.

If I have misunderstood your question, sorry for wasting your time.
  • #3
  • Dec 11, 2009 10:27pm Dec 11, 2009 10:27pm
see help:
double iClose(string symbol, int timeframe, int shift)

also use iTime or another method to get correct shift.
  • #4
  • Edited 3:02am Dec 12, 2009 2:09am | Edited 3:02am
Quoting CodeMeister
I'm not real sure I understand your question, but I will take a chance.

I think you want to identify a pattern of bars. I have done this a number of times for things like a 2 bar reversal and an inside bar
Hi CodeMeister,

The point to the pattern is that all of the bottoms are the same whether it is an open or a close for the particular bar. The lows all the same also, although they are much easier to code, for me anyway.

This is the ugly code I have and I have no clue how to make it better so I was looking for ideas from people with more clues than I have.

Inserted Code
 
  bool   Market4High =       (iHigh(NULL,240,iHighest(NULL,240, MODE_HIGH,20,2)) < iHigh(NULL,PERIOD_H4,1));
  bool   Bar4Bear =          (iOpen(NULL,PERIOD_H4,1) >= iClose(NULL,PERIOD_H4,1));
  bool   Bar4Bull =          (iClose(NULL,PERIOD_H4,1)>= iOpen(NULL,PERIOD_H4,1));

if (MarketHigh && type== OP_BUY)
 {
if (Bar4Bear && (MathAbs(iClose(NULL,PERIOD_H4,2) - iOpen(NULL,PERIOD_H4,3)) < 3*Point && iClose(NULL,PERIOD_H4,1) - iOpen(NULL,PERIOD_H4,3) < 3*Point)) MayOpenOrder=false;
if (Bar4Bull && (MathAbs(iOpen(NULL,PERIOD_H4,2) - iClose(NULL,PERIOD_H4,3)) < 3*Point && iOpen(NULL,PERIOD_H4,1) - iClose(NULL,PERIOD_H4,3) < 3*Point)) MayOpenOrder=false;
 }
I guess if no one can think of a better way, then this will just have to do. Thanks so much for your help
  • #5
  • Dec 12, 2009 5:17pm Dec 12, 2009 5:17pm
Quoting asgard2
Hi CodeMeister,

The point to the pattern is that all of the bottoms are the same whether it is an open or a close for the particular bar. The lows all the same also, although they are much easier to code, for me anyway.

This is the ugly code I have and I have no clue how to make it better so I was looking for ideas from people with more clues than I have.


I guess if no one can think of a better way, then this will just have to do. Thanks so much for your help
I think your approach is good. I didn't check your code for correctness as that takes a lot of testing. I like the use of the Bool variables Bar4bear and Market4High because they are simple and understandable. My only suggestion is take that idea further and define others so that the clauses in the if (MarketHigh && type== OP_BUY) block are simpler.

Simple is good and not ugly.
  • #6
  • Last Post: Dec 13, 2009 6:50am Dec 13, 2009 6:50am
use MTF indicators , that's what you really want, you see the higher time frame in a lower time frame , google it , if didn't find i have it in my indicators , i have to look for it , i'm really lazy , you don't be like me
0 traders viewing now