Can someone please help me with this code . . . .

Hi Guys,

Can someone please help me with this.

When the condition is met for the Alert to popup it keeps on popping up every few seconds for the period of the bar. I run this on one hour charts but it keeps on forcing the alert window to pop up.

Also, if I can stop it popping up (so I am only notified once) does the alert reset so if it is triggered in 3 bars time if the condition is true again.

If anyone is able to help I would appreciate it.

Regards
Steve



//+------------------------------------------------------------------+
//| My_First_Indicator.mq4 |
//| http://www.forex-tsd.com |
//+------------------------------------------------------------------+
#property copyright "Steve Dawson"
#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Red
#property indicator_color2 Green
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
bool buf_alert_already_triggered;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0,DRAW_HISTOGRAM,EMPTY,3);
SetIndexBuffer(0,ExtMapBuffer1);
SetIndexStyle(1,DRAW_HISTOGRAM,EMPTY,3);
SetIndexBuffer(1,ExtMapBuffer2);
string short_name = "MAX - OBOS Histogram with Alerts!";
IndicatorShortName(short_name);
return(1);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();
//---- check for possible errors
if (counted_bars<0) return(-1);
//---- last counted bar will be recounted
if (counted_bars>0) counted_bars--;
int pos=Bars-counted_bars;
double dVal , dLow , dResult,value;
Comment("Hi! I'm here on the main chart windows!");
//---- main calculation loop to load the ArrayBsearch
while(pos>=0)
{
dVal = iCustom(NULL,0,"J_TPO",13,0,pos);
if (dVal > 0)
{
dResult = 1;
}
else
{
dResult = -1;
}

//This is where the color is Set
if (dResult == 1)
{
ExtMapBuffer2[pos]= dResult;
}
else
{
ExtMapBuffer1[pos]= dResult;
}



//ExtMapBuffer1[pos]= dResult ;
pos = pos - 1;
}
//---- buffer is now loaded

// Do the alert thing now
if ((((ExtMapBuffer1[0] == 1) || (ExtMapBuffer2[0] == 1)) && ((ExtMapBuffer1[1] == -1) || (ExtMapBuffer2[1] == -1))) && (buf_alert_already_triggered == 0 ))
{
Alert("Possible BUY for ", Symbol(), " on ", Period(), " chart!");
buf_alert_already_triggered = 1;
} else
{
buf_alert_already_triggered = 0;
}

if ((((ExtMapBuffer1[0] == -1) || (ExtMapBuffer2[0] == -1)) && ((ExtMapBuffer1[1] == 1)) || (ExtMapBuffer2[1] == 1))&& (buf_alert_already_triggered == 0 ))
{
Alert("Possible SELL for ", Symbol(), " on ", Period(), " chart!");
buf_alert_already_triggered = 1;
} else
{
buf_alert_already_triggered = 0;
}
//----
return(0);
}
//+------------------------------------------------------------------+

this part is setting it back to 0

} else
{
buf_alert_already_triggered = 0;
}

youl need to change that

Thanks Tom it works great now.

One more question if you don't mind. If in say 10 bars the alert is supposed to be triggered again what will happen? Does the variable get reset on the next bar or does the alert not work again until I restart the platform?

Thanks
Steve

youl need some way of setting it back to 0

#property indicator_chart_window
#property indicator_buffers 8
#property indicator_color1 Magenta
#property indicator_color2 Aqua
#property indicator_color3 Magenta
#property indicator_color4 Aqua
#property indicator_color5 Magenta
#property indicator_color6 Aqua
#property indicator_color7 Magenta
#property indicator_color8 Aqua

//---- input parameters
extern double stoch_period=9;
extern double stoch_max=53;
extern double stoch_min=47;
extern double atr_current_norm_factor=0.435;
extern double atr_before_norm_factor=1.5;
extern double atr_period=7;
extern int atr_before_step=1;
extern int NumBars=10000; //If you want to display ALL indicator values, set this to 0 - will use more memory of cause

//---- buffers
double sell_stop_dot_buf[];
double buy_stop_dot_buf[];
double sell_stop_line_buf[];
double buy_stop_line_buf[];
double sell_signal_buf[];
double buy_signal_buf[];
double down_buf[];
double up_buf[];

int init()
{ SetIndexStyle(0,DRAW_ARROW);
SetIndexArrow(0,115);
SetIndexBuffer(0,sell_stop_dot_buf);
SetIndexLabel(0,"sell_stop_dot");
SetIndexEmptyValue(0, EMPTY_VALUE);
SetIndexStyle(1,DRAW_ARROW);
SetIndexArrow(1,115);
SetIndexBuffer(1,buy_stop_dot_buf);
SetIndexLabel(1,"buy_stop_dot");
SetIndexEmptyValue(1, EMPTY_VALUE);
SetIndexStyle(2,DRAW_LINE);
SetIndexBuffer(2,sell_stop_line_buf);
SetIndexLabel(2,"sell_stop_line");
SetIndexEmptyValue(2, EMPTY_VALUE);
SetIndexStyle(3,DRAW_LINE);
SetIndexBuffer(3,buy_stop_line_buf);
SetIndexLabel(3,"buy_stop_line");
SetIndexEmptyValue(3, EMPTY_VALUE);
SetIndexStyle(4,DRAW_ARROW);
SetIndexArrow(4,108);
SetIndexBuffer(4,sell_signal_buf);
SetIndexLabel(4,"sell_signal");
SetIndexEmptyValue(4, EMPTY_VALUE);
SetIndexStyle(5,DRAW_ARROW);
SetIndexArrow(5,108);
SetIndexBuffer(5,buy_signal_buf);
SetIndexLabel(5,"buy_signal");
SetIndexEmptyValue(5, EMPTY_VALUE);
SetIndexStyle(6,DRAW_HISTOGRAM);
SetIndexBuffer(6,down_buf);
SetIndexLabel(6,"down_trend");
SetIndexStyle(7,DRAW_HISTOGRAM);
SetIndexBuffer(7,up_buf);
SetIndexLabel(7,"up_trend");
}

int start()
{ double stoch_current,
atr_current_normalised,
atr_before_normalised;
double value3,value4,value5,
val1,val2,
close_diff, r;
int flag1, flag2; //flags=1 when pair drops down quickly. Stoch is below stoch_min and diff in Closes exceeds atr_current_normalised.
//flags=2 when pair goes up quickly. Stoch is above stoch_max and diff in Closes exceeds atr_current_normalised.

if (NumBars == 0)
int shift = Bars - MathMax(stoch_period,atr_period);
else
shift = MathMax(Bars,NumBars) - MathMax(stoch_period,atr_period);

while(shift>=0)
{ atr_current_normalised = iATR(NULL,0,atr_period,shift)*atr_current_norm_factor;
atr_before_normalised = atr_before_norm_factor*iATR(NULL,0,atr_period+atr_before_step,shift);
stoch_current = iStochastic(NULL,0,stoch_period,stoch_period,1,0,0,0,shift);
val1 = 0; val2 = 0;
value4 = High[shift] + atr_before_normalised;
value5 = Low[shift] - atr_before_normalised;
close_diff = MathAbs(Close[shift] - Close[shift + 2]);

//Process Sharp Drops & Rises
if (close_diff > atr_current_normalised)
if (stoch_current < stoch_min && flag1 != 1 ) //pair drops down quickly
{ value3 = High[shift] + atr_before_normalised/4;
flag1 = 1;
val1 = value3;
r = value3;
sell_signal_buf[shift]=value3;
sell_stop_line_buf[shift]=value3;
}
else if (stoch_current > stoch_max && flag1 != 2 ) //pair goes up quickly
{ value3 = Low[shift] - atr_before_normalised/4;
flag1 = 2;
val2 = value3;
r = value3;
buy_signal_buf[shift]=value3;
buy_stop_line_buf[shift]=value3;
}

//Process small Drops & Rises
if (val1 == 0 && val2 == 0) //
switch(flag1)
{ case 1:
if (value4 < r)
{ r = value4;
}
sell_stop_dot_buf[shift]=r;
sell_stop_line_buf[shift]=r;
break;
case 2:
if (value5 > r)
{ r = value5;
}
buy_stop_dot_buf[shift]=r;
buy_stop_line_buf[shift]=r;
break;
}


if ( close_diff > atr_current_normalised )
{ if (stoch_current < stoch_min)
flag2 = 1;
else if (stoch_current > stoch_max)
flag2 = 2;
}

if ( (stoch_current < stoch_min && flag2 == 1) || (stoch_current < stoch_min && flag2 == 0) )
{ if ( close_diff > atr_current_normalised )
{ down_buf[shift] = High[shift];
up_buf[shift] = Low[shift];
}
}
else if ( (stoch_current > stoch_max && flag2 == 2) || (stoch_current > stoch_max && flag2 == 0) )
{ up_buf[shift] = High[shift];
down_buf[shift] = Low[shift];
}
//------------------------------------------
shift--;
}
}